From patchwork Thu Mar 6 17:59:05 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 14005067 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABEDCC282D1 for ; Thu, 6 Mar 2025 17:59:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 99A5A28000B; Thu, 6 Mar 2025 12:59:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8CD7D280003; Thu, 6 Mar 2025 12:59:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7491328000B; Thu, 6 Mar 2025 12:59:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4CC09280003 for ; Thu, 6 Mar 2025 12:59:26 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 651DD1623BD for ; Thu, 6 Mar 2025 17:59:26 +0000 (UTC) X-FDA: 83191888332.05.7CD322D Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf15.hostedemail.com (Postfix) with ESMTP id C251CA000A for ; Thu, 6 Mar 2025 17:59:24 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=S14s7Ljy; spf=pass (imf15.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741283964; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DgjEkhAn+mMvLmPP3h8lceD6E155+4EdiW7oFduyr9M=; b=7ZtLEw8nRtteBT7FGj0Cdu1Ap1xVVL8jdxeP3fhxDzWgZ5xAE4wun0RtQNWCGRuQCR749+ c6Y7C5e9UnZ93REf5LEniY3NOPJcMIQ38hKhrUoBn/eQcUTutOypZIujPt3UheZ4qneVFB DCDQzg+Br4zXxf+U9xOVy+zoymRQ8o4= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=S14s7Ljy; spf=pass (imf15.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741283964; a=rsa-sha256; cv=none; b=bKH6lJoNviENvgWEJ5Uug9WuJO+/KEOcUoZZQ4+mrPbVqL9xjG4O0QpGcnH33GV3SFEhNa kh7WGAvuq7Grn6n0KWWHnoc0tZnRdt8rHf22plN/wehe+eDkEc48O4wPR1vQP4NqdgLz8R M4F5GcxX/5TSNYkDtY5UGvabbnqbENw= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id DE5D9A450DD; Thu, 6 Mar 2025 17:53:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3196FC4CEEB; Thu, 6 Mar 2025 17:59:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741283964; bh=S+TNIBRN6YsZ8tOcYDy9gAmvy6YsqhXhgFNOQBl/SdM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=S14s7LjyIEJw6vYOzHXcs45rJA5HM0smXIDKTwtGIGtVg5j4Sxt57Tb2BNY0Wgjwn xdgaz6Fw4jpwFIPd5XPf6KLq/W/hF9v2XhGQIy3gCw0x3sdRU4rGi4SwT91xRrwwOH KX3cZ0lWMRUJhp+OpdXdF4cviM/flmortjg5iANDvX4Ia+0gNzA/yQqhLzEY8LBBDp TY27V/oidghlrJ2674LYT4BZqSH+9+a2LBo+rApY0WnHbBOcSemaaayM0B11vDngc9 z0arz79RE8XCm17cIDz6LQwfsUJD3k6SJEWsh4QHFeKFBgHxYxBZQlfaPzrPXSg7IK V1xIHhSvP40rw== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 10/13] mm/damon: remove ->before_start of damon_callback Date: Thu, 6 Mar 2025 09:59:05 -0800 Message-Id: <20250306175908.66300-11-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250306175908.66300-1-sj@kernel.org> References: <20250306175908.66300-1-sj@kernel.org> MIME-Version: 1.0 X-Stat-Signature: 5qxy8kx7yf5sd4idfa63wuogy3raw9b8 X-Rspamd-Queue-Id: C251CA000A X-Rspamd-Server: rspam06 X-Rspam-User: X-HE-Tag: 1741283964-12728 X-HE-Meta: U2FsdGVkX1/+2qPWPRmoh+FOSF2QrVIeyx/WVGj6EZAp98LEP04Xpj2uSR85MSeHHwIca9cVKeUwcEwtHepxNTHXyCAI7i1agPnuogqLhJLAEPJbJ2khEb64BvJl3MVRqUeQEZhLRL0sioNoexIAaaXTAqxFrtejBH6ci7JVUXkf7LO07xa9jPo8EvJ1MpmmwyO1W7FphEX5Wg6iPJSl1FmV5jjIHqkuopJl3FAfhabd/5H3oFRA5JIa5yJhKaM3j1TMp9jo35d+NzV1RQ8O19coQgsapp672MhpORk1tXH9b5aQic6yI+3IEIwd2fehHdcTS1RSj0JY9rgHzsxtSB7fbfNCD8k2cO+xq73AVcCbuq8zYQjCOk9hM/KyqAD2Yh3m4wrtnSYLxp3Svih0HLUPs03AVO4f8dP6+ADnC2GammYFrTN6h2F5utUTiY/j9j7AKxE7PqOUl7uId7ByQNYN2SDP9pPRhM0u8fTL9yAg0gRN7kEcTOLStXIsfWh4T/FohXNHVPavrkL+cdT5s3XYsTvHuVFZ43lzQ6HfTQmWfM8Y8qz43FXIAxdZxlE9F0l6/iDQPJ1ItgL+0mn/+rFsEnNw+8K6hccIfcRQPyeuQvmEMyBqm+ukpq5RLjdhd8XhenBDEAhJNDYDbO46oAtc3xqUrMDhxuEyH4b5syEUA9lqFdFCvUBpl91qXrP3nAmhx7V7WkzdahT0VNDOhHEjCUsuk+nx2tI/aYlt8j1L2GeWROa/+tk86eGFJ0pTAaUxGGKhTITiCAQsSkQzx6jSVKnItxVLvRNBqUJ1wdAjmBGhzstGQvkswgbaY64Cel8bNHAJiDKDlxtJ/FlDkTzM44ttjkUgy17GaaYJa9fB7Myqvtk706BdNmlpp5IubenO39rv4SMGSgX/i9ZgIjLKkWDnaL20xj5Vsm+rRqq2pCOjeaj9HvchB8dy9bsU6yhrHDq6hRVZp5+1DzZ ZPsPuJqG DCAyKbvfQuRaA6TJsd0vxkpx48lyXkiUoTNGqzk3l8OvvLxK9XP0iqrtPHU6ujYxWBXYULoN3SLy5o8U6YE8eBulHSNgK9GZ4TpZjIyCy7n16E944cMxSNDShRqpPTcKUQQ0hn9VmIPapeseYy/GmtBxBYkHEJxjXTAK2xG2F0LYa+jCKNUsSSDzI1TR+qqz225P/EIbDTqPR60Wk5x2UDeSkBCZdwsMr2JkSmhyD/0+LBE4vfJrNBseSsw8raxI1wmqpBNKn5K62SBuSVmsIn69f9g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The function pointer field was added to be used as a place to do some initialization works just before DAMON starts working. However, nobody is using it now. Remove it. Signed-off-by: SeongJae Park --- include/linux/damon.h | 7 ++----- mm/damon/core.c | 2 -- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/include/linux/damon.h b/include/linux/damon.h index dab4bb0fe39d..043de2408c65 100644 --- a/include/linux/damon.h +++ b/include/linux/damon.h @@ -603,16 +603,14 @@ struct damon_operations { /** * struct damon_callback - Monitoring events notification callbacks. * - * @before_start: Called before starting the monitoring. * @after_wmarks_check: Called after each schemes' watermarks check. * @after_sampling: Called after each sampling. * @after_aggregation: Called after each aggregation. * @before_damos_apply: Called before applying DAMOS action. * @before_terminate: Called before terminating the monitoring. * - * The monitoring thread (&damon_ctx.kdamond) calls @before_start and - * @before_terminate just before starting and finishing the monitoring, - * respectively. + * The monitoring thread (&damon_ctx.kdamond) calls @before_terminate just + * before finishing the monitoring. * * The monitoring thread calls @after_wmarks_check after each DAMON-based * operation schemes' watermarks check. If users need to make changes to the @@ -628,7 +626,6 @@ struct damon_operations { * If any callback returns non-zero, monitoring stops. */ struct damon_callback { - int (*before_start)(struct damon_ctx *context); int (*after_wmarks_check)(struct damon_ctx *context); int (*after_sampling)(struct damon_ctx *context); int (*after_aggregation)(struct damon_ctx *context); diff --git a/mm/damon/core.c b/mm/damon/core.c index de30b788e13a..8904b3c079e6 100644 --- a/mm/damon/core.c +++ b/mm/damon/core.c @@ -2407,8 +2407,6 @@ static int kdamond_fn(void *data) if (ctx->ops.init) ctx->ops.init(ctx); - if (ctx->callback.before_start && ctx->callback.before_start(ctx)) - goto done; ctx->regions_score_histogram = kmalloc_array(DAMOS_MAX_SCORE + 1, sizeof(*ctx->regions_score_histogram), GFP_KERNEL); if (!ctx->regions_score_histogram)