From patchwork Thu Mar 6 17:59:08 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 14005070 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35CDDC282D1 for ; Thu, 6 Mar 2025 17:59:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A92ED28000F; Thu, 6 Mar 2025 12:59:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9CB3C28000E; Thu, 6 Mar 2025 12:59:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 86CCB28000F; Thu, 6 Mar 2025 12:59:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 64EFC28000E for ; Thu, 6 Mar 2025 12:59:33 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 7BE52A9FFD for ; Thu, 6 Mar 2025 17:59:33 +0000 (UTC) X-FDA: 83191888626.07.9DA2BDE Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf16.hostedemail.com (Postfix) with ESMTP id CF1A9180016 for ; Thu, 6 Mar 2025 17:59:31 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=KLOqrOWm; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf16.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741283971; a=rsa-sha256; cv=none; b=22sCYi6zfHMeffHZTLJiDt/x0CYh9gnBieGss+y1s4nKohodpgYh+W7NZC2ajvRSjYo45G YqGqYbW1ahNWo6+3f3G3zZMi5VtbjZ5arLE0ESmM5N0TXbil0EGGj+PL2w7iyPc8wHRNGT 4AEZ68gjCMLV4a13TJMtFblR2Q1wGd0= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=KLOqrOWm; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf16.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741283971; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OTmmSMPWuAchNQ3rehtZGvWkVJW9LY/zdp2XUaDw66k=; b=BHQ6JV494HAdCJr2UF4lfIq6+nIEbgR/j3+R55IyoWEE36Bspf18qXqZg0h1UGne0rQqb6 rAp0dN8LtrFnD4Aq51deVzt1cy/Y0Wv6rN6QkmzwPS2qCc5N1CibELEk2drFW0c4ijrcZT /77lLp8znD61rleX5XMIvIytDjhX1Ds= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 65246A450E7; Thu, 6 Mar 2025 17:54:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7E640C4CEE4; Thu, 6 Mar 2025 17:59:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741283970; bh=Rn+6YydnhrV6FETkcIfmvP4YuDQr4oebn96i4+L/goY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KLOqrOWmjdNfeRf4uTFfilXrUOaL0GSy6hMQWsxUT2If3kQvq6UTPuQULqnbC0NZn 9fo5jXUGPK0CFGpdYaOcnKVIAEj6wx/i3uexc3urCzkplgnA6CiTAnvtxiq2JRXyGR uqK60K9LqCudw0fkFgiyspQa41ohjAmBNmgVfh4u0/PSzjxTlek38b8SFnPpeGeThw FKTmWUH3bxOdyCiVdpMeDsqqEZ0uZuTRsCAbxd5XT8+O2SXNfC/BjX2GgyMl8iM27O gCjMozI7x4UUkqFr3/B1s+4nUS32ekumybJfXPGl99tntavBZW6wAgYyJt+HG5U1Sn hOgCwGYkq6fZA== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 13/13] mm/damon: remove damon_operations->reset_aggregated Date: Thu, 6 Mar 2025 09:59:08 -0800 Message-Id: <20250306175908.66300-14-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250306175908.66300-1-sj@kernel.org> References: <20250306175908.66300-1-sj@kernel.org> MIME-Version: 1.0 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: CF1A9180016 X-Stat-Signature: dzspi4r896fy1nx8a94oawzt1y6woj4z X-Rspam-User: X-HE-Tag: 1741283971-141678 X-HE-Meta: U2FsdGVkX19Oh7mje/cAy4pmIuNf32P4ULv7UcH0Q6/xuUzPF8PRjPQ8WCHZNckWNuKOyQe/8bGGRmI3SpERwtNdfuxN/cfh9RHXz0292d8ItBRvT5eGa0FLnFs2Il8YzIj/P419oaSRTdxiA6GMPpCBIXPB5p+NW9dhnuotjJgUFiTWNO/jlBm7bhAajdlB3fR3E71W9oG2sTCAIFkNsxOSbiXjcj4ylXqiEk5kYB2iLlAMuELNKSzGTfn6NdIhsIHlQ0Oil5ak7MC7ESpdVOVIfixQlu2YRJ9UEydQEsQGzrH2MXOKRFG1fmPd/zHN37QiyOdjXeTdXsKIF4zhQ3pXiLNiAdR/5IuSkdULmUu4jdiK0sHREVk5/AjXkp+mhX/cylT6atkxBLjQFi2KLRxxs5zNowR3VU+yuENNqUrPV+GAN6ThHDzlZF0cWuAor6w9s1TaMqcVMu3Yq1mpQXn5K2AWLl1t745Urnvv6Qmzi8pZiwCh740bhIDhKDK01DDTLR/VifU4HYDPfikUtiN9cP+qRPgYHv4F/UsVNBvCoFKOrZc+aqFeX8vAsj4ThOiQDeOD1VpFR+JMSieliNkvzkS3OXxe15K5UVnZsNsrkp4jLge26QbTSSV8rboiYYFDIPOqQ5S946Axjlcv44Bil3DmUEihQaz2EG+uAoHlvXPLQlWSm8p6+EIwSdopDOXDRjbSc4X0FEQffoF0mJ6abF6T8ZnJ/E8ltz/2jqBi6PMl0QW5DtLvH3WO+2fTcWzWS4WbKPm51w6mBKAJaU7K7Btzz9UtU9A8uuDCmjGai87jQFn/A89Ee1zHHYqy06Hsis5LkNOkA337YNPaR0ZJLqJVYotpFnVQFcNgXXfO8/OGksgF4lkuyvuaiZopa+ryR6ddcorAYb4Ri6Aeyhza4eH9948W8zshznzNwJn1ftYmQkMvieWWop4LdEHhsMM5nwG+FktgZiN5lKp +G3bW7Rz HWEeKM/L6MtZT0FGnZ3fhaPA2XIk8v/TuYAN2wDSYsTQ+ag1DYqsSkug6qKcFAxGAHoLqvDKgqfvn+mmA56I5snq4WDjAm5QwoHevzd6ccUb0G0XR5ixXYp6t7pXyKWjK/hjW0nnRx8Lxicqavq4eM7k174tlWQn+w0wsxuRLdDFngkmB29wL/KFO9Wg880DlU3LUKChKGZRggxOu0kdHzvec19/2NDUmsXk+blbwG/BMRkx079g+GIfbs3k4CxqJm/JBNFML5n0WutdExR00qoJ99w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The operations layer hook was introduced to let operations set do any aggregation data reset if needed. But it is not really be used now. Remove it. Signed-off-by: SeongJae Park --- include/linux/damon.h | 7 +------ mm/damon/core.c | 2 -- mm/damon/paddr.c | 1 - mm/damon/vaddr.c | 1 - 4 files changed, 1 insertion(+), 10 deletions(-) diff --git a/include/linux/damon.h b/include/linux/damon.h index be7b281fb922..3db4f77261f5 100644 --- a/include/linux/damon.h +++ b/include/linux/damon.h @@ -542,7 +542,6 @@ enum damon_ops_id { * @update: Update operations-related data structures. * @prepare_access_checks: Prepare next access check of target regions. * @check_accesses: Check the accesses to target regions. - * @reset_aggregated: Reset aggregated accesses monitoring results. * @get_scheme_score: Get the score of a region for a scheme. * @apply_scheme: Apply a DAMON-based operation scheme. * @target_valid: Determine if the target is valid. @@ -554,8 +553,7 @@ enum damon_ops_id { * (&damon_ctx.kdamond) calls @init and @prepare_access_checks before starting * the monitoring, @update after each &damon_attrs.ops_update_interval, and * @check_accesses, @target_valid and @prepare_access_checks after each - * &damon_attrs.sample_interval. Finally, @reset_aggregated is called after - * each &damon_attrs.aggr_interval. + * &damon_attrs.sample_interval. * * Each &struct damon_operations instance having valid @id can be registered * via damon_register_ops() and selected by damon_select_ops() later. @@ -570,8 +568,6 @@ enum damon_ops_id { * last preparation and update the number of observed accesses of each region. * It should also return max number of observed accesses that made as a result * of its update. The value will be used for regions adjustment threshold. - * @reset_aggregated should reset the access monitoring results that aggregated - * by @check_accesses. * @get_scheme_score should return the priority score of a region for a scheme * as an integer in [0, &DAMOS_MAX_SCORE]. * @apply_scheme is called from @kdamond when a region for user provided @@ -589,7 +585,6 @@ struct damon_operations { void (*update)(struct damon_ctx *context); void (*prepare_access_checks)(struct damon_ctx *context); unsigned int (*check_accesses)(struct damon_ctx *context); - void (*reset_aggregated)(struct damon_ctx *context); int (*get_scheme_score)(struct damon_ctx *context, struct damon_target *t, struct damon_region *r, struct damos *scheme); diff --git a/mm/damon/core.c b/mm/damon/core.c index d6271fae4dd4..db357892da74 100644 --- a/mm/damon/core.c +++ b/mm/damon/core.c @@ -2489,8 +2489,6 @@ static int kdamond_fn(void *data) kdamond_reset_aggregated(ctx); kdamond_split_regions(ctx); - if (ctx->ops.reset_aggregated) - ctx->ops.reset_aggregated(ctx); } if (ctx->passed_sample_intervals >= next_ops_update_sis) { diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c index fba8b3c8ba30..b08847ef9b81 100644 --- a/mm/damon/paddr.c +++ b/mm/damon/paddr.c @@ -621,7 +621,6 @@ static int __init damon_pa_initcall(void) .update = NULL, .prepare_access_checks = damon_pa_prepare_access_checks, .check_accesses = damon_pa_check_accesses, - .reset_aggregated = NULL, .target_valid = NULL, .cleanup = NULL, .apply_scheme = damon_pa_apply_scheme, diff --git a/mm/damon/vaddr.c b/mm/damon/vaddr.c index a6174f725bd7..e6d99106a7f9 100644 --- a/mm/damon/vaddr.c +++ b/mm/damon/vaddr.c @@ -710,7 +710,6 @@ static int __init damon_va_initcall(void) .update = damon_va_update, .prepare_access_checks = damon_va_prepare_access_checks, .check_accesses = damon_va_check_accesses, - .reset_aggregated = NULL, .target_valid = damon_va_target_valid, .cleanup = NULL, .apply_scheme = damon_va_apply_scheme,