From patchwork Fri Mar 7 05:44:04 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shuai Xue X-Patchwork-Id: 14005966 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5006C282D0 for ; Fri, 7 Mar 2025 05:44:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E38D8280001; Fri, 7 Mar 2025 00:44:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CAD83280005; Fri, 7 Mar 2025 00:44:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9F00D280001; Fri, 7 Mar 2025 00:44:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7D315280003 for ; Fri, 7 Mar 2025 00:44:16 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 7350BC0374 for ; Fri, 7 Mar 2025 05:44:17 +0000 (UTC) X-FDA: 83193664554.14.159432B Received: from out30-119.freemail.mail.aliyun.com (out30-119.freemail.mail.aliyun.com [115.124.30.119]) by imf26.hostedemail.com (Postfix) with ESMTP id 6E336140004 for ; Fri, 7 Mar 2025 05:44:15 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b="Gw8AA/zt"; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf26.hostedemail.com: domain of xueshuai@linux.alibaba.com designates 115.124.30.119 as permitted sender) smtp.mailfrom=xueshuai@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741326255; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zNNjpjby7OEVOGOuCOx/+9vNU60KKs/GI6CHsj1/Iek=; b=HYXbgod5Rc1ufL9l/FmMaiqpTdE/YRqG09iekLEuISJU7CLvDEE7g34JlwOMLNPGcGyfaV YC0MUqK/6bPV/MbCz7U1K79xAOhj1oR6w3s0CgNlYrnUoYcEOQkCEULorXqpMUTItX1UtV bmgluSDVoWnwFtqpjBrb4UhYTiXF7Pk= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b="Gw8AA/zt"; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf26.hostedemail.com: domain of xueshuai@linux.alibaba.com designates 115.124.30.119 as permitted sender) smtp.mailfrom=xueshuai@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741326255; a=rsa-sha256; cv=none; b=Yb1kbSfgDUjX8Zo75wP1zDaP00ZBkPQzIJwe86KM8gq8/GBKtvYBiwn5xfCBBYCkel7oDF 82btTyol2xp48N++uftu5JxWrqhLJrpuOQlO1D6KRVQ/Itx7NaakSzR2Pe0GFg+2BB1thD lKZ+yq2JfJfPUQUEgP2HVEAFGjJ+BeI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1741326252; h=From:To:Subject:Date:Message-ID:MIME-Version; bh=zNNjpjby7OEVOGOuCOx/+9vNU60KKs/GI6CHsj1/Iek=; b=Gw8AA/ztNQ85AetmvGmhWPIWaVv+CguWO4BVFcsMXIVRyM9n9Uva64hjw0b0VsFP5xNl71Y2Yp20zcWpDr7ZwXQTQkOEj4hpx8fePxaOvxSEk1lldv6/rb30NnhN0gr2zzrMBl6QcN/aVjZZ4UxHug+sYGktx5Qph8VJ5Zq1J2A= Received: from localhost.localdomain(mailfrom:xueshuai@linux.alibaba.com fp:SMTPD_---0WQr2xBP_1741326249 cluster:ay36) by smtp.aliyun-inc.com; Fri, 07 Mar 2025 13:44:10 +0800 From: Shuai Xue To: tony.luck@intel.com, bp@alien8.de, peterz@infradead.org, catalin.marinas@arm.com, yazen.ghannam@amd.com, akpm@linux-foundation.org, linmiaohe@huawei.com, nao.horiguchi@gmail.com Cc: tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, jpoimboe@kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, baolin.wang@linux.alibaba.com, tianruidong@linux.alibaba.com, xueshuai@linux.alibaba.com Subject: [PATCH v4 3/3] mm: memory-failure: Enhance comments for return value of memory_failure() Date: Fri, 7 Mar 2025 13:44:04 +0800 Message-ID: <20250307054404.73877-4-xueshuai@linux.alibaba.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20250307054404.73877-1-xueshuai@linux.alibaba.com> References: <20250307054404.73877-1-xueshuai@linux.alibaba.com> MIME-Version: 1.0 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 6E336140004 X-Rspam-User: X-Stat-Signature: n4ydnaojgakw4n19ciybsi353kxhqn7f X-HE-Tag: 1741326255-570441 X-HE-Meta: U2FsdGVkX18t9I7Ty50/ScAlWN1brO6e00cMUGepjL9051zStSCdfiMBTkLUvms8X9zphIXOVnnjXcS4KPqlkXcobKvZlcyUIwm7oeSjLW2wA/VoymiYOVzRDiAT4cD03wZY41yl1bMBjqTmi3sCpIfaA+u2ktiCSKbEAB+cb8gIPvtH5QN4MzCVLGzUc9mi0F3ynj3vNLal0uJRtAG8QhG8aJGiqczuwTbybv+ctBuxmCJGlCPFCMAogRsfkugyGXQHbk24zHOGGpA+HlEqOlm0BB4H6gAqs80ZcO6YFyqvMxvRv15aH2uvlVegwX56AeO1jQKgSs/I9RpVASE6761oDruvoHRTspjvHiEbDcexwCQJ1hod5Op9yijxQc/878fDhPtCRZBNpqpQ5wNpjfhLeZlwFjcXdu/RCT9Cfid43moFmwSc3sTL3CkEPOaj+CamK7BvB17ksBUcLZ3eTOQ7hW70j6mRCDBcvKh7Ec2ycRf1rhLcKWpPz+AnF9koK2UzTpfH83Li3eHZx4rxh+Us8fsMB1+91FD0G+fzEdGXX3RkzkVFsYSeCuQ8Nafh/bCYFsLQCnM5eSzB093dTchdrwtwHsoHPMaqGxXCof4GIAMwKkNtZBOzFW6U6JEGYXSaiX3teMlJj7yqqwicUCLclg7UCDC0AKVgfJP0UGWymF0tW1U4oQbtV4XcFFKQi4tUEkNQYMyMfN0FE5MoVrg5maEQdBjAnm+xM6LrEwHPND1T381SCksJA3vbC3XPY28aQQqZT9rowH1ONILzQDHvQAxQWj8WcfnE9Ymm3HrOqohMuAAN7fv4o7njwjS6dmPAC+hYwMzG6qME0g+Eh0vEbKtcGot38G6tcgfky3GB/0EwUax6PyQbg61yAAE3TAJ6xOH36yl/5TG/+XVJl7/73DE10a7pymEkGgRbn92+1xvBZvlW96/SlRBOP3oC93GkpJQSnHKYECJIlOu M84UHjrA InCf9s/gZhoykcrKlFxS0nXdMaPXz93iI5694xo0IXeXBIUT5Uv3MuAFyqignuxg+eG6lvo7WOPtMXPGIc/f8dPhbYpwW2CLmEh74ZzmzL5PbVVmPBu5p+QBosEWHLUDFXx/V4El1PcIg1cNsouE+KjFeN2tHQ6mJknDJ7zfnEZv/hFdcfouyKrYQ2lLqopsROGp5ef0iqiWhKvRiVGi7z2R9KQr/UXdzDBZqt+aSPBzN47OTeHjHkWgATo9mfH605Egh+t6TIscgQpUVe8d8BukUiVa+pIauCnDbmvy7I06HwXQXpNESahHN8rzn7T7V5O/HfWcj+GfzZpOMkAzmgOvM2zn64fKiELc7pkuhHNSTK5DLo82Cukh7W/YYN+m1az4JqTP+h78I8TIhzqs/Fp58NkFihScsrfsQ/cVIlyjwZjmTcmVh3xmZAg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The comments for the return value of memory_failure are not complete, supplement the comments. Signed-off-by: Shuai Xue Reviewed-by: Jarkko Sakkinen Reviewed-by: Jonathan Cameron Reviewed-by: Yazen Ghannam Reviewed-by: Jane Chu Acked-by: Miaohe Lin --- mm/memory-failure.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/mm/memory-failure.c b/mm/memory-failure.c index b037952565be..8649849bcdb4 100644 --- a/mm/memory-failure.c +++ b/mm/memory-failure.c @@ -2216,9 +2216,13 @@ static void kill_procs_now(struct page *p, unsigned long pfn, int flags, * Must run in process context (e.g. a work queue) with interrupts * enabled and no spinlocks held. * - * Return: 0 for successfully handled the memory error, - * -EOPNOTSUPP for hwpoison_filter() filtered the error event, - * < 0(except -EOPNOTSUPP) on failure. + * Return: + * 0 - success, + * -ENXIO - memory not managed by the kernel + * -EOPNOTSUPP - hwpoison_filter() filtered the error event, + * -EHWPOISON - the page was already poisoned, potentially + * kill process, + * other negative values - failure. */ int memory_failure(unsigned long pfn, int flags) {