From patchwork Fri Mar 7 06:11:28 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sunliming X-Patchwork-Id: 14005984 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6944AC19F32 for ; Fri, 7 Mar 2025 06:12:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CB35F280004; Fri, 7 Mar 2025 01:12:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C6429280003; Fri, 7 Mar 2025 01:12:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B50DC280004; Fri, 7 Mar 2025 01:12:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 990DD280003 for ; Fri, 7 Mar 2025 01:12:25 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 61DB25178B for ; Fri, 7 Mar 2025 06:12:25 +0000 (UTC) X-FDA: 83193735450.04.BEF1A61 Received: from out-179.mta0.migadu.com (out-179.mta0.migadu.com [91.218.175.179]) by imf28.hostedemail.com (Postfix) with ESMTP id BEEFCC0006 for ; Fri, 7 Mar 2025 06:12:23 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=ORH6dbqI; spf=pass (imf28.hostedemail.com: domain of sunliming@linux.dev designates 91.218.175.179 as permitted sender) smtp.mailfrom=sunliming@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741327944; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=bioy24DUV/2OG8cBBKOG2c94GvtSiwsNOhqhjVfSmEE=; b=omotIoP2gAkHeB+dk3yBLF4MEMK13q0bN+qU9YPu2vFTj1yHga4LvCKBc/OzP55Ow8GtOM JwqMyre/CU5tb/++pNQOtmVbGe8/YLs+PdFS3Mtya1IyoEHhhIuE/XucsSo9QC/a/Iewvs /0o3sMIfD0qfH4zkrXGEYm9pGy3j+cc= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=ORH6dbqI; spf=pass (imf28.hostedemail.com: domain of sunliming@linux.dev designates 91.218.175.179 as permitted sender) smtp.mailfrom=sunliming@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741327944; a=rsa-sha256; cv=none; b=LDrzT8BsJVanjqG3/kXCkoBcsC7SCJRSifgml+E8NqRo7yuYspFcxwa5fTmktd6Up7A7Yo ODeQ5O5JG80Pg2Q/jvt8nHWHhlvzHVt+ZahXqd/GHGQmfPLlEJaZwDHCDhMWWyMcugCoPw LmuoZn7/kIvAMClJ+VROzuy8cLfmUok= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1741327941; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=bioy24DUV/2OG8cBBKOG2c94GvtSiwsNOhqhjVfSmEE=; b=ORH6dbqIDicSzrn6+UeGXamopLDg39lSxzptTnJsQxJfiA5kMm/NUWgDnTfvnkiZYFlV3X OjKt7+L+UKAy02k4mInJ51JsEF1SbPtUzSlJz4J8CnjasSqIimvBy5yQrcIkG2ZBrfewRG On2m9r5QHhVQcMAPHCsAlrJijF/xS8w= From: sunliming@linux.dev To: viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, kees@kernel.org, ebiederm@xmission.com Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, sunliming@kylinos.cn, kernel test robot Subject: [PATCH] fs: binfmt_elf_efpic: fix variable set but not used warning Date: Fri, 7 Mar 2025 14:11:28 +0800 Message-Id: <20250307061128.2999222-1-sunliming@linux.dev> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Queue-Id: BEEFCC0006 X-Rspamd-Server: rspam09 X-Stat-Signature: 79fxpq7xewy54w4kedrk4cxk8abttdqe X-HE-Tag: 1741327943-309 X-HE-Meta: U2FsdGVkX1/VNE/i/MRq/YE0sU+M6EnN2AOEH+bpFH2OS0+jpeIeDs59ovOqmGYPMXVexwLrgg512Cs7WzMGWBVoQ/AxJEy0xKfP/IvuV/mYsTOpUtoMpgmsIBXGzKtWEyJC+V7/TtOdh6C/RNypPcq18WwX81wjAsHetMyQ+yDbxtJ9KtiqLfgvRGFDvvCBSYP8ub8jmoGtew8rygUCad+5/ogY/rmTaRxAI8BVIPLMU3VnfU1SbCHvVCDIHRDhVZGHcRP/Kd44gW0ajfHvSLzcB+MWa2TDZi/wgXIm9shGorXBkmKukJkm3dXCMapu7noUcoWBmw6aV724ppw2UyVojAmR8TYxDCh2d8Cp4ca523Px+efxbQWwnK6gtQ1AhtkGGll15a4AZFlYo8pBGURNf/P/AQfO9aXqpJ2xh8wljCfvC8kaue5QbP/1FXehVpf3fE5CKWRZ639GqB2eoVV6N/I+WImuNN2elPBVqYnTvAOlkTwCIJLhAu/tpW1ad/WaYXL3DHRVoZP5M7T2INBymx7T9dAEdl9NeMt6hBkhUUk6ArQHEjFZSfo5GKTzGlXwbt63Mnl0FNyEkltUIiI+KD1Ju1OWSfTsBapAYbxlwIeoWqSkrs3fi0qcdKClMdko9rEJHeAb/Y+pNx/8mSFlY3t87+pfGAGtxSlqc5eblnEdtnMentQW8SARWX3RgXQZrxlwo5ktKcnfiZSmNUUyLSVWCvQJ18PMb29t/5V9crZy/u+M29AyVZ3pLQFMoiGcWu2GDqdl7gF9JAFA7RAUz7fclcOpnVwKrzYSwlYPKBxX4sLjE+YQ6chwsQJQJCXcZSYL9wQyDDRYMDVIyYgq1xriq5Z36ljhg/8tofypVjd6e+YocsC25LZylgU8bDoy4FEymaR7GQpphSXLi3z/ECYPXWCuRBQx6SkvwkZB1ne5WzMguYYsQPPNk/bXrh0Ug1ytZ3VTvom0Lp+ 8QiAnLFm 4EgVKmd8NIf3edKZCEtgAkDmJw5oB7maI9SzBLNJEgowwwqfioDLAWFxHYXE3Ef4dxwMrB1+AGSh0Wdvhz+mGEDPe00mx3/2yVpuSPOVMqU+UsyzVMJbtuKmxAAQJRVokn/xu9vJuSNQm+dd9OpQcVz3nEwrpVCchh/JkgGoI5HZEIZFHzFF/JEMJrrD41TECkCr0sL8te8Lj4JpdAR/FOfBjK4bdNwGHGyySDOBM/bZaMToIbW+slX1Tmg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: sunliming Fix below kernel warning: fs/binfmt_elf_fdpic.c:1024:52: warning: variable 'excess1' set but not used [-Wunused-but-set-variable] Reported-by: kernel test robot Signed-off-by: sunliming Reviewed-by: Jan Kara --- fs/binfmt_elf_fdpic.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/fs/binfmt_elf_fdpic.c b/fs/binfmt_elf_fdpic.c index e3cf2801cd64..bed13ee8bfec 100644 --- a/fs/binfmt_elf_fdpic.c +++ b/fs/binfmt_elf_fdpic.c @@ -1024,8 +1024,11 @@ static int elf_fdpic_map_file_by_direct_mmap(struct elf_fdpic_params *params, /* deal with each load segment separately */ phdr = params->phdrs; for (loop = 0; loop < params->hdr.e_phnum; loop++, phdr++) { - unsigned long maddr, disp, excess, excess1; + unsigned long maddr, disp, excess; int prot = 0, flags; +#ifdef CONFIG_MMU + unsigned long excess1; +#endif if (phdr->p_type != PT_LOAD) continue; @@ -1120,9 +1123,9 @@ static int elf_fdpic_map_file_by_direct_mmap(struct elf_fdpic_params *params, * extant in the file */ excess = phdr->p_memsz - phdr->p_filesz; - excess1 = PAGE_SIZE - ((maddr + phdr->p_filesz) & ~PAGE_MASK); #ifdef CONFIG_MMU + excess1 = PAGE_SIZE - ((maddr + phdr->p_filesz) & ~PAGE_MASK); if (excess > excess1) { unsigned long xaddr = maddr + phdr->p_filesz + excess1; unsigned long xmaddr;