From patchwork Fri Mar 7 06:35:31 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rakie Kim X-Patchwork-Id: 14006006 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B769C282DE for ; Fri, 7 Mar 2025 06:35:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5947A280008; Fri, 7 Mar 2025 01:35:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 51E78280003; Fri, 7 Mar 2025 01:35:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3708D280008; Fri, 7 Mar 2025 01:35:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 17701280003 for ; Fri, 7 Mar 2025 01:35:52 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 9FE74C0515 for ; Fri, 7 Mar 2025 06:35:52 +0000 (UTC) X-FDA: 83193794544.26.2F113EF Received: from invmail4.hynix.com (exvmail4.hynix.com [166.125.252.92]) by imf13.hostedemail.com (Postfix) with ESMTP id B07CA20003 for ; Fri, 7 Mar 2025 06:35:50 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf13.hostedemail.com: domain of rakie.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=rakie.kim@sk.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741329351; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ypOBI4s7pyAyush3au0mUMAlfPNN4/SmsoKZaX9nx9Y=; b=tYP1maDv/SOPlAfB3Lb/Grq5ba2KRglK1xyFu5ybl0TOmu7k7M07GIlZ5FES0sc60VCroF LOkbqLCVIpR77C0IA1hZxwMfBsxtJx6NdS7v/KuyFZz9ZJUU43NHyEPqgWGX2zZfLE3Fhf SQD4owEjxBuDVC5BUuNdudQc247jK+c= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf13.hostedemail.com: domain of rakie.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=rakie.kim@sk.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741329351; a=rsa-sha256; cv=none; b=M2+fISWxTyP+44sosU4YWnLKl4/TXl9qDgtlJFVYgXsiR7PrOafweVegLzH+MuovEhjCpR M1UZncrQIyoThHYYC+0v/TVKpx0c0U0CB8losvDDxHjzlLeKuyoYGcU4Xl/XWv166diqR9 lgpw3eMZhFBecLDogOS1uceqDvHnpXs= X-AuditID: a67dfc5b-3c9ff7000001d7ae-89-67ca93c54175 From: Rakie Kim To: gourry@gourry.net Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org, joshua.hahnjy@gmail.com, dan.j.williams@intel.com, ying.huang@linux.alibaba.com, kernel_team@skhynix.com, honggyu.kim@sk.com, yunjeong.mun@sk.com, rakie.kim@sk.com Subject: [PATCH 2/4] mm/mempolicy: Enable sysfs support for memory hotplug in weighted interleave Date: Fri, 7 Mar 2025 15:35:31 +0900 Message-ID: <20250307063534.540-3-rakie.kim@sk.com> X-Mailer: git-send-email 2.48.1.windows.1 In-Reply-To: <20250307063534.540-1-rakie.kim@sk.com> References: <20250307063534.540-1-rakie.kim@sk.com> MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrDLMWRmVeSWpSXmKPExsXC9ZZnke7RyafSDb5c0LKYs34Nm8X0qRcY LX7ePc5ucXzrPHaL87NOsVhc3jWHzeLemv+sFqvXZDhweOycdZfdo7vtMrvH4j0vmTw2fZrE 7nFixm8Wj50PLT0+b5ILYI/isklJzcksSy3St0vgyuhuPsZa8Fix4k3bd7YGxl7pLkZODgkB E4lbZ76ywthrX94Esjk42ASUJI7tjQEJiwiISsw7Opuli5GLg1lgMZPEwsPrmUASwgKJEg1/ lrGD2CwCqhJ32o+AzeEVMJa48PMAM8RMTYmGS/fA6jmB5h9f9YgRZL4QUM3fXaUQ5YISJ2c+ YQGxmQXkJZq3zmYG2SUhcIJN4u7E50wQcyQlDq64wTKBkX8Wkp5ZSHoWMDKtYhTKzCvLTczM MdHLqMzLrNBLzs/dxAgM42W1f6J3MH66EHyIUYCDUYmH12PqyXQh1sSy4srcQ4wSHMxKIryC m4FCvCmJlVWpRfnxRaU5qcWHGKU5WJTEeY2+lacICaQnlqRmp6YWpBbBZJk4OKUaGKWSuH+r F546P1fljarLppQPzl6KHMFSy2SCH7OFVkdsPLLgoauH4Kre59LfLhdHtFhbx1R/4tPo/5e2 8n+YrafFkdbr6WcPartf5359cdfi0DRpjxPRc9zcgwS/qs+Z2HRDzHkFn1856ysTh9szenxn fYi6kHudc+cWpasP1yeduvS40cdyhRJLcUaioRZzUXEiAEvJmvVfAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrGLMWRmVeSWpSXmKPExsXCNUNNS/fo5FPpBsf2qFjMWb+GzWL61AuM Fj/vHme3+PzsNbPF8a3z2C0Ozz3JanF+1ikWi8u75rBZ3Fvzn9Xi0LXnrBar12RY/N62gs2B x2PnrLvsHt1tl9k9Fu95yeSx6dMkdo8TM36zeOx8aOnx7baHx+IXH5g8Pm+SC+CM4rJJSc3J LEst0rdL4Mrobj7GWvBYseJN23e2BsZe6S5GTg4JAROJtS9vsnYxcnCwCShJHNsbAxIWERCV mHd0NksXIxcHs8BiJomFh9czgSSEBRIlGv4sYwexWQRUJe60H2EFsXkFjCUu/DzADDFTU6Lh 0j2wek6g+cdXPWIEmS8EVPN3VylEuaDEyZlPWEBsZgF5ieats5knMPLMQpKahSS1gJFpFaNI Zl5ZbmJmjqlecXZGZV5mhV5yfu4mRmDoLqv9M3EH45fL7ocYBTgYlXh4PaaeTBdiTSwrrsw9 xCjBwawkwiu4GSjEm5JYWZValB9fVJqTWnyIUZqDRUmc1ys8NUFIID2xJDU7NbUgtQgmy8TB KdXAWG8i7DNjevR7o2UPft+xnvLqhOZ+lcl/jmg7czEHyXxYcfP4v76XfquD35tpHDHyKs6P U3ynOKFEaV1S52VH5daT2e+eh9SG3i7m1Zgw/dq/rGsnOvsPq2t55m/kmOPBwhoVKB15s+9R 9/Jf3Jc4xdhtzH8en5GzfmLnh0k8vaKy9l/Ky7v+K7EUZyQaajEXFScCAECoqS1ZAgAA X-CFilter-Loop: Reflected X-Stat-Signature: arwg7x5ke6p38yqp6fenqmstyhuzi4bk X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: B07CA20003 X-Rspam-User: X-HE-Tag: 1741329350-301783 X-HE-Meta: U2FsdGVkX18nFAxNV8+lPIGrseMHzT3dhzdq7hgw+OK6VMWQZ3FmANJ/xliYv0DKiEkKueJIZOlvfzgmq45tolC9Zm7DTQjcUkllN4OCkNNxFGLgJUVO/+8jg0LmHMWDbJ/fp0VzTUCI8L3njCn+FHsy7CvPUUa6VVq+spbWWkjRCkxp+VbRGg69GednGkPobTR94lPTJmODvb6SeD5mUGp9JX01ph6HQvqh7lBbW4+t2fW2KRD7YVyOb0ytAmladDSVmTL8o2zHv+kzF0/4o5/VY7CINt0YiqeaQCd50MGw+yaFN4kLY6kAwKUZXj8VrpJuaGnUJKOzzcsSUTwOtsob6QITUbPrH0d2kGPXuUmeFy9tVUhyX0WEm4ccatrVy8UtaU19L9P7SlVle5xnzdX2otjXfwf0tLktofR4UONTibJEMDuC/AYzEcmTuNkdDxxlvhF6ZAQkHJnDBemsxVitcwp0qnpsZ3pqm7GOGfA5fy3Ar3nX7MH7im5wDAbaKAOPt0CjAuk9Kg1/52/4FT74WKYqS1pZHO2YZVWUquTmRSLMVJOUZiw43kLLaqpKWavGL+F+xjWQsuEdCclXsupDTqlsBFVvCqyunMF+GJ+W0/+ppU1DE1kepSSL1fKjnS6vv53N2O/vMz5hLAwbJWcQTCYEFb9lkV04eO56XgrFNlLiHnMZ8HWCYJ0UGa58+0AL3WTygzvwxONQPvWKOWR6LgP4SvZ12qr2SSi9HBAah7CkOkBI6H4XVH8JU7h5bR0CuLyLCYRMe0OjLD/8rlfHuCXBRpTqta6QTbXWF1tNoWaWEQIONMY+1k+MdQGMCO4gPBZ/+Ifp4Uv4lbI7LJ80Ku0vhgUtdA6awbKp4jwHxUF31HLEziIU9df1nDUPYR+BQWjMFnhbLpbVEzVKT6Vee826F4psNQSH3d3uq3F+vVORBIRZl491QlpRvlKE5eNtNAmQa5LOgNRq7hP 3hUL4IA3 Fc9jMD22HGJpmnwPUyMIVqM9afcIDYzjNpUSPMrlpHyxFkFFogR2jXE3zHZNfX3N9soemwWN6Wx6FKAtsS8AVYo1KfFRTwTwiVCD28Et0RyPB4f4oaQX28JT0TKoG0tJ/gxJC7zuuiwmC37w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Previously, sysfs entries for weighted interleave were only created during initialization, preventing dynamically added memory nodes from being recognized. This patch enables sysfs registration for nodes added via memory hotplug, allowing weighted interleave settings to be updated as the system memory configuration changes. Signed-off-by: Rakie Kim --- mm/mempolicy.c | 51 +++++++++++++++++++++++++++++++------------------- 1 file changed, 32 insertions(+), 19 deletions(-) diff --git a/mm/mempolicy.c b/mm/mempolicy.c index 385607179ebd..fc10a9a4be86 100644 --- a/mm/mempolicy.c +++ b/mm/mempolicy.c @@ -3389,6 +3389,13 @@ struct iw_node_attr { int nid; }; +struct iw_node_group { + struct kobject *wi_kobj; + struct iw_node_attr **nattrs; +}; + +static struct iw_node_group *ngrp; + static ssize_t node_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf) { @@ -3431,8 +3438,6 @@ static ssize_t node_store(struct kobject *kobj, struct kobj_attribute *attr, return count; } -static struct iw_node_attr **node_attrs; - static void sysfs_wi_node_release(struct iw_node_attr *node_attr, struct kobject *parent) { @@ -3448,7 +3453,7 @@ static void sysfs_wi_release(struct kobject *wi_kobj) int i; for (i = 0; i < nr_node_ids; i++) - sysfs_wi_node_release(node_attrs[i], wi_kobj); + sysfs_wi_node_release(ngrp->nattrs[i], wi_kobj); kobject_put(wi_kobj); } @@ -3486,12 +3491,10 @@ static int add_weight_node(int nid, struct kobject *wi_kobj) return -ENOMEM; } - node_attrs[nid] = node_attr; + ngrp->nattrs[nid] = node_attr; return 0; } -struct kobject *wi_kobj; - static int wi_node_notifier(struct notifier_block *nb, unsigned long action, void *data) { @@ -3504,10 +3507,10 @@ static int wi_node_notifier(struct notifier_block *nb, switch(action) { case MEM_ONLINE: - err = add_weight_node(nid, wi_kobj); + err = add_weight_node(nid, ngrp->wi_kobj); if (err) { pr_err("failed to add sysfs [node%d]\n", nid); - kobject_put(wi_kobj); + kobject_put(ngrp->wi_kobj); return NOTIFY_BAD; } break; @@ -3521,14 +3524,14 @@ static int add_weighted_interleave_group(struct kobject *root_kobj) { int nid, err; - wi_kobj = kzalloc(sizeof(struct kobject), GFP_KERNEL); - if (!wi_kobj) + ngrp->wi_kobj = kzalloc(sizeof(struct kobject), GFP_KERNEL); + if (!ngrp->wi_kobj) return -ENOMEM; - err = kobject_init_and_add(wi_kobj, &wi_ktype, root_kobj, + err = kobject_init_and_add(ngrp->wi_kobj, &wi_ktype, root_kobj, "weighted_interleave"); if (err) { - kfree(wi_kobj); + kfree(ngrp->wi_kobj); return err; } @@ -3536,7 +3539,7 @@ static int add_weighted_interleave_group(struct kobject *root_kobj) if (!node_state(nid, N_MEMORY)) continue; - err = add_weight_node(nid, wi_kobj); + err = add_weight_node(nid, ngrp->wi_kobj); if (err) { pr_err("failed to add sysfs [node%d]\n", nid); goto err_out; @@ -3547,7 +3550,7 @@ static int add_weighted_interleave_group(struct kobject *root_kobj) return 0; err_out: - kobject_put(wi_kobj); + kobject_put(ngrp->wi_kobj); return err; } @@ -3562,7 +3565,9 @@ static void mempolicy_kobj_release(struct kobject *kobj) mutex_unlock(&iw_table_lock); synchronize_rcu(); kfree(old); - kfree(node_attrs); + + kfree(ngrp->nattrs); + kfree(ngrp); kfree(kobj); } @@ -3581,13 +3586,19 @@ static int __init mempolicy_sysfs_init(void) goto err_out; } - node_attrs = kcalloc(nr_node_ids, sizeof(struct iw_node_attr *), - GFP_KERNEL); - if (!node_attrs) { + ngrp = kzalloc(sizeof(*ngrp), GFP_KERNEL); + if (!ngrp) { err = -ENOMEM; goto mempol_out; } + ngrp->nattrs = kcalloc(nr_node_ids, sizeof(struct iw_node_attr *), + GFP_KERNEL); + if (!ngrp->nattrs) { + err = -ENOMEM; + goto ngrp_out; + } + err = kobject_init_and_add(mempolicy_kobj, &mempolicy_ktype, mm_kobj, "mempolicy"); if (err) @@ -3602,7 +3613,9 @@ static int __init mempolicy_sysfs_init(void) return err; node_out: - kfree(node_attrs); + kfree(ngrp->nattrs); +ngrp_out: + kfree(ngrp); mempol_out: kfree(mempolicy_kobj); err_out: