From patchwork Fri Mar 7 13:54:02 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthew Wilcox X-Patchwork-Id: 14006520 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85AF1C28B25 for ; Fri, 7 Mar 2025 13:54:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EC5BB6B0088; Fri, 7 Mar 2025 08:54:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B77836B009B; Fri, 7 Mar 2025 08:54:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 76DDE6B0098; Fri, 7 Mar 2025 08:54:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 094776B0095 for ; Fri, 7 Mar 2025 08:54:20 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E7D92120B8A for ; Fri, 7 Mar 2025 13:54:20 +0000 (UTC) X-FDA: 83194899480.17.3B16620 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf05.hostedemail.com (Postfix) with ESMTP id 56CC0100009 for ; Fri, 7 Mar 2025 13:54:19 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=K0rUlg3+; dmarc=none; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741355659; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gYAlq/IZDrN3gAui/tjJNHWS0bZWyHE15MvZlcNIc7w=; b=gn2lR5SovmBby46JjsADOZzNgkUhjETQgNuDZGRWl9Jd0kFuv8RsZ3MI8RtShocZwghkeC Oi/qZ3k6lzhLRS9NleQktKkaanEeC6kcGDKPABjlgu3cwz3Y83OvKUUWvbVPWC0KoP84LA RL+eljmKaFwpm4nkWpVU1+csLsgw7LM= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=K0rUlg3+; dmarc=none; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741355659; a=rsa-sha256; cv=none; b=UF4viGKeaU+yM07wilQ3ejq+C8REZF1Rf+IWg5+Irahqmk5XZpPD8Aj8mD90mUjqJWwSAr M1Z5C39njV/l/7cP9h0sWXV4LOTjYmVSVh8Mprb/2qqLnrADKzrDiWXpmC8waeTzINvB3W mQvI0J1koAuD2VvnXMt3TpABFE990xo= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=gYAlq/IZDrN3gAui/tjJNHWS0bZWyHE15MvZlcNIc7w=; b=K0rUlg3+uTjZX3ud/LW+9LOept eIWClltyGb551+sTtSjHCSZEBJNGkuChoXa74eq4oYYIuEdEAfgeArfvO3oklLkFCn/EYC7h2mCqI E75wHlKErYegjFzgWWReHWhUTQqWQ2FhM1ffcbZgz4t1t3Z7Tnu3hFNPX72K23UrXm1Oyka/m4Ymu vOjmwRLhefSEPrfeUv0U9xEZLAmnegRAjGVleZzIUtp00VM2cT/JnPGqEZzXEAyA3nCx5In+W7si8 K4V51BwGYhJgz2F/Pbnsyc3xyQ0uwSUWzyVps7NBtGXl7vNBcGZ79Mfg4Lgzs6lW8WsUWx55917/c pqF/8D4w==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tqY9X-0000000CXFt-2gHs; Fri, 07 Mar 2025 13:54:15 +0000 From: "Matthew Wilcox (Oracle)" To: linux-fsdevel@vger.kernel.org Cc: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org, intel-gfx@lists.freedesktop.org Subject: [PATCH 02/11] f2fs: Remove f2fs_write_data_page() Date: Fri, 7 Mar 2025 13:54:02 +0000 Message-ID: <20250307135414.2987755-3-willy@infradead.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250307135414.2987755-1-willy@infradead.org> References: <20250307135414.2987755-1-willy@infradead.org> MIME-Version: 1.0 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 56CC0100009 X-Rspam-User: X-Stat-Signature: n989jkw8zf4ojajm8tzkybdmt4ufgri7 X-HE-Tag: 1741355659-304772 X-HE-Meta: U2FsdGVkX1+1BP3y3/ZMU8hSV3c3Ga5l15TsXsE0osrOjAPxMR2buJwNyiDsmK6xiLc5T8u4jyyJcTqfFK+y5nfvPier6Brn0w/lCcBVmDgtH30QEPkaVVLGcyP9ndValpS+IdrI8hESU944tLBSdiZfejYWnAv9POPTH0D5ByT7aUacqoL3T+oNVC2TBbK4j3tkZivf8CQvJdHvrPr0N2el2hQnB0ceh8/64kIPzpCp/rn9ICGfVdREcw9TmjWm5Q4tAdm8UpFUm1pSZsgjOwCvZQc3XuVCxR84D4jmCgo1BiNTTfQp2IT5Q08VJLFAqxIG1BjyllR82W9L0OZyPbZ/Jb2fXi3Eut5yHJuYaUU1iQcRpQssndw3Jn8USDSXB8fgyIw1bMjJ7x1kE7faDFkGL2h8wGaDtMRA1842uAQFpEpqKzcU+VrubXR47FZ1teth4RI3PDZuLv8MLO41mNubOpmAJjPf+P8qm1idGTuXE0asQIt/kpn8mzw05lCXxGCqeI+0Zkn8Li0E3YJod6cteVq7y3lO/m4WLherlWS/HM7Lncx8jlyogudFhilVBpIJwqClGi1Q9Lqzqqd0jl5sgCpitoTx8TLjLANivnaxKjF+xb4ly1kcdwXp0zwTYp8ycI0T5RtayYsuTrpHiAC3L4zTRjcZqmZJCoAmVDplwqzEutUMuHHYfTLj86SQea2wsmkYTkBzPpu1uczNaD4fwZNPdVOPCIozA1v0KK/CiAXreC5fUpIfMo+BNZOmBSCa6umZMIEEeVS2rnDodwUh20UpsQ6prv8w8s3hTrWYEZIUuQYRSeUgMu4U3tiFwij43clLO7CrPO8UDKMRMVcJCU/5MOtbw8gf/bFPuAZJWjSqcMVhucq0VyZxIy2kfns5JKWMjcO3OyjBHsBn5wnFJhRsxV4IA8a2WoBB+LfQm9iGDkp0a5uK3I6BK+nXkYGs1NrrVXjHhS+WWOp 68BdOIkV Scktq4QhIaSGC9Td7+ZIcLnLYY+1JPABui+j0yu11zQ2dytcL0G/2yZ8fUcydQRXmucdzxq11Iao+6mur1wsioo8jxPq9kYT7r2wkbVqpEtCstvkpD01fxyspt7KHyHcDsPoFI8ezpMBOPKkbMdwUY8CjfBbwjEpBESB5pQQZmvLcM/NmqNiC3rcmmbqKBltvt8ZRlqnsrTLQKj65zHPfct6/ljThnbi7CAX+G1S+pnz4jC8LQJR3hI5/zaHbTupxS4OWLRzPeHcyXfKyt1UkzgRkZixZmXbvRyqm X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Mappings which implement writepages should not implement writepage as it can only harm writeback patterns. Signed-off-by: Matthew Wilcox (Oracle) --- fs/f2fs/data.c | 24 ------------------------ 1 file changed, 24 deletions(-) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index a80d5ef9acbb..cdd63e8ad42e 100644 --- a/fs/f2fs/data.c +++ b/fs/f2fs/data.c @@ -2935,29 +2935,6 @@ int f2fs_write_single_data_page(struct folio *folio, int *submitted, return err; } -static int f2fs_write_data_page(struct page *page, - struct writeback_control *wbc) -{ - struct folio *folio = page_folio(page); -#ifdef CONFIG_F2FS_FS_COMPRESSION - struct inode *inode = folio->mapping->host; - - if (unlikely(f2fs_cp_error(F2FS_I_SB(inode)))) - goto out; - - if (f2fs_compressed_file(inode)) { - if (f2fs_is_compressed_cluster(inode, folio->index)) { - folio_redirty_for_writepage(wbc, folio); - return AOP_WRITEPAGE_ACTIVATE; - } - } -out: -#endif - - return f2fs_write_single_data_page(folio, NULL, NULL, NULL, - wbc, FS_DATA_IO, 0, true); -} - /* * This function was copied from write_cache_pages from mm/page-writeback.c. * The major change is making write step of cold data page separately from @@ -4111,7 +4088,6 @@ static void f2fs_swap_deactivate(struct file *file) const struct address_space_operations f2fs_dblock_aops = { .read_folio = f2fs_read_data_folio, .readahead = f2fs_readahead, - .writepage = f2fs_write_data_page, .writepages = f2fs_write_data_pages, .write_begin = f2fs_write_begin, .write_end = f2fs_write_end,