From patchwork Mon Mar 10 17:23:18 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 14010450 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55D41C282EC for ; Mon, 10 Mar 2025 17:23:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D16A928002A; Mon, 10 Mar 2025 13:23:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CC1D7280026; Mon, 10 Mar 2025 13:23:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AA1EB28002A; Mon, 10 Mar 2025 13:23:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 87C7B280026 for ; Mon, 10 Mar 2025 13:23:36 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 1619BA9E9C for ; Mon, 10 Mar 2025 17:23:37 +0000 (UTC) X-FDA: 83206313274.21.D481AEB Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf17.hostedemail.com (Postfix) with ESMTP id 768CF4000A for ; Mon, 10 Mar 2025 17:23:34 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Set4HVYi; spf=pass (imf17.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741627414; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=le7eqrsuiKcHpEYbmiuI7mTII8OSn/wYe9F5C6bWfsM=; b=CYPNiG5RZOnqechY5SWeU8b0+JEo81R+Iw7/lUXz9qprYCM9wzxYf2iVNnmXd73LSnaMBE HlMwumqM1Co2E6eGR4d3LMLelduQW9U9XtTb7mTbpAy5STvn+wVA0r1C5knSqBHOabot7M s+0ja8rtSjQFEbXCmkoRqHlW3t4hJhI= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Set4HVYi; spf=pass (imf17.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741627414; a=rsa-sha256; cv=none; b=ahF5U3huAYDTsAaJ0g4T79+9nP+s59rSfUF1hvhZjOoQlMFRpftLBj2su/pJmIG/P7WwJq deCdYQAFuqJx5rE3D0K+pJr11YN19R0okFwFggJVctQzIwZm0McW93UEU1VJ0qSTcbk+2g yXriQ8SVPjriqcqaP/DQdGzZhY89uqI= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 6688F5C1191; Mon, 10 Mar 2025 17:21:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D4A8CC4CEF3; Mon, 10 Mar 2025 17:23:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741627414; bh=P3FkpaakjLXsflqPzPkcSxDHFwcvtfrO/BuhT1Vlk/c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Set4HVYiJXagZv6AHBunmJA2YaxUOJNXk/xAV/vhDbFjpU1vNEeI+SBBALuj/M05i KURLdN1pNktQabof22sMSLvUlHkADTNX1hIHgdSslYYSh8X5MurEWENbg0as8amXZ8 3j67efJT7/8ngHcGzDhAqL3JWDpqLWmrNa3eE93RbLgP3ZaGBOJN+U3MkkZUcfemAX j2w0y5eq4tpmZ16QqA+T7gOEJOtMnGL7tyQX/IHV0A4AE+tJiAxejseb4ofZt0hmKP 64a4hJBNiaED6o2r144J+62wh3s3o/d4eb9OVTVKRL8Ck59jNEoJ81sBI1Qo/AZK4L t4BlhlGEzf4NQ== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , "Liam R. Howlett" , David Hildenbrand , Lorenzo Stoakes , Shakeel Butt , Vlastimil Babka , kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 9/9] mm/madvise: remove !tlb support from madvise_{dontneed,free}_single_vma() Date: Mon, 10 Mar 2025 10:23:18 -0700 Message-Id: <20250310172318.653630-10-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250310172318.653630-1-sj@kernel.org> References: <20250310172318.653630-1-sj@kernel.org> MIME-Version: 1.0 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 768CF4000A X-Stat-Signature: jhxgaqjqdx87mnnirqrcztyx9akp5g5t X-Rspam-User: X-HE-Tag: 1741627414-240424 X-HE-Meta: U2FsdGVkX194dW4W9sK03Rvxr/poRuzZX2t8htwI3+4D1FkaLuYcqH556w/dP9749mDv/PVBVAehJahR1DZgzKxYiEGEiCqgkCekiXL/SRdPmUPjN/3Rf9l7Br7YMJmwfAtN1lzAqmxZY5oGzL3/JaxQy35Zya7pscvuTYYXComHlQpu/aKJILdwrr/8sgdf51NtxdQL8XIXXJR1otkL3jndj1+K2+MPDXLd376Oblff8d/IJHhwYSCOLiRWlhdOoOqxCweBvp35MaJkJrbOq8E3fVj+Qd4wlaqXfMn3UBk2e8v587yvgZ1HYvTw5sp7jqF5F1l4iJph3kmU0UscjS98bvShWK08/Cc0IdUH7zAkw5COvPV8bnxS8ALlF/BwJXU7TyD5HhwIJTwg0D2OBuxo7HhzMhyXiAKmYME3kWJsFyBgO9n9iQRinKdxuSLFca3cYtPgVmB72YUkKMiquVnISWJFKw4tIm5yI2ti8YKQk+2oRLPfXoau6SioylMP1qIDBGZodjgPjnhq4VW9KtBuSk2JhBm4PpLQDNTit5o1tXBp4QLoPWRrXBIod0C/cAZK1T6uQ7P7LgwI6NgQ+1w0WjEQ+pw/ERreeT89oicKLEgUDpxaNMxkmhlC1zGtJ/mLYo5gmkCxxAv1KOFva7kSfLPLKkLDNsOUpoUSShdW0VINR5OwyvVhGfo+H5MfrXZKT56xPKhITqu1NvKUXp9Jg66NyKTpg8edBNd9spl7YAiR47cPrbIkl2TDT5XCUmT2/CvWYBoOTfUFfO+xZjmjaLORVdtrflEsqrNTTzCwTwuMB4KyAVryPmZmkhfQVVoK5BCtEp82muWP9ka53NI9JQ1vHugzJkpUNRGgiQDK6PqCDSNFIr029xB05F8k5wc1kBjkLpNpVm5vTFLCgQhyOLX3Y24LP+2yI09eDmFTd3o6D08HvIeNsBuAodHKK6s+X2/TWTej/CqWEb/ 3cLvIisT Q6WidoDxcXplFZQz8PjTt3JPLk34VBJNJpYREr/giRaK1OM+SOx36+Ild6fGnZW6paFVfRI7J2FJO/VPYyv+I1OOZO4b7CFJjXIkOB+/h0UZd9Fh9uJDI12SWZSsR70VS+dTSbpVKJJRmHA71i4gRK/x9aLYl3J7gy3QHQTB3nm09vct4plZR0qsMHlbQ+ENlApO8aK56H9o96zyD/IDoOnc5qKgVAaEMt1lZDiR8LGs4356tftsG/KCGkY7W3Zt6NNBh3LX4aScaRSffgHPcswKRWdJm2yDI2epYNQxglLjCBDn4XkaUHrelH438B6JXvWsj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: madvise_dontneed_single_vma() and madvise_free_single_vma() support both batched tlb flushes and unbatched tlb flushes use cases depending on received tlb parameter's value. The supports were for safe and fine transition of the usages from the unbatched flushes to the batched ones. Now the transition is done, and therefore there is no real unbatched tlb flushes use case. Remove the code for supporting the no more being used cases. Signed-off-by: SeongJae Park Reviewed-by: Lorenzo Stoakes --- mm/madvise.c | 19 ++----------------- 1 file changed, 2 insertions(+), 17 deletions(-) diff --git a/mm/madvise.c b/mm/madvise.c index d5f4ce3041a4..25af0a24c00b 100644 --- a/mm/madvise.c +++ b/mm/madvise.c @@ -795,18 +795,11 @@ static const struct mm_walk_ops madvise_free_walk_ops = { }; static int madvise_free_single_vma( - struct mmu_gather *caller_tlb, struct vm_area_struct *vma, + struct mmu_gather *tlb, struct vm_area_struct *vma, unsigned long start_addr, unsigned long end_addr) { struct mm_struct *mm = vma->vm_mm; struct mmu_notifier_range range; - struct mmu_gather self_tlb; - struct mmu_gather *tlb; - - if (caller_tlb) - tlb = caller_tlb; - else - tlb = &self_tlb; /* MADV_FREE works for only anon vma at the moment */ if (!vma_is_anonymous(vma)) @@ -822,8 +815,6 @@ static int madvise_free_single_vma( range.start, range.end); lru_add_drain(); - if (!caller_tlb) - tlb_gather_mmu(tlb, mm); update_hiwater_rss(mm); mmu_notifier_invalidate_range_start(&range); @@ -832,9 +823,6 @@ static int madvise_free_single_vma( &madvise_free_walk_ops, tlb); tlb_end_vma(tlb, vma); mmu_notifier_invalidate_range_end(&range); - if (!caller_tlb) - tlb_finish_mmu(tlb); - return 0; } @@ -866,10 +854,7 @@ static long madvise_dontneed_single_vma(struct mmu_gather *tlb, .even_cows = true, }; - if (!tlb) - zap_page_range_single(vma, start, end - start, &details); - else - unmap_vma_single(tlb, vma, start, end - start, &details); + unmap_vma_single(tlb, vma, start, end - start, &details); return 0; }