From patchwork Mon Mar 10 17:23:13 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 14010444 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15358C28B2E for ; Mon, 10 Mar 2025 17:23:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 21CD7280024; Mon, 10 Mar 2025 13:23:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D12628000B; Mon, 10 Mar 2025 13:23:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 06B69280024; Mon, 10 Mar 2025 13:23:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id DCAA328000B for ; Mon, 10 Mar 2025 13:23:30 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 711461A1310 for ; Mon, 10 Mar 2025 17:23:31 +0000 (UTC) X-FDA: 83206313022.09.C65FAA6 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf16.hostedemail.com (Postfix) with ESMTP id CF1A8180016 for ; Mon, 10 Mar 2025 17:23:29 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=GElwyusP; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf16.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741627409; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lI3TwUnH54UiiRxQDoJXdOa/94ioR5BB4qZlg/lOUG4=; b=CwPs9pTKXg8DFVD3Qqo557CxZc6GRFx4MdA6i62dqk7tjZah4qv2M0edo99nj2j8K+6kse rmaqE5eVPzX5SZHFtXC7FwObIboohd2jWGXlrS6/NCEHEa5LhGLtoLngqJv+euPbtY7EmW VeyPzwbkzRhmoeRIiUHJW3SiTs/pUus= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741627409; a=rsa-sha256; cv=none; b=c8wJR8gRLw/qUUVVHPWo93BqWjoNC6w7hMqSlO+bGGOlVjCG28wjVlQLHpsbOX35ph5VmY 7Y60wayhn72BJFzqUeVtZBdnd46XdfhbhUaX4kICcvRs8IP+eQZmN7KzYS5Yb8BrjWHJqt BkkcaWAGLqXIfwGbnFYXMQRDHFfHV3c= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=GElwyusP; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf16.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 38B485C550D; Mon, 10 Mar 2025 17:21:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6388BC4CEEC; Mon, 10 Mar 2025 17:23:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741627408; bh=Z3sSqaG1uhkCQqbFP7NKK185LV7FFPBVBGM4l1BKW9I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GElwyusP/WtY+XI/onO9LKP/4XGLXdBGbtjzZdwAGOE+F2xfTt6R/VDsNLdlx+0oZ BBKfLvM7iAu/KTC55Szh02Mfi4ajdSBhMaMRPxk7Dju5LCrOFP4yvqRnEraUQNijrT 85tjmyujh2l7Yj4mEk5zlXDgXBw3pseUyDEbTrDQ7NCSP0ohbe/IpYetUZD5quIBFk WRytS3AOLmgHHaThSSqghYVqfm03VCfkdjN9OGQZ0M63Ipvt6NLtyTfhQNsTGzenTU eASBFEQCg+i6eFPetX/VEhwS5Qx/W4Quts1/SEA7O6vOaH/e+/YIqOC6CeMogn+Gmz 0+QB8QKk5/H8Q== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , "Liam R. Howlett" , David Hildenbrand , Lorenzo Stoakes , Shakeel Butt , Vlastimil Babka , kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 4/9] mm/madvise: remove len parameter of madvise_do_behavior() Date: Mon, 10 Mar 2025 10:23:13 -0700 Message-Id: <20250310172318.653630-5-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250310172318.653630-1-sj@kernel.org> References: <20250310172318.653630-1-sj@kernel.org> MIME-Version: 1.0 X-Stat-Signature: z84kzdstbm9ii946bh4q3uw7zq67s61j X-Rspamd-Server: rspam05 X-Rspam-User: X-Rspamd-Queue-Id: CF1A8180016 X-HE-Tag: 1741627409-490651 X-HE-Meta: U2FsdGVkX18HtbvKENRVi37YCKBN4+yjL2mLQBnWdQJ4AkqOVLgwx+G7FGA90Pzc6rQkTcMxecAO7V72nzxqkPp34Lmh15zjkqBKJHQ+lBqZjghB9T1f7U9RnhizB1jUixgzCuvkGopbFkR81nKKDYKJPKRa56TIrhCLHt0m7WuDk9HdcU11RMw4syqR1lYX1G2ajbEVCezn1PaXyPKxOyG1YyjzHaANtndrycqb8ZDFSy2IZBtXkKbpUiVxOKIxcst5ZqwOnufJJgjGp2+x5h0ivS/Rtrsm24AtVk3Jczkvxy5PnAaUWfZ23RTvUNnxKAO0c30ij+Tfu8luvzrJr9Z45WkhcT9V2g6qSrakHLyywfNjzYWTsGPjUb3bRqM5LuuCciPoPAO96Pptthq3adCcGwwn0TtqkoRthO7nuCPZOPlG2Yv3vt+4KVhdEcNiI8/gnmLIHSBezLONGxB8cSj+m90gqphwo8vcCJdZ6lXWxHcE/EkTigalxXfGZHHxGUv8Yt8ds/Al7D2U/pVKjKj07OyAIvpSee6FaZu81jsOtr5gQgwu5MXfHepmceVxYD5fGWgSKJEOzRbGv+8at4DUZlq245x3sujY25oOubGOagmRpi/jwqPnHWqicG3OyVHzI2irqdOM/cK5Q73JcoqX9k/I9EZJL7LnVpssSgQROnvqg3AiQkpNgn24DCVHO/M1dH+L8NT6unA4yEyURxk3gbhPI54GwUStXgvSPZMGHHgNypm/dSLqzaTYcbXyNmOnigSqsfJyAHPUsKDNQuhRiyoYYByi7ap8Q+83JYazG/kNqwQf2ZkglkZ8ym0eQWkZx+XMCfuBzpoS+FYVwqiUbnOJvAA1t7QSE5ewg9JGKo+D5qCjlbwVzv575ngkuHyGCJTk43l3sdzaEW1byW+T0M3cUQC1fez5xml8iQC2kXTCPEtyQkKIq1dy0mO6v5PbJAy8rC8kN7eEqcC VOOjr7Gi SvTPUvt4Y0z6B1ETF+oXXllIg/yvtl9EmvUDld/ZMcB05ZuYmWrKS4m1K4t1A5wH+C6BabvvQJP56+yH+Jqxpaiq1RbEmrqPZ1pZmP5WL+O4CXC2D2k7EBvr8FcsD/XlAeOEarUrFWrYaHJkUZAHBqN5gT/M9e5pVnWyKN1+m+0D7Z6oEF0R11jxftXIHr73Ewj57o36YiYRQF/qR7y6UYJV/YA/N9I/C7LbZrWg+zLnUnz+Rt52UXaavSN/yI6hf4+Dql6aUe4E2ysrYwlgi0ivi4g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Because madise_should_skip() logic is factored out, making madvise_do_behavior() calculates 'len' on its own rather then receiving it as a parameter makes code simpler. Remove the parameter. Signed-off-by: SeongJae Park Reviewed-by: Lorenzo Stoakes --- mm/madvise.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/mm/madvise.c b/mm/madvise.c index 764ec1f2475b..469c25690a0e 100644 --- a/mm/madvise.c +++ b/mm/madvise.c @@ -1673,7 +1673,7 @@ static bool is_madvise_populate(int behavior) } static int madvise_do_behavior(struct mm_struct *mm, - unsigned long start, size_t len_in, size_t len, int behavior) + unsigned long start, size_t len_in, int behavior) { struct blk_plug plug; unsigned long end; @@ -1682,7 +1682,7 @@ static int madvise_do_behavior(struct mm_struct *mm, if (is_memory_failure(behavior)) return madvise_inject_error(behavior, start, start + len_in); start = untagged_addr_remote(mm, start); - end = start + len; + end = start + PAGE_ALIGN(len_in); blk_start_plug(&plug); if (is_madvise_populate(behavior)) @@ -1775,8 +1775,7 @@ int do_madvise(struct mm_struct *mm, unsigned long start, size_t len_in, int beh error = madvise_lock(mm, behavior); if (error) return error; - error = madvise_do_behavior(mm, start, len_in, PAGE_ALIGN(len_in), - behavior); + error = madvise_do_behavior(mm, start, len_in, behavior); madvise_unlock(mm, behavior); return error; @@ -1808,8 +1807,7 @@ static ssize_t vector_madvise(struct mm_struct *mm, struct iov_iter *iter, if (madvise_should_skip(start, len_in, behavior, &error)) ret = error; else - ret = madvise_do_behavior(mm, start, len_in, - PAGE_ALIGN(len_in), behavior); + ret = madvise_do_behavior(mm, start, len_in, behavior); /* * An madvise operation is attempting to restart the syscall, * but we cannot proceed as it would not be correct to repeat