From patchwork Tue Mar 11 13:18:23 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brendan Jackman X-Patchwork-Id: 14011872 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23D79C28B2E for ; Tue, 11 Mar 2025 13:18:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 33CDE28000D; Tue, 11 Mar 2025 09:18:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2D304280001; Tue, 11 Mar 2025 09:18:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 059FA28000D; Tue, 11 Mar 2025 09:18:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C6325280001 for ; Tue, 11 Mar 2025 09:18:44 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E67BF81F50 for ; Tue, 11 Mar 2025 13:18:44 +0000 (UTC) X-FDA: 83209324968.23.A29A99E Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) by imf09.hostedemail.com (Postfix) with ESMTP id 1E0A8140017 for ; Tue, 11 Mar 2025 13:18:42 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=LjsRqoFr; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf09.hostedemail.com: domain of 3MTjQZwgKCCgNEGOQERFKSSKPI.GSQPMRYb-QQOZEGO.SVK@flex--jackmanb.bounces.google.com designates 209.85.128.74 as permitted sender) smtp.mailfrom=3MTjQZwgKCCgNEGOQERFKSSKPI.GSQPMRYb-QQOZEGO.SVK@flex--jackmanb.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741699123; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YKUi+ss9u14qyT/Zwiy2mGBFpcrhT9F3tYQ4X8eVY2g=; b=g02UfCvfcqsvnk2u09l8S+8YWjRjALv4EZHR7wxFUoEiJIwWOahwNW3EM9MQ+8labOzVbn 8n+0K8ljUY9rHV24oXQNr9Xcnfdoj+c9sKpuwI0lwVtey/1bgO9dzI8P6yKwtZ4kN1+0CV bHYRlXW4kvweX1hl/I/xceVvKDR71rY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741699123; a=rsa-sha256; cv=none; b=lJREOZ7/JN4tmgc1QYqXe/s7w2Nk7oy/pPdLm5+9yD/5eAnUdaFyZqinPLrpaU8n5dkYC8 eI0klfFRlZN4OurG7U+9Dr2s2yFs3wqG7Xcr6fg+X/41OP2+QfnIOtfrF4PsCm2c37AGwz 78NEgEGcRUbK5/tqrAcucVcry1W8xNg= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=LjsRqoFr; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf09.hostedemail.com: domain of 3MTjQZwgKCCgNEGOQERFKSSKPI.GSQPMRYb-QQOZEGO.SVK@flex--jackmanb.bounces.google.com designates 209.85.128.74 as permitted sender) smtp.mailfrom=3MTjQZwgKCCgNEGOQERFKSSKPI.GSQPMRYb-QQOZEGO.SVK@flex--jackmanb.bounces.google.com Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-43ab5baf62cso38005125e9.0 for ; Tue, 11 Mar 2025 06:18:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1741699122; x=1742303922; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=YKUi+ss9u14qyT/Zwiy2mGBFpcrhT9F3tYQ4X8eVY2g=; b=LjsRqoFrUkbinutXqUnckYUFzfrCJ4je20/3SR7Bpidlmgsc67H1tdsCLz3QteAQAx dRY4JKZLZlsivJ/dvlahc9GnJd29HcFbxjuPA2c1DGlr2N6pRNjqK/0dxRqXITRiqqkE WK7ku0ikLNDxG+bfRHLP9ZQHk56/qssWKYzU20aydaYcIBePPbA1L5M+x/GIjqEu1W+M CCWvC/MWSoyi46w1L/TaIC/+5GAmuxQPeOkq7h1obpV/pm2jW+sqeblohPjkTo9SPWIm 9N68OG/kF1579H6Lpso82SiLe0VWzMvgvq+iJagWZtckn9ggq4RY0WbD/NhDu58KDlXK hnxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741699122; x=1742303922; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YKUi+ss9u14qyT/Zwiy2mGBFpcrhT9F3tYQ4X8eVY2g=; b=SvQn1jIzGLDwqlT7Zl1dbdb+y43emc6s1/9BIqEZ0ivC7SvXCOdQuKuDzUyG7qEtBq Qxu6UfF2Lkdogp5Dz9zvhpliCnXKZS0/QPTQlF7Va7JtGO0iuweDxP4k5Y0FXYTqviz7 mCVAP799dXk2BsbaNZQQWAXRQSC0d2TSZqnL2/fA6k0hoJjowxfVCapLskKly6K7Dulj G7kaORvja6TMuNKcRCZGUZvGKAC78f5h4ys/pSqVg9iSRNvj8A2vXK12Ta82LNDL7Mmg yW8towpvz9l7KTABU/jKjT8OpwRSdLy6ZZczkzNp2wAL+35+eDbN9idLk4/8GewO/16S gtpQ== X-Forwarded-Encrypted: i=1; AJvYcCVxEUFu1Xnk5Ad2Hpg/q9S/7L5JF+/GfEfTor6tFH/Ut7HZk8aRGLb9ldLkbW+yuKd18aPYyivyQg==@kvack.org X-Gm-Message-State: AOJu0Ywtou5AHzn1oD8VAKL7BulO9LVaNG3cftWCTvNPjMzounGJFPiz vRsJ2GK2q2ifdvEm6ik5bd/tWkdV5vysiHw3zA/XxbB5GopdaPlT88O71pVIPxSTdkIZ9+IwK41 Nv0G2EZxwbQ== X-Google-Smtp-Source: AGHT+IFEGPTY7Ml+tuTOynefjzLO+UpkB6moVI+rzTawpqu6Ohcjxyu/ir2TjMNVGvCGq6alb9Lb1cZqdGxcFw== X-Received: from wmpz18.prod.google.com ([2002:a05:600c:a12:b0:43c:ebbe:4bce]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:6d9a:b0:43c:ef55:f1e8 with SMTP id 5b1f17b1804b1-43cef55f398mr97810345e9.13.1741699121899; Tue, 11 Mar 2025 06:18:41 -0700 (PDT) Date: Tue, 11 Mar 2025 13:18:23 +0000 In-Reply-To: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> Mime-Version: 1.0 References: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> X-Mailer: b4 0.14.2 Message-ID: <20250311-mm-selftests-v4-12-dec210a658f5@google.com> Subject: [PATCH v4 12/12] selftests/mm/mlock: Print error on failure From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman X-Stat-Signature: dg1qt6zj97jm8z66hf33p4htafrmfssk X-Rspamd-Server: rspam05 X-Rspam-User: X-Rspamd-Queue-Id: 1E0A8140017 X-HE-Tag: 1741699122-243322 X-HE-Meta: U2FsdGVkX19Jb6AY+LGZhABIvE1yiNgV2BOwuQGNJ8lZi5gnkVDy8RYlD6j8a9ZWf0ywqA1k4ZrOcejOxCfvX3f6kkbZOZnwfEqcgZYRvF5JqNquZseuTTHeBNbHj2HPTpwGXmuSygSws4GT8oB2OEKPPMyXg0aJwtBdAiWzaZG9nm9pzhsepAnFFfRmbKLdUH9rFURRMUKt7c5SoudUDzeCts40ptYc7l1uJQsR/neFO94ByGAZTgtog54+312qrNXs7ACYV3k5oYRYtu1Gl9M5zzn6fyhFN3fX3gZ00WOIA9C534QavZPY94c2K4LQSriJgqWYt9RM3QAv//c2u0VguDvDSUrfNTycKL/Ur7XUfJRgN+LpxONVivd+cq2TA7+aL0knUN1fb9bFjM0cxG8tNHtIg4c/ShHmRdUgdUZL03j9bLWHaYNvAsgDeKxyYz+I1I1JXj0aJFIq/M7JFGu239OsP1YrfQXK5RxrJLkyPKWKxiBo2RMIn4+dWAF+iO98SQtd4+wpAYklleWjCouMQY+zJD/zfF7mn0AQf37zJuECRojOR0deExytuIJRVwVI9Oks7OiyoQGKdF6Vxle5YWV+QxC2peq5FdU+D/alf5fSX0v+qmFtxRWyjbL4r5J5EVmzT+qzbQ45rEkSsk4u3Pak5Zn6YP42gW3vbQUq/VAJFSgRLB41bBJZ6DJ8EwlpWOhnYC0FGodRdF3NaeApO9Ryo7/hLWZ0uW94h7jPRk4pAILJAOkKewZtRlLJvETO8/IKyw3Z3XdXq3eUn8cVJZwuroyzELFlldzP3Z/cj8PgNTCCEci3+ilIVj03CdcZlOLFizzLYLf7PCF/zzQ2TqrDh0hX9edRX965D6KUy7lNPG1RyjMism2O5qd0XCbeMyYox7yaVJpiKirBJG7HJGTMqSLmFLz7RCPyKahF79t3uEC3njbM5GbP+Btnrgc4KCgxngmUBfL4DdU nvAiRAOy G0PEysbuZaHCURUkcLq+jkKoXTljgMIDb2NJk/IPKyKMh+N0pBgv0rnSU5h1fppKEKxUGvuszLG92IX4rTus8CGN2zNyFa44AEbn4HnYigO1sjGb/r4dCczWVH4huKOUwZ+6cAkgwiMKIuPr89b5DNHTobKDZtcCj6TRh15qqin29RU/ZiiPSfADIgoBSgaJSkK79ecmKzyGx/Hzju8M30Zjp9Kr4ztbel+kB8YAp4aM0nPeNkfYUtFXChIZAT/S1BeuPuyOq7NkU1jWv7yj+UEXlvo8pTkyPPEUVG9XI/PevuyWM5caazUrcU2HP0lO1zC8dfWgG5joqZzCaj1s0QHLTw8ZNXl4fVKuHRSMnQY0ADqS8HLX1vt7vbTGUEw9mDFv6iNU8ulH9YJOw2wUVC0ulRLjLQQ+sZ5Ya34+C1qZmZyUSL8ADhI+ozkeql05x1yHlKXBKGxNCA9L91K9YdTMMzUBhKvss8aR+xWwUDzSz6+2jd6JiIVaq2TNrEVP2vSxjsa2wLBVysBSjr0G6GLFmCXbTdbNiYVb2h9iyRBZ5+4XzX7ryMnNZ7A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000228, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: It's not really possible to start diagnosing this without knowing the actual error. Also update the mlock2 helper to behave like libc would by setting errno and returning -1. Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/mlock-random-test.c | 4 ++-- tools/testing/selftests/mm/mlock2.h | 8 +++++++- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/tools/testing/selftests/mm/mlock-random-test.c b/tools/testing/selftests/mm/mlock-random-test.c index 1cd80b0f76c33f04ef01f4dee6602f28b6a7c991..b8d7e966f44c67e5606d384bd660e5a4e5e8fda9 100644 --- a/tools/testing/selftests/mm/mlock-random-test.c +++ b/tools/testing/selftests/mm/mlock-random-test.c @@ -161,9 +161,9 @@ static void test_mlock_within_limit(char *p, int alloc_size) MLOCK_ONFAULT); if (ret) - ksft_exit_fail_msg("%s() failure at |%p(%d)| mlock:|%p(%d)|\n", + ksft_exit_fail_msg("%s() failure (%s) at |%p(%d)| mlock:|%p(%d)|\n", is_mlock ? "mlock" : "mlock2", - p, alloc_size, + strerror(errno), p, alloc_size, p + start_offset, lock_size); } diff --git a/tools/testing/selftests/mm/mlock2.h b/tools/testing/selftests/mm/mlock2.h index 4417eaa5cfb78ba2bb0f51d3418c9b768ff0fe90..81e77fa41901a095cc041e05d01da7dffbf2f4fe 100644 --- a/tools/testing/selftests/mm/mlock2.h +++ b/tools/testing/selftests/mm/mlock2.h @@ -6,7 +6,13 @@ static int mlock2_(void *start, size_t len, int flags) { - return syscall(__NR_mlock2, start, len, flags); + int ret = syscall(__NR_mlock2, start, len, flags); + + if (ret) { + errno = ret; + return -1; + } + return 0; } static FILE *seek_to_smaps_entry(unsigned long addr)