From patchwork Tue Mar 11 13:18:13 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brendan Jackman X-Patchwork-Id: 14011864 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AF1AC28B2E for ; Tue, 11 Mar 2025 13:18:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1727F280005; Tue, 11 Mar 2025 09:18:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0D1DE280001; Tue, 11 Mar 2025 09:18:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E41BB280005; Tue, 11 Mar 2025 09:18:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B51FD280001 for ; Tue, 11 Mar 2025 09:18:23 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id CC4B781F44 for ; Tue, 11 Mar 2025 13:18:25 +0000 (UTC) X-FDA: 83209324170.18.2B298DB Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) by imf09.hostedemail.com (Postfix) with ESMTP id A579314001A for ; Tue, 11 Mar 2025 13:18:23 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=16+sEb6f; spf=pass (imf09.hostedemail.com: domain of 3HjjQZwgKCBU4vx57v8w19916z.x97638FI-775Gvx5.9C1@flex--jackmanb.bounces.google.com designates 209.85.128.74 as permitted sender) smtp.mailfrom=3HjjQZwgKCBU4vx57v8w19916z.x97638FI-775Gvx5.9C1@flex--jackmanb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741699103; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eNnWwlE7ZfA4njYaSa6+RHThvRYMfszFV0jljda2YI4=; b=qO60iN/t3idz4aNqgayIAuFMd2aQbblaTn3ESvpeC0vmc492yV5zSiZ61aQX+Gbi8r4r6b veFCOa3BcTNgw1peMKTZdC8FyaRZmJ4DoA7cjobSxMPrXQ8Hf770Yd4QFDvl2b9HlhtOd3 CHV4YX8Ntx1b6M/zYK4K/l/1JLJiIl0= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=16+sEb6f; spf=pass (imf09.hostedemail.com: domain of 3HjjQZwgKCBU4vx57v8w19916z.x97638FI-775Gvx5.9C1@flex--jackmanb.bounces.google.com designates 209.85.128.74 as permitted sender) smtp.mailfrom=3HjjQZwgKCBU4vx57v8w19916z.x97638FI-775Gvx5.9C1@flex--jackmanb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741699103; a=rsa-sha256; cv=none; b=LuvVG/06Y7EzK8RR6rU+XbwS36iBeRc+hY2vlDo9fGtn1RYKCH0FDLxfoab0fIr4+TwnjR 3tOJYUNb31nB2aAs2JQXJ1yk6puEhpubOKpjGCRawLFNTsEFXhcqQeZCCXRmz3JWBcmR2x 18XxYqqWr/nQsitOWB7ocZoaYYF5SSo= Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-43cf64f1dc5so12734045e9.2 for ; Tue, 11 Mar 2025 06:18:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1741699102; x=1742303902; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=eNnWwlE7ZfA4njYaSa6+RHThvRYMfszFV0jljda2YI4=; b=16+sEb6ftctgVSweswrnAdSQvDi6rrVf/+y5KL16B86fc1t6m1T3EcTvVeUqXrp0Au uMv8qH1kXRl3XfVeoJOKFPtmNacue+nG4jdNAXp9D8RCIQ0z9bJDooiCqtlxqFNQhEFn 1obFtl3sW87BO12GDGqGgfTlmzu/XbtwUNfaboTxNqP140+HUYeFUUrzX/U36+qcB1Pc +5PQy3xR0Td2AZVKBVlAeTYUNgy/hwrPSuD8NDpBUjv88v70zy9NSGF5ppTYdUiw29so +kaEQs44+r2zjB6PVHICDEr0H+34AECiLO8RLisK3EPC69MCl5wsBXXN6J0aGWQrrgIi fqGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741699102; x=1742303902; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eNnWwlE7ZfA4njYaSa6+RHThvRYMfszFV0jljda2YI4=; b=AFTbTsd3hOPhfbwm/9icXtgS32maLi1vl+5x72JtsZmnn9WRQeWWL1oS2s2QwLrMHo qhzV8/ZWiannS8ZW2rVrgaQ0h/Gt7G8EolOPCWRe58sB9UnbubjkkzpIVXNpJmDfFbbt Qu5TRKI6cO6V4Na9nMsTJ9KneYGz0+o6orEoIM0CRdpd9NDCz8sD+WzfGzw2x2DgCTPk krfjfktspOXRPC7+zGtSbVNQrRlkh/Ns0xlJ+PrrKnUK2sqhRA8PYd39/UjQ55ks807K B7L13i3dm2VkpDfFDCG+2Vo/Fs0/1rDa1J7P+/W6Y2Z1HQFlI6fRyqQMi9yLJ+B89+4x JIsw== X-Forwarded-Encrypted: i=1; AJvYcCUEyvgFk+2W4jFeHZCztburF91Ll5F2OMIIPfLH3PV5OHLbo4biPJ3cHACLCeWuGnYZmp8QPVdxRw==@kvack.org X-Gm-Message-State: AOJu0YzHVJM5jvNRWxAuSv4WYunT4PF2DvQ+T35PSBe58t7o9VWK7uB/ HqhJk3Lr2YwOUY02SfOPYPSZ/N2RMva1Srmyiplky/WHtEfHRLa7YFbkoyaprJvmBCz8PRzXJ/a a+9Fd0j353A== X-Google-Smtp-Source: AGHT+IF00DB9vxEjSFZYMwiT0cUkAqXFwWmkRj0Y1btbCtCISAk52bWxBSSNcRq9+pCP65pccsXXfMuEUhHyLQ== X-Received: from wmbfk3.prod.google.com ([2002:a05:600c:cc3:b0:43b:c336:7b29]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:3512:b0:43c:fded:9654 with SMTP id 5b1f17b1804b1-43cfded98b3mr57431755e9.19.1741699102457; Tue, 11 Mar 2025 06:18:22 -0700 (PDT) Date: Tue, 11 Mar 2025 13:18:13 +0000 In-Reply-To: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> Mime-Version: 1.0 References: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> X-Mailer: b4 0.14.2 Message-ID: <20250311-mm-selftests-v4-2-dec210a658f5@google.com> Subject: [PATCH v4 02/12] selftests/mm: Skip uffd-stress if userfaultfd not available From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman X-Stat-Signature: y56fs56fmhazxxx7dbabn1pocmezah9d X-Rspam-User: X-Rspamd-Queue-Id: A579314001A X-Rspamd-Server: rspam01 X-HE-Tag: 1741699103-921536 X-HE-Meta: U2FsdGVkX1+t6nfN9ZoXDT3FaEUEKWO6y3tGi4B2MBOZ0ktAqJKrEfgDftZi0BYDT5NFlGcGhqKH8VuDx8lj/BeYfXkfWAbx3NMNk2WoHiMnXYdb1/Wj4cVtEtOyM88AsxpH+PcWM0iDFP/iovIYloE2cv9Y0PmOKeEn0AMdd6T2WK/FBuINDN/a9ygblNa/LyuoTkl6VArplKTXDYXkJMuwM8wTDvL9cCtSkmtQDwrecN4z7YTon1DeL8pFN6yeHTf0pzPTEyFcU57s5vJbsonKf8mG9fS5RkSvIVidZvD8GiyqEvg3qaqjJlt8QXCJmJhvwy3nBj7TW2itk2DDtLxz6skTlhw/ahCeBEekvyizQOhXDlmxOqhBkjXQuklY4+3SGAtQnhjeVWGLJ4CKx0N0DnV1qMTtnXV65HnDDrnNy+hzWy0Y48yfzGMsCOK8qGOCEjrddfCedZeeNryuitDy9misRi6Ki1/ewuPwKiivEEVVn96a8SfusiYpxzlDp8HpGMHw+pGuj9fAWilVDaPB3g5cP7V5Lnp8xmEuytH187hODVSHWto3VvpXWpbKVrjW6N4iNP1MXWM9n4Jey1Q6VAqF6uoCg4T8ISX0vbEeR6fjszi2WWphFjMJyLNGCQws+hlBeBdOMD3E6zvr1d76EQnHq+ACXONvDI4W2SmWxjK+kGfJLVsPnqpz+ZKzvIJtSTeoHbEeuI57GBWdswKah+SXc70eWBwZ0z3mVzRbHLbPCrLm4P4kO+glfGWpduA21kV4G0Ygtgn1WFQxo4JzRhknEDQKQqChefgj//d8skz8oHOta9XtrFQRbKVPwgmBXu0psVuDPU47Tgt/nsX/mL5wsVKUyZUU8uwAgWehczgUbN2nT901yQqFQpIMu46ZR4jefm0QYicJL3TEcpYCYbb11F3IsOMj57OBh3Vff2KSTJpsZOxRDW7u1CPBwBjFrTQSUe4W8QXgspp lTrFiIjd +5YHekKsy4jNqQ2e0resjhWM3KQ1TXIrfQqOocSyBP5TFh/Ntp4gwxK07D2qBA1BxknTNRHBNnTqfm1wgxxvEpaTa+Z1a1WF7JwJH47MBeKK7FpoxAVrLH1dqXaPEsnI6I4Df70Cj32ba9ck1KbIt8fCz21vpuSgUimIgTBWwam6disE8Jce0pQDfoDOhY100kubpLpCyu3UVuZdsTpjCCYLEK77+2moOBC+PoRqLe2NDXZAlSbTlPefS+zeD/grnuDMwB5pdrGmljeol118nLP6i9+4nxbnOiBgHLO5SqGufUcatKFYIiYNn4iwyNDNrwOoBuxrK0Pnqxat9ve5hnod0jMniAT+DxDvZCuROpzqBW79sJpU+8rbqvy9JD7wzsGHjENsxorAaeQS6NhQRBboxTUKcLKge1VngA2P0f6iGmsdz1+6K7kpr/t+eDGkCOWtPeJStJUlxkHRZM/RYIZVOJUUtzi1ApWN20rIKnQd+jgrqJXtn/srY2hnHZ+KrLNgcsvNSoP8BeOgvgaPWUBPgHpHKks7Iyrkn4U261HBwfnyg8XMCrAYiX5ARBEBJuVsevKiUhK1s2LVxaBPiFXA8pE6LXH80M9HIQ6MNW5w8nOo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.067406, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: It's pretty obvious that the test wouldn't work if you don't have the feature enabled. But, it's still useful to SKIP instead of failing so the reader can immediately tell that this is the reason why. Reviewed-by: Dev Jain Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/uffd-stress.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/mm/uffd-stress.c b/tools/testing/selftests/mm/uffd-stress.c index 944d559ade21f255404eb38557660e54e81d46b8..91174e9425cde2500b459db78cb27adda6647b55 100644 --- a/tools/testing/selftests/mm/uffd-stress.c +++ b/tools/testing/selftests/mm/uffd-stress.c @@ -412,8 +412,8 @@ static void parse_test_type_arg(const char *raw_type) * feature. */ - if (uffd_get_features(&features)) - err("failed to get available features"); + if (uffd_get_features(&features) && errno == ENOENT) + ksft_exit_skip("failed to get available features (%d)\n", errno); test_uffdio_wp = test_uffdio_wp && (features & UFFD_FEATURE_PAGEFAULT_FLAG_WP);