From patchwork Wed Mar 12 01:12:36 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Liu Ye X-Patchwork-Id: 14012797 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C93FC282EC for ; Wed, 12 Mar 2025 01:12:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EB6F4280002; Tue, 11 Mar 2025 21:12:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E65D7280001; Tue, 11 Mar 2025 21:12:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D3089280002; Tue, 11 Mar 2025 21:12:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B1D5B280001 for ; Tue, 11 Mar 2025 21:12:52 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9CBA753A85 for ; Wed, 12 Mar 2025 01:12:53 +0000 (UTC) X-FDA: 83211124626.19.ED7FD65 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) by imf14.hostedemail.com (Postfix) with ESMTP id 8BD35100002 for ; Wed, 12 Mar 2025 01:12:50 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf14.hostedemail.com: domain of liuye@kylinos.cn designates 124.126.103.232 as permitted sender) smtp.mailfrom=liuye@kylinos.cn ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741741971; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references; bh=A5hj2hLsDUdFcSc6x7qrTBDZ8dtDAp4psn5BdOgIktk=; b=0qHM7va4p5xZrudCs+PjKPCYjLb8kZvdStiv4DJ4qYd44SaSyj5rbTDs4QNGOebZkuEwQn lLBWgp55wJxAoUD4OrqO68F9PUdl96bqzYjgd0Lwp8D7+nTGZ+HHXEJEjfEYRv9GTUgrwl b3pGduSD8MTd5QVk7bNGeYXRz3gpcfo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741741971; a=rsa-sha256; cv=none; b=M9SHIE65mdIdGFWcnaiL+5//dUl3R5s0u1mEb+vfy9EqJCQl36uDqZ1ylyN43BlsgzsZpt kI398rguC5dzz18/+6oPMtDYyy8j1o+BRCzIFEf6Hm0bs2BGhUBDa8QYVKRkkAQMP7xFMm TblU4/7CTuN2u8fmRIA8QnWhxSLlPXw= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf14.hostedemail.com: domain of liuye@kylinos.cn designates 124.126.103.232 as permitted sender) smtp.mailfrom=liuye@kylinos.cn X-UUID: 188ecadcfedf11efa216b1d71e6e1362-20250312 X-CTIC-Tags: HR_CC_COUNT, HR_CC_DOMAIN_COUNT, HR_CC_NAME, HR_CC_NO_NAME, HR_CTE_8B HR_CTT_MISS, HR_DATE_H, HR_DATE_WKD, HR_DATE_ZONE, HR_FROM_NAME HR_SJ_LANG, HR_SJ_LEN, HR_SJ_LETTER, HR_SJ_NOR_SYM, HR_SJ_PHRASE HR_SJ_PHRASE_LEN, HR_SJ_WS, HR_TO_COUNT, HR_TO_DOMAIN_COUNT, HR_TO_NO_NAME IP_TRUSTED, SRC_TRUSTED, DN_TRUSTED, SA_EXISTED, SN_EXISTED SPF_NOPASS, DKIM_NOPASS, DMARC_NOPASS, CIE_BAD, CIE_GOOD_SPF GTI_FG_BS, GTI_RG_INFO, GTI_C_BU, AMN_T1, AMN_GOOD AMN_C_TI, AMN_C_BU, ABX_MISS_RDNS X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.45,REQID:cca12701-6ab0-466c-9635-9c1ff00f7774,IP:10, URL:0,TC:0,Content:0,EDM:0,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTI ON:release,TS:-5 X-CID-INFO: VERSION:1.1.45,REQID:cca12701-6ab0-466c-9635-9c1ff00f7774,IP:10,UR L:0,TC:0,Content:0,EDM:0,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:-5 X-CID-META: VersionHash:6493067,CLOUDID:74e0be48d2abf02b67b5e6b1e006481e,BulkI D:250312091244T2LLILD2,BulkQuantity:0,Recheck:0,SF:17|19|24|44|66|78|102,T C:nil,Content:0|50,EDM:-3,IP:-2,URL:0,File:nil,RT:nil,Bulk:nil,QS:nil,BEC: nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_FAS,TF_CID_SPAM_FSD,TF_CID_SPAM_FSI X-UUID: 188ecadcfedf11efa216b1d71e6e1362-20250312 X-User: liuye@kylinos.cn Received: from localhost.localdomain [(223.70.159.239)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256) with ESMTP id 1136214138; Wed, 12 Mar 2025 09:12:41 +0800 From: Liu Ye To: akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Liu Ye Subject: [PATCH] mm/debug: Fix minor issues in mm Date: Wed, 12 Mar 2025 09:12:36 +0800 Message-Id: <20250312011236.262766-1-liuye@kylinos.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 8BD35100002 X-Stat-Signature: 1bbb33iccwtt5bbjaotmqkcin73onkq1 X-HE-Tag: 1741741970-410418 X-HE-Meta: U2FsdGVkX1/nL82EtOVlD8cd+C79BO4bn//rTEfZSa2H0RUmu+/dEOxOgchVtZCXW1P0nXHN9/0PIIYFXrJlT63eKfFzeGX7KOLi9YjxNVL1NhOv6nbQ9amKaqIbRLOMncnHsbkp7JPi+9E0qHhme8H47TgNvg+iVTUZhYe+r5wdp9Lu12eoc3Th5ZVV3cTX0v3KM/6pC8U6zlu8iOFKuizNjDH4WjR9MYNCGb+d9PZ8hOHcnpE4EGo0PSBC+WJCjoZzZE29pFAY10RJf3Nrl1x8DUi7ZZJOV9xIHHRI/EJTmkfuo1RHWO+Sn8CQYsyp4sFVFu8n2emz/XnRQnAnDWWYvnXZT+ctOvyLssiZP6BdYYTaGhpu6o7He94JZf6YvzflrnrXPa1Ln8fwKocxflq09mBuxtF827FQgdESOP9km93KIHDzSVNwqdxDADa64JQyxZ0p4onkgGcih3tO10VI5HCjXGn19mw9v3jAopFxywaMTmBZOMkEXd4bbAGeei1jEQWkoE2HEF2U8dWIJGHxzqX6iXtxEfGSJaj64H7qJgmhewD03GXwJn5VN0Bo+yfDOYZLaEqWQI0YfxkuzJz28AORsj+qbV2matAQATQSHb3hjD27gJ1FlkV7g8a+U22MMRRYMt3mh4JRc1ikOffyCcByxYrsUoJ4KmUoqNesVZWDa6gUd35cc3oP7UZDHmCt5imUz61hrfc13CIGB1iOiOO+pD+m4Dw7AkfXJMtCbcSmFQwo5woVYuQU6SyNAPyzhVkvJ3QGzi8HKbrARMXRyoi6FAPe0COCFI6Q2jSwXnRQHfoIQHdqo7kM8pQI435cT5IruqNc7jc9GZo7AQSxlFhGukqY1gk+11yVMc3UU1RAgvZMiqDNS8dF57Owrl0Wb3e/LLZvm5K2dDBpWbr2/coo97ZzxWWeS9Q235X4GTHjoThKzDUgwutgNk30fe/+MLShk39Ndkq3g0O Bz8MJ+bX H/kZfG8CStBjnRbs8DXaTIYj5ArV0Kwfqx3/T X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This patch includes several minor fixes: - Fix out-of-bounds access in page_type_name(). - Simplify compound page judgment conditions. - Missing a newline character at the end of the format string. Each change is independent. Signed-off-by: Liu Ye --- mm/debug.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/mm/debug.c b/mm/debug.c index 8d2acf432385..9a3092e65765 100644 --- a/mm/debug.c +++ b/mm/debug.c @@ -62,7 +62,7 @@ static const char *page_type_name(unsigned int page_type) { unsigned i = (page_type >> 24) - 0xf0; - if (i >= ARRAY_SIZE(page_type_names)) + if (i < 0 || i >= ARRAY_SIZE(page_type_names)) return "unknown"; return page_type_names[i]; } @@ -132,15 +132,15 @@ static void __dump_page(const struct page *page) again: memcpy(&precise, page, sizeof(*page)); head = precise.compound_head; - if ((head & 1) == 0) { + if (head & 1) { + foliop = (struct folio *)(head - 1); + idx = folio_page_idx(foliop, page); + } else { foliop = (struct folio *)&precise; idx = 0; if (!folio_test_large(foliop)) goto dump; foliop = (struct folio *)page; - } else { - foliop = (struct folio *)(head - 1); - idx = folio_page_idx(foliop, page); } if (idx < MAX_FOLIO_NR_PAGES) { @@ -165,7 +165,7 @@ static void __dump_page(const struct page *page) void dump_page(const struct page *page, const char *reason) { if (PagePoisoned(page)) - pr_warn("page:%p is uninitialized and poisoned", page); + pr_warn("page:%p is uninitialized and poisoned\n", page); else __dump_page(page); if (reason)