From patchwork Wed Mar 12 16:47:50 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 14013692 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C63AEC28B2F for ; Wed, 12 Mar 2025 16:48:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D96D1280007; Wed, 12 Mar 2025 12:48:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D1E4E280001; Wed, 12 Mar 2025 12:48:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B7036280007; Wed, 12 Mar 2025 12:48:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 98025280001 for ; Wed, 12 Mar 2025 12:48:02 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 99FF7B982E for ; Wed, 12 Mar 2025 16:48:02 +0000 (UTC) X-FDA: 83213481204.23.21A662F Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf04.hostedemail.com (Postfix) with ESMTP id 01B4A40017 for ; Wed, 12 Mar 2025 16:48:00 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ny47xZvm; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf04.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741798081; a=rsa-sha256; cv=none; b=rRf4We1WG7eilWMEGyDTpswZwT+wy8tCScOsgyJfd6QzQsfdFYdW0eQRzymOJ1U8nHe1/d QZI5KFvGFP7bsVsudh6o2c+rG5a+N/CTn0KwJRqD8BVkBTowa+jq25Oo/mLSigd2yUdWzW vpPb9s5MnXcIqscRffOSH5HM2xo1EEw= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ny47xZvm; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf04.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741798081; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cM16TAOuVVtKKP3QrkRW1nnC5wwiHTfkUzYVvNhoMqA=; b=r3rv+2AFdRuwArHFOWMRXzE4BO12+yHEhJiMv6eZ3H+omyjiiSPLOd/ULJUyvylsqK1Bkt 7rx0FdHl+bcoMtEgyBWUlxhYgQ9J+WPIDX1ucu1kU/aEZwaqPQ5XjyGpe1y/UMFHRkfHGi RVq+UZ0+9N0wYxp+jIQbN1X1Prd2acU= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 6CA0D5C5CF2; Wed, 12 Mar 2025 16:45:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D44FBC4CEF0; Wed, 12 Mar 2025 16:47:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741798080; bh=rKIbFCwS48nnM6gxh3wFYLS526gq2KkVNyyi1h5+1tk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ny47xZvmQKh38wEZdbd3uE0N8ConIG5EFPo1F10FYLNBMl2IB7y1AwcvcMRRJNiCN 6DsaZj+4A+UAe1nWjY/dJ0cEkcnv2ElAewCEm5yRbK0LJ43cOpTWGMc3DLvjIVuwGZ C4CjRpAl0cXtZCgpM0ZJTk0XgnENCfBZNf1f08D3wl7jRV5okrmFCDVt9FKQ37CqxV ie/m5SCf8rDIfPHAr2XDJ5enChHf6IQ8fy6VADpoYh7VuZWaEBgQ6LKivy8SdaDysn sJU5R5O8Qm6vfYacjyZ2KlaOsDamPhHJmb2N0i+USWfjhepz+7RyyS9jm+RB1cUKl9 ktIavjNMuGU+A== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , "Liam R. Howlett" , David Hildenbrand , Lorenzo Stoakes , Shakeel Butt , Vlastimil Babka , kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 4/4] mm/madvise: remove len parameter of madvise_do_behavior() Date: Wed, 12 Mar 2025 09:47:50 -0700 Message-Id: <20250312164750.59215-5-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250312164750.59215-1-sj@kernel.org> References: <20250312164750.59215-1-sj@kernel.org> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Queue-Id: 01B4A40017 X-Rspamd-Server: rspam05 X-Stat-Signature: u1684i4f6yc7ty8xkc5nwj4hc7ynibs8 X-HE-Tag: 1741798080-784235 X-HE-Meta: U2FsdGVkX19xylINYky5O8uRggbrMv38QAtMtvv7p4M55sa+5Jk3/v7yL9U0TN0q91Nj0cBTZqDDUlN5As5KDDluLaSjYl8GRxHdFXjvt29ygFMpnawWOaXOT/FcMRn3L0lCp9QwhNXN2x8w3QMfq8Dpp/pv3NTS69qiv4DHI9YiCqRnpo6UN526tvpZEO4dMiF183paHRh1ZXJAM9WJoq7ael5B1glmn+HCIkjHQ6JJCy6oib/lZyOD0sQT4ftXe2s5CCfymGWX1+vi3rroyTF8RzaxDn74Xm4+aWFvEUdbInNGYGshi6i7zaQlt6YKBI8HQOcxjqxDkof1ZtdF08IRX11lRpKYWC2sNz3NgmmwR52Gq+lGplAacOAutnpnhjcOkJU8tP5n18P24lU1KomfzUeX7bOEw3QZTXJjBWvEfzZC0rjfQ0I2biUMpb8P/cvipFxMKAPrmfZA9JCxtIQYzdVg83xL7x+tCHS8G9QhbylAfqmlESw9HLNtrXv3sNaLyMrnrBFIDiI1sM88ZppTyEK9zg15W7w/XcfOY+ZBVfJQdod46HzCnP1ec5j2nolbTuYPU5AgQhYVCzYW/kcmJvERYSFP2QDmUF/YwVMdy+L6st6khuS5CxKe1uFeFuR9nv+tgSLdCS/wtSiDI/XsGgCmBIvB9FuW808a+R0bcFPprZ7exGhdYQf1z5njGovT5cfWz/JIhe8TZukjt5B0xEXSRqF1K+0/hRvzzfnyG2h2ICqebApw7dwvfy9+vNtqYJyTkfyq7HOtzh+7Vw0239uZuhLuDa60BIOjOpov+5uGYrbL7wAiLSCVCP9/RXlfP0NFW1L/HHKhKyQ4Y4qKzmYbyfRay1Fflkn4AuV3UxK0mo9XLTGF+3DE0+CUY0nuWqFO1c6r/NeGLi49cPb3q7PIaewQDGXsyzyBkD6CrlY6HsBfhe3SjZo/cqAe359vlt44nV12BcMDjgV jNX9vA/4 G88t7AQo7IKNY8PxKzH6mPdVUienKRk7jVnvNg1WXbMSxNGw2RsiaXQWG+inwS0yY+gvEWDD1XtOszgjncjFU8d+YT1QlZUh+cdPoki64ysoMlETrj6emmwfWdYPisJG3MF2ZMEL4D+1Nhom4Xi1Tc/omhsD7Uqp8KhCsFe3PfYg9I2N7Y115DxKJLrjkkFNEa+rNX5oEAoDrVS81kcfuxdd77pOZargttfUOmYaHzv+pu2bBs3P9qbrGOaQ9XbIZvCBQLtRflInel3py90TImDt0+74go0NEub2gHe9hegHTBn6fNqBaddgp/g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Because madise_should_skip() logic is factored out, making madvise_do_behavior() calculates 'len' on its own rather then receiving it as a parameter makes code simpler. Remove the parameter. Signed-off-by: SeongJae Park Reviewed-by: Lorenzo Stoakes Reviewed-by: Shakeel Butt --- mm/madvise.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/mm/madvise.c b/mm/madvise.c index ba006d05c7ea..b17f684322ad 100644 --- a/mm/madvise.c +++ b/mm/madvise.c @@ -1677,7 +1677,7 @@ static bool is_madvise_populate(int behavior) } static int madvise_do_behavior(struct mm_struct *mm, - unsigned long start, size_t len_in, size_t len, int behavior) + unsigned long start, size_t len_in, int behavior) { struct blk_plug plug; unsigned long end; @@ -1686,7 +1686,7 @@ static int madvise_do_behavior(struct mm_struct *mm, if (is_memory_failure(behavior)) return madvise_inject_error(behavior, start, start + len_in); start = untagged_addr_remote(mm, start); - end = start + len; + end = start + PAGE_ALIGN(len_in); blk_start_plug(&plug); if (is_madvise_populate(behavior)) @@ -1779,8 +1779,7 @@ int do_madvise(struct mm_struct *mm, unsigned long start, size_t len_in, int beh error = madvise_lock(mm, behavior); if (error) return error; - error = madvise_do_behavior(mm, start, len_in, PAGE_ALIGN(len_in), - behavior); + error = madvise_do_behavior(mm, start, len_in, behavior); madvise_unlock(mm, behavior); return error; @@ -1812,8 +1811,7 @@ static ssize_t vector_madvise(struct mm_struct *mm, struct iov_iter *iter, if (madvise_should_skip(start, len_in, behavior, &error)) ret = error; else - ret = madvise_do_behavior(mm, start, len_in, - PAGE_ALIGN(len_in), behavior); + ret = madvise_do_behavior(mm, start, len_in, behavior); /* * An madvise operation is attempting to restart the syscall, * but we cannot proceed as it would not be correct to repeat