From patchwork Wed Mar 12 17:58:23 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fuad Tabba X-Patchwork-Id: 14013736 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCA56C28B28 for ; Wed, 12 Mar 2025 17:58:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 01A1F28000C; Wed, 12 Mar 2025 13:58:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EE27B280001; Wed, 12 Mar 2025 13:58:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CE49628000C; Wed, 12 Mar 2025 13:58:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A8DF9280001 for ; Wed, 12 Mar 2025 13:58:48 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3EA43815C4 for ; Wed, 12 Mar 2025 17:58:49 +0000 (UTC) X-FDA: 83213659578.27.A062A65 Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) by imf30.hostedemail.com (Postfix) with ESMTP id 66A278000F for ; Wed, 12 Mar 2025 17:58:47 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=L6HHSf5V; spf=pass (imf30.hostedemail.com: domain of 3VsvRZwUKCHkqXYYXdlldib.Zljifkru-jjhsXZh.lod@flex--tabba.bounces.google.com designates 209.85.128.74 as permitted sender) smtp.mailfrom=3VsvRZwUKCHkqXYYXdlldib.Zljifkru-jjhsXZh.lod@flex--tabba.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741802327; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IlIj3TjUhtkedIPYTVHeRQbthVzaFoCCtbaBiaH1aMs=; b=Nx4kHL6x/bkFb0/ATd9En960e7c5jwcVuqAvRBCCzu6kOPv1pSwY1d2dM7Gx64tIj+VHFI DH8MU+GQF7Bombh9d5eYJya4WT/3RoYEBhw1BNOsHl9IEjYLgprV55vszWeboXKmT/XHOT Z1vTPHiIkQetieXzf9JxgX/7GKPQBMY= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=L6HHSf5V; spf=pass (imf30.hostedemail.com: domain of 3VsvRZwUKCHkqXYYXdlldib.Zljifkru-jjhsXZh.lod@flex--tabba.bounces.google.com designates 209.85.128.74 as permitted sender) smtp.mailfrom=3VsvRZwUKCHkqXYYXdlldib.Zljifkru-jjhsXZh.lod@flex--tabba.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741802327; a=rsa-sha256; cv=none; b=XVybHq5CAIQoeqQREUwfpvKJx56coer0ddG1IRBBIy3FZe8sVbws7VFwXe/LYecQWCb3IJ Rzh9DugRc7xEqGVQbr8J3hDfjoqJJoxdBbBQR7u+BJQDRj6Yyp9UsS+cjcppRnoylA8Utt UPTwO0/YrfnB2vF8srLMuQygX2ldtOk= Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-4394c489babso347595e9.1 for ; Wed, 12 Mar 2025 10:58:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1741802326; x=1742407126; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=IlIj3TjUhtkedIPYTVHeRQbthVzaFoCCtbaBiaH1aMs=; b=L6HHSf5V6EnJcaJTi2y8z+CUIGO0dA/keW9pw/8zpceveX5iGb5TIE9t7lCZYd99Rx /CQOGb/RaRQWQUXeMqn+ce2u7wCbIXow0etmaYPWiwJEJbABuEfjJ1eyXkphwWj0uICB KGHhEPPkbmTstQKqwCt2acYRubk7xEupBTsv+2gVS9ceENKiF2bX6rJSIPz2OJHjQIRp zppioEJwOyifvHg3fqG4fgsBK80Z/t7xvqOhUQQ1Z+sYVwuEogmw9RH2K8fvCerB3mWp l3G6YMLt5NoeAkoFKdlcOwa7nUp1LL0dhUzMRzM3MtOpZoFxHIFtmW6nJ+cvyZZ56BDJ DWGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741802326; x=1742407126; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IlIj3TjUhtkedIPYTVHeRQbthVzaFoCCtbaBiaH1aMs=; b=ps9A/GYVy3VVtxu05iW090pEFtU/kyvGnLtzaAz4uPbWMA+fbgQA8S8qid0H1t0LwJ nNHVnPu5DjSmLAWUyyZQoEJ9RFnJx3QMLAzae8DmaQfmUCnoZiTTmd/TQQx6crTtPgp9 sVHqGFbiR+ngevbnAzgBGwhLHH1wsdPq6OH2y/Wkwl4FvPbc5g+0uzMU9kboPz+FLS+y BMS9pWE7gq0u/bYJfa1rLzFD2Ep4okIp+aukka+mq7VH1tYBJJDDEGBRSvnJv+psSTqf Q++8UoR3lN7GKM3QnnhZNAsHVU7r1Ve4FUKriKjXKYJb60ghoxH+m6VT41FesIzTFOx8 58XA== X-Forwarded-Encrypted: i=1; AJvYcCUJ57Nk2m2NCPJH6zZ+QmjvcPaciuXnpERdADIS3evdgDcPH/Sr/7HZFhuCqzfS35Dnv5EEYBXU1w==@kvack.org X-Gm-Message-State: AOJu0YxquH/37MapqnnQpyz0ZT9Tl0NCT0rkxiZOHLwgj+b9crSnCjO+ Fs3viImg7OKdgn4dKAeKi4pKjTLs8O5QUJ3CJ1icgm8L3ZuTZewDnuI4hp9knkFTHf3xiSpgwQ= = X-Google-Smtp-Source: AGHT+IEjvTr2HYGSAjPDkNMw4G4npR8OoTHD1VZTAuD0hSm6xCoVT94NRgIvuCOHObtSUaBMEiPsUwonRg== X-Received: from wmqa16.prod.google.com ([2002:a05:600c:3490:b0:43c:fa2a:77d]) (user=tabba job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:1d09:b0:43c:efed:732b with SMTP id 5b1f17b1804b1-43cefed78bcmr140968325e9.5.1741802326090; Wed, 12 Mar 2025 10:58:46 -0700 (PDT) Date: Wed, 12 Mar 2025 17:58:23 +0000 In-Reply-To: <20250312175824.1809636-1-tabba@google.com> Mime-Version: 1.0 References: <20250312175824.1809636-1-tabba@google.com> X-Mailer: git-send-email 2.49.0.rc0.332.g42c0ae87b1-goog Message-ID: <20250312175824.1809636-11-tabba@google.com> Subject: [PATCH v6 10/10] KVM: guest_memfd: selftests: guest_memfd mmap() test when mapping is allowed From: Fuad Tabba To: kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org Cc: pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, david@redhat.com, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com, tabba@google.com X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 66A278000F X-Stat-Signature: sdqyws8cosdxdrc38w1rtt4yge7fwxry X-HE-Tag: 1741802327-986287 X-HE-Meta: U2FsdGVkX19OBjnJKFeL31UTcJ4vVsxJC3tArCxy8MAPFcjSFmv1OuIgohOieCKi+1g11eDPRl0808iwgDC2C0/P1xBIoqQh3C6FSiRehgrxitXc5Krl8QbUJaK2FhAwnBLl32e2zZLSwXvhOYTjSUu3CGub63S1QLvIhUZCsjtlmjdzDJRj76Ss0QqZqYYTp7rvI/V1G+eE9qzjua3uCOyr5NG7abDNi04tqUkSmIJ6mmnWCdYC/ngVnMIFEnv7334c5vg/ErRnc+6en7W91+DVVfHsfWzv5ZnyYM8tv7vrwN1TmsPUIqi4A0ypHsho0CAtVnl0kRME5/OuMRazMZeQLuzR7UG4rCxWDYjs9a8EAOroy+XootxAhLwwvRf+VylpuGPUBWFX1y44WNrSLdNFyN1j1qMT/XyKOJVR1251D7nJQqZHrECpmPFfFLYdWhGn22EB4bLG9L81dBi1f+y8vx6BJ2jwWVET6Lo4aRFcDXpBEE4Q8N9TpbGvFX8S/34hmvhkUnm63IsWr9/jpurX6I9NutqgH4f+UusxJduaZjUQ8lJxvw7lnpwo0CoMnOMxFb/vqc9307YVN2pVZgW13LIRRtCkKbMJ3Lk9/mBystWO7eiJtdQcqc6EN2a/G5cwxysqul/QChJhiYqVv/EdDJydCtmYWGXe6eFa+g6beef2RWqbyGRvxJT5vd8HQgqrPSXKVYUFSLuUDnIPr3zWMgslF6A4S7Fe55xJFhMePm8LJeSpQW6PkpiZL4Ik1P3BrhSEqreNYUSxZ8gz3b/i0xQaqMR3qqjBP5Y6nzReBTOhmqJ9iACUHIz5z4nO/R+m9dtTHjiYnvqbE+umivjJUHQx2QTikG0TX4QMOkgmjgnEw41s5KWxPD+xgDRCdXcUqxVFmR1sL3oKXd9TJHHs0gyDJZvz5t2RUNN54ERt3sXnVfBCE3uPAzHetNSpE5vaEhSkZxtlFUCQvzJ 7C78PRF3 lwZyQ8m1lpJ5U2jpxWoWhQyEKasJQV5I9bRNTFNO3gixEOQsF4ZUaBVvEToM3lsYcAfA+ILJy7CxnC7TyxCnzFHfwNMBgr7GNlatPvPR8dHCI679xcP5mL5kQiCNW9LoYPhNDOWkebSoiFEnbSEX+dhd8TpvCnTeIlHpyakl8ISXBbOCPXUlf0jfdeiclmV8z+sCCZ3capSefQ0MyN0DHlmFYOZ/cZOVuEJfnl8dXLKzgZCf+Ccy2q/FvQykRO+mqd6dpr/J9a7rGyh6Od82J6zD83PYnMlVQ/8RmWdz9C6tJ265MLi9n2V5rawOt2vQEE7etwuBNo6pa/u1hX75c6qJ6Cvl0fkGVB2Cl3zoJNEGlLwM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Expand the guest_memfd selftests to include testing mapping guest memory for VM types that support it. Also, build the guest_memfd selftest for aarch64. Signed-off-by: Fuad Tabba --- tools/testing/selftests/kvm/Makefile.kvm | 1 + .../testing/selftests/kvm/guest_memfd_test.c | 75 +++++++++++++++++-- 2 files changed, 70 insertions(+), 6 deletions(-) diff --git a/tools/testing/selftests/kvm/Makefile.kvm b/tools/testing/selftests/kvm/Makefile.kvm index 4277b983cace..c9a3f30e28dd 100644 --- a/tools/testing/selftests/kvm/Makefile.kvm +++ b/tools/testing/selftests/kvm/Makefile.kvm @@ -160,6 +160,7 @@ TEST_GEN_PROGS_arm64 += coalesced_io_test TEST_GEN_PROGS_arm64 += demand_paging_test TEST_GEN_PROGS_arm64 += dirty_log_test TEST_GEN_PROGS_arm64 += dirty_log_perf_test +TEST_GEN_PROGS_arm64 += guest_memfd_test TEST_GEN_PROGS_arm64 += guest_print_test TEST_GEN_PROGS_arm64 += get-reg-list TEST_GEN_PROGS_arm64 += kvm_create_max_vcpus diff --git a/tools/testing/selftests/kvm/guest_memfd_test.c b/tools/testing/selftests/kvm/guest_memfd_test.c index ce687f8d248f..38c501e49e0e 100644 --- a/tools/testing/selftests/kvm/guest_memfd_test.c +++ b/tools/testing/selftests/kvm/guest_memfd_test.c @@ -34,12 +34,48 @@ static void test_file_read_write(int fd) "pwrite on a guest_mem fd should fail"); } -static void test_mmap(int fd, size_t page_size) +static void test_mmap_allowed(int fd, size_t total_size) { + size_t page_size = getpagesize(); + const char val = 0xaa; + char *mem; + int ret; + int i; + + mem = mmap(NULL, total_size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); + TEST_ASSERT(mem != MAP_FAILED, "mmaping() guest memory should pass."); + + memset(mem, val, total_size); + for (i = 0; i < total_size; i++) + TEST_ASSERT_EQ(mem[i], val); + + ret = fallocate(fd, FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE, 0, + page_size); + TEST_ASSERT(!ret, "fallocate the first page should succeed"); + + for (i = 0; i < page_size; i++) + TEST_ASSERT_EQ(mem[i], 0x00); + for (; i < total_size; i++) + TEST_ASSERT_EQ(mem[i], val); + + memset(mem, val, total_size); + for (i = 0; i < total_size; i++) + TEST_ASSERT_EQ(mem[i], val); + + ret = munmap(mem, total_size); + TEST_ASSERT(!ret, "munmap should succeed"); +} + +static void test_mmap_denied(int fd, size_t total_size) +{ + size_t page_size = getpagesize(); char *mem; mem = mmap(NULL, page_size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); TEST_ASSERT_EQ(mem, MAP_FAILED); + + mem = mmap(NULL, total_size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); + TEST_ASSERT_EQ(mem, MAP_FAILED); } static void test_file_size(int fd, size_t page_size, size_t total_size) @@ -170,19 +206,27 @@ static void test_create_guest_memfd_multiple(struct kvm_vm *vm) close(fd1); } -int main(int argc, char *argv[]) +unsigned long get_shared_type(void) { - size_t page_size; +#ifdef __x86_64__ + return KVM_X86_SW_PROTECTED_VM; +#endif + return 0; +} + +void test_vm_type(unsigned long type, bool is_shared) +{ + struct kvm_vm *vm; size_t total_size; + size_t page_size; int fd; - struct kvm_vm *vm; TEST_REQUIRE(kvm_has_cap(KVM_CAP_GUEST_MEMFD)); page_size = getpagesize(); total_size = page_size * 4; - vm = vm_create_barebones(); + vm = vm_create_barebones_type(type); test_create_guest_memfd_invalid(vm); test_create_guest_memfd_multiple(vm); @@ -190,10 +234,29 @@ int main(int argc, char *argv[]) fd = vm_create_guest_memfd(vm, total_size, 0); test_file_read_write(fd); - test_mmap(fd, page_size); + + if (is_shared) + test_mmap_allowed(fd, total_size); + else + test_mmap_denied(fd, total_size); + test_file_size(fd, page_size, total_size); test_fallocate(fd, page_size, total_size); test_invalid_punch_hole(fd, page_size, total_size); close(fd); + kvm_vm_release(vm); +} + +int main(int argc, char *argv[]) +{ +#ifndef __aarch64__ + /* For now, arm64 only supports shared guest memory. */ + test_vm_type(VM_TYPE_DEFAULT, false); +#endif + + if (kvm_has_cap(KVM_CAP_GMEM_SHARED_MEM)) + test_vm_type(get_shared_type(), true); + + return 0; }