From patchwork Thu Mar 20 17:41:13 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Cameron X-Patchwork-Id: 14024214 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4E40C28B30 for ; Thu, 20 Mar 2025 17:42:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4DFC928000B; Thu, 20 Mar 2025 13:41:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 48E76280006; Thu, 20 Mar 2025 13:41:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3628A28000B; Thu, 20 Mar 2025 13:41:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 18A47280006 for ; Thu, 20 Mar 2025 13:41:59 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id BE0C6141777 for ; Thu, 20 Mar 2025 17:41:59 +0000 (UTC) X-FDA: 83242647558.18.31E46B0 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf15.hostedemail.com (Postfix) with ESMTP id ABC00A000D for ; Thu, 20 Mar 2025 17:41:54 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf15.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742492514; a=rsa-sha256; cv=none; b=GJdnBnracppKNpw05YfV+QaCxqogosedE3XyNqbXa9Iv9iLuAisPBW8Qv8yYrTsx0gt6kO g6IcmsoF1BmcBg3yAJho0MuYivczsWRD1rY/cFEqBtljvURKvcdDkViIC1osZchJthDiDs TQYEIlLML4r97fZHnclyebgCHg98Zao= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf15.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742492514; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HNmXxUwPUUbE0uhZLdV/DpoiIzAnJIP9flb3a3foWIU=; b=Sv/L4E1tTSrb+1Ix4enDD/KZlfvDasUtTRsizKoZvWbb6qoKSzjC16fUulZqjzKEcpqNK4 gEEpeHH+eVdX37x6NSjMhlDvA4+lnCar6IUJJbeLdaarFQFc1CNTleQ9dnpGrMMuT0gWkI OATM2NSs+pK/GTC3SHsd8Gn+Uo5lU9Y= Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4ZJXqW3MDtz6M4LB; Fri, 21 Mar 2025 01:38:31 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id BA7F21405A0; Fri, 21 Mar 2025 01:41:51 +0800 (CST) Received: from SecurePC-101-06.china.huawei.com (10.122.19.247) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 20 Mar 2025 18:41:51 +0100 From: Jonathan Cameron To: , , , , Yicong Yang , CC: , , Yushan Wang , , , Lorenzo Pieralisi , Mark Rutland , Catalin Marinas , Will Deacon , Dan Williams Subject: [RFC PATCH 1/6] memregion: Support fine grained invalidate by cpu_cache_invalidate_memregion() Date: Thu, 20 Mar 2025 17:41:13 +0000 Message-ID: <20250320174118.39173-2-Jonathan.Cameron@huawei.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250320174118.39173-1-Jonathan.Cameron@huawei.com> References: <20250320174118.39173-1-Jonathan.Cameron@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.122.19.247] X-ClientProxiedBy: lhrpeml100001.china.huawei.com (7.191.160.183) To frapeml500008.china.huawei.com (7.182.85.71) X-Stat-Signature: u3b7eskp7xf6ubc818hedgdjh9f8oske X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: ABC00A000D X-Rspam-User: X-HE-Tag: 1742492514-674134 X-HE-Meta: U2FsdGVkX1+wYU+QIKGRXYEnkgQKXUPFa/RdfR+zEpishzYYxL7szyvEGr540ysI+9u61Pg/zjvgPT04KFx23hofDxL/G+qfDwniClfcJD7oQx7F4Cs0XYFtF9oAE5OJSNExqt4Lbz6e7Rs059MmfB0xbnCTzdffwdG6pAY3tH3qP7K4NBmcczFAm8ks1WMDn5p1hSGdhv63HkJIlZfOaypOprGbRTgoYcGB19PRvzzgXbIqHX4l0hnkcZh5JOktFwuOIaPgaBBl/S+S3oo9hAHwjkrky+FZTBtsXOQTqmad080UlyQJckDY6TqNJyQsQ/vmXWQIqmdumUK2ZKN/tq177wKoB5Dh3nYJ3JSEgEgdxhho2tW8rZqlQZKYElQAVEQ6zQpQBeNneF2xtlY+2vuf4ISvjyyPXhhfx9ZdUwI77nNnqrUhJRqbMTLK+fGJRIO/WiFPNrKAFjvd12MDRZDqG50i8M5oqKMz6yLNi/DMZ6plJnxw8xs4SHwuOoxIcu4W3slReS2E3ke9UiYYGZBRKfX1ActIqYXTFq5oI1wKEfGyaC2Ep121sdZjVA/7wzEQQvLl1MaKtmP7NOSeTHkDKP+vVMX6oNYhI+ake7XXLFTDdySUEqXoRCA0dmOH44csa/Xo1cCLP7yEifcf4ZlWz0GdaPDDjUbccc+xV/uw0KxRu4JdIEJVy0pRTqQdTfYDZXaRc7j6W8+X59br+hh/AurFd9Dw50uO5TRXLG50lZ83/xsx2KeVHrKBpIvsRUBH0LIuwBjAEQtTyDhYKmV7oHmZTwQNMYqA9WqhgAmhoj+4ZT/f+JHEUE2H3QaTG6ozhppN5bDvAR8nmO/Hq8C39UEa7eROQmS0WLM1qjTd4PQS/8VwrOEq9FH9QmmnMK4sOqVft9TPc1Vc/FSZ2nvJvTF3/QS++pURMBUc5nUv4J137fpv1TFJ6ik/87ikQRpLK35obEGKc5rmnuy 8hfN59Jz 3QtDtpM5ctlFlefuEIzBRAGY77bBYKi1ptYdCLX3G8zORTsd3vDn/J+wx0Yorb1uN4ynKgKzODSB8OBC3y2Ly6fKTv1+tEax1u0279OlYNK4cvKgDQZpXKqTQQ8AX9H9Fo3Ip53i8vTrlFHOH06QhLQV4hev/9m4QxuKyc7ca1y/Y+Uug4VZ5dVfTiC/kN0uAQXlrMNQLX8deXvtQeJpxcYrPu0fLj97YjOUL X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Yicong Yang Extend cpu_cache_invalidate_memregion() to support invalidate certain range of memory. Control of types of invalidation is left for when usecases turn up. For now everything is Clean and Invalidate. Signed-off-by: Yicong Yang --- arch/x86/mm/pat/set_memory.c | 2 +- drivers/cxl/core/region.c | 6 +++++- drivers/nvdimm/region.c | 3 ++- drivers/nvdimm/region_devs.c | 3 ++- include/linux/memregion.h | 8 ++++++-- 5 files changed, 16 insertions(+), 6 deletions(-) diff --git a/arch/x86/mm/pat/set_memory.c b/arch/x86/mm/pat/set_memory.c index ef4514d64c05..5d2adec1b0d4 100644 --- a/arch/x86/mm/pat/set_memory.c +++ b/arch/x86/mm/pat/set_memory.c @@ -354,7 +354,7 @@ bool cpu_cache_has_invalidate_memregion(void) } EXPORT_SYMBOL_NS_GPL(cpu_cache_has_invalidate_memregion, "DEVMEM"); -int cpu_cache_invalidate_memregion(int res_desc) +int cpu_cache_invalidate_memregion(int res_desc, phys_addr_t start, size_t len) { if (WARN_ON_ONCE(!cpu_cache_has_invalidate_memregion())) return -ENXIO; diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c index e8d11a988fd9..6d1c9eee4cd9 100644 --- a/drivers/cxl/core/region.c +++ b/drivers/cxl/core/region.c @@ -238,7 +238,11 @@ static int cxl_region_invalidate_memregion(struct cxl_region *cxlr) } } - cpu_cache_invalidate_memregion(IORES_DESC_CXL); + if (!cxlr->params.res) + return -ENXIO; + cpu_cache_invalidate_memregion(IORES_DESC_CXL, + cxlr->params.res->start, + resource_size(cxlr->params.res)); return 0; } diff --git a/drivers/nvdimm/region.c b/drivers/nvdimm/region.c index 88dc062af5f8..033e40f4dc52 100644 --- a/drivers/nvdimm/region.c +++ b/drivers/nvdimm/region.c @@ -110,7 +110,8 @@ static void nd_region_remove(struct device *dev) * here is ok. */ if (cpu_cache_has_invalidate_memregion()) - cpu_cache_invalidate_memregion(IORES_DESC_PERSISTENT_MEMORY); + cpu_cache_invalidate_memregion(IORES_DESC_PERSISTENT_MEMORY, + 0, -1); } static int child_notify(struct device *dev, void *data) diff --git a/drivers/nvdimm/region_devs.c b/drivers/nvdimm/region_devs.c index 37417ce5ec7b..eefd294a0f13 100644 --- a/drivers/nvdimm/region_devs.c +++ b/drivers/nvdimm/region_devs.c @@ -90,7 +90,8 @@ static int nd_region_invalidate_memregion(struct nd_region *nd_region) } } - cpu_cache_invalidate_memregion(IORES_DESC_PERSISTENT_MEMORY); + cpu_cache_invalidate_memregion(IORES_DESC_PERSISTENT_MEMORY, + 0, -1); out: for (i = 0; i < nd_region->ndr_mappings; i++) { struct nd_mapping *nd_mapping = &nd_region->mapping[i]; diff --git a/include/linux/memregion.h b/include/linux/memregion.h index c01321467789..91d088ee3695 100644 --- a/include/linux/memregion.h +++ b/include/linux/memregion.h @@ -28,6 +28,9 @@ static inline void memregion_free(int id) * cpu_cache_invalidate_memregion - drop any CPU cached data for * memregions described by @res_desc * @res_desc: one of the IORES_DESC_* types + * @start: start physical address of the target memory region. + * @len: length of the target memory region. -1 for all the regions of + * the target type. * * Perform cache maintenance after a memory event / operation that * changes the contents of physical memory in a cache-incoherent manner. @@ -46,7 +49,7 @@ static inline void memregion_free(int id) * the cache maintenance. */ #ifdef CONFIG_ARCH_HAS_CPU_CACHE_INVALIDATE_MEMREGION -int cpu_cache_invalidate_memregion(int res_desc); +int cpu_cache_invalidate_memregion(int res_desc, phys_addr_t start, size_t len); bool cpu_cache_has_invalidate_memregion(void); #else static inline bool cpu_cache_has_invalidate_memregion(void) @@ -54,7 +57,8 @@ static inline bool cpu_cache_has_invalidate_memregion(void) return false; } -static inline int cpu_cache_invalidate_memregion(int res_desc) +static inline int cpu_cache_invalidate_memregion(int res_desc, + phys_addr_t start, size_t len) { WARN_ON_ONCE("CPU cache invalidation required"); return -ENXIO;