From patchwork Fri Mar 21 01:07:10 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ye Liu X-Patchwork-Id: 14024744 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBB2CC28B30 for ; Fri, 21 Mar 2025 01:07:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8CEFB280002; Thu, 20 Mar 2025 21:07:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 87CA9280001; Thu, 20 Mar 2025 21:07:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 76CD7280002; Thu, 20 Mar 2025 21:07:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5B3F2280001 for ; Thu, 20 Mar 2025 21:07:35 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 8FFCE1A1A98 for ; Fri, 21 Mar 2025 01:07:36 +0000 (UTC) X-FDA: 83243770512.18.EB2D296 Received: from out-172.mta0.migadu.com (out-172.mta0.migadu.com [91.218.175.172]) by imf26.hostedemail.com (Postfix) with ESMTP id CAB4C140004 for ; Fri, 21 Mar 2025 01:07:34 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=X4NCCT0m; spf=pass (imf26.hostedemail.com: domain of ye.liu@linux.dev designates 91.218.175.172 as permitted sender) smtp.mailfrom=ye.liu@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742519255; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=oKv6kzy1r+Z2q8HbnIAwNuqiBX6WfkJJspdk8MGx/EI=; b=CAlqJOrrn/ZkDlh4rIVx2D/2Udi0QCXOxOf2l3yrgfOeabLjCD/MT6oL+odzbnEOFCfnx1 DFE5xLJxqQ5xepntJpDYON8isu5HX8LAXI2NhK9U47AYWU167nYVLAS3mOb1l05szx13dk iYhaxRT2BRFXBIZPzdC9vgI1091sXXs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742519255; a=rsa-sha256; cv=none; b=RPhZXBYmRThIvFHZHrmTQy06NYdGqJAdoL7/VnESLM2HRx7XAOhhoc+FjLtbze8PduVYhl AWHw9h/AfbtjEHZScwEezKPNuFVzQo4Xt1nXHGY5Zkm61U++kX57r+UziPZgK5cKJHwMoy ZlItdPrK2loTiDluHMFmlgK9iZEYhZo= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=X4NCCT0m; spf=pass (imf26.hostedemail.com: domain of ye.liu@linux.dev designates 91.218.175.172 as permitted sender) smtp.mailfrom=ye.liu@linux.dev; dmarc=pass (policy=none) header.from=linux.dev X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1742519252; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=oKv6kzy1r+Z2q8HbnIAwNuqiBX6WfkJJspdk8MGx/EI=; b=X4NCCT0m8yVvPld4nR2v3PrMAh/pWqGGO2LAre9fM6HvqDvhs10jYFX4g5rYhzo31QE3vo Y0MGnqlrirEqMC0XiBcQmpdT6hRm1LBy2P+jmk/i7fnsP7zXcyUifvAs7LzIBarOsSa17w GRhtc+Aof101ORw++Q4QTnlxZm7RE/E= From: Ye Liu To: akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Ye Liu Subject: [PATCH] mm/page_alloc: Simplify free_page_is_bad by removing free_page_is_bad_report Date: Fri, 21 Mar 2025 09:07:10 +0800 Message-Id: <20250321010710.548105-1-ye.liu@linux.dev> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: CAB4C140004 X-Stat-Signature: u9dt35zpcbg5q1wyrtthtsyafrxxd6ns X-HE-Tag: 1742519254-474118 X-HE-Meta: U2FsdGVkX18DFj5G1FwoFluA6MLZyYPRDv29/ZxTqp/pleJaF1ud0Fc3NfJkeqImTYcDGCno4Z6hAuPUcWBy86MqMhhbv5L3NtaBmI0RoOqcNCco5PVMRHyfrqqAGOUoOoYajeS7W86v46axv/zOkRM0iR7SZjgrllhUQmE5G4W57Z7lEEO25ZxUubH6ll/KMbd7rVn6fXV4EK6oBlomnRg4cQLm0NOp3ber45VDhqEwauHchoso8UIPwXd0u6/d+kElGICbcT0NAIa2W2NN723AEmcDfZ8ZhqZyy3iDeeqJcuMReV2i1lwRNbxQMl8oeajeAmW+M/+lv6T0EkV9LqoN7ie4OaZjaeCvZxN2/UPcJNWD76tww/cvXojNXpjyFdL4tJiWxwMBSdsJ26rnfYUrQNX0zPqxYlq3xyZJGJVICjLuyrA5YrwUox2ML0rCPRuwMWByxYTqERket57F9nwMgXNTnDlWzgOyv5OhDsj1lzCHMFKNdiKAOXR/Kh0LRTXPoT8UK6eycfVMRYpTCGri+UWqjH2W+uIgplt9EoBlg5OfWmFdHwsrQu9mwfsQjCQN/N6tKVNJ90a9mWOW6dY0QyhbSSd1zY9ZeEVzQnVcZ+3dABZgEn666tgfyyK1EKWOU70fbY90W59V+RCwO9JoQuwEzyCom4cv3tRPQTE/mIPWU1gfySuvy709OS250DpMCNuj0LspylFj3hmU8y5/kLX1Gi02dpxD6kPNbUcaOqbo5WnWAqNhbPs/oPNYzRhQ7TPkkEZkK/VMk/m7bWAmIvekkMrHQpRWTe2AufXQH9DL0Wr/T7gnP7yWH0zVDwBvNHnWT3D0qiOBywK4QbKkkuGnHgELpYUXTngCX8Ee/3O0dq9MGE8q0oUZ2Bchw9+jyq56nnpWQKzWw/v0nPNCZSmd5tRzHV9gB5stTjOme7Tbs8QiQ/866DxKqB76OTLxI2enorjFjgIi8ig qsw4fvi1 xtIpXGGwPdhnf/Z35EoKqYlO94bHJ1yRWu/pAve927xFIkCbwferEFHFoDHX9rmVWqDyreWWKG5JX/hSnXO6WS9mqGB41dsghqwPL7g6srFDgXwZVCLAXOjnzHHw7LmOvRAq/XhX/mDDMhceGZbJi7/r5qGTg4vSi0zz7eR5nSFr6hUM8pdXnK5qvj05jubR8C2V69EDRx5Ry/EWyRrXcSw0IDg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Ye Liu This patch refactors the free_page_is_bad function by directly calling bad_page() instead of using the intermediary function free_page_is_bad_report(). The removal of free_page_is_bad_report() reduces unnecessary indirection, making the code cleaner and easier to read. The functionality remains the same, as free_page_is_bad_report() was merely a wrapper for the bad_page() call. The patch also improves maintainability by reducing the function call depth. Signed-off-by: Ye Liu Reviewed-by: Anshuman Khandual --- mm/page_alloc.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 61d6a3b1b286..2842da893eea 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -933,19 +933,14 @@ static const char *page_bad_reason(struct page *page, unsigned long flags) return bad_reason; } -static void free_page_is_bad_report(struct page *page) -{ - bad_page(page, - page_bad_reason(page, PAGE_FLAGS_CHECK_AT_FREE)); -} - static inline bool free_page_is_bad(struct page *page) { if (likely(page_expected_state(page, PAGE_FLAGS_CHECK_AT_FREE))) return false; /* Something has gone sideways, find it */ - free_page_is_bad_report(page); + bad_page(page, + page_bad_reason(page, PAGE_FLAGS_CHECK_AT_FREE)); return true; }