From patchwork Fri Mar 21 11:16:55 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jocelyn Falempe X-Patchwork-Id: 14025282 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6E52C35FFF for ; Fri, 21 Mar 2025 11:25:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B7C3E280004; Fri, 21 Mar 2025 07:25:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B2A0A280001; Fri, 21 Mar 2025 07:25:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9CCAE280004; Fri, 21 Mar 2025 07:25:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 7D25E280001 for ; Fri, 21 Mar 2025 07:25:14 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D18E1140C6D for ; Fri, 21 Mar 2025 11:25:14 +0000 (UTC) X-FDA: 83245326948.02.6E480EA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf11.hostedemail.com (Postfix) with ESMTP id 1F41C40010 for ; Fri, 21 Mar 2025 11:25:12 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LdOeBjF+; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of jfalempe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=jfalempe@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742556313; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3ULjzTuWq4KWWMz5FWBM7gDBkyDsf2B5DDVUjmTkqks=; b=nQ5n6A4A0M5JWs0gd4DKj3RT72bW/SFb4fs2yiXC9ehXhktVEN3L9kHzjl5q9+7wxdmiS1 NE9/6coKTx3SC6pXC4EXqo+VYXKb8n+8Jq/GShXKLrMSYHilX55JL0M5R2T0OJGAj8geKO P5Yiu2i3v6rOj8uuK41JZjjtI3AfMBQ= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LdOeBjF+; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of jfalempe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=jfalempe@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742556313; a=rsa-sha256; cv=none; b=hn0RzjTb1fHC3qQSNAu8p0wpqKte4gZNNpDCxZFbl70RGOWEbjDftiKaitwA2PaH2P0qAI twEePN33N1udSk1D1hslky+/+gSl2VLJoCzLs0R6ZnD/sbcdjt+SJnc1LMVxZA703qG5Pt h/z0dnNrCTV/OQQ3k70ZjDgZp/B2Mrk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742556312; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3ULjzTuWq4KWWMz5FWBM7gDBkyDsf2B5DDVUjmTkqks=; b=LdOeBjF+VwE9Gl39gogjmn+MSCD3kYHdN1RQunE7nnml+qwtio7SaQlH2b+QIA9qKV+RvX Psde7GiJjNmC0IJlSEA4tl7cwY9bxJZqvHmJcKTh7cLuDCtk+WDwm8LiLoyCibLSGZEdWl W/hZsfylzLNGNSH5RpF8WChS/Hs2Vww= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-203-sWdaQcbIMZuU33p4OBIaMQ-1; Fri, 21 Mar 2025 07:25:09 -0400 X-MC-Unique: sWdaQcbIMZuU33p4OBIaMQ-1 X-Mimecast-MFC-AGG-ID: sWdaQcbIMZuU33p4OBIaMQ_1742556307 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2CD581945103; Fri, 21 Mar 2025 11:25:07 +0000 (UTC) Received: from hydra.redhat.com (unknown [10.44.34.21]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id A5F87180175B; Fri, 21 Mar 2025 11:25:01 +0000 (UTC) From: Jocelyn Falempe To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Ryosuke Yasuoka , Javier Martinez Canillas , Wei Yang , Andrew Morton , David Hildenbrand , John Ogness , Thomas Gleixner , linux-mm@kvack.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Jocelyn Falempe , Simona Vetter Subject: [PATCH v2 1/2] mm/kmap: Add kmap_local_page_try_from_panic() Date: Fri, 21 Mar 2025 12:16:55 +0100 Message-ID: <20250321112436.1739876-2-jfalempe@redhat.com> In-Reply-To: <20250321112436.1739876-1-jfalempe@redhat.com> References: <20250321112436.1739876-1-jfalempe@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 1F41C40010 X-Stat-Signature: 3hg4b8wu8qie9kjb37xwsray63f3whft X-Rspam-User: X-HE-Tag: 1742556312-76205 X-HE-Meta: U2FsdGVkX1+HRjrmlqUepKnFG3NUavr0JonH8fPwmc1ci9TtTyPbBlw4XqXELiLkLLC2KPSey2rAY8hMQq/jlDcy5Qo1xSsj9NUC3Yzuh05+DcZUukxZqlSl91WHSUu1rwrfOEqZdpiq/zbC1RbTW2XAMEz/MsiWcPjkTmCTKTWo/HoBE+v4BxHVaVgweivii0ZLFeVOwRcZBY9I8SgV2Ty57b7QPU7oYWzXRyQ4IMNP+raWtbTAu/OIO9eefpzAKZsYIgqqXe/qeWwjLdp6R/P4bYKc0FnoSMKvXOQsgmcLQRHEdrZComAh9UsW4hk6SCUK/b06q4mI7hp5dcivDMAOhG2k2PYGIA8Ev1QQ6w2iE1OR9yvqrAqXPJL7G2Jesu6LgWXNCC0O2AWodhvjV8Q98AUBJ/9kvwtAGrsnBkdFosGFw+GKA/Tw33eGI6K9T8hYv3JfkUHoFgl4qbZ213+zy5XP6igwITqiuQ+zYnsn1JKG4trWeaKl0L0gRGtmt1qQFi1NNIYRcpIThhDVChhttdC8y8qCYAT/KDRJvBoKnm/H4T6arrXXa4Uz0XUn4a5GzYJJBvuoL15+GEVaV8ON5cNBh9+c5VzlNKvlUIK03QCmDDBvXdjD54/7kK6FvJWaNnJ2kvG4fWH5Bcpzh28XDCIUhDP4zMS6x1XMkF4DgzOUtQXxtf6UovfLUc1kB5oIwhoLWIb8bwHTVcAhvL0j9K/dYZhTX7su0dZnpW/JNYbDG2hODVL08ThKVrDJIkB8BiIMj7qAVdnbUOZxAKsLXqAYvf4/Qq77V1pJZGKuZK1EClf8GeklDXywasHW4cJQEeUJqELRDT1994+PaMoCjN1b0n92ufX5SrkOeP474PzjK/XiaRm71lL05RDAkdEoekAOfDZYa2A0qa7Nw3FfBwYLBD9IgFUgN7JkyNNxsbf1ZTk2YevPO++Cb6Jk9n8l5yUUvU4GzhPmPL8 nM+2d7gq Xfm+FukFRxy7e8gE8pF2YqIMVc9YWw8Lu9opl0oE3GSbFqN7zhBDACNfN3Tn2PA5MxzUxr2tS+LgdQwvFh+BHtTTKQ/CZ6Hj8eHpFUNPHpFdo7Zqjk58Rwu//TqFf5kGIIYGWa1/7/eObHst+ulxoTxZFBCvAbM8y9CJgXtCP9Ij6qoaYc0W81uQseLfqLJs81rfu6Q+j2EhM7HQkZubn0L0bSzs6kq1C1q21ZnYeApAggOIi6WJ/z2vf68l+IOIrz8a1IZjP/w9jNVNLMiZDLk23DYw0lpXz6fH1aA3lh9rnsmUbhxms6YvXmJ6v1bBS5HKBnGynNPHoDkNOEIW9CYktjULwK5ATgsZdYlocgzAGd6kEYs1Jgp/c6sn+YVg7fVWnmAjvjWLTN2HyUvIjS0NDquxa6ZmepGZExtI6Z9w1iWP+oyM47VI4NniZmb61jL4zV5ZM/5F+ltA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: kmap_local_page() can be unsafe to call from a panic handler, if CONFIG_HIGHMEM is set, and the page is in the highmem zone. So add kmap_local_page_try_from_panic() to handle this case. Suggested-by: Simona Vetter Signed-off-by: Jocelyn Falempe --- include/linux/highmem-internal.h | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/include/linux/highmem-internal.h b/include/linux/highmem-internal.h index dd100e849f5e0..5d089b0ca56de 100644 --- a/include/linux/highmem-internal.h +++ b/include/linux/highmem-internal.h @@ -73,6 +73,13 @@ static inline void *kmap_local_page(struct page *page) return __kmap_local_page_prot(page, kmap_prot); } +static inline void *kmap_local_page_try_from_panic(struct page *page) +{ + if (!PageHighMem(page)) + return page_address(page); + return NULL; +} + static inline void *kmap_local_folio(struct folio *folio, size_t offset) { struct page *page = folio_page(folio, offset / PAGE_SIZE); @@ -180,6 +187,11 @@ static inline void *kmap_local_page(struct page *page) return page_address(page); } +static inline void *kmap_local_page_try_from_panic(struct page *page) +{ + return page_address(page); +} + static inline void *kmap_local_folio(struct folio *folio, size_t offset) { return page_address(&folio->page) + offset;