From patchwork Fri Mar 21 20:40:59 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kees Cook X-Patchwork-Id: 14026035 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 548DEC36002 for ; Fri, 21 Mar 2025 20:41:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9D048280007; Fri, 21 Mar 2025 16:41:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 909D5280001; Fri, 21 Mar 2025 16:41:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F240280001; Fri, 21 Mar 2025 16:41:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D9E46280001 for ; Fri, 21 Mar 2025 16:41:10 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 59460C0704 for ; Fri, 21 Mar 2025 20:41:12 +0000 (UTC) X-FDA: 83246727984.13.5091607 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf17.hostedemail.com (Postfix) with ESMTP id 85EB940004 for ; Fri, 21 Mar 2025 20:41:10 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Nq6FRsac; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf17.hostedemail.com: domain of kees@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=kees@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742589670; a=rsa-sha256; cv=none; b=TjfXpHZRqdcnli90HXMiXpBNF/M3iPkNSavgJj86q0HxiGV6Ic4bddJtMqOABRrl6RofWj GVY64sjmCV7wFCzwWI9PwfJPfjGEmlhJ52vd5a5t2Lj3GrvuJ3I9VdvYdU3kjuxRrjfuW7 6p/mgT0kZwXBNeg5NyS5QT4BM2EdbTk= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Nq6FRsac; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf17.hostedemail.com: domain of kees@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=kees@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742589670; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NwA0vpLHRswOrrUDEGyeJ9tjq/EbLER33ygPfPPt9WY=; b=Psa1phcj5VMnv6D0mVurBDYRn80e8HdPH/rmawF7g6reag63S5p3bTMKjVDxm6fz7kpIYO Wn4oVr9rbav6qXS4UUG4Yst0kUW0liOqBTWvWwIri7xXbSfQOb0pL97eCzooO71p91pG7D JVHyUh+zXV9nijKuo+k8gbHG5tE+sxg= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id B3FE043799; Fri, 21 Mar 2025 20:41:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ED03EC4CEEC; Fri, 21 Mar 2025 20:41:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1742589669; bh=pXkT7am0yPdv1f217KYbpZB7Vpb7nbz805ybospBIJs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Nq6FRsactxGBEYHtLF3Za33uutSX27PtxKislPtxAwTqwMQ+zcr2Pnher41Tvum6B 2MOaTtLPlzws2XoXhOa/xU/E4DXa+FKn/vGZc9vfUk+t8/h5lqpJ/eSOzKiT84fzPT vUpDmjlqWK5LNXSsjCZW3LOkMFBD7zzsWOlaTPS7uf0l8j1ELbatdPAbVIfI1egtjZ qa/src68Zz9yI10j3UmXT1QTSzgrxUohavaH8Y/7BrXUcMQaxGUojp/YqxfwUUa7Hf 0duFvny7lEZ26T+ZnseYRDDE6O3AYCqS0VE58E++i0Lonsc1J5jF6zzEEKCzVV1PgR yWliFNrMPyTww== From: Kees Cook To: Vlastimil Babka Cc: Kees Cook , Miguel Ojeda , Nathan Chancellor , Marco Elver , Nick Desaulniers , Przemek Kitszel , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-hardening@vger.kernel.org Subject: [PATCH 3/5] compiler_types: Introduce __is_lvalue() Date: Fri, 21 Mar 2025 13:40:59 -0700 Message-Id: <20250321204105.1898507-3-kees@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250321202620.work.175-kees@kernel.org> References: <20250321202620.work.175-kees@kernel.org> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1255; i=kees@kernel.org; h=from:subject; bh=pXkT7am0yPdv1f217KYbpZB7Vpb7nbz805ybospBIJs=; b=owGbwMvMwCVmps19z/KJym7G02pJDOl3z92xNW0r5P3/MeLSnvR0CZZtWdbr/5dHKHKuqdLay qwz5aNgRykLgxgXg6yYIkuQnXuci8fb9nD3uYowc1iZQIYwcHEKwEQmVTEyvPh086Doky/nYrhe V8tftL7GnKNle7gx7YFvQXqK9tPeDIb/Cdzvpq39JNZ6hde6yu7FQpEkxr8qZt3HYo7wXCvqzvv FBQA= X-Developer-Key: i=kees@kernel.org; a=openpgp; fpr=A5C3F68F229DD60F723E6E138972F4DFDC6DC026 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 85EB940004 X-Stat-Signature: 9kxxdnhb51874jniwjutx667hatixw7r X-Rspam-User: X-HE-Tag: 1742589670-490518 X-HE-Meta: U2FsdGVkX1/14QNSmuCJDPwTEnP8+I1QGJUaZ6Rw7HsUku1YbwGVKJS03yNZTfFBV2pc/C8BGxGQSIIyacM5SfrTqsLxsxQqGWe09NaTeqFcCzaUzbJTDopk1/kpz2tG5rheoeJQHOL8MzPaXoIcId5gQcsD/SLGxP9wOAEj5YvGkYBiRXyn9MejQ+ipZOkHPOicOMKlD4D9tcksNpnuwDS8dHmC9TGUQnE15C6OxP6Pi/dhCgkvtud/5CBKLaLC6VSv7z56HBWQ2wfbsyHz3HG1zqpEsUGN9Y/GjZhDxbGZuGFdDAN0NGcRaqgeOPIABOQdDeRjqxczTNTNvHUnwVnjW6CAgKbqh87J/o0ka+JaP3s8C7dXAYxYNV7Ynuc/Sihoa//KjGt6ZaMnjoI9I7XXzdPt6xltOtlq3rY5gwhtjEnze3mXBK+s3HHWsPDbebhwE2g5WShMMFXYfTFMZc9QPUfAkxQ8hhJI1rSoYg77ImSkEW7O5xVM9YYjvcHiq0cwUxFSobup+kNFahrLuYgkXJOvFAe4rlQyJBmzRdSQ19IwSFGZ3P2NxW2E9JCGYsdJGMIkidV6RBSWGMYUOfeLObeOc5gQbmPT/AQm9sd0WAqFYnJHUOJg0ByPozkzhirXdXeP5k8Yz87PcIJkb4lhWHUvWx8/1C1hFY6fWzMa/H4V3OCp7fIsDrV2s3nR2ORQE3H39OXZ09bRaRiwwNhxdH3uAKu4CBrMI9xV9Ox/2cwQ7iWEHuY/EKAgKO/mIi4UP/fuJLIDFGcorfUqAFoggKUfQQzW2aGsrg5QuKVVkdww/Rx9FIEX3qM4XXoRy3Geh67/CfMbwb8FEtQkHqTzxFPLY4golh+AUcFOARrypZvmnhTpa76jL92uc8pnv2nsdImv/3nDe1CZGWa/lR5CHPc7K0gbLSVqivWKZtccnXD1KaAipuG4/xEb56tPYX6DDAlGMODnFFHyinb 9864TYxn aQU5T7xfWyYG0ZR0sTnu3Ag4oM5mDhgtkMjPCVD8YwOUDZS/vJYBr+2BjEKHt04zaltKCl0LuiNMpjAXeEUtwdBNpb7SBa2fM+fwj7JR7woj/NVotOUqguHOYfj25RcgC/g/aWht9V+RMFE9s5kMM5sLRyDwPoNvvDUI7nXV4neyQInVi20cmTxuqmJ/aiD8dqWLTo1aVXYP+E1O5t2qDmAze8NLTlc6VGMQwl7POyzQctNkGyxUxbnZxUD2va56Je4sAO4Fd/uA4/ggcF2S9eldvzMYW64edSUa302g4TIYDIlNOambnYzOXRDI0HjdjeMeUcetSJqvOp9eSdLFDGklFJWnN8XAcYDGMY9/ZHJkJ4ClqcYWjvI/G/4JNNR5TvIfpa9nkCNq7hHx7Lk2LgA0wI7i93M+2MTyOKVdA0TZAqkg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: If __builtin_is_lvalue() is available, use it with __is_lvalue(). There is patch to Clang to provide this builtin now[1]. Link: https://github.com/kees/llvm-project/commits/builtin_is_lvalue/ [1] Signed-off-by: Kees Cook --- Cc: Miguel Ojeda Cc: Nathan Chancellor Cc: Marco Elver Cc: Nick Desaulniers Cc: Przemek Kitszel --- include/linux/compiler_types.h | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/include/linux/compiler_types.h b/include/linux/compiler_types.h index e09d323be845..eb016808dfa8 100644 --- a/include/linux/compiler_types.h +++ b/include/linux/compiler_types.h @@ -468,6 +468,16 @@ struct ftrace_likely_data { #define __annotated(var, attr) __builtin_has_attribute(var, attr) #endif +/* + * Determine if a given expression is an lvalue for potential + * assignment. Without the builtin, report nothing is an lvalue. + */ +#if __has_builtin(__builtin_is_lvalue) +#define __is_lvalue(expr) __builtin_is_lvalue(expr) +#else +#define __is_lvalue(expr) false +#endif + /* * Some versions of gcc do not mark 'asm goto' volatile: *