From patchwork Sun Mar 30 12:17:11 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoquan He X-Patchwork-Id: 14032901 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3AE8C36011 for ; Sun, 30 Mar 2025 12:17:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C00A4280003; Sun, 30 Mar 2025 08:17:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B8A09280001; Sun, 30 Mar 2025 08:17:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A0424280003; Sun, 30 Mar 2025 08:17:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 82C73280001 for ; Sun, 30 Mar 2025 08:17:36 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id CA5F4ABA71 for ; Sun, 30 Mar 2025 12:17:36 +0000 (UTC) X-FDA: 83278118112.27.05FA67F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 007E4100007 for ; Sun, 30 Mar 2025 12:17:34 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ekssB7FZ; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743337055; a=rsa-sha256; cv=none; b=qQTJzUcIGketJDdKgq1T/JzGFkHTKavNdziOJIZeXbVzgCM9emkHciTsYYrm8jUTi1Oo7i Ml8KelcSdemCruLOvEfG3vLTZpiT+0HLS2fPNLpVCEfb2OFRAgAvUsKdfqYxYNu2wlpFin YvmnJ6UAQVsHzVJ9TrbmCpOjIDK8wG0= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ekssB7FZ; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743337055; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=66JPNi1zYSbyVc7TO8PPyR6Yrn7uiScYJyyuaMI/UWs=; b=ZcMcskiL55fRgWrz6YXObifcI36HjYFEM17YWnyYSmZPVt9R9hWclQj/5czodo1ZGf6yP1 HZvbAasRkdvJj2E0hjYG6eSLk+65E0FpIYtozr5/151YJX1v1lLDSZrBc3sOQWja5t/2pj wgs3eqfptM20OShnCOCANvRlvV2kbbU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1743337054; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=66JPNi1zYSbyVc7TO8PPyR6Yrn7uiScYJyyuaMI/UWs=; b=ekssB7FZiKW0HrZmHkDCZT3Yc7UEg2ljXIz7dmT8qGqQLvR3yY0eESDLqDE1fwQp7Uyk5C gEVJKlGzG/+Nm4+9TLG0+N2D1BE9BPeCq/hSgoVIF3Ih/lASIT7A1jlaph1KMPrK24wb2y NxhM6QHE6EU3cnHFI7jlS3yxBmzLNnM= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-207-vuwXJPkUN92ViNpZjUnXmw-1; Sun, 30 Mar 2025 08:17:31 -0400 X-MC-Unique: vuwXJPkUN92ViNpZjUnXmw-1 X-Mimecast-MFC-AGG-ID: vuwXJPkUN92ViNpZjUnXmw_1743337050 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 992B5195E92A; Sun, 30 Mar 2025 12:17:30 +0000 (UTC) Received: from MiWiFi-R3L-srv.redhat.com (unknown [10.72.112.17]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 0E5C71801750; Sun, 30 Mar 2025 12:17:25 +0000 (UTC) From: Baoquan He To: akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Baoquan He Subject: [PATCH 1/7] mm/gup: fix wrongly calculated returned value in fault_in_safe_writeable() Date: Sun, 30 Mar 2025 20:17:11 +0800 Message-ID: <20250330121718.175815-2-bhe@redhat.com> In-Reply-To: <20250330121718.175815-1-bhe@redhat.com> References: <20250330121718.175815-1-bhe@redhat.com> MIME-Version: 1.0 Content-type: text/plain X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 007E4100007 X-Stat-Signature: bp7r5szk54oqnbzfxbz7ybqe9z37gxdj X-HE-Tag: 1743337054-907030 X-HE-Meta: U2FsdGVkX19c3sxolvMM96XjpI1ZQSWGIWmRczWaZYKGVdjyL1YL7TYciC+xyezamwylEW2zrpoXKS++A6HyA2fVREY2DeBlSAPhkSjd6kWKFekVfJFvUGZhIcdNIOXNqW+uDHZIUwXDickoE/QnkIZr+jtgqLAzy8/WRc+NFR79RW8aFC7nuDorklgB3AMyzyLaqMpRa8YC/bkfpmjH/VmZAq/o11qmZseAEm1itVyKwdcXsyOqiCjvaoPgWFOW339DL/W1Cf+lY9+j/7Zg9oUFM75zzNACW7VVUio2R6VrgK3Gse9IRnK6Ewyd53BkMk71pOiCeGqigv2/0rgBUpuD59e47cZ3iyFIblpsG96FJtvZAOOSF8qoijPsHE3XRMJBxnh9cUcHMGN6BIq2zyTtDrjGKmlBxOyj+rQy5tjgcVsosWaijzqLC/9GDAchpEz89nQFfg+xoRFEDgB/nFAS5Uw9HCGT0kL0YrEq3y+YLBlsbPyeZh/G3Rs+0UVQrnNz/6SA7OwsJ9tNeWFKUHcDA9nWK2lirEcm50xX1anbZmhye/0NZkp6yQg2p0f2UEoxYlLhcj7qIIAeYedYWLi9zwG58m0KkJG9VGRgNYan6CRyGjAa19rYQ7vGN5rkDMkgDoj9HThPzzmJJzwy+YPTztu8oAFROswJsVaEvnJDkYlrmdThO4nTFFevRKfSFoXTiX6MmLZn52a24rhHf3HBmEgOL4uSGFdvWGKwyJ6n/fRFTa16i0DjIVn2VJ8aUV/V4kzqqXj7czSAkQbFmCWhUBWKQIvsFe5SPL0CxVj9T44vvv97zvMjah+H5snHXV7xjxMRngm3RAN1oO7+Tk5obyc3fv4E1bFRKAHbFo536AcdNBSCHav2rPHdg/eqnf/8QoBNEOiVF2ZURpDngx5cd9JmqX6aiFpIGyTJ7bsQKSEDXMA8ZRW4jICFlhlvWBdU4swCZIuGsHz45U2 zOGLbvUZ nCX30UXk11TB8SgypDDzHda7a6mpfTI8UW+3pJzy2kJpKTRgHyiQLGcUTCUchNZWjONgsxu5Hmr+krTgG+9BhVFj11Ki0fW0fwRoWjaDPkEO0NLtM1YzsOt2as888LP/EGteCSh9zIJis0Av0/JXm2QPzqoSAA5VCN5JYzNPphwhs+zinJjRUv0BtvNqCP0e1iBr0zOXtUbfFRDiuJJjM+97EIunjRey9scVnZUeAukbOQaz9ns4d+EqhY0UhKBTJhu6i6tkbgxtn53hEoY2gSFlu1VrTkI0XTA6pPh188A6P1AuFCiUvcVcifKzNrMXOrF8wNogKwTRyKhxaJlWpkQQXKznyg/flJGJJVgxF5U5zURz9yki8c5+1SmOT1Ub/oZsq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Not like fault_in_writeable() or fault_in_writeable(), in fault_in_safe_writeable() local variable 'start' is increased page by page to loop till the whole address range is handled. However, it mistakenly calcalates the size of handled range with 'uaddr - start'. Fix it here. Signed-off-by: Baoquan He --- mm/gup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/gup.c b/mm/gup.c index 855ab860f88b..73777b1de679 100644 --- a/mm/gup.c +++ b/mm/gup.c @@ -2207,8 +2207,8 @@ size_t fault_in_safe_writeable(const char __user *uaddr, size_t size) } while (start != end); mmap_read_unlock(mm); - if (size > (unsigned long)uaddr - start) - return size - ((unsigned long)uaddr - start); + if (size > start - (unsigned long)uaddr) + return size - (start - (unsigned long)uaddr); return 0; } EXPORT_SYMBOL(fault_in_safe_writeable);