From patchwork Fri Apr 4 07:46:20 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rakie Kim X-Patchwork-Id: 14038180 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00418C36010 for ; Fri, 4 Apr 2025 07:46:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 763DC280005; Fri, 4 Apr 2025 03:46:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 67605280001; Fri, 4 Apr 2025 03:46:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4C8F5280005; Fri, 4 Apr 2025 03:46:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 31356280001 for ; Fri, 4 Apr 2025 03:46:41 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B7760ADED9 for ; Fri, 4 Apr 2025 07:46:41 +0000 (UTC) X-FDA: 83295579402.29.09C0884 Received: from invmail4.hynix.com (exvmail4.hynix.com [166.125.252.92]) by imf19.hostedemail.com (Postfix) with ESMTP id CB3261A000E for ; Fri, 4 Apr 2025 07:46:39 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf19.hostedemail.com: domain of rakie.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=rakie.kim@sk.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743752800; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ejezUsIK19i+6DJDkw722EMxwAbCiAXODvyrDity0y8=; b=NJsTqWhGOsB0c7X0HhmeD+od70SYPot54PQ9+Sfr4nD0lCDOgu9q11CEc8GpLmZhh48la8 wOkVeKzw1/j1GABe59QKZLQT5gAeRhAOu0QQip2EO0sbOd7opTcteZKu2GaOk7BdFUvI0I 9tnXaVcoLN8zLJYPkqazMGSUj5K/xwk= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf19.hostedemail.com: domain of rakie.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=rakie.kim@sk.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743752800; a=rsa-sha256; cv=none; b=IRQwdn2BOda1GZ5VTulCteRXGqVwMSIvjMDAPNUXGtAUF5h0piLGS/661rHcMMZ5IWynh1 sJR6lOolX1EcnkEeiLpMvl4JITjIeNhwilYz/sJM5eE4zhbMJzINwBV8fYSH8wOQ+iPZQT l7doQke2rsmIBBy1hIK18wIlqYzE6jM= X-AuditID: a67dfc5b-681ff7000002311f-d0-67ef8e5ceb36 From: Rakie Kim To: akpm@linux-foundation.org Cc: gourry@gourry.net, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org, joshua.hahnjy@gmail.com, dan.j.williams@intel.com, ying.huang@linux.alibaba.com, david@redhat.com, Jonathan.Cameron@huawei.com, osalvador@suse.de, kernel_team@skhynix.com, honggyu.kim@sk.com, yunjeong.mun@sk.com, rakie.kim@sk.com Subject: [PATCH v6 2/3] mm/mempolicy: Prepare weighted interleave sysfs for memory hotplug Date: Fri, 4 Apr 2025 16:46:20 +0900 Message-ID: <20250404074623.1179-3-rakie.kim@sk.com> X-Mailer: git-send-email 2.48.1.windows.1 In-Reply-To: <20250404074623.1179-1-rakie.kim@sk.com> References: <20250404074623.1179-1-rakie.kim@sk.com> MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrBLMWRmVeSWpSXmKPExsXC9ZZnoW5M3/t0gzeXVS3mrF/DZjF96gVG i6/rfzFb/Lx7nN1i1cJrbBbHt85jtzg/6xSLxeVdc9gs7q35z2pxZlqRxeo1GQ7cHjtn3WX3 6G67zO7RcuQtq8fiPS+ZPDZ9msTucWLGbxaPnQ8tPd7vu8rmsfl0tcfnTXIBXFFcNimpOZll qUX6dglcGff2H2QqeKFWcejmG8YGxm/yXYycHBICJhJ7pt9jhLFbV50Fsjk42ASUJI7tjQEJ iwjISkz9e56li5GLg1ngMZPEo+cvwGqEBaIkni1WBalhEVCVOLr+GhuIzQs0ZtryOSwQIzUl Gi7dYwKxOQVMJX4/PAlmCwHVrH56hB2iXlDi5MwnYPXMAvISzVtnM4PskhD4zCYx/+5ZqEGS EgdX3GCZwMg/C0nPLCQ9CxiZVjEKZeaV5SZm5pjoZVTmZVboJefnbmIEhv+y2j/ROxg/XQg+ xCjAwajEw2tR+C5diDWxrLgy9xCjBAezkgjv3Zz36UK8KYmVValF+fFFpTmpxYcYpTlYlMR5 jb6VpwgJpCeWpGanphakFsFkmTg4pRoY2wLnmyZ+n28i/CLDI+72odeVqs9Zlizb4Wxtcmaz 2Mu1eT9PdpsGHb1RWjh17Up7F+6NTWkS3dvWzcku2C3wWTJ9+a9nAVNum25W+8W3ZVpUVprO reN1nnZXdFmljddVFLaf1Uh+PGl2Fadzd0GT6U63fUlT1l11PxYxjaF+SfEG24vHCj5/U2Ip zkg01GIuKk4EABrSeI57AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrELMWRmVeSWpSXmKPExsXCNUNNSzem7326wa21UhZz1q9hs5g+9QKj xdf1v5gtft49zm7x+dlrZotVC6+xWRzfOo/d4vDck6wW52edYrG4vGsOm8W9Nf9ZLc5MK7I4 dO05q8XqNRkWv7etYHPg99g56y67R3fbZXaPliNvWT0W73nJ5LHp0yR2jxMzfrN47Hxo6fF+ 31U2j2+3PTwWv/jA5LH5dLXH501yATxRXDYpqTmZZalF+nYJXBn39h9kKnihVnHo5hvGBsZv 8l2MnBwSAiYSravOMnYxcnCwCShJHNsbAxIWEZCVmPr3PEsXIxcHs8BjJolHz1+A1QgLREk8 W6wKUsMioCpxdP01NhCbF2jMtOVzWCBGako0XLrHBGJzCphK/H54EswWAqpZ/fQIO0S9oMTJ mU/A6pkF5CWat85mnsDIMwtJahaS1AJGplWMIpl5ZbmJmTmmesXZGZV5mRV6yfm5mxiBIb+s 9s/EHYxfLrsfYhTgYFTi4bUofJcuxJpYVlyZe4hRgoNZSYT3bs77dCHelMTKqtSi/Pii0pzU 4kOM0hwsSuK8XuGpCUIC6YklqdmpqQWpRTBZJg5OqQbGjpDJARse9C59wZ8tkmQXtMORLeLu 9cieiW2LTWaaGFyZ4bUxm0n0o+aKY6KLn584apRuYhi6f9eCpaIVEfUxu4tntS2dHvBVSfQC Z2LcRv5s9b3pX0vmqE7oVva7GV95XHWis03oJeH0/iOiawokT63KXXpvEVeh0fptTwokHN7P Odxla2OpxFKckWioxVxUnAgAjwN6gnUCAAA= X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: CB3261A000E X-Rspamd-Server: rspam05 X-Rspam-User: X-Stat-Signature: urnykm8d1e6t5xon1g6yo53e3odywgny X-HE-Tag: 1743752799-169515 X-HE-Meta: U2FsdGVkX19JUCfykUEOtqF2gZRdwkJFlymYDOpQ6xkaGQhzx7BlAIYyRbEcKNnP652i9+B077jtVlsB+gaAV+pyGg6dSwrouHYFZK4NNcaJKT/03YZebN+PU6l1VkMk33EylggAt5UNTnrBD1UUyJFBXgPsXolyVFnOtSjnSRi+tJnrV0xE36Rg1NEoYdLy6L0l3Mtp9IhGTzRXmN6TNVEqIEnqztl1HiM2A/5Srrs784jboPVWICM3asjqg+zJ31AyK9eWKM9Rpk8k4yqCT+PdiL141DPlZnGHeyhREcq+L6x6H3o3rqmStxDWSZiVagSJiYyn2Ek4bI5wYSavrmvFwseHpQ2WNSNzTH+0UkZDtcIIiwKAjHW+hxw3CcqpK3tFg/fyKMea2AxGSQ0AL5CMzDsyaPeKb0U69LaUEuxWZuiQosiPIarmRrtusmib1kj2mgbjJHhpsj9ctRPA+P4TfC+pxQ6rxrurdmtfaOEC/vNC5L+iR9j/zX1M2g0NZNC74PA+eEFsLDSPCTtTmJvbasQo/qqpb/TyTjlUEJS9gwAk5GWar37cnP0mXd3Ec7IpJ5+vxIQYOa96cjGVvAT0jUtQWVY0cYLSlrCvjnsx025PGyo6dtXznLnpq9tNoTzZSP4UFMUQXF1/YZn+VFZUkQGiSbKQ+RSpxWnD+W33EyvOHUswP2rlYlRPL2RzvbCmJALh7eEZZ6jtGzLOWWSxZqcjwKOQnu1tXKHjstmJQOquz+ov5mr72aXZZYX0R5v/EDwUe7+zvypItNvvm+JsNYzLcdPU63mS1ORNBRTIIWYkQCenonaG+TIt5GO+iJceFTMyrOgxRR+sbbx1MGWcV+JMkt9zoi2aDYrJ0QDsgtjLaYwaQy/E0MrGBxfr2iz2MUj+5PqKwuzSCAPM52mnUZXddsoNKxbk3nwM0KmTIU0zYyX07jMw5e26heHJFjbzbSeupTzdhpc8b0R lAwkrqqH S8SknHzm08igKmPjSZ3z++/7A2Eu+g0LxNLwcARiPC6f/cAFsJ8B+07g02WCCioRWnNDzmN46u34LxOX2byWFJ2Cag8TU+SVVsFeEvlUqsQgBfsbkuXBtu7CmdP01GrHJoSWEIAGMpOa3+hMb6eT7ahbOc7XMSXhMPr3Z X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Previously, the weighted interleave sysfs structure was statically managed during initialization. This prevented new nodes from being recognized when memory hotplug events occurred, limiting the ability to update or extend sysfs entries dynamically at runtime. To address this, this patch refactors the sysfs infrastructure and encapsulates it within a new structure, `sysfs_wi_group`, which holds both the kobject and an array of node attribute pointers. By allocating this group structure globally, the per-node sysfs attributes can be managed beyond initialization time, enabling external modules to insert or remove node entries in response to events such as memory hotplug or node online/offline transitions. Instead of allocating all per-node sysfs attributes at once, the initialization path now uses the existing sysfs_wi_node_add() and sysfs_wi_node_delete() helpers. This refactoring makes it possible to modularly manage per-node sysfs entries and ensures the infrastructure is ready for runtime extension. Signed-off-by: Rakie Kim Signed-off-by: Honggyu Kim Signed-off-by: Yunjeong Mun Reviewed-by: Gregory Price --- mm/mempolicy.c | 73 ++++++++++++++++++++++---------------------------- 1 file changed, 32 insertions(+), 41 deletions(-) diff --git a/mm/mempolicy.c b/mm/mempolicy.c index af3753925573..73a9405ff352 100644 --- a/mm/mempolicy.c +++ b/mm/mempolicy.c @@ -3388,6 +3388,13 @@ struct iw_node_attr { int nid; }; +struct sysfs_wi_group { + struct kobject wi_kobj; + struct iw_node_attr *nattrs[]; +}; + +static struct sysfs_wi_group *wi_group; + static ssize_t node_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf) { @@ -3430,27 +3437,24 @@ static ssize_t node_store(struct kobject *kobj, struct kobj_attribute *attr, return count; } -static struct iw_node_attr **node_attrs; - -static void sysfs_wi_node_release(struct iw_node_attr *node_attr, - struct kobject *parent) +static void sysfs_wi_node_delete(int nid) { - if (!node_attr) + if (!wi_group->nattrs[nid]) return; - sysfs_remove_file(parent, &node_attr->kobj_attr.attr); - kfree(node_attr->kobj_attr.attr.name); - kfree(node_attr); + + sysfs_remove_file(&wi_group->wi_kobj, + &wi_group->nattrs[nid]->kobj_attr.attr); + kfree(wi_group->nattrs[nid]->kobj_attr.attr.name); + kfree(wi_group->nattrs[nid]); } static void sysfs_wi_release(struct kobject *wi_kobj) { - int i; - - for (i = 0; i < nr_node_ids; i++) - sysfs_wi_node_release(node_attrs[i], wi_kobj); + int nid; - kfree(node_attrs); - kfree(wi_kobj); + for (nid = 0; nid < nr_node_ids; nid++) + sysfs_wi_node_delete(nid); + kfree(wi_group); } static const struct kobj_type wi_ktype = { @@ -3458,7 +3462,7 @@ static const struct kobj_type wi_ktype = { .release = sysfs_wi_release, }; -static int add_weight_node(int nid, struct kobject *wi_kobj) +static int sysfs_wi_node_add(int nid) { struct iw_node_attr *node_attr; char *name; @@ -3480,58 +3484,45 @@ static int add_weight_node(int nid, struct kobject *wi_kobj) node_attr->kobj_attr.store = node_store; node_attr->nid = nid; - if (sysfs_create_file(wi_kobj, &node_attr->kobj_attr.attr)) { + if (sysfs_create_file(&wi_group->wi_kobj, &node_attr->kobj_attr.attr)) { kfree(node_attr->kobj_attr.attr.name); kfree(node_attr); pr_err("failed to add attribute to weighted_interleave\n"); return -ENOMEM; } - node_attrs[nid] = node_attr; + wi_group->nattrs[nid] = node_attr; return 0; } -static int add_weighted_interleave_group(struct kobject *root_kobj) +static int add_weighted_interleave_group(struct kobject *mempolicy_kobj) { - struct kobject *wi_kobj; int nid, err; - node_attrs = kcalloc(nr_node_ids, sizeof(struct iw_node_attr *), - GFP_KERNEL); - if (!node_attrs) + wi_group = kzalloc(struct_size(wi_group, nattrs, nr_node_ids), + GFP_KERNEL); + if (!wi_group) return -ENOMEM; - wi_kobj = kzalloc(sizeof(struct kobject), GFP_KERNEL); - if (!wi_kobj) { - err = -ENOMEM; - goto node_out; - } - - err = kobject_init_and_add(wi_kobj, &wi_ktype, root_kobj, + err = kobject_init_and_add(&wi_group->wi_kobj, &wi_ktype, mempolicy_kobj, "weighted_interleave"); - if (err) { - kobject_put(wi_kobj); + if (err) goto err_out; - } for_each_node_state(nid, N_POSSIBLE) { - err = add_weight_node(nid, wi_kobj); + err = sysfs_wi_node_add(nid); if (err) { pr_err("failed to add sysfs [node%d]\n", nid); - break; + goto err_del; } } - if (err) { - kobject_del(wi_kobj); - kobject_put(wi_kobj); - goto err_out; - } return 0; -node_out: - kfree(node_attrs); +err_del: + kobject_del(&wi_group->wi_kobj); err_out: + kobject_put(&wi_group->wi_kobj); return err; }