From patchwork Fri Apr 4 11:20:49 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shuai Xue X-Patchwork-Id: 14038310 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 351FAC36010 for ; Fri, 4 Apr 2025 11:21:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C9A166B000D; Fri, 4 Apr 2025 07:21:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C2B6D6B000E; Fri, 4 Apr 2025 07:21:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AC5606B0012; Fri, 4 Apr 2025 07:21:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 8BDCD6B000D for ; Fri, 4 Apr 2025 07:21:03 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D9727C26CD for ; Fri, 4 Apr 2025 11:21:03 +0000 (UTC) X-FDA: 83296119606.12.1060E99 Received: from out30-119.freemail.mail.aliyun.com (out30-119.freemail.mail.aliyun.com [115.124.30.119]) by imf11.hostedemail.com (Postfix) with ESMTP id 6A8F340010 for ; Fri, 4 Apr 2025 11:21:00 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=p3iyPJ3q; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf11.hostedemail.com: domain of xueshuai@linux.alibaba.com designates 115.124.30.119 as permitted sender) smtp.mailfrom=xueshuai@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743765662; a=rsa-sha256; cv=none; b=Y3z7J05TmGyY7bSU14OO4g0mYQ5NpsikMNUj5/wD6RwbFL43iaxyJBfCcrBAvlPL7AndvL Ix5EE73N3QkhpQe1izlt070+o2eMaLyCOX/GuIACTnZEdljmgKj0Lx9VuUkhn+TRmFS+ch sGr7QndZK4vt52M3lwblfmSk8+IvBTE= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=p3iyPJ3q; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf11.hostedemail.com: domain of xueshuai@linux.alibaba.com designates 115.124.30.119 as permitted sender) smtp.mailfrom=xueshuai@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743765662; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZDTzk5K2g15UxWfl6j/3+PEqqENlWe4tABU88QNYdSI=; b=1ShroRq5Ks4MRaHJo3XjXKovsvYt+JE/3EgGcxvg7v9Kq5Qnxu4QRf9lH8Ke91fqcfgDiO Sni9bEKfLjWjfOrwcBeSrESX1hLa42N07Mtu/Ug1AGikdrTKUObjaN8HGUSexuR6LdCN12 XKvT7+Ri89KeUXASJIDIqCGfKlm7xVo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1743765658; h=From:To:Subject:Date:Message-ID:MIME-Version; bh=ZDTzk5K2g15UxWfl6j/3+PEqqENlWe4tABU88QNYdSI=; b=p3iyPJ3qb61nPLuFNltF6VPy3PUAfmBiKFCr4MyShp0rCHur+GYMIR0BBBW5REpRcmkFLn6WJLbd5WAXaBwvg4PqBozc4GV2WcDvHfe1K7ZDkoIWaoHLBYZIbPp1rwvOaHqATGPeEKbK5CC+yxyGLsG5SXG9UOfj0T/e2axT580= Received: from localhost.localdomain(mailfrom:xueshuai@linux.alibaba.com fp:SMTPD_---0WUylQJe_1743765654 cluster:ay36) by smtp.aliyun-inc.com; Fri, 04 Apr 2025 19:20:56 +0800 From: Shuai Xue To: catalin.marinas@arm.com, sudeep.holla@arm.com, guohanjun@huawei.com, lpieralisi@kernel.org, linux-acpi@vger.kernel.org, yazen.ghannam@amd.com, mark.rutland@arm.com, mingo@redhat.com, robin.murphy@arm.com, Jonathan.Cameron@Huawei.com, bp@alien8.de, rafael@kernel.org, linux-arm-kernel@lists.infradead.org, wangkefeng.wang@huawei.com, tanxiaofei@huawei.com, mawupeng1@huawei.com, tony.luck@intel.com, linmiaohe@huawei.com, naoya.horiguchi@nec.com, james.morse@arm.com, tongtiangen@huawei.com, gregkh@linuxfoundation.org, will@kernel.org, jarkko@kernel.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, linux-edac@vger.kernel.org, x86@kernel.org, xueshuai@linux.alibaba.com, justin.he@arm.com, ardb@kernel.org, ying.huang@linux.alibaba.com, ashish.kalra@amd.com, baolin.wang@linux.alibaba.com, tglx@linutronix.de, dave.hansen@linux.intel.com, lenb@kernel.org, hpa@zytor.com, robert.moore@intel.com, lvying6@huawei.com, xiexiuqi@huawei.com, zhuo.song@linux.alibaba.com Subject: [RESEND PATCH v18 1/2] ACPI: APEI: send SIGBUS to current task if synchronous memory error not recovered Date: Fri, 4 Apr 2025 19:20:49 +0800 Message-ID: <20250404112050.42040-2-xueshuai@linux.alibaba.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20250404112050.42040-1-xueshuai@linux.alibaba.com> References: <20250404112050.42040-1-xueshuai@linux.alibaba.com> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 6A8F340010 X-Stat-Signature: u1kur57uo1919h95imfyykoot4ijt8bp X-HE-Tag: 1743765660-759558 X-HE-Meta: U2FsdGVkX1+rr3edWkTW5WHGjXfQxoRhsjLJ88ZWtMJ92+LmMvmkV0vwxM94nmWc3wE3DxU0PfSzMJxEEd29bS/55uHlz2DMDA7b6CmRGczbB0iiEszADegrDIWunWPrK8UnrPwgbck901j1euJqbxo8FmXsdEPVjU9XC/2nsqYAI2R8d5e4Px4s5xQshK6xmPr0CAyBhoLyDsno0RVo9lNerQGti3vrG56Q8Wgwhy4CiX8KSQrd0aYSohVkl5/BHKO+f+ZDfySGc28qBnuN3lnl84upRH/XQM6EYIdNFW+kjfB0Emwv8gd8PSIm7Tk1kcDSVTIsgwB0OsddR+3xGWKumEoSsD3N/MdAniilPgfQAwMGG9soXHL+b1+dth6EU2YyaFsyFNbyDAtEAk8vbEhAfXkFnq0P26CxouVFUkK4m60TyhNryN+sVVflWNrvRGs9yPs7DetJIbQXteSjzHnV70jOWhdih2tr8B65KnCbQ0SlNQ8LeAchXE5DaLHpTz62JiZCA/+q0TgUCQaQ92tFVjCFS/ENJxmlzvpy+8wr9c35oFSx9ID3qg3ZrMSmlLcFoUHPz2Lx8W2QZ/gzxTRm57AmHQiVrkQKbME7Cr1WEOv0ESjT11K7ABlzzfFMXay96xhtqi2bXCXV9Gu754WW6fTVJiMMStGg/tMkDzhz2Dhf3kQjLdItABluICYIkJ9tyOoEEccPgcR1VR+rUESbl2MMO/SdK5eZ5SOHyajmlQ964I7wsL/xY/5R/BHoWkY66N7xqu4alikPLHOtFYGpflO52zRPx29j2tJ7qq2IOpPn9YEv5Kg8r+kwEQOXm+ALjqgIYWZeTpMrbHlfEoXg3SgQXU88J6aeR+RY3ESpapdGbmxvG1qELyOx2XNvipEYsOylZShro+s567I4r40ae+cYL2ReZBOAKAzhPNaLGrDDRVGbeExGawAH1qtSfhqU36GNipNZz+lDZIv xyrRX1ZH +R29r2DQF5CA6Omyl8q3aowGczMHyCdyOM8/XyP41/x/sYsWgrIhX+7nayMk3y3ufWu1JLRNCJ8mbTxlbavI4xRSSHU16lqA5+2KvkacK0XkEj0mUlGeP57D1QgHISWRemRq5/K0AlHH5sFjaLYLm0/pbZfFi8qPfyjoV8qMw34rZqabJG5Ggjjo9ro4l/wnoxUnSeZMgmjYv+cJrd9ZwBroFrI2UFaLhPItXbqLFQYUfZPcTobskjD9PIfRsU7tBw3xayEEEwDg8wMMQe/laqRqaME5M7NllETtLn9VKHFg7yKOIKSS15dxpH5/WrvRpu+cr X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Synchronous error was detected as a result of user-space process accessing a 2-bit uncorrected error. The CPU will take a synchronous error exception such as Synchronous External Abort (SEA) on Arm64. The kernel will queue a memory_failure() work which poisons the related page, unmaps the page, and then sends a SIGBUS to the process, so that a system wide panic can be avoided. However, no memory_failure() work will be queued when abnormal synchronous errors occur. These errors can include situations such as invalid PA, unexpected severity, no memory failure config support, invalid GUID section, etc. In such case, the user-space process will trigger SEA again. This loop can potentially exceed the platform firmware threshold or even trigger a kernel hard lockup, leading to a system reboot. Fix it by performing a force kill if no memory_failure() work is queued for synchronous errors. Signed-off-by: Shuai Xue Reviewed-by: Jarkko Sakkinen Reviewed-by: Jonathan Cameron Reviewed-by: Yazen Ghannam Reviewed-by: Jane Chu --- drivers/acpi/apei/ghes.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c index b72772494655..50e4d924aa8b 100644 --- a/drivers/acpi/apei/ghes.c +++ b/drivers/acpi/apei/ghes.c @@ -799,6 +799,17 @@ static bool ghes_do_proc(struct ghes *ghes, } } + /* + * If no memory failure work is queued for abnormal synchronous + * errors, do a force kill. + */ + if (sync && !queued) { + dev_err(ghes->dev, + HW_ERR GHES_PFX "%s:%d: synchronous unrecoverable error (SIGBUS)\n", + current->comm, task_pid_nr(current)); + force_sig(SIGBUS); + } + return queued; }