From patchwork Fri Apr 4 15:59:58 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Woodhouse X-Patchwork-Id: 14038655 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2043EC36010 for ; Fri, 4 Apr 2025 16:00:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C89EC280006; Fri, 4 Apr 2025 12:00:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 87769280001; Fri, 4 Apr 2025 12:00:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5D939280007; Fri, 4 Apr 2025 12:00:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 23213280006 for ; Fri, 4 Apr 2025 12:00:14 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C15981C7CA6 for ; Fri, 4 Apr 2025 16:00:14 +0000 (UTC) X-FDA: 83296823148.29.D78BFF2 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf18.hostedemail.com (Postfix) with ESMTP id E5BA91C0005 for ; Fri, 4 Apr 2025 16:00:11 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b="d7l3I/9/"; spf=none (imf18.hostedemail.com: domain of BATV+341917c36a2da2958cd5+7894+infradead.org+dwmw2@desiato.srs.infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=BATV+341917c36a2da2958cd5+7894+infradead.org+dwmw2@desiato.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743782412; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SAQbWjWGGmEWV/yrGcgLnMo50LiJ5Xc9HvWor5bjKpE=; b=8BgpqlD01dtxeZ4+aMwvLSB+L2HZZ4/tJ/lH3rYpTkYdh+UMtVyfmJoxKnPBv+RVGSe6xE cdHePrsWtoN5SUeYXuPQQBynazsyV/7/3g6QRtREU4oek/VdDiGyaisKc+oyNmo5iWzsBO taJEWgBLZovmPwE3jR099psRduoZto4= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b="d7l3I/9/"; spf=none (imf18.hostedemail.com: domain of BATV+341917c36a2da2958cd5+7894+infradead.org+dwmw2@desiato.srs.infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=BATV+341917c36a2da2958cd5+7894+infradead.org+dwmw2@desiato.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743782412; a=rsa-sha256; cv=none; b=in6UTSYr0zwi/A/G6WeTcua7CYynPqKu1M5heI373hTpf6f7+ILaKaZaDcXMuHnOM0/BW8 oStMcqu0O5U+/PpGHncnHG00M4+LUw3j0C0hBXw5J13T4IUimDpungcKCc0CQrGOnJWj62 nRLQC8cDdoHeW0aTdP4aEnZxX5W65es= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description; bh=SAQbWjWGGmEWV/yrGcgLnMo50LiJ5Xc9HvWor5bjKpE=; b=d7l3I/9/QLogRFJbAFJpwKuy6H B0t3Z7Upm6Db3cxysxtEATptTKPyFIjrvR1IiTqa6fj8zd+dQ8qw/mYXmi9eramZYOT01xjsBr9gv g3S8NHQZZWom5Th4kzq6dixygw3CD0iPWHeYGA+zJcTe5SD91Taidj9jqPX5gJFJP4ueN+seQocDD jPgCHdxWYs/rmNqy4h+MUxbebrc9j5fMAou3iLqAwi6nhlq91/43pUrP3Nh2E91NbF/NfMzh1yd1o cmGSfeUGIxkQ2VCvR8WSn2FWLQC/FlgQVqNRFhNpjyGM/f89o/R33M7cx3j005R7UGgMZUqNNonCz 5OSe/p9g==; Received: from [2001:8b0:10b:1::ebe] (helo=i7.infradead.org) by desiato.infradead.org with esmtpsa (Exim 4.98.1 #2 (Red Hat Linux)) id 1u0jSc-00000007QOz-0XcV; Fri, 04 Apr 2025 16:00:02 +0000 Received: from dwoodhou by i7.infradead.org with local (Exim 4.98.1 #2 (Red Hat Linux)) id 1u0jSZ-0000000ERSQ-40aW; Fri, 04 Apr 2025 16:59:59 +0100 From: David Woodhouse To: Mike Rapoport Cc: Andrew Morton , "Sauerwein, David" , Anshuman Khandual , Ard Biesheuvel , Catalin Marinas , David Hildenbrand , Marc Zyngier , Mark Rutland , Mike Rapoport , Will Deacon , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [RFC PATCH v2 6/7] mm, x86: Use for_each_valid_pfn() from __ioremap_check_ram() Date: Fri, 4 Apr 2025 16:59:58 +0100 Message-ID: <20250404155959.3442111-6-dwmw2@infradead.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250404155959.3442111-1-dwmw2@infradead.org> References: <20250404155959.3442111-1-dwmw2@infradead.org> MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by desiato.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: E5BA91C0005 X-Stat-Signature: dbbjcfwdcmbt5yxgstfu9adg1trp3t9u X-HE-Tag: 1743782411-57594 X-HE-Meta: U2FsdGVkX19KFA/D58RJLf4fSmBrUVspjCD91KIlAonRFNilBXZHTFh36TWgQZlhFV/RnlGbJenxs50xhU8dy0ecJMQBRrsrnNWhICOuqQ4QcCw8x4PHsdbHFj/eY11Slo1JXhQV3Hb5FDMvkDvzdsCZw0Q7ekWnT3s8DFibLzkawvt9TigFGNkomEKDsv5quQo6xOKc5oPFjKVZppMr7tZFz7gmIOGnnoRtWk1SltumpwKAOkQGiTo5GbeYP6HV2J3xpu8Oj/+xmEfmKxGdCVMu16/zksjwLVSXbQesacwvtnbmeQokKnBSUDyo8lru8+g+Lz3gyyPUYKWDGxUNTtgwY93DIx02LQJBjlw5mc+Kwj2FaPl7fkLnYiRwd61ZLFBMfVuZHUV6Lnt22z/tYkOSxZmYqmSOY2S0yRaPr78CVOBD/opn0ynXjy8TIB+Fc22ervvwtxAUeNYm1iwG98alg3FX2fhPRNZ108+mFi8c1oBsLRyj1f1oXXvYd1j0qlH8OkQ9YylZSj58N5AEtH6gvL/Gz4oN2PO6uzpGD9vI/xNfG+aZXnzfotlDVW4Kh5H3JXa0NEROosCKEfKwEFdHaP2HKtnk8ECnUHj0WiEK7FR8+v0kOhyzP11nzrxAri3KkPWk8f38cY4oG0ffbuE4H4pPILOeI80Q+Cop74tKjEpYKimvGj54Vr0pLRdieIrWB1xhRYRDjp6rTGRZpnmVLLaKBT80cCaIurlxpdh7jk8/KzORD32uO5VnCSb+9uhBtn6P70gXTPZQiRgUViFYft9B7fFkoxuT+GfIGL1bSvVba5Eql0Fn0wqMdhjgABU2UroLWCnWVPNWYaWAIXrjpI9jqvltlhxPb0OwXQ/JXy2zsQ93GObtrjtNrpLYVnaywMO0ARZ4G+oA1GF2ijOBn+rL0zcqCI7kbmepb/qItLVcNFoOn7H8PDmhTJoahCHP6xSJZzdz2BJBIw0 xSTeYJfz F16pqI8RDjzjaDCNlt4jZjjHAbwZb/G4ExUro7RtZgBqUiCpgt6zAlysASUjXohn88ZkqiCF5nXhCoPssXo6J/U6NSaVlGnIsi+dGCmdStkFVDMx5+83qVmQ7kkkSh6KFDSkzfRF0CAapRAlu9Wfp9Qy7R3GO2NjoEZF/oDfTdqZCMEAsk6WMCOPItj8bFGdovg+QF3aWmDK1eCLtBCIF2ikGZ8Fbhm57TxBnDU+ORWB01kw7MULEzWMYFUdciICtLtqXmSp1mE9EAqs4l6ecLCHgxPPdmQiFXOji/Vz7Yl0WfJx+p+Vt8166R6HESZpavN3TwQHB9xzpNRSS48dyOt0brN54X6DAVrUzpdiGMvNrSDHpnMZmHJ05iKMM/jrGgd3lop9Ierw6OF7KM0WnU5SPR6i/NObwc9li8MZLVGw/FGyJMunrDmg1tH3XOemHvzHX0p3WTxcxpNXRR60V8C+DIM2zj0koMoWAwX6fVMWdF658agki+Ezs8sEYGf6egZYOmcwvv6Eb9a2ixWsD9LmTYy4W8ht45/98 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: David Woodhouse Instead of calling pfn_valid() separately for every single PFN in the range, use for_each_valid_pfn() and only look at the ones which are. Signed-off-by: David Woodhouse --- arch/x86/mm/ioremap.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/arch/x86/mm/ioremap.c b/arch/x86/mm/ioremap.c index 331e101bf801..12c8180ca1ba 100644 --- a/arch/x86/mm/ioremap.c +++ b/arch/x86/mm/ioremap.c @@ -71,7 +71,7 @@ int ioremap_change_attr(unsigned long vaddr, unsigned long size, static unsigned int __ioremap_check_ram(struct resource *res) { unsigned long start_pfn, stop_pfn; - unsigned long i; + unsigned long pfn; if ((res->flags & IORESOURCE_SYSTEM_RAM) != IORESOURCE_SYSTEM_RAM) return 0; @@ -79,9 +79,8 @@ static unsigned int __ioremap_check_ram(struct resource *res) start_pfn = (res->start + PAGE_SIZE - 1) >> PAGE_SHIFT; stop_pfn = (res->end + 1) >> PAGE_SHIFT; if (stop_pfn > start_pfn) { - for (i = 0; i < (stop_pfn - start_pfn); ++i) - if (pfn_valid(start_pfn + i) && - !PageReserved(pfn_to_page(start_pfn + i))) + for_each_valid_pfn(pfn, start_pfn, stop_pfn) + if (!PageReserved(pfn_to_page(pfn))) return IORES_MAP_SYSTEM_RAM; }