From patchwork Fri Apr 4 15:59:59 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Woodhouse X-Patchwork-Id: 14038661 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4389AC3601A for ; Fri, 4 Apr 2025 16:01:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 943946B0008; Fri, 4 Apr 2025 12:01:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8AE276B000C; Fri, 4 Apr 2025 12:01:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 615CB6B000D; Fri, 4 Apr 2025 12:01:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 40E876B000A for ; Fri, 4 Apr 2025 12:01:55 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 027C5B771B for ; Fri, 4 Apr 2025 16:01:55 +0000 (UTC) X-FDA: 83296827432.25.DF31C5F Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf12.hostedemail.com (Postfix) with ESMTP id 4322640021 for ; Fri, 4 Apr 2025 16:01:52 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="rcQ/TZXn"; dmarc=none; spf=none (imf12.hostedemail.com: domain of BATV+be2fdb05a07bd611d225+7894+infradead.org+dwmw2@casper.srs.infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=BATV+be2fdb05a07bd611d225+7894+infradead.org+dwmw2@casper.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743782513; a=rsa-sha256; cv=none; b=pHItXPFgHk+g219fStzuoJ+lV+LPGsp3CGHdT1Z54jeZR3UGkBS0JZHCGpGzYHvfCfF0/t 6KjKcoGedwW3adq1/MXCgGnGLGJdEv7ZBUmn8+JXUQVcg549xZu2CjHS15VZ008/EGRS3d sM+62FaOOWVoKMehvr2r360H7T6SzaE= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="rcQ/TZXn"; dmarc=none; spf=none (imf12.hostedemail.com: domain of BATV+be2fdb05a07bd611d225+7894+infradead.org+dwmw2@casper.srs.infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=BATV+be2fdb05a07bd611d225+7894+infradead.org+dwmw2@casper.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743782513; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zwrAwVynWffEuxKPl0OEyEEBjA9QOQig2FF2bzdhEpA=; b=J663a1suryPtjNb6DvG/LGxWxlZISAzamZ4pIVPRDyVwVO1jwC1cJ94LLxI/XAxvtZGxnv L+VkFLj0bWNrvElU52v9cJRqx9AI2ljJ56zamm5dCthwWMpdbD2OmcFyscqXuHZbQ+g1/j /kbNi3o10rx6C3yUVnCUWlMfcMHfiA8= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description; bh=zwrAwVynWffEuxKPl0OEyEEBjA9QOQig2FF2bzdhEpA=; b=rcQ/TZXnLakdQxL4crd49SXX3c edNsEOVe5KuObd9N9FvHOyENAzG1hCUGVegfPjAUI+DESeHQ2QnvFHahouiLIKJXGm/9RbMSGbECY 3H7F9hOPYEdMTiEfgcGsbG7aWDxhy3ZY9WqpRK44a5vaJHV37Lx6OginK6lDUrp+urL++BV2mtbH5 p+ZFyzIAKAcSjEt2BvR0qBo1O4L3+1RqPBeKcN2MGAKLhzlFZ2wIbiVn+ohK9/LZ1v86JEJ+uw17N 4zNZ8gbxTQmZ4FYx30Cw1FcflV3mnJKiulvzObmjLOk24f6Y0o78MuVRM7S5DrvoDrcue1z65zfMb chjOXhaA==; Received: from [2001:8b0:10b:1::ebe] (helo=i7.infradead.org) by casper.infradead.org with esmtpsa (Exim 4.98.1 #2 (Red Hat Linux)) id 1u0jSa-0000000GFHw-3A3Z; Fri, 04 Apr 2025 16:01:01 +0000 Received: from dwoodhou by i7.infradead.org with local (Exim 4.98.1 #2 (Red Hat Linux)) id 1u0jSZ-0000000ERST-48Ac; Fri, 04 Apr 2025 16:59:59 +0100 From: David Woodhouse To: Mike Rapoport Cc: Andrew Morton , "Sauerwein, David" , Anshuman Khandual , Ard Biesheuvel , Catalin Marinas , David Hildenbrand , Marc Zyngier , Mark Rutland , Mike Rapoport , Will Deacon , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [RFC PATCH v2 7/7] mm: use for_each_valid_pfn() in memory_hotplug Date: Fri, 4 Apr 2025 16:59:59 +0100 Message-ID: <20250404155959.3442111-7-dwmw2@infradead.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250404155959.3442111-1-dwmw2@infradead.org> References: <20250404155959.3442111-1-dwmw2@infradead.org> MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 4322640021 X-Stat-Signature: wdg87u9dsxck1ocrpwut1r1tqzif9i1n X-HE-Tag: 1743782512-132928 X-HE-Meta: U2FsdGVkX1+Oo/2IIQXE6tjhFMgZer5857zfxdNmrrjnq644vf813FwI17M8XlbI3+MPbe76U7f3AaRwuVChT3j2wbkaXoBkANEaa6c6Rr0K8SZkEN00+fhOM99A2mDtOoji3FBiAIQJYBoo5fokzZa+GUviQSQEY59205/aN76TiSoW6mUbfEirMZg25a/UbkPI5NxtJ3Z/6dNy6PrQX/2ytQ/4IAeEcbFweSUmn6mGYEA9rxGK0aHw7Mwtb/q+NA8MUmLcUvEunojpD4vKoH70pxxTgSKhm3q3JnH8gOUG4cOzl9zKhY7lLLeoAni+CpVGj0lu+QgLid+Jgd64KIijuTyT/lN4Ncfj5aSRJa1Y8WnVESf1C8j8nDGKZ/jdOyES2MZFhBb1DsX6vMOm8CH0kuTglt989vR79NJZCxOInlwz3XGk9m58lq8xyK5wpWeoNlOvf9gle813qykhihK3lrV+DXGiGTBXki3SG+/f+VCYtWOkXiNlWE6T/910+lE91yUG898uYV24LHwdcmqk8wRZjiDTWKHbP3CevHxyoaVSLyznOgXcxSfnlCTk+P2mRhltn7b808TMi4TkZsgq73j7fWrk9a28e4z7kIqZugu7Kq0pYz9nvSH+BK6Q6ci+3XTt/Wlsctc6viU8P8NmS9DSL7isDfAMFhO3by4iYU5a95FWeb4fmPl+nWze/0VHMx+m0npqe7swfEXm5WXEWLIgdbky/LgjKVLek5yxlKcBhCHMd4wgR6ku0W2BZZDYOvzBJk+k2FG48YJuH9PzZb6grT2qNdDJ4egXlpjLYo2L+H/ArA3rDXNWkg8UShTtw+CBP94UOzVXIpYp1b78rFvsngIZqozs5IA0pBBMm0g47WA8TZyig2MnjqpNE/TMmCbKHwHsM+DlUOMQSrt3YB4Z5CnQU+uHJ7W+ufAelBfP2Kd6L5uLT+pvEHc/7h7hXUMoRym/5CMloXY 1qI51Ui3 /PakcblMDCPuWdt5AI3mgSnJJAf4+KXuHWrBlmhcbDJM1XhQWpFSzDGjJMqvh9ThL13BTGQR/KPDt5lLXw9T2HCRg0oFUbqNnfNcisFMYxk3X0ZYWkNrB8LPuym40gdX+GgCXzXnu1tLvMxC9LV9YK1iYTnzHeGKatzxZMsgdQDzTI5zmreSnu47zVQDGCJd7w6mBastCDbdpGWYr38L9W/mwq1b3X7mLJHI7G89sZ0Ag2Nw8dR09rMCM1/whUXHaS4d/Pv8542Igz2vDZkwsj3Pu04+i2GBUnlvQZyvnGUMTlz5LUvaEfxU9X54vYgkFHurGOwn7DrYIKGU1nNn+vHK0M6Z3zqqYrd/DAG+MSOGEl0yO3s3twXigDr5WCU+M4emXSxRIKDvReLz2YZrdTcNPuE7kqInH2+ev/GRrswYnYsb5eeIoxJnhWQGN5TI5jfx4R85iKROgqMERRQu8OCoYJJ6vefg00RrKdL0jvLDgvTq92rvwC5SNh78YHXyzRYNXArEtZfATZvAvouHpz4xB+Ch4X6ZjdvDz X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: David Woodhouse Signed-off-by: David Woodhouse --- mm/memory_hotplug.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index 75401866fb76..20c39ae45016 100644 --- a/mm/memory_hotplug.c +++ b/mm/memory_hotplug.c @@ -1756,12 +1756,10 @@ static int scan_movable_pages(unsigned long start, unsigned long end, { unsigned long pfn; - for (pfn = start; pfn < end; pfn++) { + for_each_valid_pfn (pfn, start, end) { struct page *page; struct folio *folio; - if (!pfn_valid(pfn)) - continue; page = pfn_to_page(pfn); if (PageLRU(page)) goto found; @@ -1805,11 +1803,9 @@ static void do_migrate_range(unsigned long start_pfn, unsigned long end_pfn) static DEFINE_RATELIMIT_STATE(migrate_rs, DEFAULT_RATELIMIT_INTERVAL, DEFAULT_RATELIMIT_BURST); - for (pfn = start_pfn; pfn < end_pfn; pfn++) { + for_each_valid_pfn (pfn, start_pfn, end_pfn) { struct page *page; - if (!pfn_valid(pfn)) - continue; page = pfn_to_page(pfn); folio = page_folio(page);