From patchwork Sun Apr 6 02:40:09 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Waiman Long X-Patchwork-Id: 14039283 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CBC0C36010 for ; Sun, 6 Apr 2025 02:40:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4DA266B0005; Sat, 5 Apr 2025 22:40:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4616D6B0006; Sat, 5 Apr 2025 22:40:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2DA646B0008; Sat, 5 Apr 2025 22:40:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 0A2E86B0005 for ; Sat, 5 Apr 2025 22:40:36 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id EECDB1419E4 for ; Sun, 6 Apr 2025 02:40:35 +0000 (UTC) X-FDA: 83302065630.20.7EA2BFF Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf11.hostedemail.com (Postfix) with ESMTP id 351D040002 for ; Sun, 6 Apr 2025 02:40:34 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TlTVZHaw; spf=pass (imf11.hostedemail.com: domain of longman@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=longman@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743907234; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=B5YDLmhSbrpf/aebgnSWHj5blPXWvVGMTpTVQlCY6Io=; b=vUbL7WzC8ofH+kr8LezI3U3yfZWxdbO6g6xgtsEOj9USQ2Cdsayb0fccmkb9/8FmvlYTx1 V1NTF24XZPSeWT3tLAXDJFPXs8ODF4gNNg2XNFL6Q3qsAujYJZ7cdltmm6WLhIsv6SRbrJ wq/6VsXPlHw1gDadviQJdNHFWIndlZ4= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TlTVZHaw; spf=pass (imf11.hostedemail.com: domain of longman@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=longman@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743907234; a=rsa-sha256; cv=none; b=NLTLHFDbMivw7Ik0ZfQB8utxUUwLx2knQxyrN/4fAvEbcZhJAc36Z7Vo3X5QK2XnE4BfTo rssC76FiIR9aRMkOfaMdi9row5VCiPUdHwlhgKhWcv0NZJWFdt2w92wWciWLXDoEppXTWt c0AE1sUCyjHr3TM4lgRv/pujewvGnbg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1743907233; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B5YDLmhSbrpf/aebgnSWHj5blPXWvVGMTpTVQlCY6Io=; b=TlTVZHawFrJQ1SlESHLmMqMZ3KwFSUH2jmvea+wQM17iWl5ZLqImh8lYWrM7Lt2N6exVUw 2GAcVC6WdDPh5Q7ke18uyemaQ7plVlkBAANJONRR/n6zKLqIYJNjlU6HTwLcWlC1h31XXF kpjzYZ1f9YMm9PSvD1aCtJMQpKz6bxE= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-338-L5K0I2a_NX67Xvs9u3r51g-1; Sat, 05 Apr 2025 22:40:30 -0400 X-MC-Unique: L5K0I2a_NX67Xvs9u3r51g-1 X-Mimecast-MFC-AGG-ID: L5K0I2a_NX67Xvs9u3r51g_1743907228 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 94A3C18004A9; Sun, 6 Apr 2025 02:40:27 +0000 (UTC) Received: from llong-thinkpadp16vgen1.westford.csb (unknown [10.22.64.19]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id DDA331801766; Sun, 6 Apr 2025 02:40:24 +0000 (UTC) From: Waiman Long To: Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , Tejun Heo , =?utf-8?q?Michal_Koutn=C3=BD?= , Shuah Khan Cc: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Waiman Long Subject: [PATCH v3 1/2] mm/vmscan: Skip memcg with !usage in shrink_node_memcgs() Date: Sat, 5 Apr 2025 22:40:09 -0400 Message-ID: <20250406024010.1177927-2-longman@redhat.com> In-Reply-To: <20250406024010.1177927-1-longman@redhat.com> References: <20250406024010.1177927-1-longman@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Rspamd-Queue-Id: 351D040002 X-Rspamd-Server: rspam05 X-Rspam-User: X-Stat-Signature: k5eqm14hzsbaq5ry75isg77yswoubm5i X-HE-Tag: 1743907234-786184 X-HE-Meta: U2FsdGVkX19VNoRMBt3Ia9RRN6UMfrB4HnxmE1gPlp/210d2XhaySCgt399AM17fDqLqQ1FkSQ3OT7wHU2vNTeswuYJLRO4qs0r9LssIXPS/S4MITdqyQGR4X12jVjeYIMRkZdtHsI8uLP0iKbp9RaqtHsEYL60a1ob13K9LLFq4i+DohXBA9aRYfGNvn+lyxkmQA/cmtptVfxE+o/F70I2i9UzMvDZW1znHNG9z3Vek5aUK1YBrRHEDjS3BcdcvPG9Y8TgPNagNghPTW44ac4khTmT1KJLMy4c4/olAKu6eonznG474fzQfqgz43/v0Mxp5XVRYKPk+3vnyRoaTs350oByMDuXlYSTrvWEZwOLfxWNEKfYYBb2uNtZUEzOi3ffkNTrgxcObq4KBFVO9EwK7Gpq2F2uXocXd4gDhDfYQBRk8GDCWJi9qZBw7/bnGaR/LYjgwmCZ3O19AVobV9T3ehEbacAPcccaWBuJ/iVVwt0mm06GgIXA4ODKwJiIGQOUESXitoggJLolHPV+qWQbnTt39nxnRGzoHd2DWPokRxKw1rSEdFnivamXZOs70iJy/1EpVvTqTixKxg7G9QzoWsurFq1enAXUSiaNtCT517NQdGg8yvnwxk2HTc6y3tU77AlhdBCdLtmRLh3u8Gcjok2H52YOg64LWyQPMQdfPPo0RJnLJIfBUaLDmXsYJZLH4XJAtRMu98paXki4/ttbjOh1s7AMhuBmAaAFJ6X/oOFI2ZK0ncSay7KlotIy3jGxIztf9YG6QVCcBomMkMubhUE9UBnWQkD9OuVtRWnr3Mbmb8FICLSD9m7P+cAtp1I4s2c3q4LRUVw2Odo2EXtQ2Bzaz8tzSYc+nmk0JTZxvNWddbQploQ9EGJ4Grc/knu/B50oRT8pBXAcY7MuVSa1qIni2KCNmDXu2RBCao/zxLONAeBJf9XyhL9Hx2PPer1quZHdh8QulZWuroZl JrK1YVND nyQCM4PBve14ooGRoXTKpRcjdO/4qGMK/MKDMDNBrIYL3oPKS9uZW33+flXENrm0/1EdJ2Mkm5d+2rKqVE77k42ky61wexQKGBdaQsApLKEYcrdRMLT0yjSGb9lI+2w9dn/we5f3T53ROqua5cr1UrG8gj0aKtuGIsoUSqv5irxSTfSZI4nt8lJjepUmTtyhibXQD1SMiG2zvclu+dK0d3G4IaNUtFfq/dmF9H9uCZkT8sScnL5lq9qGCa9PEaYpnwfdUz16Bbn2ObuXFJoGjlvDKQPh7mHn5T5MWgEtW1BwdGv8IIGWpGAiePQ9pxvHrIbKMJXsrIk9mD+sfI5oEOir85G8ZO567lqlogFvLzYsfAlXveAFihJjTrqj27IzCotOy7xFH28YcH4/K2HcEw58dPsneg3FXHJUSfQ0xPyPz5YOqM6R9hCh6YYHwgDiTdLiMDNurHCZfwntzNOwqe0vguibCyvAJyR4a X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The test_memcontrol selftest consistently fails its test_memcg_low sub-test due to the fact that two of its test child cgroups which have a memmory.low of 0 or an effective memory.low of 0 still have low events generated for them since mem_cgroup_below_low() use the ">=" operator when comparing to elow. The two failed use cases are as follows: 1) memory.low is set to 0, but low events can still be triggered and so the cgroup may have a non-zero low event count. I doubt users are looking for that as they didn't set memory.low at all. 2) memory.low is set to a non-zero value but the cgroup has no task in it so that it has an effective low value of 0. Again it may have a non-zero low event count if memory reclaim happens. This is probably not a result expected by the users and it is really doubtful that users will check an empty cgroup with no task in it and expecting some non-zero event counts. In the first case, even though memory.low isn't set, it may still have some low protection if memory.low is set in the parent. So low event may still be recorded. The test_memcontrol.c test has to be modified to account for that. For the second case, it really doesn't make sense to have non-zero low event if the cgroup has 0 usage. So we need to skip this corner case in shrink_node_memcgs(). With this patch applied, the test_memcg_low sub-test finishes successfully without failure in most cases. Though both test_memcg_low and test_memcg_min sub-tests may still fail occasionally if the memory.current values fall outside of the expected ranges. Suggested-by: Johannes Weiner Signed-off-by: Waiman Long --- mm/vmscan.c | 4 ++++ tools/testing/selftests/cgroup/test_memcontrol.c | 7 ++++++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index b620d74b0f66..2a2957b9dc99 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -5963,6 +5963,10 @@ static void shrink_node_memcgs(pg_data_t *pgdat, struct scan_control *sc) mem_cgroup_calculate_protection(target_memcg, memcg); + /* Skip memcg with no usage */ + if (!page_counter_read(&memcg->memory)) + continue; + if (mem_cgroup_below_min(target_memcg, memcg)) { /* * Hard protection. diff --git a/tools/testing/selftests/cgroup/test_memcontrol.c b/tools/testing/selftests/cgroup/test_memcontrol.c index 16f5d74ae762..bab826b6b7b0 100644 --- a/tools/testing/selftests/cgroup/test_memcontrol.c +++ b/tools/testing/selftests/cgroup/test_memcontrol.c @@ -525,8 +525,13 @@ static int test_memcg_protection(const char *root, bool min) goto cleanup; } + /* + * Child 2 has memory.low=0, but some low protection is still being + * distributed down from its parent with memory.low=50M. So the low + * event count will be non-zero. + */ for (i = 0; i < ARRAY_SIZE(children); i++) { - int no_low_events_index = 1; + int no_low_events_index = 2; long low, oom; oom = cg_read_key_long(children[i], "memory.events", "oom ");