Message ID | 20250407234223.1059191-15-nphamcs@gmail.com (mailing list archive) |
---|---|
State | New |
Headers | show
Return-Path: <owner-linux-mm@kvack.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF6CDC36010 for <linux-mm@archiver.kernel.org>; Mon, 7 Apr 2025 23:43:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C9BCD280001; Mon, 7 Apr 2025 19:42:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A0D6F280004; Mon, 7 Apr 2025 19:42:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 80755280001; Mon, 7 Apr 2025 19:42:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 54A31280002 for <linux-mm@kvack.org>; Mon, 7 Apr 2025 19:42:35 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 7EEE281725 for <linux-mm@kvack.org>; Mon, 7 Apr 2025 23:42:36 +0000 (UTC) X-FDA: 83308874712.01.5CE9A8C Received: from mail-yb1-f180.google.com (mail-yb1-f180.google.com [209.85.219.180]) by imf25.hostedemail.com (Postfix) with ESMTP id B6704A0005 for <linux-mm@kvack.org>; Mon, 7 Apr 2025 23:42:34 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=hbqLYu+5; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf25.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.180 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744069354; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rEZyehd4zLYWxImC6V7ghpPr92k+M9DC2r20TkQaMas=; b=QxO5P/R1z68qCa56MhKC7K4Jxm28IAzfjqiI6BJZ96m2dq2aWVkyDoP4InY1ystCVyD95n 1mY8gkrsOHE9QHMMooSvW6b+kFaJU5F8Nb/S22F0B+DDMvuk5NwTIlR2EMGGjyyUmOF9VB 9uOYJCWyGE2gQyyrws4AWvuiAvXroIk= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=hbqLYu+5; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf25.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.180 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744069354; a=rsa-sha256; cv=none; b=4luzDxnWt0W2ScOT4TlTEPRgmrd8yPWx5enwL/9Vih5s4+RqfbIAyeEBRDWZ5aw1TWsyaQ vf8x+45xcpHEbS2oEFO+Vbzy8EE9S0rlGjSpzL4XpS1rk9BsiaDw2mCzKFQWMKC56imX9v STfS1yfW0FehI5dk31128mtT+lDMn7A= Received: by mail-yb1-f180.google.com with SMTP id 3f1490d57ef6-e461015fbd4so4004023276.2 for <linux-mm@kvack.org>; Mon, 07 Apr 2025 16:42:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744069354; x=1744674154; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rEZyehd4zLYWxImC6V7ghpPr92k+M9DC2r20TkQaMas=; b=hbqLYu+5jG+YA6StPeEzRKo+7wM8H9OxG4E7oBelf1KHyFnDfY3/aJMabxUXEDL9PT NWMiwp2ct4URqZgmXxiTfqVcwJ9NzqEKlkfGSWVVioIkCoL/FBdjVP3mT6RZbs0Nlu90 poTmDk2CtTiL+62GzCRqp4VA1ctLb81SeweGKZQp9LjzLv+9dL/fnW8tiXX5ao7sVX5i rHdnT400FgTwGCDUWItAvjuhH8XvdJTp+FSmBlx8r20xV0vOpo2OHDVT6lgOBCd6Io2m DAYSnK0k58sQ4cCBmqRLfZXo9O2Ux5/81YP4nC3M0uOxmdNTwuCxTT4R7GoBNxDlZfcy /xiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744069354; x=1744674154; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rEZyehd4zLYWxImC6V7ghpPr92k+M9DC2r20TkQaMas=; b=ReBZBDduMBOnyh2HoqKM4k+4zIv1zyxT3ggGeBHkGSygkhov902YuRM/JpNgMne52X y59m4Nz6taIXwgtQh/XN97wGDUb8KqpGRzczAh6APFC7BKUGTLt7W5/uRAk2oYY4nbdj zqfuL6Tu8Gj7mx/r7K+kJ5SlZUgZKo8x1OrzUjmvnsDBLl965gFAvC5D0Q0lMqGf0sLb /jiU0EFWahyPJXqdoq3wqji1vbABFDntbWqHQPdl4TQNqCSRZ2/wzZdMti3OFQgDSgR4 ubX4AdQIFM1hWw00yAKNkpS3eUsO1wNxJFqEn064stJOmvxE3wAQQIZZkoGmPriUXtQe PjHA== X-Gm-Message-State: AOJu0Yxj4pSBSoLKdppHpWTTIbbqurwJN38LA47bih9y0KlEO26tzTHB KvFrSWLqE2fZTc9zFgItU9Vt0swVFhyo0i4IO2EroPZnFKoCJ4PgNmPf8Q== X-Gm-Gg: ASbGnctGxCqNNafZe+cC2Y+WWSKxUkOT8i1z2+fdVbGLuWqImETvFpeS1BnP1tTBHfW pHpt4jtVUtFJgtG3EpF5CFQ4pUV9/E5TLofePfyRHpUPIK9oC8mMnajCud0BvK+FFJrCHK8Cahe 3dKe+BhsoN9XUv64cUr2PzB2R9q79HczvRL5Gq2TonSfuqnFQI3U6peA5mWroghaERuidCvjHIT Rms1mF87tXk5d4CfftV63TUv+0fYwTv+SpMNp+FPbDR8JMMyFRoj+X75o6OuCkYvbiFSTmCn99m YVFlAnjvoJHW/FnE8q32kysdX3vwTOPS+qAb X-Google-Smtp-Source: AGHT+IE5QNAfFkOFKjfUYz3+47925/olDBVlwaEQV+A5zw8RcFXQs1h3huSyPi7xSOcPqQJx6E0RTA== X-Received: by 2002:a05:6902:480e:b0:e6d:deb9:6381 with SMTP id 3f1490d57ef6-e6e1c2dc239mr23407047276.43.1744069353752; Mon, 07 Apr 2025 16:42:33 -0700 (PDT) Received: from localhost ([2a03:2880:25ff:74::]) by smtp.gmail.com with ESMTPSA id 3f1490d57ef6-e6e0c8cf2d7sm2583871276.14.2025.04.07.16.42.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 16:42:33 -0700 (PDT) From: Nhat Pham <nphamcs@gmail.com> To: linux-mm@kvack.org Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, hughd@google.com, yosry.ahmed@linux.dev, mhocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, len.brown@intel.com, chengming.zhou@linux.dev, kasong@tencent.com, chrisl@kernel.org, huang.ying.caritas@gmail.com, ryan.roberts@arm.com, viro@zeniv.linux.org.uk, baohua@kernel.org, osalvador@suse.de, lorenzo.stoakes@oracle.com, christophe.leroy@csgroup.eu, pavel@kernel.org, kernel-team@meta.com, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-pm@vger.kernel.org Subject: [RFC PATCH 14/14] zswap: do not start zswap shrinker if there is no physical swap slots Date: Mon, 7 Apr 2025 16:42:15 -0700 Message-ID: <20250407234223.1059191-15-nphamcs@gmail.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250407234223.1059191-1-nphamcs@gmail.com> References: <20250407234223.1059191-1-nphamcs@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam01 X-Stat-Signature: xbdjoxpn3dcbssyx79oyy6ekix3rpk44 X-Rspam-User: X-Rspamd-Queue-Id: B6704A0005 X-HE-Tag: 1744069354-724304 X-HE-Meta: U2FsdGVkX189xq++vpqCgoRuujqDE4tQhZ0cbzvoEmh5SRFIqyHpqL0tSql7yx1oUzAL4DvAZI09wOoYGPzYCSJsTnV/J6fkijoYxUGVsSgn8d6942ywqzYOvkxq7fDTFlCbtW16uJ5omFHvrvu+07MYR0YTjSjcd30XvGgAJFkHGiU9PdZxSZo9ULTT+3Yc8jGYYpPZhCAZWfVLvCtZHi2DVpFevgnQ6ZXRWRNlhtPsqpevqTLUtLofCV4G1UJ6ugM0TpRvYSw2CbhYStt3JrBlDRVytOCOS9Ulvrc6DhDIhT3TzjHml9pqHe2GSWz+LI8ENuGjkKy3VN5/JxRKX369LgZpGZIIr8+lGPpuHtSfN1jt+tXF5i1fTM8sodbn6zLcVjSKn4RgnjiWtkbkEXyTBCBnsT/7eY+ROktxU3lqq9U8U9ik+hSyyyfRM0BO7kXN7XbXwY/lJAiWNJa1XBqfGvcZDdeURNidGNdIVvlFo6e03G3X/dwJn3EC+wKNbCuTg2+esRFg8fEmULJd4JXtSDL/8Eq1zUZbI24JFaUudbfE+tBIkQoAnQmXvXj7rjYS7ROxMuphHPT3BzwmMZPJZjhg+lYii2p0fcMfCOQvoMdWEIYj4hYanwQlAW1otKax6wxxnGVBsWW0X8NrDWZjboN5dmR8Fn/K0ArW+pfLRB/jggNpDF9wmyohXCG6VDsUmEpE5W3IIq6NSGaI1lWRvlpPpJ9vxf4cIK5kpC+pQByszX09qk7tb9Vz7J9FSa+cZN+cwR4cSUaX+6mYhnHgKiBPXC7D67Nn9lWFrpq6St974RBEqRBPIg1rHVFBBzICPEt2zv6JlyftPFSk67Q7XXyEfUm5CXuTlFo+yx9DPsOdL2SH0o2wmsRNpJV3YuaXTYapZTswbJSN+esq+wc+YMcUi3Km96aHSALESttD/MiFMxQ+Yul1hwNSwBuUPX3tBGGuDkVMMavW6fx KrLvyQkP EiZxtm3Wswt05kd8mY9/VRhAnPhgXZfSs3U9P5LNPSEPDGNGFH9VnTLy4Fkn+kd6dB56dlr4ljU2+6tQm+jAP6HbTIH3gZtOMoZ42buglRbN3un+IizZSQI85xKJXRzcm37YPTcnfRFeTy+oEPsrUqHEV2LleCK/OgSc0uKgB21YDF2P8P9rdytWQGmg9huDBapeBfSS4xtyS7ncu0FNmo//AABsuxbFgOhMHIHIugCQUYQNXezpDGlTgPuJUYc4f/wgd5GZfAI0zGR4rcHZ24I7b6nl4J2s5CZL1t+mwyj9ozNTa1Le38j1gwg6GETHsDWCBZP2m6reviwT+vKVeRfyRBJ4YOMdr/jOiVakvW2i39jnWQYNXWQTjgl4/lO7GgC7ybvLE/XrS99Np/8mazvXwzkclMM7zqincrTadbomahNHb8nncM1ART1cHPouvlKO5Ql+a5iFD7OIQT7/4sMmiGhmdFwNbNo/OGGR5k1ExaA7hYFxMwklKCA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: <linux-mm.kvack.org> List-Subscribe: <mailto:majordomo@kvack.org> List-Unsubscribe: <mailto:majordomo@kvack.org> |
Series |
Virtual Swap Space
|
expand
|
diff --git a/mm/zswap.c b/mm/zswap.c index 15429825d667..f2f412cc1911 100644 --- a/mm/zswap.c +++ b/mm/zswap.c @@ -1277,6 +1277,14 @@ static unsigned long zswap_shrinker_count(struct shrinker *shrinker, if (!zswap_shrinker_enabled || !mem_cgroup_zswap_writeback_enabled(memcg)) return 0; + /* + * When swap is virtualized, we do not have any swap slots on swapfile + * preallocated for zswap objects. If there is no slot available, we + * cannot writeback and should just bail out here. + */ + if (IS_ENABLED(CONFIG_VIRTUAL_SWAP) && !get_nr_swap_pages()) + return 0; + /* * The shrinker resumes swap writeback, which will enter block * and may enter fs. XXX: Harmonize with vmscan.c __GFP_FS
When swap is virtualized, we no longer pre-allocate a slot on swapfile for each zswap entry. Do not start the zswap shrinker if there is no physical swap slots available. Signed-off-by: Nhat Pham <nphamcs@gmail.com> --- mm/zswap.c | 8 ++++++++ 1 file changed, 8 insertions(+)