From patchwork Tue Apr 8 09:22:43 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alice Ryhl X-Patchwork-Id: 14042485 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65500C369A1 for ; Tue, 8 Apr 2025 09:24:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F02326B0023; Tue, 8 Apr 2025 05:24:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E379A6B0024; Tue, 8 Apr 2025 05:24:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C4DA46B0025; Tue, 8 Apr 2025 05:24:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A2BD86B0023 for ; Tue, 8 Apr 2025 05:24:13 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8256F120943 for ; Tue, 8 Apr 2025 09:24:14 +0000 (UTC) X-FDA: 83310340428.05.F10C059 Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) by imf04.hostedemail.com (Postfix) with ESMTP id 8CC584000E for ; Tue, 8 Apr 2025 09:24:12 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=nWxkdUxl; spf=pass (imf04.hostedemail.com: domain of 3O-v0ZwkKCCwITQKMZgPTOWWOTM.KWUTQVcf-UUSdIKS.WZO@flex--aliceryhl.bounces.google.com designates 209.85.128.74 as permitted sender) smtp.mailfrom=3O-v0ZwkKCCwITQKMZgPTOWWOTM.KWUTQVcf-UUSdIKS.WZO@flex--aliceryhl.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744104252; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NbS7MAhMYKAe1fvQnX5I031aFw3fZNHXs82c8Rh/ZM8=; b=Xpu7UriPxKQPn7KnOnQVgjt5fuIJiftb9OPRSqnmQxHqBM+2QtZLoyzQLYQA6DstLUh/7W CLstyopEiE9t5cV5/ZTzV9pnyGxLMlc0gnIBpCoH9GfxmC8p0DWUByxEYcNLtX0I+sf9nH m0MV6191zi895k/hLzZ7ihS0qz5ZFZc= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=nWxkdUxl; spf=pass (imf04.hostedemail.com: domain of 3O-v0ZwkKCCwITQKMZgPTOWWOTM.KWUTQVcf-UUSdIKS.WZO@flex--aliceryhl.bounces.google.com designates 209.85.128.74 as permitted sender) smtp.mailfrom=3O-v0ZwkKCCwITQKMZgPTOWWOTM.KWUTQVcf-UUSdIKS.WZO@flex--aliceryhl.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744104252; a=rsa-sha256; cv=none; b=akPak6SjINL5OcjM+pWVQU4d4MkY0poJK0CDH3Nv88pAFE87TiBhDZdhZLUzr7x//8ST+8 URYBNz8+wuURl6QlAlM1s2SRreqIXDSgAIRF/F9MQkRIAD6Jo/UCCwkUitzI406VE60ukX mBjGxZHyOpFzDVFz2xj6QqQIsz1qRvc= Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-43cfda30a3cso31647405e9.3 for ; Tue, 08 Apr 2025 02:24:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1744104251; x=1744709051; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=NbS7MAhMYKAe1fvQnX5I031aFw3fZNHXs82c8Rh/ZM8=; b=nWxkdUxlauEzSG2MV+yUPFKi3r1MiNzXDLx06KMHHV7do9pA/rlnSzCnrfGjbOdMJw vMNProLjtI5bSv98MfP1ECZD7+ebDwzFkmP+q0ioeDxbsujGSTDjEJXmM7V58RRBixhV 55ELGsvORKdGmwcHz2nog1h8STKUYXglJ2G+ksjOdZFI2YN3i012rJKnXEu2b+PKOWza 9kLiOjGpwkzPTsJ4Z3WgllODNmsYcBLd0rvvphNiWtSNeRYoCJ9DxSnpqy4Cpnc/Uj4o UT6kOplwi7QbnLB/+CQ1L0wk6Gi6C7orGNzkA5rmilqs2IcDSDRygQOJJCBrRx1blwUo nTkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744104251; x=1744709051; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NbS7MAhMYKAe1fvQnX5I031aFw3fZNHXs82c8Rh/ZM8=; b=Obbro+lgRtkE4btXy6wHM5JJAh4L2VzXhQgKYieFmUXSf9r/mh/KoZGqf/btyB3XfJ qZTV5qZVqojevgVh+V+FZv3NlTpuekSSs3ruJawFVegQy8aPP5EbjUvAMfQWigqhQrrk I7xk6M5moO9JAfwPCUxL/1WHKIIu1GWUHEuNOABKfAl+W68WB3Hoe+mVHlQHVBzWamkt MsrBjZKjMjwMHgMaEr84WMXT75JNaViRB1ji304Jwh2Dn/R5MUyCO2rjry7pYXGzJfxF Ho/tV5yJL04uzZ0hM/etGCd3TNNUDSKjhagGA525yTDJ6EUXSg68yPEEDlBtJYapZYgh M74g== X-Forwarded-Encrypted: i=1; AJvYcCVfqGeAZh8cQVa9sGVzL5Z1ARqTfwe4ZTqX7DOWyy6V6amJnvoqSJAC/WIP+pd37RXFZcMpprhThg==@kvack.org X-Gm-Message-State: AOJu0YxzGnmwCJLqysWNzaVAJ1WjUyknrqw+teOFGW/mFHRYd03rj5T4 3m9ysx0VJ3G/1aSvZi5MUNY4ttw5I/vebxdF20RBM4qDIsEgkeaakWZIKIPo15cQcrsn1AJZ57K hNFkgjc9jsx2NCA== X-Google-Smtp-Source: AGHT+IE4W/KsQEJrmEgz9IsoTLynGVEAhAHKzspx/nbrSFmIxb6oHbD2e0Mgj+efPoxDwU0BvGGyyufB1Mi07JA= X-Received: from wma7.prod.google.com ([2002:a05:600c:8907:b0:43d:4038:9229]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:a0a:b0:43c:f689:dd with SMTP id 5b1f17b1804b1-43ecf8d0a37mr135840695e9.19.1744104251264; Tue, 08 Apr 2025 02:24:11 -0700 (PDT) Date: Tue, 08 Apr 2025 09:22:43 +0000 In-Reply-To: <20250408-vma-v16-0-d8b446e885d9@google.com> Mime-Version: 1.0 References: <20250408-vma-v16-0-d8b446e885d9@google.com> X-Developer-Key: i=aliceryhl@google.com; a=openpgp; fpr=49F6C1FAA74960F43A5B86A1EE7A392FDE96209F X-Developer-Signature: v=1; a=openpgp-sha256; l=8695; i=aliceryhl@google.com; h=from:subject:message-id; bh=y7o7ZyQ2dPEky50Ue+6FuWOqrOt6CBr0m5lqB46eSLI=; b=owEBbQKS/ZANAwAKAQRYvu5YxjlGAcsmYgBn9OspqQy5WgY/Qd+8dWuqTUfQ3HnCwBb8dVD05 EA6Kry80NiJAjMEAAEKAB0WIQSDkqKUTWQHCvFIvbIEWL7uWMY5RgUCZ/TrKQAKCRAEWL7uWMY5 RgG+D/4imuYCLk7UElHu8hBZPmO6nTzNlNaQKt0LiTcGYywxsrABM/WJ8sMq5nF56+zZSR06nuc 56Kmkc7+8F2O1qfjff8l3mHCzT0J9cf6wAYYALBXOkz5KvBs7hWsjNTdnJzWZn++ZEjrRbTdrvq yg+RSfCLjZlIhNX6Qd/XZpMrLipc6MkzjLWxzEujf6AnkG17xmf4E8Kg02holVGJXsTKo+qM766 seqiZkbFJzPBajPN6woE0fyAqN8+JidK+UJmAYYNB/Xdfl4yGudLtE7gjgbrHNhlS1anVWwuFZC FdSApqsObE8OK9MNeI6RuiAjuro8QX9Qw/jocbWr0aBk1+Pn7TnOFobEil62TNdBYyA+8peUYAG jh93VskPs3P8of4BOr051oLK5kwcG25LOWkkStYuiYb3Emdi6ep3U/6tAcPb5MGnFCl5lBjr++/ UDPMjSqUQdpDlqWBx7rNRwDmCe2sMGlf7qo5K8Oly0cNdX+wmfJZ7/sKVg9sVXfAmH5RoKej18i LgUdXmjLd8L1exfbJ5E35i+jFmbusUl3F1xK+8ontqpt4uMc17eaMyDYaBc4ao+gqBIk2U3Nzgj LLd9Y59W9MRwdX2jJf8mifll5w1o9piYo9LgxbM7KFZHEPIIHAOfsvTSGIK/N3PmMbd89l33pKn WLK3RhVfl1Zx/4g== X-Mailer: b4 0.14.2 Message-ID: <20250408-vma-v16-6-d8b446e885d9@google.com> Subject: [PATCH v16 6/9] mm: rust: add VmaNew for f_ops->mmap() From: Alice Ryhl To: Miguel Ojeda , Matthew Wilcox , Lorenzo Stoakes , Vlastimil Babka , John Hubbard , "Liam R. Howlett" , Andrew Morton , Greg Kroah-Hartman , Arnd Bergmann , Jann Horn , Suren Baghdasaryan Cc: Alex Gaynor , Boqun Feng , Gary Guo , " =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= " , Benno Lossin , Andreas Hindborg , Trevor Gross , linux-kernel@vger.kernel.org, linux-mm@kvack.org, rust-for-linux@vger.kernel.org, Alice Ryhl X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 8CC584000E X-Stat-Signature: 78cimxmzg49cp7o4w6ewsp9cjoq1dieq X-HE-Tag: 1744104252-822847 X-HE-Meta: U2FsdGVkX18K6KdkZB0nqoT5spKvb+saaVCBRgsUvIn6gqRA+ZeavKxn5vLWvPKEJNXmr1HOv2VU51cMrYvyJCcD+py/2sUS+bX7zj8/E9pN4/3nZGDcTGLKkdNXx8BmckY29fUSaqo/kB+t5ilpPGNC9WdKHGDmypJYlAQdwBPRsMGKYblxS5fKDxQtLSCFknafbyjHHrFSsS1s1mF1u+b688Z54p3J1psilPmkrso0rVkDn5GtZvOjJe7zMkCCEg15YoxtI7Z7Y0G47hT5/Qzb6S7VhNs1mbQrzzzS1+nhMiJCR/phkdzojPYaiwtSnZsQeujaVws0iXplQQVBWNUbQQnYrgVJIn7clyHs+owwNWePbDTZ990eWC3L8NI69xN4ZYX759FJyA2ZpHM6ODgUqbv+kP+F9AcAE1zKcDP8ZWLSTJNgqXx8imji/oF0IElJYZVaDf2lzW3vysECLQUf6wbZ7b7fO6o/v3wF33VETZdEueW7QJwWYMqUvcdaJkcUfGftLED4T87aAAkxNznMb+muB3ZoAE/1dKqL8tAlEvSlk4D2sLInP/mPFscVOmTy7+qWsvG1/JMDngBOmyX8hY5r7dprjq8bPguYKNk1sEUj098zos3PgJzpA+B3sOA4YkKxj/EktP8vYKPBc+tLCGRYleNhh8sSAw3k3cDZiubkPzFLpXDFrnQTw1/sYHA0pkaYyBbRzhFhaaaWu1/zeN4xrwGLIPS8MlLjipIxHc4+fGq0CO0Y3l8QK6vMQyTdU34yUmuqirIqR1ZmyrTg5DjxRghbTpf/FmqZ47qwxCcT0GkRApNxX+liX1dyvnMZe+a8r528hW/enZxTa8tvXNYPeW9AzldkRoYl5T9/M+NmILrWO791E6gQNy8CJco6BPkdZ8Ya8+7ahvLt5W2CeRc+WEdzvtnUbZkghmM4zj8Q52i5fbaHT02fXNypYDwZ7aQz33Bf9zzvkDX 54JZHyhy OuP+hXjTVbZDxmtO4B2R/4knlm9QI+WX++kEFsMtGEp4sknchG4Safm2U0Juz8oHHQRXRJP89yAgubeWfNefLbHwOYBrhHy/tf6+HrK4SAS7wU2m2liPA2GBMXsvUaXKfOTrDyqN5KYtziyRyDzR0KhyIZnjjNfD66nGpZ1NYvmGbUmRhrKeqm5fwopomSyyy3rLV5uB1AFZIsosOvGTW/XywZrXVEapoWXjyaMGSNy1MQAy8NKpteaCZQB9CDJMQiKDVWnkWtnotBla6UEPqD7szWDLukg7xUz39s1M7bsulJGUZ5iN8B/PC7tOLQIFAwtiOeHppHygT3kLy9uxQNotdLzX6mL6FTLvud/iSWuT8hxCDvasRwlbr96fDYbfTq0EA5RG/jtcRvMSflyJoTCRlve0NLVqWbzsxcRqVFrzkD1tURgS+W1IyQ9kFwJG6Z+hASpyaDLSc3uYuZgoZYAQlWHJTdZ7zUWmeyPzv3stDm2bvjqZtSKhoVIUWXCZPjkjPNxEDLJ/6K4NdaOPEH9jb5DxrSwH+QefHjuVk+GBXyGoUSSDWuypjOhevgGSjq7YUvbmrZQYaOahYl9D1z1E7BRui0HCezrZtqePwe4XE3Uy0of7QBPNs/dwyxhiMmjdJlM78nS3d9f59waBOBtzr++cw60+QlAfTnKngCf/CqkGK83nKq8V9yL57sG9BlXalYEYO85IPl4Mg0mWMQIys2MkCeCZfj+6n X-Bogosity: Ham, tests=bogofilter, spamicity=0.130391, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This type will be used when setting up a new vma in an f_ops->mmap() hook. Using a separate type from VmaRef allows us to have a separate set of operations that you are only able to use during the mmap() hook. For example, the VM_MIXEDMAP flag must not be changed after the initial setup that happens during the f_ops->mmap() hook. To avoid setting invalid flag values, the methods for clearing VM_MAYWRITE and similar involve a check of VM_WRITE, and return an error if VM_WRITE is set. Trying to use `try_clear_maywrite` without checking the return value results in a compilation error because the `Result` type is marked #[must_use]. For now, there's only a method for VM_MIXEDMAP and not VM_PFNMAP. When we add a VM_PFNMAP method, we will need some way to prevent you from setting both VM_MIXEDMAP and VM_PFNMAP on the same vma. Acked-by: Lorenzo Stoakes Acked-by: Liam R. Howlett Reviewed-by: Jann Horn Reviewed-by: Andreas Hindborg Signed-off-by: Alice Ryhl --- rust/kernel/mm/virt.rs | 186 ++++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 185 insertions(+), 1 deletion(-) diff --git a/rust/kernel/mm/virt.rs b/rust/kernel/mm/virt.rs index 3e2eabcc21450497a02ffa1ed1f31f3e7e7e1b6b..31803674aecc57408df7960def17cfdc2cebcd6c 100644 --- a/rust/kernel/mm/virt.rs +++ b/rust/kernel/mm/virt.rs @@ -16,7 +16,7 @@ use crate::{ bindings, - error::{to_result, Result}, + error::{code::EINVAL, to_result, Result}, mm::MmWithUser, page::Page, types::Opaque, @@ -198,6 +198,190 @@ pub fn vm_insert_page(&self, address: usize, page: &Page) -> Result { } } +/// A configuration object for setting up a VMA in an `f_ops->mmap()` hook. +/// +/// The `f_ops->mmap()` hook is called when a new VMA is being created, and the hook is able to +/// configure the VMA in various ways to fit the driver that owns it. Using `VmaNew` indicates that +/// you are allowed to perform operations on the VMA that can only be performed before the VMA is +/// fully initialized. +/// +/// # Invariants +/// +/// For the duration of 'a, the referenced vma must be undergoing initialization in an +/// `f_ops->mmap()` hook. +pub struct VmaNew { + vma: VmaRef, +} + +// Make all `VmaRef` methods available on `VmaNew`. +impl Deref for VmaNew { + type Target = VmaRef; + + #[inline] + fn deref(&self) -> &VmaRef { + &self.vma + } +} + +impl VmaNew { + /// Access a virtual memory area given a raw pointer. + /// + /// # Safety + /// + /// Callers must ensure that `vma` is undergoing initial vma setup for the duration of 'a. + #[inline] + pub unsafe fn from_raw<'a>(vma: *mut bindings::vm_area_struct) -> &'a Self { + // SAFETY: The caller ensures that the invariants are satisfied for the duration of 'a. + unsafe { &*vma.cast() } + } + + /// Internal method for updating the vma flags. + /// + /// # Safety + /// + /// This must not be used to set the flags to an invalid value. + #[inline] + unsafe fn update_flags(&self, set: vm_flags_t, unset: vm_flags_t) { + let mut flags = self.flags(); + flags |= set; + flags &= !unset; + + // SAFETY: This is not a data race: the vma is undergoing initial setup, so it's not yet + // shared. Additionally, `VmaNew` is `!Sync`, so it cannot be used to write in parallel. + // The caller promises that this does not set the flags to an invalid value. + unsafe { (*self.as_ptr()).__bindgen_anon_2.__vm_flags = flags }; + } + + /// Set the `VM_MIXEDMAP` flag on this vma. + /// + /// This enables the vma to contain both `struct page` and pure PFN pages. Returns a reference + /// that can be used to call `vm_insert_page` on the vma. + #[inline] + pub fn set_mixedmap(&self) -> &VmaMixedMap { + // SAFETY: We don't yet provide a way to set VM_PFNMAP, so this cannot put the flags in an + // invalid state. + unsafe { self.update_flags(flags::MIXEDMAP, 0) }; + + // SAFETY: We just set `VM_MIXEDMAP` on the vma. + unsafe { VmaMixedMap::from_raw(self.vma.as_ptr()) } + } + + /// Set the `VM_IO` flag on this vma. + /// + /// This is used for memory mapped IO and similar. The flag tells other parts of the kernel to + /// avoid looking at the pages. For memory mapped IO this is useful as accesses to the pages + /// could have side effects. + #[inline] + pub fn set_io(&self) { + // SAFETY: Setting the VM_IO flag is always okay. + unsafe { self.update_flags(flags::IO, 0) }; + } + + /// Set the `VM_DONTEXPAND` flag on this vma. + /// + /// This prevents the vma from being expanded with `mremap()`. + #[inline] + pub fn set_dontexpand(&self) { + // SAFETY: Setting the VM_DONTEXPAND flag is always okay. + unsafe { self.update_flags(flags::DONTEXPAND, 0) }; + } + + /// Set the `VM_DONTCOPY` flag on this vma. + /// + /// This prevents the vma from being copied on fork. This option is only permanent if `VM_IO` + /// is set. + #[inline] + pub fn set_dontcopy(&self) { + // SAFETY: Setting the VM_DONTCOPY flag is always okay. + unsafe { self.update_flags(flags::DONTCOPY, 0) }; + } + + /// Set the `VM_DONTDUMP` flag on this vma. + /// + /// This prevents the vma from being included in core dumps. This option is only permanent if + /// `VM_IO` is set. + #[inline] + pub fn set_dontdump(&self) { + // SAFETY: Setting the VM_DONTDUMP flag is always okay. + unsafe { self.update_flags(flags::DONTDUMP, 0) }; + } + + /// Returns whether `VM_READ` is set. + /// + /// This flag indicates whether userspace is mapping this vma as readable. + #[inline] + pub fn readable(&self) -> bool { + (self.flags() & flags::READ) != 0 + } + + /// Try to clear the `VM_MAYREAD` flag, failing if `VM_READ` is set. + /// + /// This flag indicates whether userspace is allowed to make this vma readable with + /// `mprotect()`. + /// + /// Note that this operation is irreversible. Once `VM_MAYREAD` has been cleared, it can never + /// be set again. + #[inline] + pub fn try_clear_mayread(&self) -> Result { + if self.readable() { + return Err(EINVAL); + } + // SAFETY: Clearing `VM_MAYREAD` is okay when `VM_READ` is not set. + unsafe { self.update_flags(0, flags::MAYREAD) }; + Ok(()) + } + + /// Returns whether `VM_WRITE` is set. + /// + /// This flag indicates whether userspace is mapping this vma as writable. + #[inline] + pub fn writable(&self) -> bool { + (self.flags() & flags::WRITE) != 0 + } + + /// Try to clear the `VM_MAYWRITE` flag, failing if `VM_WRITE` is set. + /// + /// This flag indicates whether userspace is allowed to make this vma writable with + /// `mprotect()`. + /// + /// Note that this operation is irreversible. Once `VM_MAYWRITE` has been cleared, it can never + /// be set again. + #[inline] + pub fn try_clear_maywrite(&self) -> Result { + if self.writable() { + return Err(EINVAL); + } + // SAFETY: Clearing `VM_MAYWRITE` is okay when `VM_WRITE` is not set. + unsafe { self.update_flags(0, flags::MAYWRITE) }; + Ok(()) + } + + /// Returns whether `VM_EXEC` is set. + /// + /// This flag indicates whether userspace is mapping this vma as executable. + #[inline] + pub fn executable(&self) -> bool { + (self.flags() & flags::EXEC) != 0 + } + + /// Try to clear the `VM_MAYEXEC` flag, failing if `VM_EXEC` is set. + /// + /// This flag indicates whether userspace is allowed to make this vma executable with + /// `mprotect()`. + /// + /// Note that this operation is irreversible. Once `VM_MAYEXEC` has been cleared, it can never + /// be set again. + #[inline] + pub fn try_clear_mayexec(&self) -> Result { + if self.executable() { + return Err(EINVAL); + } + // SAFETY: Clearing `VM_MAYEXEC` is okay when `VM_EXEC` is not set. + unsafe { self.update_flags(0, flags::MAYEXEC) }; + Ok(()) + } +} + /// The integer type used for vma flags. #[doc(inline)] pub use bindings::vm_flags_t;