From patchwork Tue Apr 8 08:41:51 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oscar Salvador X-Patchwork-Id: 14042402 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43730C369A1 for ; Tue, 8 Apr 2025 08:42:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BFC0E6B000A; Tue, 8 Apr 2025 04:42:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BACBA6B000C; Tue, 8 Apr 2025 04:42:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A4B846B000D; Tue, 8 Apr 2025 04:42:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 844146B000A for ; Tue, 8 Apr 2025 04:42:20 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 3CAC25893F for ; Tue, 8 Apr 2025 08:42:21 +0000 (UTC) X-FDA: 83310234882.30.FFCD595 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf25.hostedemail.com (Postfix) with ESMTP id 3FE5CA0008 for ; Tue, 8 Apr 2025 08:42:19 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=2XwOos+r; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=yTNQnpGT; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=2XwOos+r; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=yTNQnpGT; spf=pass (imf25.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744101739; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OY+ktWKu7rfDC6OOLEBMjxNMAtURJVUDnyjqclkHyqM=; b=eoe7egYH7PaBVisEdBU+quFzGni31VlYRdBbbfu1zfI/uqeZQBAmR8kus0Gl8Cvk36LNS+ g0h1L/NJAot9+29niwE3NTqYCz7Dh6E48ItkHqdAnP5Ra7CaOIuqNoupHkXIPXnTJ/wfVr IJV/W2peM539MUGDsapVYFFUmPIS1js= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744101739; a=rsa-sha256; cv=none; b=fc9pve11Pece0f5PMOGBOC/y+ru/uqcz/K7aeBaFv6yWKxrFGEhx3cuNCrTaAfaiu6G+1C FQ0lq5x9rJcdMVhLayFho0gPd1y6K7/R7ofKXpb3hLMHFWJdGkxFpq2pW6ambgkMu7Tiu+ d7KlbOpKJmv43eG6L1RS2JWawjtHv8I= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=2XwOos+r; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=yTNQnpGT; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=2XwOos+r; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=yTNQnpGT; spf=pass (imf25.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8F70F21185; Tue, 8 Apr 2025 08:42:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1744101735; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OY+ktWKu7rfDC6OOLEBMjxNMAtURJVUDnyjqclkHyqM=; b=2XwOos+reVOOfP6FDGwVtID+hc1km1M67+rQc5mr+wTPYI+REDBlJopVzQMlrL1E7CAO3E lUZL0Ic521Xjz97TP4pFuGxx9Im+1n0C5l+Qu2L+8CF+krGA9KcSddez6DZ54mT/8hhuOJ o60Gtr334jhZUSn5GaswJ2c8wNyZDI4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1744101735; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OY+ktWKu7rfDC6OOLEBMjxNMAtURJVUDnyjqclkHyqM=; b=yTNQnpGT7fZKJ4td9Qa8ZhjB6Y7OIvjcsBUoPEfAj65BwcjwxQLJQ2GTC7ZjNZwKOLm8BS wl7Jz92XSxp3RgCA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1744101735; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OY+ktWKu7rfDC6OOLEBMjxNMAtURJVUDnyjqclkHyqM=; b=2XwOos+reVOOfP6FDGwVtID+hc1km1M67+rQc5mr+wTPYI+REDBlJopVzQMlrL1E7CAO3E lUZL0Ic521Xjz97TP4pFuGxx9Im+1n0C5l+Qu2L+8CF+krGA9KcSddez6DZ54mT/8hhuOJ o60Gtr334jhZUSn5GaswJ2c8wNyZDI4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1744101735; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OY+ktWKu7rfDC6OOLEBMjxNMAtURJVUDnyjqclkHyqM=; b=yTNQnpGT7fZKJ4td9Qa8ZhjB6Y7OIvjcsBUoPEfAj65BwcjwxQLJQ2GTC7ZjNZwKOLm8BS wl7Jz92XSxp3RgCA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 0EAFA13691; Tue, 8 Apr 2025 08:42:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id cFXGAGfh9Gd6VgAAD6G6ig (envelope-from ); Tue, 08 Apr 2025 08:42:15 +0000 From: Oscar Salvador To: Andrew Morton Cc: David Hildenbrand , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Vlastimil Babka , Harry Yoo , Jonathan Cameron , linux-cxl@vger.kernel.org, Oscar Salvador Subject: [PATCH v2 1/3] mm,slub: Do not special case N_NORMAL nodes for slab_nodes Date: Tue, 8 Apr 2025 10:41:51 +0200 Message-ID: <20250408084153.255762-2-osalvador@suse.de> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250408084153.255762-1-osalvador@suse.de> References: <20250408084153.255762-1-osalvador@suse.de> MIME-Version: 1.0 X-Rspamd-Action: no action X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 3FE5CA0008 X-Stat-Signature: hwrgwdby6nh6bpsp7xsnszsqyynajmyu X-HE-Tag: 1744101739-542440 X-HE-Meta: U2FsdGVkX18qQLopwULF1vc3QueuPhMwi1Bn3RJIWM4ZdIfK1GP4+gPN4O48mfFORthFsei0QHYsZD5lm6sgm2+GJq1kPWf9kbttlMKo8qHgHbWDYJnWEjjZfj/CjEpTkTV/XgMQGPpHxL68qpmqBLZmpC1XxbAL0r7S8NengKdHE7E3L1k1iapdTqwMuLWCTCf8bEyDz0wDl8YU8X3ZBdc/3cpt7MKiYkBkWf/NE6/p9PtgjAV1wnwcxUJ9f9aTyedWR1B/j/GzkUIy694ufW8hUBPVqwgJIWT7ai2PIZAQ5BKAdbzfNPHyg+I2p/9WZQlKmE2K9eGDNM8/nC6EnCtigH6OsqHVrPoIxWNgmI+fsQ1+V+dsV2AJ3SzjXGmLdN1G9aBy/NG3vN5YfEOS3EPOTF+yF/kCupRhKlescwtMQJQYsFWykG1brRBgOsJqzgraWRi2IVioIMAbrVjG/0/baN4kqRUycvm+2Od4kxzbdUsJ6Q6JOnGtupzTrXyTRAJx4MRH7Lycla764YnAhA/1akZ+NyIlkB/uynOvP9HtX0tiOOblwSGTHXsdmgwtqNHc+BnaVoWdrrEqXzK/ePJnZziSbh2fi19vrEUZSmB6blfmUkpak+2gPtp5GXV/j4POZv2RuMeJ/GeRwJLE4vfqiCT8Y2a3xUvvXK+dnmjV1FxbqS8IT/F2rVCl5V9KamY6MX3F5i1iOouyOZEJLRPVKqxPd/ED5Wj2O8OMfKk6CfeRIlAteFyoSCGSrKOMew1HcFcn7etQelQefvxdzGSA0j5nMBfYfSS+44gYeHWzOpH+V7/iKDGNtfQ8z0z64EZhlNYqC8DQrscmeV2sYX0qsHxxkXV1ZfvhxnCONWtqDZ11Ple7L61TNnffUGjZgNgy+NP7ZvU7F17hapFHPy04lIqWCaXPQGlACTqTLKLMGQkV+7Y2D+ZtcYESaQepdSYnURzGNMFdAYJYcuq 1aAv2Pu7 ZNm6HiL2cdVMiuX0NATu00a9T2Rso6yV3Y3x1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Currently, slab_mem_going_going_callback() checks whether the node has N_NORMAL memory in order to be set in slab_nodes. While it is true that gettind rid of that enforcing would mean ending up with movables nodes in slab_nodes, the memory waste that comes with that is negligible. So stop checking for status_change_nid_normal and just use status_change_nid instead which works for both types of memory. Also, once we allocate the kmem_cache_node cache for the node in slab_mem_online_callback(), we never deallocate it in slab_mem_off_callback() when the node goes memoryless, so we can just get rid of it. The only side effect is that we will stop clearing the node from slab_nodes. Signed-off-by: Oscar Salvador Signed-off-by: David Hildenbrand --- mm/slub.c | 30 +----------------------------- 1 file changed, 1 insertion(+), 29 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index b46f87662e71..e716b4cb2d0e 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -6164,36 +6164,12 @@ static int slab_mem_going_offline_callback(void *arg) return 0; } -static void slab_mem_offline_callback(void *arg) -{ - struct memory_notify *marg = arg; - int offline_node; - - offline_node = marg->status_change_nid_normal; - - /* - * If the node still has available memory. we need kmem_cache_node - * for it yet. - */ - if (offline_node < 0) - return; - - mutex_lock(&slab_mutex); - node_clear(offline_node, slab_nodes); - /* - * We no longer free kmem_cache_node structures here, as it would be - * racy with all get_node() users, and infeasible to protect them with - * slab_mutex. - */ - mutex_unlock(&slab_mutex); -} - static int slab_mem_going_online_callback(void *arg) { struct kmem_cache_node *n; struct kmem_cache *s; struct memory_notify *marg = arg; - int nid = marg->status_change_nid_normal; + int nid = marg->status_change_nid; int ret = 0; /* @@ -6251,10 +6227,6 @@ static int slab_memory_callback(struct notifier_block *self, case MEM_GOING_OFFLINE: ret = slab_mem_going_offline_callback(arg); break; - case MEM_OFFLINE: - case MEM_CANCEL_ONLINE: - slab_mem_offline_callback(arg); - break; case MEM_ONLINE: case MEM_CANCEL_OFFLINE: break;