From patchwork Fri Apr 11 22:11:09 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gregory Price X-Patchwork-Id: 14048810 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9633DC369AE for ; Fri, 11 Apr 2025 22:11:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A4D7068002D; Fri, 11 Apr 2025 18:11:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D4FE680024; Fri, 11 Apr 2025 18:11:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7DDC068002D; Fri, 11 Apr 2025 18:11:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5B407680024 for ; Fri, 11 Apr 2025 18:11:37 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 87CAA808F8 for ; Fri, 11 Apr 2025 22:11:37 +0000 (UTC) X-FDA: 83323160634.21.6D27917 Received: from mail-qk1-f172.google.com (mail-qk1-f172.google.com [209.85.222.172]) by imf08.hostedemail.com (Postfix) with ESMTP id BED3C160012 for ; Fri, 11 Apr 2025 22:11:35 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=GCbFgUgA; dmarc=none; spf=pass (imf08.hostedemail.com: domain of gourry@gourry.net designates 209.85.222.172 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744409495; a=rsa-sha256; cv=none; b=aYjfevKx8HJIO7LwiQ3infzUtxuolfKIfS/295eT9SCue8GWgWrEd3vkJOWDn+QcqndXjJ hQ773QotrNxMr/30e1ktaqBY8vv/T9fwTJTZ5q643YvZq569xCPVQyauSp50wtxBtUVidp 5313dKzbon5GnBiDgS93hAG/+fkfQIM= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=GCbFgUgA; dmarc=none; spf=pass (imf08.hostedemail.com: domain of gourry@gourry.net designates 209.85.222.172 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744409495; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sQiBfRqPk8mw1dZkgLepdccSbpRToMErHEtsnH4pLbA=; b=4Sk+5a9E0X6ErqTPIM2bNoy+/91XWVPr26NkC1uumheXLLykvIVUrBMzTRDm8sNFWNd5tY YdwViqkT9393MDiG0XhfFb2rzjdxrt1+BaWxM4J1i9J2nWfNe6ycE79Kau9cpwhEUN0pqY ZnG5Ma1TjC313VI2gfnEQhRCe0wwB+Q= Received: by mail-qk1-f172.google.com with SMTP id af79cd13be357-7c560c55bc1so256335985a.1 for ; Fri, 11 Apr 2025 15:11:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1744409494; x=1745014294; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sQiBfRqPk8mw1dZkgLepdccSbpRToMErHEtsnH4pLbA=; b=GCbFgUgA3bB604DWEEwbOWzZiF2cLy4i5+j9zZh5u7lyCfzAtg7Q9egiaHPYj+xaHx Kf3gFCIHgqp02fFbNmxruKA3qH4P+RTIHj7EPUExc2ISq4hTZMLk8C0fXjJvTGvtqbCA KPO+1SfLzZIt61k53VUe+0veT8+r06thsTqha8ofnJ+lx0rk7BGkL/rls6NDI6WD+U5q whb+qnW9pApWo/4ilKyrebM/tQMh+/2w17B0RbncOGhSOfJVcLN6frzq+Csj7VgicXvO 4IIkjYVWECilh4Rm3xgPr25ww/pkwZJhWdioCCoJhJ0CK7D1EBs3/MkQvgYN1OAPLxXq aXsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744409494; x=1745014294; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sQiBfRqPk8mw1dZkgLepdccSbpRToMErHEtsnH4pLbA=; b=SSG3iRUM25+LvcPUF6gT3oXtjPq8nTziu03xvJvvB03q53w88gC4QFGzqcQfd0C28T 2Zk2+UZ7Vw14rEZox3FpKPeRmkbTg/6jUvK8ht98+EPgVdE96StevrrVzwjXT76iSVqM DjE0RSNDjQUuQhbTe8G7km6BVFdALKCiOxZIV0D+L6rfBiFixJTjG5N1I4f3YRIMR19U 1SAE3yum6e7wwpjA20XCI+/jwzZ8SxPxhBG/z/Y9ahM55Demto8R8tfI98GT3SZpcrjI +0Uawz6nmwEQnS0Y+LFae5Fg4eYPRH5EuAEq4EMcSPuDC1IY+fUTLOXDYFW65ilaJKI8 MldA== X-Gm-Message-State: AOJu0Yy/XZEoAy2kjLZlGK9LaSEC8gewf83VOb0S8BXETNHpDfqdF6rd D1r9cpHtpgLXaI3nB7LKGCysMuDUWe+yaJ7amMfXO6r5dQM+MZnHGHJBdI2y92/pVvAmx+WYZtX F X-Gm-Gg: ASbGncubt4N3kPrCY1hLkhXQUD4cAT7ajTwtrXoAeKu7cobR84/wUJgDI8eiFtdB/yS gTs3WVK43SMraHcC3XIb3IJRxLNWX5fsZmm3TXqW2vH/bWQcdAOxEO5xCDb1l10zSFkdznPaSkF L4fOZLcwzTKL9P5Qh6a4nKtHxX/Z4Kbetv47JgpG09IdPN1XttGcsE8psRkUhJrI9Q37v2/iqh9 WMAtD9Uy1e9x+VDJsebBKPetPfe4v4PWeqmuFZswhYsvlLgD8kWBhGtcEIJORDBgR5Odx0KUwu4 lNKg/Polg7S6Nj2Yrsvr05UVqIReJHcblatic2Bz3Ii7LR6oerbvBD4Fi7+lwCO0P7f7zxRliwA K1m7+TlOqNz2F9imI9YQPGCxm8Omz X-Google-Smtp-Source: AGHT+IHFJC0NN/wSPotsTklWaXCxqH3AtdGqhorgwESblRoLtPrItNQuVu4sWimxPm4HxktfyaglUg== X-Received: by 2002:a05:620a:2586:b0:7c5:aec7:7ecc with SMTP id af79cd13be357-7c7af0d3f56mr657187185a.13.1744409494387; Fri, 11 Apr 2025 15:11:34 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F.lan (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7c7a8943afcsm321264485a.16.2025.04.11.15.11.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Apr 2025 15:11:34 -0700 (PDT) From: Gregory Price To: linux-mm@kvack.org Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, akpm@linux-foundation.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, donettom@linux.ibm.com Subject: [RFC PATCH v4 4/6] migrate: implement migrate_misplaced_folio_batch Date: Fri, 11 Apr 2025 18:11:09 -0400 Message-ID: <20250411221111.493193-5-gourry@gourry.net> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250411221111.493193-1-gourry@gourry.net> References: <20250411221111.493193-1-gourry@gourry.net> MIME-Version: 1.0 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: BED3C160012 X-Stat-Signature: eu18oxzjpmay1m5p1e1u7cga9gh4y98k X-Rspam-User: X-HE-Tag: 1744409495-438512 X-HE-Meta: U2FsdGVkX1/F/vlEqG2rBdVFMHgZju9NSo/Z61dfY0mFLGEdyXVcmyLDR4ri/V+BohVoGRKdUCETbW9ELXyNcKFydoRrVOracT/jNbXCMNMoCLNKiRSqhFKWjUtFILVmOaTIC0lT4M+8va34ztUAzvUuWOGFduyhtu7saKrF+B53XRIWODVgNRMrMnPn2Lgv5Z3q8IwkGMKvN3e+u+AfhJ1wPEWN8f355DoHz/paUH6bkM7SxL5wgakfP7tcFOrX03ULVOXq3eIwruyrAeQaOxR62NrjEDMtzFTwtM+LblPSSNZb9n2V47CT+mfRs84PBWdvIusrvs94n4Ln5V1pmyz7hkfcGBwoOWVBRxg9rvyFcbRNiZOHzV2ujk57Ef8BENcMk+XSZqElalclmB6AxcSv9GwP+hNzMynmDktJ+isQOFD7gn81KOqclqssi3esmCMECyYNr2eiiX2r+5OLfTC3cmJ4t/3WKQJ9twG7ycBYXVJZVpVv9VaR+o8CTy3YROCqjGNDnVBC53Yt2SG6/lxSVyfVJcHAdnujEaWIWybYw15Tos1/DaG2syXIbvhU1Kk7jAs76yVbo2GVL+l5SHPHPR8oI8sJmUNaorFNL8zpXNW94i5nXh1PZWCJA6vN4zFiQm0MfoxX1QqXdkz0smEZKWDpu/5mwKMNDRpemJcLY2J/dQR9b7bQjSwekEhipcWM4yEkvlhg/WV6M6yzlcb4B37+fVH/QhebZblAEM7lGgEGPVTZ6+eFU75sIiqV5PEeK5uYHvNrio7JxiGVOmzKMBJ+t93pW1CG6lQSoHPRt2HJDSrU0TW+teCg97xSsr5aNnTC0MFOi+H67WfOltoUfG130nDzQ1hHjKqVp+0WvidQMD3llMmp+R22hUbJFzomTTr5nUtfxA4gbgib9Y3c3o+Mkz1CRBwFOT+Yk9mnstIxqz7XloemmkZm47x8j+xgiOsNAGDkPlqV7LU V+9GwyrE Ct7butuOhLvAliIf88utwEyvQgP1YiY8z7X2g3z334HakujSnoNh2XosKyPVdNVwt1TjY904+f+v37fDrhTZDHYoiQe5nmO8XOtuOMJWaUloiRCvO7uNi+R2g/ls4MB+ZIFTYZbIw9Tqci6qP5fw8/+L/pNxjJHt3RFa0zwHFW6wEnwTOySz2lcNOLYVkK53rc0uALPHQKsPC3SdENnL1H1LJrQOrz3r4azk6rlpruUciWoIHQIXurGYEFVazgreciS+rFYibnlwAV29b2HWFnapFOg97jSRUTASd7+6QfPlbixfuo1fUupf8CcroLciAAC4Q6C0ufrb/2xzbnMPWdj1FNWNCgM+JOx5a X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: A common operation in tiering is to migrate multiple pages at once. The migrate_misplaced_folio function requires one call for each individual folio. Expose a batch-variant of the same call for use when doing batch migrations. Signed-off-by: Gregory Price --- include/linux/migrate.h | 6 ++++++ mm/migrate.c | 31 +++++++++++++++++++++++++++++++ 2 files changed, 37 insertions(+) diff --git a/include/linux/migrate.h b/include/linux/migrate.h index 61899ec7a9a3..2df756128316 100644 --- a/include/linux/migrate.h +++ b/include/linux/migrate.h @@ -145,6 +145,7 @@ const struct movable_operations *page_movable_ops(struct page *page) int migrate_misplaced_folio_prepare(struct folio *folio, struct vm_area_struct *vma, int node); int migrate_misplaced_folio(struct folio *folio, int node); +int migrate_misplaced_folio_batch(struct list_head *foliolist, int node); #else static inline int migrate_misplaced_folio_prepare(struct folio *folio, struct vm_area_struct *vma, int node) @@ -155,6 +156,11 @@ static inline int migrate_misplaced_folio(struct folio *folio, int node) { return -EAGAIN; /* can't migrate now */ } +static inline int migrate_misplaced_folio_batch(struct list_head *foliolist, + int node) +{ + return -EAGAIN; /* can't migrate now */ +} #endif /* CONFIG_NUMA_BALANCING */ #ifdef CONFIG_MIGRATION diff --git a/mm/migrate.c b/mm/migrate.c index 047131f6c839..7e1ba6001596 100644 --- a/mm/migrate.c +++ b/mm/migrate.c @@ -2731,5 +2731,36 @@ int migrate_misplaced_folio(struct folio *folio, int node) BUG_ON(!list_empty(&migratepages)); return nr_remaining ? -EAGAIN : 0; } + +/* + * Batch variant of migrate_misplaced_folio. Attempts to migrate + * a folio list to the specified destination. + * + * Caller is expected to have isolated the folios by calling + * migrate_misplaced_folio_prepare(), which will result in an + * elevated reference count on the folio. + * + * This function will un-isolate the folios, dereference them, and + * remove them from the list before returning. + */ +int migrate_misplaced_folio_batch(struct list_head *folio_list, int node) +{ + pg_data_t *pgdat = NODE_DATA(node); + unsigned int nr_succeeded; + int nr_remaining; + + nr_remaining = migrate_pages(folio_list, alloc_misplaced_dst_folio, + NULL, node, MIGRATE_ASYNC, + MR_NUMA_MISPLACED, &nr_succeeded); + if (nr_remaining) + putback_movable_pages(folio_list); + + if (nr_succeeded) { + count_vm_numa_events(NUMA_PAGE_MIGRATE, nr_succeeded); + mod_node_page_state(pgdat, PGPROMOTE_SUCCESS, nr_succeeded); + } + BUG_ON(!list_empty(folio_list)); + return nr_remaining ? -EAGAIN : 0; +} #endif /* CONFIG_NUMA_BALANCING */ #endif /* CONFIG_NUMA */