Message ID | 20250415024532.26632-22-songmuchun@bytedance.com (mailing list archive) |
---|---|
State | New |
Headers | show
Return-Path: <owner-linux-mm@kvack.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAC47C369B4 for <linux-mm@archiver.kernel.org>; Tue, 15 Apr 2025 02:47:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 79F292801C8; Mon, 14 Apr 2025 22:47:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7025C280126; Mon, 14 Apr 2025 22:47:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 57CF42801C8; Mon, 14 Apr 2025 22:47:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 317C9280126 for <linux-mm@kvack.org>; Mon, 14 Apr 2025 22:47:52 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id DE6B1C0B94 for <linux-mm@kvack.org>; Tue, 15 Apr 2025 02:47:52 +0000 (UTC) X-FDA: 83334743184.12.DEF2BB0 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by imf13.hostedemail.com (Postfix) with ESMTP id 06C7220009 for <linux-mm@kvack.org>; Tue, 15 Apr 2025 02:47:50 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=KExeryQ5; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf13.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744685271; a=rsa-sha256; cv=none; b=YGRDvJBKSuMeR04LyyjviunXk3YAAWBl4cWrKfUFO5oc9wXTx7T36nbR5ppQwf3X8Gb5BF osbQyreLoHTiH40wR+kiwuGTOOszBzWaXwOU3R93PGAq/dY2kKCYqfiaSBXcw51QeMXdDA yKGLPzYdjRRXtF6hBJ2V2A9wonPB47Y= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=KExeryQ5; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf13.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744685271; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Dhcsyw5OvFqI3eRSntntJlPhmFn+ppWjISpYyf0tCPE=; b=TraKhMmR+Npcc5WmKKIszk8TSULOl62oqRUaiLnDUQWsrZZk2MJsIidvPBmiduerT+Exab o++VdJdcGvj60KT7GaynN+sVXM9xnYuQYryxre4FX2qhkVCD53B4bmtjyeU2qP/Cq4mUly P7qT2yQD5V9s22oQL/DOoE2Wxai22LM= Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-22423adf751so45814315ad.2 for <linux-mm@kvack.org>; Mon, 14 Apr 2025 19:47:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1744685270; x=1745290070; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Dhcsyw5OvFqI3eRSntntJlPhmFn+ppWjISpYyf0tCPE=; b=KExeryQ5BJdMtv+EdtUh/pWJDp6Ee13+3n6TrysbTHcScPwE3DE92QpyVt7SC1Dn9f yrs6DImoyF0NEOm2NU90C+PDRqNoYbGrkUsgmO9UcyHKjpEP/7yNZR9nmNHpyRuvItDB WF20klttRJ4Ev+cmRIHwaR0uwJHqHBu4aZHyXqLngobZOnkCUM4D5f3yQTXCA0D2qPQM Th0NdqfGlJSS3YjHpgE1Afi7PmedjKuxQ928EGvi4LQyBPhzHkvO++WUf7SmrFxBVbMB JahK2msZWg44gUtc1ShxfnRjBrpoOwgFWSsphMjBG9K0QKwjIeQUk5MW3wF7770Rqdxs h2mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744685270; x=1745290070; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Dhcsyw5OvFqI3eRSntntJlPhmFn+ppWjISpYyf0tCPE=; b=DFLnl0Rfxi/Kn47R+rQ/E9NuTCZEVTwAjUIYtRJuUkXAx3QottEAtsouZ+XLRiMJhm yWE86X0heTppCXmAPc5K85mWYaVKpK9p+HFRTnktEzSOGJQd6oY+FQE2sCwygaBJ4Fvg McQzySFIqzNjIj9/esQLmx2PX3gGEonNbjQfu5EX63ypNdz7fn/8i6fO5Rd/MrijVXfu gzZVqgjxZTmATHXBFVRLaUq+7q1b+oVFTYY14BLVzCOiRzCx4ODIB5IrNdAp9ABIxFba U6Hk2GXb4BWNnfWXOAEuWZeZZNhkpdFjuGIiLOE+ShlRjEZO8XjjMxh6Z3P7/exWNYk0 aBEQ== X-Forwarded-Encrypted: i=1; AJvYcCUyy4FmWxt9djhUGlWPp13/ZDYn2886peIeDEmd/KEYADdmGonJFOE1G+6iIVnBT8v4VxZ5x18jGQ==@kvack.org X-Gm-Message-State: AOJu0YzdsEUZBq1jeafnARjYVUjvFibsHg4cPEQbXQsBSweYY5aAsuFN AwlzN3SogyTxbzIkYHfHx3U5XEzqOMW0GAi5172QTYRMJ2PolnL5uDrPujVisJI= X-Gm-Gg: ASbGnctwXLdZVT5Sqjjd0tUXM+saHIFSwvbcmxLOqL/aq3gYklWcLwESJPZ5iVuwTUL hp0QYAp2a0qtDQEgVgZZgF09lNyCmy2iNmIUCCsJIfEtWjfpNxh+F6xrqr2QQ3wMeknescUgjPU iBcfnmFFI7K2L4an0kdJAdgdLmtqGEFb8c8fdlfW/tsqCiPtD35ZGUTSXi+BKRgDFz85op27sfV v/ztU9mW47xwBQcELhM4B9v59i48J2oQSGhbN6s4ewKkcAPWUn1W178o+/D9N3IcPonwaDrRaZI +FdLszozB0TWM3LPyrvIPM5I9GHZXa+1h3vy5XQV0UXKf+JOE8BZrF3QXfVjN9fcvgSjSKyX X-Google-Smtp-Source: AGHT+IHQB5bi/wRWV63xYCSrz429tnAZcPPlisuUNzOS3Dpdg6ZYVtpDC/C2wxVGDE/gRRdOBX11FA== X-Received: by 2002:a17:902:ef4c:b0:224:76f:9e4a with SMTP id d9443c01a7336-22bea4ab7e3mr209530695ad.14.1744685269959; Mon, 14 Apr 2025 19:47:49 -0700 (PDT) Received: from PXLDJ45XCM.bytedance.net ([61.213.176.5]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22ac7ccac49sm106681185ad.217.2025.04.14.19.47.45 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 14 Apr 2025 19:47:49 -0700 (PDT) From: Muchun Song <songmuchun@bytedance.com> To: hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, akpm@linux-foundation.org, david@fromorbit.com, zhengqi.arch@bytedance.com, yosry.ahmed@linux.dev, nphamcs@gmail.com, chengming.zhou@linux.dev Cc: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, hamzamahfooz@linux.microsoft.com, apais@linux.microsoft.com, Muchun Song <songmuchun@bytedance.com> Subject: [PATCH RFC 21/28] mm: zswap: prevent lruvec release in zswap_folio_swapin() Date: Tue, 15 Apr 2025 10:45:25 +0800 Message-Id: <20250415024532.26632-22-songmuchun@bytedance.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: <20250415024532.26632-1-songmuchun@bytedance.com> References: <20250415024532.26632-1-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: 06C7220009 X-Rspamd-Server: rspam04 X-Stat-Signature: mh34frn35pppmfihq873498hs6yj9m1u X-HE-Tag: 1744685270-42003 X-HE-Meta: U2FsdGVkX18YDh5iqBHH3J/Wb3VgeRiqhOPuM28pm0+UY/qdmFcguctTEfCoBaFaloWFJ/evLX/01dxc65Oaipo6e5bilkm2+vhPWVduSEqvKnfl/Nky4sK4KE3shBQF6zoFtmpVkd6staVEOELWY38/AYvi5Ktd4VCCAqc3CLRsK1pjPLLDPVP1+sETv79JBIZ9/47kuQNDMOJqEuoPQoCFykq7lxMvAy9CLAG67hFLbsotKF1PEn+t/Fn7w7Njmq7JIUaTnrLAnchnVq16uGI/u98HLJDG5JimTAcq1Ro3Y7IXjMfZu96S8zTr2aDrQme1cR5+NkqgYdCTq6FU7Wf+lLVa39LMUzq09k8fkMfdQGIMRDNdbT0jV1V9kny2IBrJWxd4fD7DKU0pygkOJelsffOSnyljn+aH2ux9tBZvKmPuZoMkQFGK0CDSPdAmAIJ5OMNyuY10iTEosXsuHQ9m/BuS6qVGVr8ub81T650u1Ctp/y9NiUMVKIg1SjvFJQQmT/igkVkhiqULXyBdx8Fvdqze2QCWFWaCJsGYw5pvMvu0Zcmc13FgfjvN4CO3O5JTbdWf0d3dLZ7oGlulNM6bxb+litkkviNJt6Bc90Ss3vuv/6FThJJjwqoHnmH2CpxjtWVBFYG8HB7zyCa1f+DLGasRko3RdEUwEAq7igBAWZ/8xRRIWlIao1O84Wu78lGOOW/vC9EfP5ElAZ1yxPMBlsRC2rJKk9M8TQS+OdVjxS7b2EZ/1zYZ4TVRpHgfhPmaDp5wSgLIuwhOQr1lpUUtbYAlGlILUaz7zRBQq7ReaH/L7pXsl66CO6t2/7gsD9wNk8EKXsO2SZwDMOtU3VgkXHVSAJTPLd3kY4Xt7xHSarZgeLLJ3D0IQDam6WHssEG/VYKKCBtPe6M4qSRwEWDEYoarwj7MsFTaqp7AeYJDWd92M8dtNnzBxVeYWgsBAPf6r6+q0w5Fy21uwno DQDUSacj /m+lHVqh+jT+W7haQ8rFr7i2Fxa7ykxdP/n8RFuu+7eUNSeruapsMZvc9Y0HVW//IGeHSpHKaOMSHpOLTqNW5+guDWwloUo+evkqwP3sa2pgV9ZMTW7itBITGIoRMGc3A2wkn4qkW5YiDUaRqEvcB1DkmjwjFGlvKV2GxUJY4/addQNc6zpNM4jWU9xBFtwzwpYx/ZAzKH8EUvWUeOx635c+jyh14DyeczDiilyg/goJ02qisRHNTKfCV+zOKi/teHdBWhA9aYi41X0Q6uN2OI2D20wVQGOkhSJsrTCvFmr6PhNrsu49R09SOgGXJh54r0n+ddrQMKogqpQVqyKP5ACGK7aTTEFJlg6cNhbFZDexaegY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: <linux-mm.kvack.org> List-Subscribe: <mailto:majordomo@kvack.org> List-Unsubscribe: <mailto:majordomo@kvack.org> |
Series |
Eliminate Dying Memory Cgroup
|
expand
|
diff --git a/mm/zswap.c b/mm/zswap.c index 204fb59da33c..4a41c2371f3d 100644 --- a/mm/zswap.c +++ b/mm/zswap.c @@ -752,8 +752,10 @@ void zswap_folio_swapin(struct folio *folio) struct lruvec *lruvec; if (folio) { + rcu_read_lock(); lruvec = folio_lruvec(folio); atomic_long_inc(&lruvec->zswap_lruvec_state.nr_disk_swapins); + rcu_read_unlock(); } }
In the near future, a folio will no longer pin its corresponding memory cgroup. So an lruvec returned by folio_lruvec() could be released without the rcu read lock or a reference to its memory cgroup. In the current patch, the rcu read lock is employed to safeguard against the release of the lruvec in zswap_folio_swapin(). This serves as a preparatory measure for the reparenting of the LRU pages. Signed-off-by: Muchun Song <songmuchun@bytedance.com> --- mm/zswap.c | 2 ++ 1 file changed, 2 insertions(+)