Message ID | 20250415231635.83960-7-dave@stgolabs.net (mailing list archive) |
---|---|
State | New |
Headers | show
Return-Path: <owner-linux-mm@kvack.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A38ECC369AB for <linux-mm@archiver.kernel.org>; Tue, 15 Apr 2025 23:17:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AC1736B00FC; Tue, 15 Apr 2025 19:16:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 878796B00F9; Tue, 15 Apr 2025 19:16:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 47E886B00F5; Tue, 15 Apr 2025 19:16:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 053746B01F7 for <linux-mm@kvack.org>; Tue, 15 Apr 2025 19:16:50 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D751C16198E for <linux-mm@kvack.org>; Tue, 15 Apr 2025 23:16:51 +0000 (UTC) X-FDA: 83337840222.25.2F3C511 Received: from skyblue.cherry.relay.mailchannels.net (skyblue.cherry.relay.mailchannels.net [23.83.223.167]) by imf16.hostedemail.com (Postfix) with ESMTP id 8F57118000B for <linux-mm@kvack.org>; Tue, 15 Apr 2025 23:16:49 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=stgolabs.net header.s=dreamhost header.b=pg09XEWF; dmarc=none; spf=pass (imf16.hostedemail.com: domain of dave@stgolabs.net designates 23.83.223.167 as permitted sender) smtp.mailfrom=dave@stgolabs.net; arc=pass ("mailchannels.net:s=arc-2022:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744759009; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6FfTau9BvNuszvB4UDUEdiDHpoFoAKapXPdYyQlxMQo=; b=oxb87shbaQlZ837k3sqdj3TioXFMO0uhzWRODxPfQF0GlIAy6TP0jz+VgQgljmRXoEYJYX 7b3cvoct4zvayr55KpgyIsPR4whwRwEoDFEZWJRI3RjfGLk9pH4ABbaiKrqFxTNUi6/gkD UFu4//fo7KjJ4uFsNylAz3jdIIi6BxM= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1744759009; a=rsa-sha256; cv=pass; b=ioPsHeIJ4BpOTgrH6VOCGGFO6n7wCSboMe1htrWE76/VQ6sKAHz34bBSiKCVTBwmbS1bha Fe0fKynKKrePLmuJiQfppGQy8yEV2hf5jpV9KDpZa08dY6vGye3iAgyj1Y13I4jLfCICOV rGjhzWQ27PNo3b431dYri0MOxBiRdEM= ARC-Authentication-Results: i=2; imf16.hostedemail.com; dkim=pass header.d=stgolabs.net header.s=dreamhost header.b=pg09XEWF; dmarc=none; spf=pass (imf16.hostedemail.com: domain of dave@stgolabs.net designates 23.83.223.167 as permitted sender) smtp.mailfrom=dave@stgolabs.net; arc=pass ("mailchannels.net:s=arc-2022:i=1") X-Sender-Id: dreamhost|x-authsender|dave@stgolabs.net Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 7EF532C5169; Tue, 15 Apr 2025 23:16:48 +0000 (UTC) Received: from pdx1-sub0-mail-a273.dreamhost.com (100-109-60-75.trex-nlb.outbound.svc.cluster.local [100.109.60.75]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 1AFCA2C5171; Tue, 15 Apr 2025 23:16:48 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1744759008; a=rsa-sha256; cv=none; b=clEznkgPy+EiYjqUnRdlPY8Xp256oAtxLK8cc6A+4Gm0epRB7VXUfT7ExZGEN77rddkfpL e0bl49d7HoXQON5YjRd6det+et3bFtNO2oigtM0yRuu5IwLfEU9gYhtYrcdzfaV9Q3uvF8 9I3D6+u+VzZuHvbq2PXTYnvrOQXVsCYCF/HuFTa3bqHP+Q9NdEgX2tn0d9sUUmFl4/mEnW VXtgXvRQK+kCoaz2rMnLQkfJVcKiyHkbwgWX43W1hkg/RehTG6ZRBzHn5eeI14GOQ3+kYP EMl8S6uqzmsZ6Xl0cWOwY1E9fXMnJY6fz7czshQxgFpbhgXCBY+Cgpb/tpINQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1744759008; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6FfTau9BvNuszvB4UDUEdiDHpoFoAKapXPdYyQlxMQo=; b=nURM1QbZ8resQiKJZ/eyNe7DaQHlU3vRHyL+780WHcnXyDRCbixiPFP16n6TH0NhroRl1D xPpvLcNj3xrkRYbRF5ZcrQkgcllEchx6ElHLL4F+W8pqaOyGYSFqRw3J7PihrHE3M8xkOB 0OHAr+jP85LNrDg9+WvH7KNr+XAg7BO0d9eqgrgCy3N+u9Sy2wWBva6EZramdT5R0C8Yq/ vjRkiG3pzzJg3zuoCRcU6Iji6lFWh8YQq4Lc4aqFgI+QqZ7p/nGUpBGiKa5YA3/44Ji4w5 1LO7RSsVHEYHeJ4NKRhJinCQoPclOXybu4Ogx2A3QlPMRS+1YavkncfEcOpVgQ== ARC-Authentication-Results: i=1; rspamd-5dd7f8b4cd-xblgx; auth=pass smtp.auth=dreamhost smtp.mailfrom=dave@stgolabs.net X-Sender-Id: dreamhost|x-authsender|dave@stgolabs.net X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|dave@stgolabs.net X-MailChannels-Auth-Id: dreamhost X-Decisive-Whimsical: 522e76535dc1ed42_1744759008414_2568278399 X-MC-Loop-Signature: 1744759008414:2054462833 X-MC-Ingress-Time: 1744759008414 Received: from pdx1-sub0-mail-a273.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.109.60.75 (trex/7.0.3); Tue, 15 Apr 2025 23:16:48 +0000 Received: from localhost.localdomain (ip72-199-50-187.sd.sd.cox.net [72.199.50.187]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dave@stgolabs.net) by pdx1-sub0-mail-a273.dreamhost.com (Postfix) with ESMTPSA id 4Zcg5q22wGz2Y; Tue, 15 Apr 2025 16:16:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stgolabs.net; s=dreamhost; t=1744759008; bh=6FfTau9BvNuszvB4UDUEdiDHpoFoAKapXPdYyQlxMQo=; h=From:To:Cc:Subject:Date:Content-Transfer-Encoding; b=pg09XEWFvL3hZNxtY/VDXfDL5ZCooaIA8HYiDt/u/3oux4VT9K+jFGKbHmVcjzcPd grF69IcAdvJuY6lGH3U4/s2hAcRJmU4emU7ho9eAladkVMV0mPpiMQ8uR5VIcXeGhJ vbbiGvxCYpow72dtTdU44yfi998QZ3/xlVXJc+E2IaMPjqFmeyCfoXEL7K48GQTKXL pSLU0TMODhtWFMf3XokCIOdycNz68Q8+R1xTT/xebpBQXzL6DsqHIS0qi0JruhBBpq btnXHvFG5Gwle0+0tiyXuey0J8Wuxvx9iYVTA9cX59YKm57EnrjLMlceY6qH6Jozp8 338AqUh01jPjg== From: Davidlohr Bueso <dave@stgolabs.net> To: jack@suse.cz, tytso@mit.edu, adilger.kernel@dilger.ca, brauner@kernel.org Cc: mcgrof@kernel.org, willy@infradead.org, hare@suse.de, djwong@kernel.org, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Davidlohr Bueso <dave@stgolabs.net> Subject: [PATCH 6/7] fs/ext4: use sleeping version of sb_find_get_block() Date: Tue, 15 Apr 2025 16:16:34 -0700 Message-Id: <20250415231635.83960-7-dave@stgolabs.net> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250415231635.83960-1-dave@stgolabs.net> References: <20250415231635.83960-1-dave@stgolabs.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 8F57118000B X-Rspam-User: X-Stat-Signature: du9azxsweftep5x7gn5befau5gg6bkfp X-HE-Tag: 1744759009-785999 X-HE-Meta: U2FsdGVkX1+83Al0OwsXBNToafqLvTpwQfLFA+rfhSdU+5XO2lLnP0ZdzCjIjfLaWbzXrluS0M2SUQ643xwDM4G1CGBmq8qDIv2euQfxZt4qO7pcXju6pD4+JGIvJGcFivAGjr3Nu/ZKoxAk0HgRPTJVdXWrzJc6Ix9gtstuRaipbIH24awERsDOtlg/eodpZxcIUkvm6ROayqMtTOaMnrtt55G/w5JfKtvDm4oQ0HP9WwrsqWyh78NcT8Fb82r/IKMySbPkdLVgGccX0MxWQJXIJWXov1JblM9tO+AZ1LqY9oF5fmHy2w+6EBpgu0UryiJmDxaB20ILv8HOKeULVpcDhnK+YuJ9xeTHtZ7aMZYYfqUvJ39G+H3mfKQLI17geD+G/zcEE409uQCs4phsgBaqo+AMDLf7UdM9rhLrz1+ScywVfPMhmerFicrsYGZ75CdxDs7AFmpbXTSXjBm9C0eXyeR8leqwYnIR4RfHkshMhBDBL33/LV3z/5wjx9MqxnatgrXuy91c6xFfrrD1qnBbh+xk02c8ZLs85cj85ostSHgJOW1Q9rvAqZjM43PGNBXLuAZ/vOwzqAGOTd7Ig7O+qlJ4DfHNHlgPGYmEGa3/Tznh8+tlP5npADLgETCfNBIwjWr1G8gZgP5qFQL14g6qgbWJ4Og2hZnVaXZfY5SzbzFH9xKyvx6sLn4Z13hTN4fgIlR6GBLr+ikXKBckKK2UC9KFUlgopMeceEW6OYulsERhaWaL96PhAqbi+oQ0qSvu73PKMmlz0oM4l0zJ2CipobiOxTQ0OJgnyJZFQPw4Jz0WHOijd4UyIg6sge4sOASff6g+0v3tphkfBiI40+kqSk9bNCZujSVz9Ea7pRSGnEvQhkH7kI43a0gYyJxMEq/xn/y/3DE4JK3NfgW8mAD7RlOIRgceSnVe9GUFan4LXG2nHjOAfcIs4tfaQbXLhUUuaNgfXw13erycdyz 76YEOACQ pYKLXHdUwCDzQPBc/AKg83xbWGAk31/scQ53ukeER7nNEYLQUADpkiq/zbZYMUvqO/2EXMsW6kpuT2EpYrWeAI6dCGnoUSL5GMA2dHB/BhOGAyaip4GAQTsrwYZA9JuBLycP5mn5UisQxzOfqTVxrvlWppu964jP059zIMLtoxw9d2bAzUQ3tNH6WKiP59OU37BDMYigw/jw6jtRlIjk7XTH+7hRvh/w04bgplVYAFYJOkO0DvtbKehhbGvfQRXHRdFw4KJtG9uHrSFME8Depi7FStmzBwiOJiypzL753VKHZuApShOKHTA/lw01wwDJirH/F2FdhkK7EzyBSyirxjYmieNO81dqLNSOsCILMACyKnPBgTM6UngIQfVPwRFeQfdq8s3x+2zDtny8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: <linux-mm.kvack.org> List-Subscribe: <mailto:majordomo@kvack.org> List-Unsubscribe: <mailto:majordomo@kvack.org> |
Series |
fs/buffer: split pagecache lookups into atomic or blocking
|
expand
|
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index f88424c28194..1e98c5be4e0a 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/mballoc.c @@ -6642,7 +6642,8 @@ void ext4_free_blocks(handle_t *handle, struct inode *inode, for (i = 0; i < count; i++) { cond_resched(); if (is_metadata) - bh = sb_find_get_block(inode->i_sb, block + i); + bh = sb_find_get_block_nonatomic(inode->i_sb, + block + i); ext4_forget(handle, is_metadata, inode, bh, block + i); } }
Enable ext4_free_blocks() to use it, which has a cond_resched to begin with. Convert to the new nonatomic flavor to benefit from potential performance benefits and adapt in the future vs migration such that semantics are kept. Suggested-by: Jan Kara <jack@suse.cz> Signed-off-by: Davidlohr Bueso <dave@stgolabs.net> --- fs/ext4/mballoc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)