From patchwork Fri Apr 18 17:49:55 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suren Baghdasaryan X-Patchwork-Id: 14057558 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CA7CC369CF for ; Fri, 18 Apr 2025 17:50:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 220DB6B02A9; Fri, 18 Apr 2025 13:50:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1B6226B02AC; Fri, 18 Apr 2025 13:50:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F392C6B02AD; Fri, 18 Apr 2025 13:50:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D25996B02A9 for ; Fri, 18 Apr 2025 13:50:13 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 103C6C0AE5 for ; Fri, 18 Apr 2025 17:50:15 +0000 (UTC) X-FDA: 83347903590.23.830A76F Received: from mail-pg1-f202.google.com (mail-pg1-f202.google.com [209.85.215.202]) by imf06.hostedemail.com (Postfix) with ESMTP id 3C8C6180007 for ; Fri, 18 Apr 2025 17:50:13 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=zIcryJl8; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf06.hostedemail.com: domain of 31JACaAYKCEc130nwkpxxpun.lxvurw36-vvt4jlt.x0p@flex--surenb.bounces.google.com designates 209.85.215.202 as permitted sender) smtp.mailfrom=31JACaAYKCEc130nwkpxxpun.lxvurw36-vvt4jlt.x0p@flex--surenb.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744998613; a=rsa-sha256; cv=none; b=3TkAmooGB7xTExu+twsHDp52Ssfq1wjDG3UahEyhTvgLIstIpjh3jsnAK0dRMAhhLN6Eoe 9bsWeWGDIEx062Ad061UPUuRVhebc+i2jvll5AncI1zetGOwuZITzlC5Hq7Fiw8Nx3hifS lxrJ2XSpSOmlkelE1+ftbo30UJkeYN8= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=zIcryJl8; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf06.hostedemail.com: domain of 31JACaAYKCEc130nwkpxxpun.lxvurw36-vvt4jlt.x0p@flex--surenb.bounces.google.com designates 209.85.215.202 as permitted sender) smtp.mailfrom=31JACaAYKCEc130nwkpxxpun.lxvurw36-vvt4jlt.x0p@flex--surenb.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744998613; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HUB6q+v0EpFzFu3PlHq45yNrya7EC7jKKGmhERTYTZQ=; b=2Qz3kT0CxSMYDizGK8seKzD8Fvay6d7gXnyWVP6CYEHkofVQLrMWDhm9d+kA9yZq37YtAU xyrW9XBZOzGUJKs5A6Vl0IgZvwSRfKm8wYJp/wQLlVHuh3QkQd2uF7Aj+KJPhjxicUeav0 O3ZrLL+eVsPGcwu8layy8SJ3G+n8HA0= Received: by mail-pg1-f202.google.com with SMTP id 41be03b00d2f7-af5a8c67707so1320037a12.1 for ; Fri, 18 Apr 2025 10:50:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1744998612; x=1745603412; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=HUB6q+v0EpFzFu3PlHq45yNrya7EC7jKKGmhERTYTZQ=; b=zIcryJl8PS5jrBMTYk7L/V2XauxDTUcXhyCd9cKXMVHdEiNqzsD1CSVcpHOSbuMav8 /l5Qz1c9XUfRDUwJy9ls2CRWvc7OHUFigNwO0YV1v45e/iWtlc5s9/40hjS6DVE0ml3P sOzgUPsS2E+MwBwSdi3om1DWnfzPDJ3JSPdAf95OhZsUPne3J8ezYm7CUqzAjE7mBZp2 bBIdeKCnyLwSo/sLwAoNq4HUWTfANs4w/3+sNRU9jGMyT2sbr5goJ+ngDF/rMAbHkOk+ Fi5GpCTss2dBWx5dyCHBUzhI78wB+iGJIBJfIqkfxqKJxgAErrBWpXbICJFv6wVOn+Ax OxnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744998612; x=1745603412; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HUB6q+v0EpFzFu3PlHq45yNrya7EC7jKKGmhERTYTZQ=; b=o538zsvZyill0MGQNTEI7xJP2F5SBq4FJSQJVRvyYjmcLSEV3BUvjey1h2akZRxNFa PdtuebFeIZKhTHc2MfSiRmMsO6RGhFm389hYPQwlTlIgkozU7sy65TTj2EPaFSh/i94o IdzoGmoWn8MXuy0BuA7znoZk0l32ZLg+kn2U9L+Et1HeFbUvg2V3QCLzbcgwtHve+HwQ TBTmSw9qXzqiur+yup+hmfOr2MtUWbtJL58tLN6MdKCbFbODXjIFB4NRnUYv2sx/wSHD wkzcHsXF80dSJ36E8OYNKiSomIMPsJx8h7tRdpSzi/ACYh2WoXyYZ0i/IVpSD1EtobFK pROg== X-Forwarded-Encrypted: i=1; AJvYcCWmwU/BgPp2VycCFw/vOXO0iGlnFVkyuxBA0feB8kIfjuwWcO2qSEoN55gm/zXnp8SVaS9UGRC7yw==@kvack.org X-Gm-Message-State: AOJu0Yy8wUoBH08gAjovZEqPb/1jPucK4ZQLbqFqj2Nnq3HJPyO5fdNT QjZQskbmIz+8/9q4xbNV9LOhGf5LtufHzhdHGf2JSpfi2SpsIQ493KfqoYVeCZaQGPLScUcC4VS CdA== X-Google-Smtp-Source: AGHT+IGyaQr+2pZMSmPsh5wX1RoiROvtwBkd0HseqzqLOxOjXALv+e2mSSAlluxAbqqn3sMiDcQhj5J0Y/Q= X-Received: from pjbqx7.prod.google.com ([2002:a17:90b:3e47:b0:301:2679:9aa]) (user=surenb job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:2809:b0:301:1c29:a1d9 with SMTP id 98e67ed59e1d1-3087bb66b26mr5412483a91.21.1744998612089; Fri, 18 Apr 2025 10:50:12 -0700 (PDT) Date: Fri, 18 Apr 2025 10:49:55 -0700 In-Reply-To: <20250418174959.1431962-1-surenb@google.com> Mime-Version: 1.0 References: <20250418174959.1431962-1-surenb@google.com> X-Mailer: git-send-email 2.49.0.805.g082f7c87e0-goog Message-ID: <20250418174959.1431962-5-surenb@google.com> Subject: [PATCH v3 4/8] selftests/proc: test PROCMAP_QUERY ioctl while vma is concurrently modified From: Suren Baghdasaryan To: akpm@linux-foundation.org Cc: Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, david@redhat.com, vbabka@suse.cz, peterx@redhat.com, jannh@google.com, hannes@cmpxchg.org, mhocko@kernel.org, paulmck@kernel.org, shuah@kernel.org, adobriyan@gmail.com, brauner@kernel.org, josef@toxicpanda.com, yebin10@huawei.com, linux@weissschuh.net, willy@infradead.org, osalvador@suse.de, andrii@kernel.org, ryan.roberts@arm.com, christophe.leroy@csgroup.eu, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, surenb@google.com X-Rspamd-Queue-Id: 3C8C6180007 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: daskoxw5mwaf15f8n5kxjtiqik8rig8y X-HE-Tag: 1744998613-522631 X-HE-Meta: U2FsdGVkX1/CbnL5d4tOY3oPDcBgJi5jBDt261vFV56TYyqKTvOl2HSEFQq+NgjSMDwergqfJKSnJx+OIghTwd8/2kbUL3O+89vqURGgIgpThjAhIJcWqbD0NcNVIEFqzq26IBUhLAEnaYPcGjHG6dLcs2doYDpDa4SstqvepoNzre2rPUQkUqTDn+nhJcJ/XD2ufiaJ6NxTZk1S7AZ8bfxdEitmyadGC9Rhdb7Bpm8XPEdqcgLlQNK9yv2TwCoo+80w8aEkgTuoMIMqTaVg8+4tye7Tl6HIiFfKCzBMWV79Uty7mcRVcIidkSnDy2Z+wkAzFkw+xCDf9m7JruZDxJ1kIiwdUoPpoiHIcSgpZuFBN4umjDarMNcwM5JUUqKpiuPi+yoI+kg1ni1qFW56vKzQxZUeK1f0kQ3i9Lld3DGjRfcCgF5FzHKNDAkRODzgglkwU1dZhX6yVfwuLnOGvc2BupiYk1wkd1gkaJsqIsrVU+EW3ERvX2bobh6MMAapSGKSugywF42AA2FH9PqHbIc45Yh44UsWVVFfiKvAcQZylDufH+WZXVEs0Vi7VB9nt41F16PZMmH3Fs2M2Y5Jz821bgqEHvZeAgIn8b93NlVAcIwO42aNreqS3qFHy3H0Av0GFOXBmJUkNy9Ba8YdslwLr0m/ycMsFW6YumKhdLhC0PZrakT6f0WVZG2OzLcZrx+QliFs4pE91JbqPDGJjmcxGcexaYArs4mOF+XYsUuwAB6/mjY3JfKyfzSfG9+h5HxnPExUVuPwR/BYYgxZd2E+nUd3oGKKiz+Gd3q8ieYwA6qcfibfVJizwGek/jdSTBzb3802mC3Rpr/gx03heOblVCAJ5i+2GarC2k/Fn0uCaNBX15xEBeel8zZwsZZt1VlVRCR7Hd77pJSq0+82iR4CEoL5e1gHdteaLubTwuSLaEE1Bi527s7LrUoluKbp91BnuF7UE12WAXxA33i J1Vscps7 0uNijRTj3ZTHdyVfkWTdqzQguddFQU5uBZxT5dRgxNnHqmm3N7fOKbVv0qUFIU9WpJwRBrwfqJAJjP5GyaKFFag+Y+ZGmT00QSOxbQgivBUYl4o9YKlZopwsM6BDPzpbLM2wDIdYDPVZY77YgUDGiMyPHF1CTS2LAz7t3U0vsoiQBFjyqBgjraz3LBpHqdb6+Jq96o2BecTOGtcZt4xEQwCjrpEJE85KqnoSsma52qfUg5TSuQprAqEZwo0MikG1Vr763BfOi17Qn3+U4gm6WCZor3DHRIAnROGAQdxTutrgDixHaxPp0mQs9y3gEBNzciWcplNr7ho+Rcd6/0Drh3Y0HfXfUnSzDyUJnriVY9+cuvp/ZaYxjLZRqZ91WgpCZcujNBxQXA9lNcX0soB6+xzxKV+OYN/JB0d+gQN03jKYxPt2mPe+caqEioH6tbNkqokf28ylPgUZaliK6Nsfa1sg3btluElSYS4ik1sz7tWQp5CWoDc50IRIjhD9ea9YPje7X+5qVYr+zrkdfrw9pEc6oo1ZcwKdXfKH3kw3xZiRxpMFzAFETR6ysuiwx9Ylz2UdwvuSn/AjUfqBcA/DRAkhT+Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Extend /proc/pid/maps tearing test to verify PROCMAP_QUERY ioctl operation correctness while the vma is being concurrently modified. Signed-off-by: Suren Baghdasaryan --- tools/testing/selftests/proc/proc-pid-vm.c | 60 ++++++++++++++++++++++ 1 file changed, 60 insertions(+) diff --git a/tools/testing/selftests/proc/proc-pid-vm.c b/tools/testing/selftests/proc/proc-pid-vm.c index 1aef2db7e893..b582f40851fb 100644 --- a/tools/testing/selftests/proc/proc-pid-vm.c +++ b/tools/testing/selftests/proc/proc-pid-vm.c @@ -486,6 +486,21 @@ static void capture_mod_pattern(int maps_fd, assert(strcmp(restored_first_line->text, first_line->text) == 0); } +static void query_addr_at(int maps_fd, void *addr, + unsigned long *vma_start, unsigned long *vma_end) +{ + struct procmap_query q; + + memset(&q, 0, sizeof(q)); + q.size = sizeof(q); + /* Find the VMA at the split address */ + q.query_addr = (unsigned long long)addr; + q.query_flags = 0; + assert(!ioctl(maps_fd, PROCMAP_QUERY, &q)); + *vma_start = q.vma_start; + *vma_end = q.vma_end; +} + static inline void split_vma(const struct vma_modifier_info *mod_info) { assert(mmap(mod_info->addr, page_size, mod_info->prot | PROT_EXEC, @@ -546,6 +561,8 @@ static void test_maps_tearing_from_split(int maps_fd, do { bool last_line_changed; bool first_line_changed; + unsigned long vma_start; + unsigned long vma_end; read_boundary_lines(maps_fd, page1, page2, &new_last_line, &new_first_line); @@ -576,6 +593,19 @@ static void test_maps_tearing_from_split(int maps_fd, first_line_changed = strcmp(new_first_line.text, first_line->text) != 0; assert(last_line_changed == first_line_changed); + /* Check if PROCMAP_QUERY ioclt() finds the right VMA */ + query_addr_at(maps_fd, mod_info->addr + page_size, + &vma_start, &vma_end); + /* + * The vma at the split address can be either the same as + * original one (if read before the split) or the same as the + * first line in the second page (if read after the split). + */ + assert((vma_start == last_line->start_addr && + vma_end == last_line->end_addr) || + (vma_start == split_first_line.start_addr && + vma_end == split_first_line.end_addr)); + clock_gettime(CLOCK_MONOTONIC_COARSE, &end_ts); } while (end_ts.tv_sec - start_ts.tv_sec < test_duration_sec); @@ -637,6 +667,9 @@ static void test_maps_tearing_from_resize(int maps_fd, clock_gettime(CLOCK_MONOTONIC_COARSE, &start_ts); do { + unsigned long vma_start; + unsigned long vma_end; + read_boundary_lines(maps_fd, page1, page2, &new_last_line, &new_first_line); /* Check if we read vmas after shrinking it */ @@ -656,6 +689,17 @@ static void test_maps_tearing_from_resize(int maps_fd, assert(!strcmp(new_last_line.text, restored_last_line.text) && !strcmp(new_first_line.text, restored_first_line.text)); } + + /* Check if PROCMAP_QUERY ioclt() finds the right VMA */ + query_addr_at(maps_fd, mod_info->addr, &vma_start, &vma_end); + /* + * The vma should stay at the same address and have either the + * original size of 3 pages or 1 page if read after shrinking. + */ + assert(vma_start == last_line->start_addr && + (vma_end - vma_start == page_size * 3 || + vma_end - vma_start == page_size)); + clock_gettime(CLOCK_MONOTONIC_COARSE, &end_ts); } while (end_ts.tv_sec - start_ts.tv_sec < test_duration_sec); @@ -726,6 +770,9 @@ static void test_maps_tearing_from_remap(int maps_fd, clock_gettime(CLOCK_MONOTONIC_COARSE, &start_ts); do { + unsigned long vma_start; + unsigned long vma_end; + read_boundary_lines(maps_fd, page1, page2, &new_last_line, &new_first_line); /* Check if we read vmas after remapping it */ @@ -745,6 +792,19 @@ static void test_maps_tearing_from_remap(int maps_fd, assert(!strcmp(new_last_line.text, restored_last_line.text) && !strcmp(new_first_line.text, restored_first_line.text)); } + + /* Check if PROCMAP_QUERY ioclt() finds the right VMA */ + query_addr_at(maps_fd, mod_info->addr + page_size, &vma_start, &vma_end); + /* + * The vma should either stay at the same address and have the + * original size of 3 pages or we should find the remapped vma + * at the remap destination address with size of 1 page. + */ + assert((vma_start == last_line->start_addr && + vma_end - vma_start == page_size * 3) || + (vma_start == last_line->start_addr + page_size && + vma_end - vma_start == page_size)); + clock_gettime(CLOCK_MONOTONIC_COARSE, &end_ts); } while (end_ts.tv_sec - start_ts.tv_sec < test_duration_sec);