From patchwork Wed May 31 11:50:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johannes Thumshirn X-Patchwork-Id: 13262045 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D022C77B7C for ; Wed, 31 May 2023 11:51:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DE8CE6B0095; Wed, 31 May 2023 07:51:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D98DA6B0096; Wed, 31 May 2023 07:51:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C61118E0002; Wed, 31 May 2023 07:51:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B77516B0095 for ; Wed, 31 May 2023 07:51:16 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 81213403B8 for ; Wed, 31 May 2023 11:51:16 +0000 (UTC) X-FDA: 80850384552.20.1EBD0EF Received: from esa4.hgst.iphmx.com (esa4.hgst.iphmx.com [216.71.154.42]) by imf25.hostedemail.com (Postfix) with ESMTP id 750B0A0016 for ; Wed, 31 May 2023 11:51:14 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=p7r46pS0; dmarc=pass (policy=quarantine) header.from=wdc.com; spf=pass (imf25.hostedemail.com: domain of "prvs=508ef2a02=johannes.thumshirn@wdc.com" designates 216.71.154.42 as permitted sender) smtp.mailfrom="prvs=508ef2a02=johannes.thumshirn@wdc.com" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685533874; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LoQ8onSwPqMBI9F4akjRcl6OSdc0FEMP1YnPrAl3eBs=; b=455j48mf3aDT0TXCVh7N4Wey6e+i/UQMWb4YUK1ueJFrvw8+109TqYFV/yP0EIcHDsPW6s jJbJicBBeAijEeV4m+LAqmkWL47cSF0Q+b2T9hoptIcfrl7YrTjtWrwwLHmqzw+sFCz9fJ /6hYELIKLJPC9wpLM+nbpGDJQQQqQeg= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=p7r46pS0; dmarc=pass (policy=quarantine) header.from=wdc.com; spf=pass (imf25.hostedemail.com: domain of "prvs=508ef2a02=johannes.thumshirn@wdc.com" designates 216.71.154.42 as permitted sender) smtp.mailfrom="prvs=508ef2a02=johannes.thumshirn@wdc.com" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685533874; a=rsa-sha256; cv=none; b=TSKLlRlC2gG+bYed5yYyZIl1GG7l9tguaJYJeBR9AzPZBnIByvz+2w8djekhaT/C9Azmza +fkdZCdSM5gz8d6zFh9/ErXJf3mY7oNBIytVSdy8P1iblg7t5iFiFxB4j3VUHoNpTXqGS4 DopnNs+5vayvze7lDZ2qUi2kYQfFnb0= DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1685533874; x=1717069874; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=k4a5Zi2GAZJPJB4x28jGupVJUdefs0tR8+WNO4iLVd8=; b=p7r46pS0rJ8Cvq/JeqaPZunBWGvUlRvZb3lFSE/6KjSqKin0PjfQErd6 t2l7k8/t9xKCw7tiCtQDPhy+j3BEy351LOk5kTX/m6ptpMyahNobfZsSB P2BFN+itMcH9LzDztMb3eeJt85rsAclDIEuVK2UYlNuHeKTAfbrspzugp cgmjJjJGQcoisRQ8yEf0ply/m2OxJW+i3vaG9z7BIL4AvaT7kG9bO6nh8 JFwHnJbh0SKWAPKGkBEwabdTw/6rhskONkz8PnqXNai4H+IpnvHhNfm6B eCPoW0unLKpR4zPjvVt5/f/41rcxubpJG++wD5H6aKGetaP3ig4gQyVyR w==; X-IronPort-AV: E=Sophos;i="6.00,207,1681142400"; d="scan'208";a="230207414" Received: from h199-255-45-14.hgst.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 31 May 2023 19:51:13 +0800 IronPort-SDR: XT1RvUtkeU4Jm6lqVzh6TaH1ONFSVkIM98N6Io1U7wsAipCpmLglbngGEegqV/vZnwiRczAuYX ueOkZjMaFN/gXeJfXckft8VlYQBnHiZxkuCMda/bkWKvyi2O7bQV+GWX1VUWN8V8B4xrms8Rj3 5BEju7xBGZHc4FEvUYT0nl64WsmS3m7Od2TtCkqC4Et/aFpglDcR1CjbMSiDkH22lU3A2lKiKD +ijX4ktptbgJP+gPac8Nx3mVIbA5MTiD4PteE/am12j5UQrSINjh56MIiRdCFsVCAVrDACsUYu UY0= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 31 May 2023 04:06:06 -0700 IronPort-SDR: xjFPRUk9Ifjou1cDm0luSpwn78hU9nM+Uh6/lNHb7tmpL9BnDcAHIBz7pRZNu+Y/7vgJ/Ez6sY RyJ/ivLjBW17l+dotn8hVR30logKnTYtxKcJUpZjXM3pkCCTww+Wwx1Q95GuK0KwbO7NqPBTzp ajKcCB7MvUhxXFY/oUZ+zxu7dJ2H1FZ7EusH398EBt4EExQgIH13eoEhJohKwTP8QoP4CwoW9U kzYp0zCcFcq66GRNaEJVSD6lmZnBsL7SZcjVd4x99hRY1Fiv7ecOyIyY8X6ND26gRBWXJrsssH laE= WDCIronportException: Internal Received: from unknown (HELO redsun91.ssa.fujisawa.hgst.com) ([10.149.66.6]) by uls-op-cesaip02.wdc.com with ESMTP; 31 May 2023 04:51:11 -0700 From: Johannes Thumshirn To: Jens Axboe Cc: Christoph Hellwig , Hannes Reinecke , Chaitanya Kulkarni , Damien Le Moal , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, Song Liu , linux-raid@vger.kernel.org, Mike Snitzer , Matthew Wilcox , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Bob Peterson , Andreas Gruenbacher , Mikulas Patocka , gouha7@uniontech.com, Johannes Thumshirn , Damien Le Moal Subject: [PATCH v7 07/20] md: raid5: use __bio_add_page to add single page to new bio Date: Wed, 31 May 2023 04:50:30 -0700 Message-Id: <27e6bcd762354bff74602e89159cdd12ae3d1fa9.1685532726.git.johannes.thumshirn@wdc.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: References: MIME-Version: 1.0 X-Rspamd-Queue-Id: 750B0A0016 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: jfzadtih5g6zgtdntyw56bzd699cbnkb X-HE-Tag: 1685533874-345016 X-HE-Meta: U2FsdGVkX1+NYSDzxHCVabvdljghMa+kpZbXZBdDXP2lnv/y/eiw97DuVVhu2s8nTAahw9XWK+J9kQO8jflZ3ToSRWByUqYAbF/N1Q5qWJcxlZxtjvOt7A8xujkzdKWp4LB9Fwu5DYqZqsMSQRUAttEKtO7Kq+hNVp1qePGlh3+dEpLZRXumkrve4ZRWbLgpe8MFTWn94tbfwUgB1fr8BR2FR6e2vcHnr9FXI4O6KlsYA3nVWnK/CiUjWSs+IhXcDEdVjL0w3ld6ePhPkX6ik24fDCH8BwSRt2Pb2uc4EJKCwSf7hWSm2y6Q+X/l9vRN3GR9kgAdzA7eewqE76ff++XyziMdm2j8oyn6vvgX0bsUFaDg7Fs8pFZcHwe7u92kZ53Bh9Ze1Ak5KYY63ekzAoH6vS5f+jXSSMhozZ2MJ06xaTwv+TUpS5lmgNxqVWU8VHPNOw85z7sTeoTadpZdXEYH6eFOEYfh/MxNNtj/cguah1VXwUYLMDDmT4e8NzuyqJbCHUbLNIgp/bFYT4F/8B4HPI8PmZy34vCq8i6UdoiQBVFYQx4pklqNmnhNT5ivcfFiPlzR8GJZxqZcR96tmpDtDqbQTwJqn44Bk86LJHmgMXNlVYglFQR2Qf/7yRWjT63OVDJRdkY86xQtdlwWD6fBAMAR9IPaRvFbT3cuEOkcjZasNNsmwpL8JAYZdcJYmApqv28BBhbKYM3LTBl3Z/IrXnBCQ9g5xBlldKU7sCHBSGe7kw2NDvvHk/GkW1yKv/SBYoR8rEsCTNl4ODwVCzsOHnf8uFWxEL495ypH1M9vRZuCrgBwcpLCFqKG7OgTjjmRwivGxAivcpuWODkE0EkF0ePRQpbq6S1WuuY9d3rRyQNdJFyHXtzQKFYlVqfJebUNYssaqTehGtdEgGRJ/A47UuveiZHNZkUxB+QD4Q4YtlEEPwyMgTVChw0PA06L9lGmFzINKkjycDbcAXR oFa6sawX 37+m9wTHKMJ9TN2fpmuY6e+55K/DxtlzSWTo+O40U1/twAnvbohA2vvCdPOaTOCX6oYTj/FfP+bnXivPoeB0xz0xbcwRtvX9fv5eeGVXmrUpDHI9ntG4UogCYlDAx2VC9Yzt+fnJ6AkxSxZojn9z01lGA9ehJiiajyUiUZTiYdBHeM4Y9b3tndVmv1jWw8XDZOdvBGAGruFjbzOq6DN47RuX5f+TjF5QZOG6KtdzS76Eu8h/lxZf52gfjpdCiNXY9FhsQHPqmff/71Ny2lLk4UJgw0zMQvwvihBEw0VeNhv0Yp2WxP7sfzvoVYHXuiFdatyAEpNaKid3n5F4EhOun3w1iDxH6BIz2TZ4ww60pg1RFiNhZNzU2Vpf2T+vmntA2/VCQkiMQH5IPAgJOcNUj0HpNLFuO6Bcbp8y+ClITZOp/6bmTkZbO0j5v3GsC8c958q4vUW/XbIYE17s= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The raid5-ppl submission code uses bio_add_page() to add a page to a newly created bio. bio_add_page() can fail, but the return value is never checked. For adding consecutive pages, the return is actually checked and a new bio is allocated if adding the page fails. Use __bio_add_page() as adding a single page to a newly created bio is guaranteed to succeed. This brings us a step closer to marking bio_add_page() as __must_check. Reviewed-by: Christoph Hellwig Reviewed-by: Damien Le Moal Acked-by: Song Liu Signed-off-by: Johannes Thumshirn --- drivers/md/raid5-ppl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/md/raid5-ppl.c b/drivers/md/raid5-ppl.c index e495939bb3e0..eaea57aee602 100644 --- a/drivers/md/raid5-ppl.c +++ b/drivers/md/raid5-ppl.c @@ -465,7 +465,7 @@ static void ppl_submit_iounit(struct ppl_io_unit *io) bio->bi_end_io = ppl_log_endio; bio->bi_iter.bi_sector = log->next_io_sector; - bio_add_page(bio, io->header_page, PAGE_SIZE, 0); + __bio_add_page(bio, io->header_page, PAGE_SIZE, 0); pr_debug("%s: log->current_io_sector: %llu\n", __func__, (unsigned long long)log->next_io_sector); @@ -496,7 +496,7 @@ static void ppl_submit_iounit(struct ppl_io_unit *io) prev->bi_opf, GFP_NOIO, &ppl_conf->bs); bio->bi_iter.bi_sector = bio_end_sector(prev); - bio_add_page(bio, sh->ppl_page, PAGE_SIZE, 0); + __bio_add_page(bio, sh->ppl_page, PAGE_SIZE, 0); bio_chain(bio, prev); ppl_submit_iounit_bio(io, prev);