From patchwork Fri Jan 31 18:28:58 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lorenzo Stoakes X-Patchwork-Id: 13955658 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD54AC02194 for ; Fri, 31 Jan 2025 18:30:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6D2D9280004; Fri, 31 Jan 2025 13:30:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 65C84280001; Fri, 31 Jan 2025 13:30:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 439F4280004; Fri, 31 Jan 2025 13:30:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 1B91F280001 for ; Fri, 31 Jan 2025 13:30:33 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 728D5140FCB for ; Fri, 31 Jan 2025 18:30:32 +0000 (UTC) X-FDA: 83068587504.12.DDDBAF3 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf13.hostedemail.com (Postfix) with ESMTP id 1283E20022 for ; Fri, 31 Jan 2025 18:30:28 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=OSPatDnR; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=qmW3qbaH; spf=pass (imf13.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738348229; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=APK9TXKHuRez9Uo798KK+h4eWqVx6akEX3HBP/qF1nI=; b=k61PUU34bjwl6FTTSxQeZUPKRdGAUBFA7jX2oJ5Rzc1L1/m3UDf1NU2fnozllch/xS1T5q nuhDKOXcV0QMAPO5Iks/RtgoXG4hsAHYnUc9rSVD2d7H1rW92tfm5L6jtlzwf1ZUDWUZaY 66VYWGf9em7Nkv55RA3eqs1/tZWfzdM= ARC-Authentication-Results: i=2; imf13.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=OSPatDnR; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=qmW3qbaH; spf=pass (imf13.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1738348229; a=rsa-sha256; cv=pass; b=YTdhsK93Y19uvqRXbf1BqSfGg4loQpX5DiBCxC+XywNqc0D9TDYwyMPUlix1IADk/bdtaf vQldnEes7fiJKym8o9/WMIKU4OT+EgUDuRKouRG3AEihO2Bkpi6uGb4F9Zq5Bs9ZopdgA2 hPNADgVpPL9lStbeHxybYiRyCML7lxs= Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 50VI7SiQ026914; Fri, 31 Jan 2025 18:30:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= corp-2023-11-20; bh=APK9TXKHuRez9Uo798KK+h4eWqVx6akEX3HBP/qF1nI=; b= OSPatDnRo9s1dyPc0cYfaviyKa1LuAES/SdhoQY2bvLghQZaRn0+67L3PNZC/u8b NxWn6/kwwlC3JyvXW30viiJEcn12Mm6CMW4HqUWubQVrJ6KOxiYDETNPZ4Dm6zQD dpQHyeUt2dINMQIBT0qEHzP/Ccz7kRB4R3iuJPHzY/qLMNei3dwVdig1AkIrU11d ZoLxj2DCTV0XnqbQBonnmawvQfRDPhyqzpQKPVIax5SrX/TJxYbIDyX9UX2fdvMq 7O8Ns+sU9H/Hsvjb3utfIjTKsNKXMFDBw0sVHSErhcHDrxYzS+/NS7HCzNMorXgU MkOT2RCYsAa6YPlglvQJkQ== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 44h3gh018b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 31 Jan 2025 18:30:08 +0000 (GMT) Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 50VGeuom004104; Fri, 31 Jan 2025 18:30:07 GMT Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2172.outbound.protection.outlook.com [104.47.56.172]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 44gfe59ceq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 31 Jan 2025 18:30:07 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=YGR97mi8KHZfdNmZABuDSYZ8XjBrF5BWxnUEdUIxwRoZ6vQcUVw8cVlfzWAkQvg0Ub5h/95csS0os5vy1dcEs261cIrwGo3ozTG/Wea9XifpW+UDfg8SLoMZiyDF+XmOltJGCfpDZZT/x/M1qYvT71/5WeMv6KiTHjA9zqhxNcJfI92aAnAZH8DECt9K3azXxJ4DJqoCGIAdimQbZQutLrISLxQWcJLxfXvluOdUNmp44+y8N4fN337uXHV2M6tX4XLAp+p4jKbKy6nxS5qDrmkbOSk5w3FSXspmOoHDxiJ1FCkxTFl+x7ePr9iMU/qZ58UJW8wsoZczLkrRbITAqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=APK9TXKHuRez9Uo798KK+h4eWqVx6akEX3HBP/qF1nI=; b=hYY9Z9emlk1fjl65+nnLtTY5kkcst7/j2PrazQ/Rc9FkBVmi8Ez2eTS8QHPApYI62ArtWv1ENqbd14705H+zOh8BKShyDB2JyRMcsDl0oRzHMaCRt2Nre6L6sNJPbI1QUDw6tJrVtONnVMJihd8ZediRJ0mKZHvTWmHqdnLxWmi7M2+3BeOVcjD8IQHOWOSacro/bJcsDiIsDC7gpUaM07p92l+D8OLonjFdk6Hm+5friJ07uEtUKBBI2Q7WRb8iMI7h58NFCnMffh00tq07gycGTfu5yxlo//o8q5WMfCucNohOjvo69ZxewTfwU8w2s1PInAXjien85nClx3Uf3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=APK9TXKHuRez9Uo798KK+h4eWqVx6akEX3HBP/qF1nI=; b=qmW3qbaHfnzBjKUJGAmLZ2RUpO/Ob6vIu3aK3Q9ALwnzrGhPmiQ6lXwRnWy+Eg6zYUCilrLGoJde9rEu6F62FuP6utiE6VOYw4z92pVEjsBkTWYcyKeI+tZcmKkIIESc1F6lzKJ1xC9xgJg5/ucjMf60kyvGukOsm/rnYToO024= Received: from BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) by PH0PR10MB4407.namprd10.prod.outlook.com (2603:10b6:510:31::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8398.20; Fri, 31 Jan 2025 18:30:04 +0000 Received: from BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9]) by BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9%6]) with mapi id 15.20.8398.020; Fri, 31 Jan 2025 18:30:04 +0000 From: Lorenzo Stoakes To: Andrew Morton Cc: Jaya Kumar , Simona Vetter , Helge Deller , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Matthew Wilcox , David Hildenbrand , Kajtar Zsolt , Maira Canal Subject: [PATCH 3/3] fb_defio: do not use deprecated page->mapping, index fields Date: Fri, 31 Jan 2025 18:28:58 +0000 Message-ID: <3542c5bb74d2487cf45d1d02ee5e73a05c4d279a.1738347308.git.lorenzo.stoakes@oracle.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: References: X-ClientProxiedBy: LO4P123CA0151.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:188::12) To BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR10MB3366:EE_|PH0PR10MB4407:EE_ X-MS-Office365-Filtering-Correlation-Id: b0668f92-48bd-435b-4b67-08dd42254817 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|366016|1800799024; X-Microsoft-Antispam-Message-Info: rsG9tLlraMra1fOSdJk/zz6xaXPNxnCErH0ACJwZkkbVRXmC+XDIF20qZXi3ELIM6mXO+bUEf/aajo+JvvNZMESE9ZCSy0OTnEcTnK/lLXDRsadZPF47VmsnMD846qZMHa3wU+o0bGkz95EAAIcjfW2kEYMQMiQtA/DkwVaIIzIPCwjqhkWw1MXXB32jp+xw7iPUV4EdnjJPOtimw//kyayHgOZtdGn2VvZUF2rFSYgvAwrSB8mpBx99cP/TXJpdA6JpdxFZ87qoEDuxTvC6zfSB1htwrpKO73eyIp1osEjre4jK/mNP6eYqbCzEAI+/VbI7NF1puvhRxuldMxNckIXj4nTc9xw3SeZvav8kR1qPnVD4yyYO4XUWfjz+AMjrzHWofrXwmKl+32drKvAUeo/csbYBumMiP/CkD8W95k2/jWZp1epbjyNKZ8JNzW+E+SHgdlTyL6U30sUikdooFYhYLAe7qIw3EY+XoVCSy+zwo9B2UJp4qDuMXTKG8B6v+7/0i/v9HcJ9jGHrsZSkNF4UIGFRAj0OIn08tR+hNJaqAg+99KaPklN3rXfZs2kuLvcwJJWWHlkiPf0qTuWRJ+DSP4Jl/SSF1JzLXmIGZcUMfFraPuhmGKVCBWYEk6i6s15sf+99My7rZK0M484YzMROKsK18GZ/60k/gr3IIp5S6xX3Y58PlIl4P+v4EqkH6K/UNsjp9eJ2ESfXc/LmsfhoCeEXTqq15RK+4PJ/khdo4Tu6VxhyPkJiUwsUdBsBTe04Iy+QN5mi+L9MbudO8tm/bV5yAV3CohKeOO+nnGVk5K/NjQ+Be+oa+nK8+7ZKpnIgaJXYoE7OhgaPcITLT/8G4u5yeIcC2DKQQhd/e3TLeZCat5JUMEqJcA1itKowlLBMn6pvelh4LweHnTH9YmoAWCwV40t/G+s40vbBxYWcTx2FmpURDmVlX5rExdrM8soMkm1MAvZ/QJf0UsutgemOcWUIgSbeRtVI+mMjJrb3npmV89hBBf7MOIqP4TBdsGDthhB1wY3ulVJmi5D8VdERr+6xbHAT1AStLiDQGVFdw0nzrjrLtUDDzIQnY58z+jltipjO8yZzCXxvLg25JH4WwHCFyi9jyed9QiIpVP/gq7JhGKv/ebMrwQl/41HcjGl9SvZ34yMklk8PnZHU/yU4Rm1T5BYvS8ZnYvPBNHktZRXtNEt6FsRXR18G7OQLj8NK5afwjufKdaB63uGBZmCKxngJg1CCoyWPwZRTZcm7cUkJrWHCExnUDlTfkmJnCRBflMu7d6KzS3uyQE7xUVvxdwP/mIXX+XSixxKsKBCV2wiKAk6GdHdSddvDYnWE10HJVwHBKqxd8JvByN4yUNyKCS4waw8dDHitC9A6szA/gPoz6ZhUUh7B89zW4YA0 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3366.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: StAIoSLe1C1AS5CzvhW6N2BYlP7IyLADJ3wgIIaBQ3EbbCxql3/mpzwgQVqEUtW4WQAXMYZp+LkUI+OcvyR+AKtqm0WIs9ZtShpTlN1tS+40F9iXxf1gFZgZdJ/qZ1atJWHS4WH98/MnlE+CvBcHlHmykQMzMHIZunW9tnJiOSW7hdsWl5oFpo1xjJM+fIM37vjfIyEDBiZwETNWEdNSfN8uIT9+uZM1ijjEuX8uq74Mw9kUpS1ISKuRqXpm0Q8Jtr8t2i7BXkpfiaejSOTeKr4RKI+knCLWNRQ9oMfa+eBzxO6LNg6+n8SYoHEbfGERuDsD9c8PmOhGPus/k9tZ9Dm8XY3V93VdbTjCDznlGPq8mFXNXfIOuNcyn6AnjH1wJdZJDgW48uPTx2nRtamg02igSHltnn+gSZ1+rhD3ZP3zjeT2kVvlXXZ4pj/usKhE9gto22qFnyrNyoy/k1NJkqlljdE55xhhMzt8smf7U0TIAcGGZBDpRmjg38TZBRMcYTOZWor4AqMTA55NdaDqiFeGLXQ2mg8kEVLtuszadZPcFTRQ6f14+ru3L8MNr+WaJjhFLfi+pKcyvXXSafGhNhQBWKlHpieyHL5sFP/BQykqB590ObaqxsSZiJHzHGTMzPvfBNijTA8fVe77kvA/h+XIIX8LRBRwdmbg82KVcXv51QeuJ7FX+RMUCbkMYfFb2otVIJu70s8JVeueJhctIDG7UoIbBQ9RFVuxhqMWLHqD+JZK8TR/qcblS9fxhqU6G2P0rtt/CS7RbyKudXMEzE+NqNVs9FbG64aijy0FG3iZYGfKJc1KR9AjobldYyfiR5O0iXlDuMCB8ZcpkkT8/0teD//iP2fN0bVBkU8KcO1Fr9gzaHWyLnB13F/DS8YlGOOsl197beDgJoVZACXpwpmVJ1LFYAobTfZxw4Mv8POTA32JJ7FOLHDNyAgLadhYjh6CR/rPrvmS6nuJHeQhFZ3EnmZWVin8FqAo+fh4QucgeNyqqfG7gl+EaqHAk/+43ZLudtIXUcTWGi8aANLErtpD88X1seLAuXzZumm9v3Ge/ZHXEFBSarujtI1xlSP+8fjJv2k1eTIYIlaVAkTTHbTAbF4DH+VddQat8fjckY2taHDIDMo8yrUVN+MiFeaKyHA95e+HjKbVN8LxTdySq0MrdYAaGrGaWnT1LY3GOXc8/q2MhgR/Pvm3Ov8JxwIImqpmjd0kCI2E9x2ws0u/ItgSiUjAi+H9SYOlP7ABpZ6r6LZEAhLPnR8QQvcjM+A8KZRTPNSzrbY7HIZyax87uGLbuPydtARHMFvOMoFbXLjs34tEYMEqF1nAxUGhh02noA6vbUMxoTScobY7CemmxcCVRW9Y+DDWFl+wggQwrdtwhNnA+CT3HwMNmW/uUj+eAEPbZH1MjD2pbpn8ws0VLNdDzeRMRY8GBCDd6UyZwdidWUAFt6d43c47Q+diRNSmMpTTnDLukGJJfZLhJZuKvgsuqpDpJqM5sZoaKVjNWwuP4DD0vhwiwhH3tk0UuKDBxrLswX0+cBY/yGaERrZ1j9QyLBkwWsCtgBMzqUqjJRbPc3cyXiCrzzotKRnDd6camlzKxsYoq98LysRFkfW3Kg== X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: BqkFdtTZBNp5KNNdMPsamRRgYfPBJ7nFWCfnirSvyJn7g/qa5uuQUcUqSLbJyFwrJT4+o1AlQxDtHG1zrL8KRUjZrDTrlN/HSkDSLzv1E+CXFvygqPYy24uy5qujG0gAsdaeYiqRsW8Tvg9+ieJuSNobNrKM5LzoMagWruKxt7In/3UWIocgPGvlFNrlchG5iTdrcObQerwwXUzOwTMOigjVM2al1EE3Xujv+cCbXVOA2ILK92CESmvBDtan4e6pEEAAwzrPcFpyNOKPsogfz+P+C0HwBCPj7Oxn6IMAYeK/tKsoJjLMv/64ClDw80rwtcWwC/eDnP7cxiP/RqXIJaUoERVt6si4uHvYJXfTDERPRblbXiWeuctB35AW8OKXEFx0sCoX50Q34SQs94SaimtyENgQ6b3HV7wY0ATAFtP8ymVdbPwFAJU120DQUmgnDnaL+CdRWUK2khFvgzuDStnhiPXRrICOiTEHe3oKZo9wzgtlo8XucMG7Of85kPggF+9meAnYtDmcU18lDM11CwVbckA1n3PBkc/iZOn9qkalpSsSFKkw32yTLYbzhacycd2KnW2z9YiaIW2Hmlq9hZZmzTz95mjT8NMgHMb7V6U= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: b0668f92-48bd-435b-4b67-08dd42254817 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3366.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2025 18:30:04.8050 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3vfn4+cHAhHrTO0ecdLEajCSYELviMv2yYmFPN3OPBuISEsojEHgILhRdP7ysjQp6q1IvU249a3Rzrb/pQhpgU6gw8YwBPcoKrW67ziAieM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4407 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-01-31_06,2025-01-31_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0 spamscore=0 phishscore=0 suspectscore=0 mlxscore=0 mlxlogscore=999 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2501170000 definitions=main-2501310139 X-Proofpoint-ORIG-GUID: 6gNRA5KC0du6BI6IYLCuvkP_aH-qWYUj X-Proofpoint-GUID: 6gNRA5KC0du6BI6IYLCuvkP_aH-qWYUj X-Rspamd-Queue-Id: 1283E20022 X-Stat-Signature: sngjin3cwi8pfgp8f6coujokycsh91zg X-Rspamd-Server: rspam08 X-Rspam-User: X-HE-Tag: 1738348228-457385 X-HE-Meta: U2FsdGVkX1+iH49gjoIBCKaorlxY111vs1oEtI6FpEJjIjO2+NAV7Py6zhtnDEPtdwmXSQiEyriEiEHYkFrD/lEQnVfZTd1tuZuI6b5Ex4yoFQ2rr68Y7bJIn0CFuK7Jp2TZQpaAr/exQLNd6pWczmVWZFWttRbCHul1Imw3krtM2f2/qKfbU/E0+bfqMvhm95N4korJm6yS76J9BS2ZuiZUffu93arC+pG9fMaiTGMcOcpirzcQ9fEfR78ms6sMZlztEu5hYUofgvTpVCb2kqIRuw1ey4eNJQzxUIIoUTFvlNM1gwKxEewrDQHqxK9HnUE1V28vPyVUZgIRikaGNCfIQfq3ISt4X99/dsu06qpWxbdwC6z/CbXogZUc6wd0SJtISkrlbolU7cnolrr8hOp4t9e+fgDkEDSdE3VWgGK9862r59YHJyWbFNEPEAC98dK3wvhNDvQ7QM6TKVpH3FAOgtZqlXsg1IGPw6OwSGdIjeXiudXvTLNJH38onkpYTNxCBXNVo2pnimuhhDWlR/Lq8uiii5NFlQ98AFTZNzceyQDr8tyx6XsXQURnO1GAk9E2ow+YRtZDZAUj8dZGiu+JqmEhCgPgYwdMe1ATWuFMyKSKh0fYwKu6d1i6MyIZRphM1xqmyrNYbe/0X1IFkXHOSOmLZGp0VEe8L8rFhTheTlUX5LFIfwumajbu68z+rUMowZrmrmUqwVoHGdbYNLclcBb7CK952hKE2kmg2ph5kl8kV1VCfMl2s7MdD8Rfdk/OH1r5pIPlaapv590qZRQStNlG5UiOz4Dcw5mAcoPvY36g5RH4Xk0KuQAk5hiZr16jDZ7KQe/HIjIjPXnPksWWsfR11H8Mact8NtbVdeqTOBeLZwfv07O92GEVp7FuZZzORQb5K3BVYpjlF9A+vAmj79zslbn6K425EL3ciEEAEJrao6NAM8UzqHYBZN1AUykLe1hjVutkg5iXrkn 1NITQpJl mqGWuKKoe9dYUJtYATeHT2fLwzzGqfu/WgUm7Aj2nBHMenPiaXJbaT6vamylNdpgU/eCCl6bs8V6xjY6PC0b2mQfK0cF9Afvy3otgS+bk1KSuZMfMAMiNQXyQ7vk0EWBeTV9fdWMRdmUgCvAXo+JWPphjBfm7z77KOcszUbCq3Z3CjTvHsnBC4UDIQ5PMWFijm4YFSBZvaRbUjMs9Zxj/geRbXJWY6jBy6CGuv8rAhn3kJ6dt8Q09ULNVvGC0rUlh3NnefAX2/9Bam9Bmvx+dyCe37hwFMAPKcKDi0dkXlA3aPAj2vkHSB7jPMA7VQY0CAt1V19lkRYpkP8W9AKEYi/86mntAYuMw1Cmoco3B1df1whD2klhZPCeiiL5YX3N3XKUgmI9ZC7zwoRvhUYCaXVyrFddQCxmsTJIWjstIm+rvZ7c/mDovuob58X4ack1PAXhD5y0Pf5lJmn3EB+JBOekTW255hU2NMyml51Meq7HXXa/H0qXW87nfy80TWNVKAInM1vtLYyjIoQm90uLbvENVRxn9f/0QQBehAIEdlxqUq72x0OB10TrXZVlk0NYQpZO0mohMVvpmIm6wafd6+AZGpH6JjRtu/9wcbKN5dq7N7l+/NtoJ6oQK9xfaLDdO3+EtLvrgF/D5VVpF1a3s+tMojTlOWhXfEg8P+YQfPOTYiHz0zJH+GSyvfIHy/FK+GZ2kKxEiryorv3zTDv9bTSnosROlULP7quj7LglJhWEja6AlknFPRcV0FQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: With the introduction of mapping_wrprotect_page() there is no need to use folio_mkclean() in order to write-protect mappings of frame buffer pages, and therefore no need to inappropriately set kernel-allocated page->index, mapping fields to permit this operation. Instead, store the pointer to the page cache object for the mapped driver in the fb_deferred_io object, and use the already stored page offset from the pageref object to look up mappings in order to write-protect them. This is justified, as for the page objects to store a mapping pointer at the point of assignment of pages, they must all reference the same underlying address_space object. Since the life time of the pagerefs is also the lifetime of the fb_deferred_io object, storing the pointer here makes snese. This eliminates the need for all of the logic around setting and maintaining page->index,mapping which we remove. This eliminates the use of folio_mkclean() entirely but otherwise should have no functional change. Signed-off-by: Lorenzo Stoakes Tested-by: Kajtar Zsolt Signed-off-by: Lorenzo Stoakes Reported-by: kernel test robot Acked-by: Thomas Zimmermann --- drivers/video/fbdev/core/fb_defio.c | 38 +++++++++-------------------- include/linux/fb.h | 1 + 2 files changed, 12 insertions(+), 27 deletions(-) diff --git a/drivers/video/fbdev/core/fb_defio.c b/drivers/video/fbdev/core/fb_defio.c index 65363df8e81b..b9bab27a8c0f 100644 --- a/drivers/video/fbdev/core/fb_defio.c +++ b/drivers/video/fbdev/core/fb_defio.c @@ -69,14 +69,6 @@ static struct fb_deferred_io_pageref *fb_deferred_io_pageref_lookup(struct fb_in return pageref; } -static void fb_deferred_io_pageref_clear(struct fb_deferred_io_pageref *pageref) -{ - struct page *page = pageref->page; - - if (page) - page->mapping = NULL; -} - static struct fb_deferred_io_pageref *fb_deferred_io_pageref_get(struct fb_info *info, unsigned long offset, struct page *page) @@ -140,13 +132,10 @@ static vm_fault_t fb_deferred_io_fault(struct vm_fault *vmf) if (!page) return VM_FAULT_SIGBUS; - if (vmf->vma->vm_file) - page->mapping = vmf->vma->vm_file->f_mapping; - else + if (!vmf->vma->vm_file) printk(KERN_ERR "no mapping available\n"); - BUG_ON(!page->mapping); - page->index = vmf->pgoff; /* for folio_mkclean() */ + BUG_ON(!info->fbdefio->mapping); vmf->page = page; return 0; @@ -194,9 +183,9 @@ static vm_fault_t fb_deferred_io_track_page(struct fb_info *info, unsigned long /* * We want the page to remain locked from ->page_mkwrite until - * the PTE is marked dirty to avoid folio_mkclean() being called - * before the PTE is updated, which would leave the page ignored - * by defio. + * the PTE is marked dirty to avoid mapping_wrprotect_page() + * being called before the PTE is updated, which would leave + * the page ignored by defio. * Do this by locking the page here and informing the caller * about it with VM_FAULT_LOCKED. */ @@ -274,14 +263,13 @@ static void fb_deferred_io_work(struct work_struct *work) struct fb_deferred_io_pageref *pageref, *next; struct fb_deferred_io *fbdefio = info->fbdefio; - /* here we mkclean the pages, then do all deferred IO */ + /* here we wrprotect the page's mappings, then do all deferred IO. */ mutex_lock(&fbdefio->lock); list_for_each_entry(pageref, &fbdefio->pagereflist, list) { - struct folio *folio = page_folio(pageref->page); + struct page *page = pageref->page; + pgoff_t pgoff = pageref->offset >> PAGE_SHIFT; - folio_lock(folio); - folio_mkclean(folio); - folio_unlock(folio); + mapping_wrprotect_page(fbdefio->mapping, pgoff, 1, page); } /* driver's callback with pagereflist */ @@ -337,6 +325,7 @@ void fb_deferred_io_open(struct fb_info *info, { struct fb_deferred_io *fbdefio = info->fbdefio; + fbdefio->mapping = file->f_mapping; file->f_mapping->a_ops = &fb_deferred_io_aops; fbdefio->open_count++; } @@ -344,13 +333,7 @@ EXPORT_SYMBOL_GPL(fb_deferred_io_open); static void fb_deferred_io_lastclose(struct fb_info *info) { - unsigned long i; - flush_delayed_work(&info->deferred_work); - - /* clear out the mapping that we setup */ - for (i = 0; i < info->npagerefs; ++i) - fb_deferred_io_pageref_clear(&info->pagerefs[i]); } void fb_deferred_io_release(struct fb_info *info) @@ -370,5 +353,6 @@ void fb_deferred_io_cleanup(struct fb_info *info) kvfree(info->pagerefs); mutex_destroy(&fbdefio->lock); + fbdefio->mapping = NULL; } EXPORT_SYMBOL_GPL(fb_deferred_io_cleanup); diff --git a/include/linux/fb.h b/include/linux/fb.h index 5ba187e08cf7..cd653862ab99 100644 --- a/include/linux/fb.h +++ b/include/linux/fb.h @@ -225,6 +225,7 @@ struct fb_deferred_io { int open_count; /* number of opened files; protected by fb_info lock */ struct mutex lock; /* mutex that protects the pageref list */ struct list_head pagereflist; /* list of pagerefs for touched pages */ + struct address_space *mapping; /* page cache object for fb device */ /* callback */ struct page *(*get_page)(struct fb_info *info, unsigned long offset); void (*deferred_io)(struct fb_info *info, struct list_head *pagelist);