From patchwork Mon Aug 22 13:01:32 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rolf Eike Beer X-Patchwork-Id: 12950639 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D84CC28D13 for ; Mon, 22 Aug 2022 13:36:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C9A0D8D0001; Mon, 22 Aug 2022 09:36:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C490E6B0075; Mon, 22 Aug 2022 09:36:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B38248D0001; Mon, 22 Aug 2022 09:36:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A57436B0074 for ; Mon, 22 Aug 2022 09:36:36 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 715C141275 for ; Mon, 22 Aug 2022 13:36:36 +0000 (UTC) X-FDA: 79827328392.18.F5D95D6 Received: from mx1.emlix.com (mx1.emlix.com [136.243.223.33]) by imf03.hostedemail.com (Postfix) with ESMTP id E860C20767 for ; Mon, 22 Aug 2022 13:19:45 +0000 (UTC) Received: from mailer.emlix.com (p5098be52.dip0.t-ipconnect.de [80.152.190.82]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.emlix.com (Postfix) with ESMTPS id 5DDBD601AF; Mon, 22 Aug 2022 15:04:37 +0200 (CEST) From: Rolf Eike Beer To: Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/6] mm: pagewalk: fix documentation of PTE hole handling Date: Mon, 22 Aug 2022 15:01:32 +0200 Message-ID: <3695521.kQq0lBPeGt@devpool047> Organization: emlix GmbH In-Reply-To: <3200642.44csPzL39Z@devpool047> References: <3200642.44csPzL39Z@devpool047> MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661174388; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RYPzkUAHjPg3UFO8RCR1zQmCsaoRnDrTZFvsWwLi9HM=; b=n8/qTwU0ydEgm1UN23ndctuVfKBvj7qpqKGhjN5dhctdLfwQG0ROQcdSXwh/vk/DcE3Jbh 8rynPjf/6SQt74K5H5wcukjAmGz8z5CpYfEKxwpjJollM+x4BXXWJU3UzmFo1D8v8DSiQs Hk/NDPfcyaZkymHud7UCH9eSONSAWMI= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf03.hostedemail.com: domain of eb@emlix.com designates 136.243.223.33 as permitted sender) smtp.mailfrom=eb@emlix.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661174388; a=rsa-sha256; cv=none; b=uSbfFG9bNgSuYJNMWsYZtCj/Yg5NJXV7BUT78TMnQgFQyh/ei0/trawne7UBsyXUPcAJ8q xZpxfKytbuLYGlB2JslJafk9HVGuUxneM7jEiWQz6fQa0k2riMqqqcIKqvISsQ6WGbrhNW A3CosO1E3fG5iRDvDrtan7g3Gd8eAcw= X-Rspamd-Queue-Id: E860C20767 X-Rspam-User: Authentication-Results: imf03.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf03.hostedemail.com: domain of eb@emlix.com designates 136.243.223.33 as permitted sender) smtp.mailfrom=eb@emlix.com X-Rspamd-Server: rspam03 X-Stat-Signature: hhax7kstixxd9zh6dcbjscrk4w8j4ipo X-HE-Tag: 1661174385-288471 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Empty PTEs are passed to the pte_entry callback, not to pte_hole. Signed-off-by: Rolf Eike Beer --- include/linux/pagewalk.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/include/linux/pagewalk.h b/include/linux/pagewalk.h index ac7b38ad5903..f3fafb731ffd 100644 --- a/include/linux/pagewalk.h +++ b/include/linux/pagewalk.h @@ -15,12 +15,12 @@ struct mm_walk; * this handler is required to be able to handle * pmd_trans_huge() pmds. They may simply choose to * split_huge_page() instead of handling it explicitly. - * @pte_entry: if set, called for each non-empty PTE (lowest-level) - * entry + * @pte_entry: if set, called for each PTE (lowest-level) entry, + * including empty ones * @pte_hole: if set, called for each hole at all levels, - * depth is -1 if not known, 0:PGD, 1:P4D, 2:PUD, 3:PMD - * 4:PTE. Any folded depths (where PTRS_PER_P?D is equal - * to 1) are skipped. + * depth is -1 if not known, 0:PGD, 1:P4D, 2:PUD, 3:PMD. + * Any folded depths (where PTRS_PER_P?D is equal to 1) + * are skipped. * @hugetlb_entry: if set, called for each hugetlb entry * @test_walk: caller specific callback function to determine whether * we walk over the current vma or not. Returning 0 means