From patchwork Mon Jun 27 22:34:30 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rebecca Mckeever X-Patchwork-Id: 12897272 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6470C433EF for ; Mon, 27 Jun 2022 22:35:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 615F38E0006; Mon, 27 Jun 2022 18:35:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5C58D8E0001; Mon, 27 Jun 2022 18:35:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 48D978E0006; Mon, 27 Jun 2022 18:35:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3A12E8E0001 for ; Mon, 27 Jun 2022 18:35:21 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 0A1A433D0B for ; Mon, 27 Jun 2022 22:35:21 +0000 (UTC) X-FDA: 79625473242.09.5C4A662 Received: from mail-oi1-f194.google.com (mail-oi1-f194.google.com [209.85.167.194]) by imf07.hostedemail.com (Postfix) with ESMTP id 5740D40038 for ; Mon, 27 Jun 2022 22:35:19 +0000 (UTC) Received: by mail-oi1-f194.google.com with SMTP id p8so14817094oip.8 for ; Mon, 27 Jun 2022 15:35:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hDwC4vjOEjWZbqEneYaa93PfkH0X3bD2FesquY/4DR0=; b=R40+st7n8bK+eV4IFBb9tHvqyBFduB4ioLmqU3xul880XnefKDhtRaR04BQTpmeKeL yBanLZidYKjfSZvfskhgkEjPZ0BmIOOLWdh0chrSAqBQQ/SschgLY1MOVZGPLTAblMFT sUgUIU65pAGllcGy8ETb7TOHmJoWzI+Oq6cI3sxHiBYXU2gC+puKq1E56KPQ0PoklB+K rifFfzTPNpnPEor7bIPAh2h9U5SipnO56wWhBe+XcKm+T3RCYUCIggXiz2bVa5RO02KG FBA2cbEXqf9CyYxgCC59E7V7Jq8Z5tDN6lnLTmRuLuD3JM9t5k6lIwTmuKaQ9+svKjwd f0kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hDwC4vjOEjWZbqEneYaa93PfkH0X3bD2FesquY/4DR0=; b=NeidtF/2ORc6QiTGeUFCIwZIiGaKTsufygs1Qlpi/RMNJM9fWs2UAtQDDgothjUg1H 8d3Ccd+3KhfClb58e6qB6JxcbsXKXQJpQ1Gk52w3IbFKJIDJDnoivuED9eCOA6iiNVHa wFfcr/efP5bvDpxjm1nxHUH8sYs0T+XpymS740+4plLp7H5Hcqt9wIg7Tv5cITG9NugQ ILrotZi0TLoaMfmtkkDmvglrIRKSTLW9qi33c5dDPzmz23bkH369s+hyzxN2XdQ8ieWd lZMVEWCZiWnh7mJ0Kn6m1i2pnte1VzP9EDcqdYn1zv7oOgGwVM7+A1j8YUh2rMYv7cnf f82g== X-Gm-Message-State: AJIora9WrNhDcDuejcjCJR+UP6Kd3gBAhshUUR06WiiwFmElTSf27eEp czJlY+AoFCVYZ+WLw5jXjHY= X-Google-Smtp-Source: AGRyM1uGuzpSHGJe6Y+NuWr5CrNhOjdG5PNR1gTZzBQdCC2/JmehuDVkihCx98yC7PxdYO3hHzNP+Q== X-Received: by 2002:a05:6808:f8b:b0:335:7cb9:f6df with SMTP id o11-20020a0568080f8b00b003357cb9f6dfmr2903741oiw.105.1656369318707; Mon, 27 Jun 2022 15:35:18 -0700 (PDT) Received: from bertie (072-190-140-117.res.spectrum.com. [72.190.140.117]) by smtp.gmail.com with ESMTPSA id f19-20020a056830057300b0060bd2d06a1csm7140772otc.47.2022.06.27.15.35.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jun 2022 15:35:18 -0700 (PDT) From: Rebecca Mckeever To: Mike Rapoport , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: David Hildenbrand , Rebecca Mckeever Subject: [PATCH v4 4/4] memblock tests: remove completed TODO items Date: Mon, 27 Jun 2022 17:34:30 -0500 Message-Id: <3f2da4dc9ed0d30cf0fb8041077ed640886152d8.1656368930.git.remckee0@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656369319; a=rsa-sha256; cv=none; b=Fdcr/Bz7wp3bmkAqtqfsaDdxWzJIV5Qiw6cyoZww8ElQxjFiqZqQxFiPYQJNhWPjXG6NyF n8rH2ebINE34SQq7afev43qjvTLtUx9+8YfU3Mu/gRR6NCbt5S1QosILpgBTU8FNbw/jZk PaQZAdNX74SXOn0iG68azfYVsK7IAuU= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=R40+st7n; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf07.hostedemail.com: domain of remckee0@gmail.com designates 209.85.167.194 as permitted sender) smtp.mailfrom=remckee0@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656369319; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hDwC4vjOEjWZbqEneYaa93PfkH0X3bD2FesquY/4DR0=; b=btAoM2DCtety3azsv2mxd8pHZmJp0yeBAzZc98xS0oETymtfBfkVmsz3jAX5zq1tUEUtvI iR/Je/0s5BzTpZ+T5OT1z/Yq6YXp21J4yqVPH0HThUlFAli3lFHqL3OyjO8B4iLTVJBhb7 4K4uCzbYX8vs3kuGn6TqpuuYURCCPvQ= X-Stat-Signature: nonjpq896o64x9yuxhejmtmgxjhadkuo X-Rspamd-Queue-Id: 5740D40038 Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=R40+st7n; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf07.hostedemail.com: domain of remckee0@gmail.com designates 209.85.167.194 as permitted sender) smtp.mailfrom=remckee0@gmail.com X-Rspamd-Server: rspam10 X-Rspam-User: X-HE-Tag: 1656369319-884820 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Remove completed items from TODO list. Signed-off-by: Rebecca Mckeever --- tools/testing/memblock/TODO | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/tools/testing/memblock/TODO b/tools/testing/memblock/TODO index cd1a30d5acc9..33044c634ea7 100644 --- a/tools/testing/memblock/TODO +++ b/tools/testing/memblock/TODO @@ -1,25 +1,17 @@ TODO ===== -1. Add verbose output (e.g., what is being tested and how many tests cases are - passing) - -2. Add flags to Makefile: - + verbosity level - + enable memblock_dbg() messages (i.e. pass "-D CONFIG_DEBUG_MEMORY_INIT" - flag) - -3. Add tests trying to memblock_add() or memblock_reserve() 129th region. +1. Add tests trying to memblock_add() or memblock_reserve() 129th region. This will trigger memblock_double_array(), make sure it succeeds. *Important:* These tests require valid memory ranges, use dummy physical memory block from common.c to implement them. It is also very likely that the current MEM_SIZE won't be enough for these test cases. Use realloc to adjust the size accordingly. -4. Add test cases using this functions (implement them for both directions): +2. Add test cases using this functions (implement them for both directions): + memblock_alloc_raw() + memblock_alloc_exact_nid_raw() + memblock_alloc_try_nid_raw() -5. Add tests for memblock_alloc_node() to check if the correct NUMA node is set +3. Add tests for memblock_alloc_node() to check if the correct NUMA node is set for the new region