Message ID | 405ee9e84a83178e762d8bac97dd1b36ea09074e.1538485901.git.andreyknvl@google.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <owner-linux-mm@kvack.org> Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id F3FEC13BB for <patchwork-linux-mm@patchwork.kernel.org>; Tue, 2 Oct 2018 13:13:03 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E603E285A9 for <patchwork-linux-mm@patchwork.kernel.org>; Tue, 2 Oct 2018 13:13:03 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D9516288C4; Tue, 2 Oct 2018 13:13:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, USER_IN_DEF_DKIM_WL autolearn=unavailable version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8281E285A9 for <patchwork-linux-mm@patchwork.kernel.org>; Tue, 2 Oct 2018 13:13:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4AA746B000E; Tue, 2 Oct 2018 09:12:54 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 45D816B0010; Tue, 2 Oct 2018 09:12:54 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2AFEC6B0266; Tue, 2 Oct 2018 09:12:54 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by kanga.kvack.org (Postfix) with ESMTP id BE72C6B000E for <linux-mm@kvack.org>; Tue, 2 Oct 2018 09:12:53 -0400 (EDT) Received: by mail-wm1-f71.google.com with SMTP id z11-v6so1764149wma.4 for <linux-mm@kvack.org>; Tue, 02 Oct 2018 06:12:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:from:to:cc:subject:date :message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=M+fzLalqRaXGFiw1By6nH8QQrYEhVoORFRhjy/6ZtCk=; b=INTjtW+Nqyq8MtodpB7/Hejg3uYfV8h6PVq7WWLYPEhN518EYm2mmpniDY+m2SKxKf KB0nGcPGTnwvZ6md2t9r27vvtexUvyUS32arnE+qS3SlHsi2MYsZbxJmXBdxd3r6aoIx 8kVWsEWWTWzASLKqrqm2OTXTUNVqgqar7MMBPZDfMVYQRNB2ZQO+hbk60SdREBCyj16Z 7xpyxr/7vaB8imRnZ0YqhLyid2JPt8uoPqblbIyZusFXSptV8yf2krYKPv5as30NlNH7 XphVvWN4pDjzaOZXKu+Rd0h93vYxkfNxoKZ26xZInmDWbXpe5k8Owvu+KdGV8fWHylO+ gBfg== X-Gm-Message-State: ABuFfoiyKVxCk5NYd8RyA0dGh4fu6VKs2fEfUU4q6vdMUCNoV9B9/3i0 yyh1EEMnO67cPMsbz1g/bFztYmu+vAWYjdR1w4C8hjWS+fYogVoJLxi/FDO+S74VXDSCWQWdhbQ Gt27O+/IGr50ZYwtZJNMGudEWctpCpaCcVLpdIm4MNyT4+Qz924r7+G4FJg/gDmmTwxSNU6HJT0 pKyyv2W5TV1/yUlTA0CI5q0trk9HnUUW6QTA/BNy1LQAV1BPSg8A+XqidLI7oKKenPaPD67/9R5 9b9/lT/FBM28sWDGfPvK00PkcGKp9OZ/PNH3CrnlrhLsSbALcvreP5vCQUDWdkYQ8OQfTce0Wfe A4alnDR+W0SZlIuOdL2c9dvdF/zo+DM43Rk8dfelh6OR+OtW0OPs/J2OsHMY21QM2peQQHtav6y 9 X-Received: by 2002:a1c:a9d4:: with SMTP id s203-v6mr1785723wme.58.1538485973128; Tue, 02 Oct 2018 06:12:53 -0700 (PDT) X-Received: by 2002:a1c:a9d4:: with SMTP id s203-v6mr1785673wme.58.1538485972302; Tue, 02 Oct 2018 06:12:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538485972; cv=none; d=google.com; s=arc-20160816; b=R/U3VEdxKLJZTeQWMuKLNfUtuWFe+rQs7+yFb6ivXePgd9HcGoutFd40bTnktB1iu8 riRQmyN81In4cQcT4m02Kv1z+3aint5iGa3g+UchtcCpR3KxjVTOAMlJyEyyl5B+Bgat ftS0lIisBuRtTbMMg/KSrpG8s4y/KVkCZiUMxmnKNx7mpmyKDdzFw1mGpzZM4WnDIUA2 AwMgjrMiW4FEE+JIaBhFXl1lFK86BDLJsE8amvHG65sRPFDKbQHFP4R6oMlEGC5YLEYR hyTjVlR9xWkE4r6RkGnynZnwWkzFHz2ZvYxo2+JFKe8GaGucN1GnysAX7COU5wkwnRud H0mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=M+fzLalqRaXGFiw1By6nH8QQrYEhVoORFRhjy/6ZtCk=; b=vOJU8ox/6I1qIeuZciWBndu0PoDL72eYqZ/CFCWsiLdaJ3Il9qDb+6YaxV04/2TNZU u3QagWb3OH15qImI8rEWzDv9WFPvuF4eCPkegufjND7ctCZXHr1WjuX3wwRUwkaZMiXg fGyJwm91ULb/eT2YL+883QF0CSb5EYB87cNEjZTZxvakPe1i2hf9DgJaDTuv6yDSNJi5 kWZmCnqL8GJ71fCXYI2MFSjJJjOGxh3I3To3ugzjUC9htoQwLIlf8IrAcKF64XWCCiI0 vsMSMyx9M1cNYxheCE8f/4J5BV9g5naVBgPBKJELq87L2PhztUoFUmmuuYCXfhpsiVlx 54nw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b="g/5+TE8q"; spf=pass (google.com: domain of andreyknvl@google.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=andreyknvl@google.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id j17-v6sor4831462wrn.8.2018.10.02.06.12.52 for <linux-mm@kvack.org> (Google Transport Security); Tue, 02 Oct 2018 06:12:52 -0700 (PDT) Received-SPF: pass (google.com: domain of andreyknvl@google.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b="g/5+TE8q"; spf=pass (google.com: domain of andreyknvl@google.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=andreyknvl@google.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=M+fzLalqRaXGFiw1By6nH8QQrYEhVoORFRhjy/6ZtCk=; b=g/5+TE8qrM0S966GF0ehpYeatmN6rBIDeIbCUA440M2nraTgJHSOOqRefWma3H2QFk db/TLUMgW+3DdtgV6yDyHfsewvdoZ7XQ0S1jqS57d41YAflXkP1pp9HlkbzYwNkS0JIY pRVdhsSySSV0TihlxSpRvVQSVaJywiekWjskRHndBNzF7BevnT1qmGTO4DaIhzYUXxry LRsUaYPgQ3TIeOamcd3WNyixCIR5UKwYktsOiGG1HrBcYgd/3s9nCOH/IZLWx8A6pH7v c1a8+L2HtBSCHGIVd4jnex5QRuAgpohMaN8a5DeTpNqK4l46AuDUGWCyxe5giES9UqQY RTdg== X-Google-Smtp-Source: ACcGV634rYLGlFVKrv5iDfl8Icy0xrHVGOhV9Puza2K4wNp0CAyWdiFG3gBDc0/36ZWC9rHQ4ru4hQ== X-Received: by 2002:adf:8022:: with SMTP id 31-v6mr8356555wrk.16.1538485971887; Tue, 02 Oct 2018 06:12:51 -0700 (PDT) Received: from andreyknvl0.muc.corp.google.com ([2a00:79e0:15:10:84be:a42a:826d:c530]) by smtp.gmail.com with ESMTPSA id v10-v6sm17458681wrp.0.2018.10.02.06.12.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 Oct 2018 06:12:50 -0700 (PDT) From: Andrey Konovalov <andreyknvl@google.com> To: Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will.deacon@arm.com>, Mark Rutland <mark.rutland@arm.com>, Robin Murphy <robin.murphy@arm.com>, Kees Cook <keescook@chromium.org>, Kate Stewart <kstewart@linuxfoundation.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Andrew Morton <akpm@linux-foundation.org>, Ingo Molnar <mingo@kernel.org>, "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>, Shuah Khan <shuah@kernel.org>, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Dmitry Vyukov <dvyukov@google.com>, Kostya Serebryany <kcc@google.com>, Evgeniy Stepanov <eugenis@google.com>, Lee Smith <Lee.Smith@arm.com>, Ramana Radhakrishnan <Ramana.Radhakrishnan@arm.com>, Jacob Bramley <Jacob.Bramley@arm.com>, Ruben Ayrapetyan <Ruben.Ayrapetyan@arm.com>, Chintan Pandya <cpandya@codeaurora.org>, Luc Van Oostenryck <luc.vanoostenryck@gmail.com>, Andrey Konovalov <andreyknvl@google.com> Subject: [PATCH v7 4/8] mm, arm64: untag user addresses in mm/gup.c Date: Tue, 2 Oct 2018 15:12:39 +0200 Message-Id: <405ee9e84a83178e762d8bac97dd1b36ea09074e.1538485901.git.andreyknvl@google.com> X-Mailer: git-send-email 2.19.0.605.g01d371f741-goog In-Reply-To: <cover.1538485901.git.andreyknvl@google.com> References: <cover.1538485901.git.andreyknvl@google.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: <linux-mm.kvack.org> X-Virus-Scanned: ClamAV using ClamSMTP |
Series |
arm64: untag user pointers passed to the kernel
|
expand
|
diff --git a/mm/gup.c b/mm/gup.c index 1abc8b4afff6..6f09132c654e 100644 --- a/mm/gup.c +++ b/mm/gup.c @@ -666,6 +666,8 @@ static long __get_user_pages(struct task_struct *tsk, struct mm_struct *mm, if (!nr_pages) return 0; + start = untagged_addr(start); + VM_BUG_ON(!!pages != !!(gup_flags & FOLL_GET)); /* @@ -820,6 +822,8 @@ int fixup_user_fault(struct task_struct *tsk, struct mm_struct *mm, struct vm_area_struct *vma; vm_fault_t ret, major = 0; + address = untagged_addr(address); + if (unlocked) fault_flags |= FAULT_FLAG_ALLOW_RETRY;
mm/gup.c provides a kernel interface that accepts user addresses and manipulates user pages directly (for example get_user_pages, that is used by the futex syscall). Since a user can provided tagged addresses, we need to handle such case. Add untagging to gup.c functions that use user addresses for vma lookup. Signed-off-by: Andrey Konovalov <andreyknvl@google.com> --- mm/gup.c | 4 ++++ 1 file changed, 4 insertions(+)