From patchwork Thu Sep 26 06:46:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Qi Zheng X-Patchwork-Id: 13812858 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBDADCCF9E9 for ; Thu, 26 Sep 2024 06:47:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 329726B009D; Thu, 26 Sep 2024 02:47:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2BCE96B009E; Thu, 26 Sep 2024 02:47:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 152626B009F; Thu, 26 Sep 2024 02:47:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E9FAB6B009D for ; Thu, 26 Sep 2024 02:47:06 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 69787ACD4F for ; Thu, 26 Sep 2024 06:47:06 +0000 (UTC) X-FDA: 82605957252.16.E667167 Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) by imf10.hostedemail.com (Postfix) with ESMTP id A20D8C000A for ; Thu, 26 Sep 2024 06:47:04 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=cJlrRvn+; spf=pass (imf10.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.160.176 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727333103; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7WBwKEY9MWquOlo01BPdpzLz4TZdRIsQgPATlcDwMyk=; b=8f/blPnicl1DWwkqvielr9zVAu6Rj/7S669FwmcobI39JJIT13LGFwHgnfWi0lodCfTWt9 kglNMdRzabunJdDoBz7hIBq5J2rdEL6FoDAPlQui9QWQ+hUgo6WiFRbthzi59s6rwBdBQ6 kiYprvYnaZfHa7ckDZ3smzafWQghLnw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727333103; a=rsa-sha256; cv=none; b=CXF8/ugxhSrP+U6HQZS259+clVcQ6c0d7DsC9uAAb2nxkwRMZuewyFrXtgFWwsyoJrxFcS SWlXFopoLz5IWtB+koLru2sLbStswniwkH9XMKWmlXHtnHlxTHN0i1x2o2jkOK4oUrn54P EoV0gKUU/kjVyA6r1ux1RkdXqVpSYCE= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=cJlrRvn+; spf=pass (imf10.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.160.176 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com Received: by mail-qt1-f176.google.com with SMTP id d75a77b69052e-4583068795eso4781511cf.1 for ; Wed, 25 Sep 2024 23:47:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1727333223; x=1727938023; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7WBwKEY9MWquOlo01BPdpzLz4TZdRIsQgPATlcDwMyk=; b=cJlrRvn+RlYYQeCABlWexNNqEVlOV/w8CtznFU2dtkS6BNpNH4jwI4bPecITqMNvLP ptKbVDvHmTDyLheRi9ucgm3XVzwQpq9etjcqXbtoVxBpByH+IC79KlrNoKKzf57mmhS0 03aci9MCTPlEcbEKzlVoOI2rmw23/Frv56qeELe3/BRRx0J/N4pMbpWqd0c91h6z53gY AIGLrqU+vCtYo32i4TUtuWtP87HyxYqd8VMBNumedP08aomnhuDUR0eCjEfqHF8klPMM pJI+N/FFSjjMugVllogKCbrZ1Ogf+jyzdrDMjaSHrpak90SPh8q6jORkGMQyPYSUPs3i fIjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727333223; x=1727938023; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7WBwKEY9MWquOlo01BPdpzLz4TZdRIsQgPATlcDwMyk=; b=bK6wsqLu4LvSMMv26IPoSO/4BhhCJXpGfdp8FGjJCilzXH1MnYYTFwMqIsYlIzikFd c1zZ8xdeAJeyjcntJ+mPW6IPdjdpLb7WaEgOPl0sJRJBvsF9Vr+b9grarxoVpmmtGPbG XKDUxmnZvbYuLUgJ/Yw60V8ILoC+aaLpnjADcQmPD7r/e7Yy4QVR3/+rHaM2wAzk0+k7 jLe5e7AYPFA5WuHzXCdJ4suGkxUac7gzhKvFdFYnmvV2wVzMtvvfYDzL//lUDzIdF/Jf MFO1993mTCLFip7E6O0rXm0+V7aY4VskexGuAXeapOD4gxUJs1k5MeGPJbmyO4/Aexif yRnQ== X-Forwarded-Encrypted: i=1; AJvYcCVNs9eAheYV4sxYBA/rIPhDZcPfQMLUrwEaczhGw/W9S71OQdZy/rNH3/785vFuvi/HgIhvYbgrMQ==@kvack.org X-Gm-Message-State: AOJu0YzQd8+RAcpYDp/7F6WwmvfUEVCwq5z7/CKZOA6U5mJvGWs64hOx 0q83YsPhrjUChPwPHDlZY3xFoSmDic9J72b+L5CBF1iCgkljIKS0mvJ4ZrKkx/A= X-Google-Smtp-Source: AGHT+IHKcdRFC9q2GD6595fUPe4NgxH7f7bGHM/1jVFUOYjtanMZU2hJPsIx01XdKDMweQg9NQ43+w== X-Received: by 2002:a05:622a:105:b0:458:4c86:4564 with SMTP id d75a77b69052e-45b5e0952b0mr82475131cf.37.1727333223424; Wed, 25 Sep 2024 23:47:03 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([203.208.167.150]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-45b5257ff1esm23024611cf.38.2024.09.25.23.46.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Sep 2024 23:47:03 -0700 (PDT) From: Qi Zheng To: david@redhat.com, hughd@google.com, willy@infradead.org, muchun.song@linux.dev, vbabka@kernel.org, akpm@linux-foundation.org, rppt@kernel.org, vishal.moola@gmail.com, peterx@redhat.com, ryan.roberts@arm.com, christophe.leroy2@cs-soprasteria.com Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, Qi Zheng Subject: [PATCH v5 02/13] powerpc: assert_pte_locked() use pte_offset_map_ro_nolock() Date: Thu, 26 Sep 2024 14:46:15 +0800 Message-Id: <42559e042eb6fc3129a40f710d671712030646b4.1727332572.git.zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: References: MIME-Version: 1.0 X-Stat-Signature: qsm4uqz1d9pw9r171mujufqjj481bjso X-Rspamd-Queue-Id: A20D8C000A X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1727333224-524939 X-HE-Meta: U2FsdGVkX1+e0rJZ7icgAeN006bMEUx66l/g6NKlXEpOHdyPg8kPGqlHNRM7oDaRrjBV6XIethmmM9+KPsTHs0r0fHOLlEYn/kjs1Z9jmxF5HxGyfvXkLyXwXc/4Y0g7FdecreJsC0suxETy1WW/cdpjzy591sdB9praBJTbu8g6Wfo7KcBg7Ah8ZZQB1oc9L2QYqWK2Ds9evqRUfrPywlXr/yEmYY5MhWSH47WKXOQPJE9Nyw5U7GgFXIBwlNrWmLJerfklV9UuYCni8aXcGll/KW6q+CXTF14agrNv44eY0aYutb9XFsyKvIl2KCX+YSkVFC7EkPT/TFSqE7WzEr1d9zL1QlPdeaRw8IsVm30vNZnF4NDWRNwFPor/TYouE1kwgXpnO18BvJMmwLh4K0dyLd6rrCzf1OU7wazREoF+oWUQut647yPcWsEwEn6ccSwPiCHK/gl20shfNi/C14UlUXoj97GoTltWrpZ1AfZLK7fG1fIlaOVQovMgPwcb7DkKnZ4VymEkQ1Hhysvr/ksvkTWykDDRd9c2DRDoCPIxqU4TDe3bB+MlPGWsiLD3Wu5Mtwow8Gm+2v/WAt9qnHz30T5f4TOUO0kaW4rYXibpk2zxRH9mTbuC/0w73U5DyEip5mxokPHPEktzmVFsWKcL04hB2CK6R1KratSglak2TrvhKIlu/3+WjcKt7aUDYtPU/4xSS5FQunKw6zhu6KIFc8ypfSQVGj8qRW5y9HX8aBmfzPmbgsmLBh0FQXlmhK9XianskcOv/0D2c/k5q4tgEpGFg9vSJzKMe6xARIZu6vb/W9IdLz5ozdgYayeSwyJdn4zLU1Fp7TlECqkNpbpyxYg1OIvam10nwL1Kpq0XQmVfUmUASfm1QY5RQArJLCLE4/l+a3+ml7PWoMHIet4tdidfxZ4sTsCRHamoyzYOwKevefTjDviConV8SBZg1hypahvILJ228VFB63q GTqYiNuI 8UNqS9E26UJf/Z4qLjGV7fR9KwfT72nUzDjVsi19zWmqatsPdsmn+RIK8u0mQyzuDpwMXxPdtjWHakfiL9t0VRKJQm9LZcqlhSURSnfl/98TTJRKA5SDHVVarYyCibs+jdkCKWdA28qFBMRlDg698uk5xrLzGG+2i9hILA5QxsF9ljxr6bYf5EY3ac7AqsXpeZLuoDGQ6fI0aTJNdF+oVrzsuTPcQZT9ANrEZt65Ps6B8lOKRKMz++kHJn2cgekwyjJBt8Uby08D9Ot5J3JI/K5gRD9gp3Z4s7dadbGz/+fptwoZfieXR6ts64nt6yb/OXrxTpYDSOLqgB+TT1IXgrc57xPdmKV+KZGJMq+FS4TwN80Aw1n74qFlwHVwYfhIn5GEeKARo4Nr+2nhxV7hVor+BulyW7Bek2D+qOpAYWp1zGT19AYSmXWFj/Tq5N02sUSpVqn1PZBfHK0U= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: In assert_pte_locked(), we just get the ptl and assert if it was already held, so convert it to using pte_offset_map_ro_nolock(). Signed-off-by: Qi Zheng Acked-by: David Hildenbrand Reviewed-by: Muchun Song --- arch/powerpc/mm/pgtable.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/mm/pgtable.c b/arch/powerpc/mm/pgtable.c index 7316396e452d8..61df5aed79894 100644 --- a/arch/powerpc/mm/pgtable.c +++ b/arch/powerpc/mm/pgtable.c @@ -398,7 +398,7 @@ void assert_pte_locked(struct mm_struct *mm, unsigned long addr) */ if (pmd_none(*pmd)) return; - pte = pte_offset_map_nolock(mm, pmd, addr, &ptl); + pte = pte_offset_map_ro_nolock(mm, pmd, addr, &ptl); BUG_ON(!pte); assert_spin_locked(ptl); pte_unmap(pte);