| Message ID | 433d0be927c0cae047a4ca04feff0a1dccefe324.1628174413.git.baolin.wang@linux.alibaba.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Some cleanup for page migration | expand |
On Thu, Aug 5, 2021 at 8:06 AM Baolin Wang <baolin.wang@linux.alibaba.com> wrote: > > since commit a98a2f0c8ce1 ("mm/rmap: split migration into its own function"), > the migration ptes establishment has been split into a separate > try_to_migrate() function, thus update the related comments. > > Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com> Reviewed-by: Yang Shi <shy828301@gmail.com> > --- > mm/migrate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index eeba4c6..6f048a8 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -1005,7 +1005,7 @@ static int __unmap_and_move(struct page *page, struct page *newpage, > } > > /* > - * By try_to_unmap(), page->mapcount goes down to 0 here. In this case, > + * By try_to_migrate(), page->mapcount goes down to 0 here. In this case, > * we cannot notice that anon_vma is freed while we migrates a page. > * This get_anon_vma() delays freeing anon_vma pointer until the end > * of migration. File cache pages are no problem because of page_lock() > -- > 1.8.3.1 > >
Thanks for catching that. Reviewed-by: Alistair Popple <apopple@nvidia.com> On Friday, 6 August 2021 1:05:58 AM AEST Baolin Wang wrote: > since commit a98a2f0c8ce1 ("mm/rmap: split migration into its own function"), > the migration ptes establishment has been split into a separate > try_to_migrate() function, thus update the related comments. > > Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com> > --- > mm/migrate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index eeba4c6..6f048a8 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -1005,7 +1005,7 @@ static int __unmap_and_move(struct page *page, struct page *newpage, > } > > /* > - * By try_to_unmap(), page->mapcount goes down to 0 here. In this case, > + * By try_to_migrate(), page->mapcount goes down to 0 here. In this case, > * we cannot notice that anon_vma is freed while we migrates a page. > * This get_anon_vma() delays freeing anon_vma pointer until the end > * of migration. File cache pages are no problem because of page_lock() >
diff --git a/mm/migrate.c b/mm/migrate.c index eeba4c6..6f048a8 100644 --- a/mm/migrate.c +++ b/mm/migrate.c @@ -1005,7 +1005,7 @@ static int __unmap_and_move(struct page *page, struct page *newpage, } /* - * By try_to_unmap(), page->mapcount goes down to 0 here. In this case, + * By try_to_migrate(), page->mapcount goes down to 0 here. In this case, * we cannot notice that anon_vma is freed while we migrates a page. * This get_anon_vma() delays freeing anon_vma pointer until the end * of migration. File cache pages are no problem because of page_lock()
since commit a98a2f0c8ce1 ("mm/rmap: split migration into its own function"), the migration ptes establishment has been split into a separate try_to_migrate() function, thus update the related comments. Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com> --- mm/migrate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)