From patchwork Tue Sep 10 23:43:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ackerley Tng X-Patchwork-Id: 13799476 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 223D7EE01F1 for ; Tue, 10 Sep 2024 23:44:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 112BB8D00CE; Tue, 10 Sep 2024 19:44:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 09C8F8D0002; Tue, 10 Sep 2024 19:44:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E30CE8D00CE; Tue, 10 Sep 2024 19:44:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C42FD8D0002 for ; Tue, 10 Sep 2024 19:44:41 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8771680897 for ; Tue, 10 Sep 2024 23:44:41 +0000 (UTC) X-FDA: 82550460762.09.5A02698 Received: from mail-pl1-f201.google.com (mail-pl1-f201.google.com [209.85.214.201]) by imf06.hostedemail.com (Postfix) with ESMTP id 9D948180009 for ; Tue, 10 Sep 2024 23:44:39 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=TZcK4nFV; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf06.hostedemail.com: domain of 35tngZgsKCFs35D7KE7RMG99HH9E7.5HFEBGNQ-FFDO35D.HK9@flex--ackerleytng.bounces.google.com designates 209.85.214.201 as permitted sender) smtp.mailfrom=35tngZgsKCFs35D7KE7RMG99HH9E7.5HFEBGNQ-FFDO35D.HK9@flex--ackerleytng.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726011852; a=rsa-sha256; cv=none; b=JXLTi/i9ixnH8/VMX6HPTintg1mK50+GCukfTKJ6JKpUA7xZEaugbI9B2oJNO0ob6AJN/N e4DeTwgXAWQ58GrSts1iTr1QEcOE4UuyIrNH7fT06lptRVuLue+dc16Gc9KN+bEBwNgJ0G mF4h/xV4QhbnXlNKWE8ln1yWA1+vack= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=TZcK4nFV; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf06.hostedemail.com: domain of 35tngZgsKCFs35D7KE7RMG99HH9E7.5HFEBGNQ-FFDO35D.HK9@flex--ackerleytng.bounces.google.com designates 209.85.214.201 as permitted sender) smtp.mailfrom=35tngZgsKCFs35D7KE7RMG99HH9E7.5HFEBGNQ-FFDO35D.HK9@flex--ackerleytng.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726011852; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=krcbfxFAJP32Bl8ts+LdeAkshb3wdoRz7FQc5et7+e0=; b=5Rxu75sdcdO8b5SGtvGDRCHlhWuo+0aI6/2M/iy/O0Hl0Q+9/gUAV+/6qcZzo60rzSxNLd AvUddEVgCPYq3RGVnGN+H+EedYp745E0FsdYWvhtKZosrTZ/ovBie4s/B4kuCBJzuUmykW 0Do7IomZSZQFEfxH93bXRKK5J1MkNNQ= Received: by mail-pl1-f201.google.com with SMTP id d9443c01a7336-205516d992eso15741195ad.3 for ; Tue, 10 Sep 2024 16:44:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1726011878; x=1726616678; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=krcbfxFAJP32Bl8ts+LdeAkshb3wdoRz7FQc5et7+e0=; b=TZcK4nFVJPD40vGVXqL7LL8chwjlE9QYeGUuWfEAj1PjfH+sY1hpeMG7wEsxhaIVsg CVq/r4p6m7mBK66SHd08Dewp0hXQIedRoAE4toYHiqqdDADaT0JDCO5G+esp/lW2dFSK U7Hv36a/1jMTMA82xLB9RW+WdhXwThFG87NPb9C3oGLZyIk2msbWWv6Y67oW/5Dp+H7g tz8wUoLvrUEmoc58zdC3Nr+E2tryP/wb4gnBHHPID9XdeMl+OQfImTpjTtB/+bm7nJEU GAYIwYEe91ynYudgrSaHPxd7epFdBqV2zmHj1vP9lm1RNMe+hlVqSV03omIkFjwfZxGZ XINQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726011878; x=1726616678; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=krcbfxFAJP32Bl8ts+LdeAkshb3wdoRz7FQc5et7+e0=; b=LpCBlbgvNLSA5sdZHJUvWI513/16omGweKXKqYhmVpWBpTqHtgXSyowRYOXu8q/Ega 6gQxMA9iOs49arupUPIsl1Ocw1J86KnVkn38SCmyo8TRXz1qIgQT/Qv2qHs4EAQfX9SF 6n7t/6IxwmxJ2IGqgMd6BYZoGF3Dg7YVNMe9IxM/+/j1FQyHWr3PYY+ACTedg63S2NMK gqHYc7AQoVdTHeu6YltAGtjF2e979MC/l/MWWsAFa3AYS0FD9k5sJeEoKChhcrpQ1zNx hdhup2+8Et9BBwSIxr7hZ+0vs5SNa727HsQfE2W0cxV2rJLNYgTTKgPajTs1NpHsqpD7 fqWw== X-Forwarded-Encrypted: i=1; AJvYcCUWI3GQzFjBL8oVpbKJGLRWCMbmau0Kb8Ri8tf3jYPlXmxmgayakSbwvrJ+5LiLl/FAGEvLi/DQkQ==@kvack.org X-Gm-Message-State: AOJu0YyFtDtkHqyHvn4h8YVKnY1M0DDjuSuvq9RUxB+0iRcG4zTqtihB bFyqOD0dze6S5k8t+ag4wf++wjwJtVDn1PndvgyH7O3pIBRgZa2aIkremGDaVXhlFmcA4W94wUH W9ohc26GyTLSqcX6Yvi3DPQ== X-Google-Smtp-Source: AGHT+IGzA4nKfM70wloRZKktU8I5wwl9MfYLThvDDzHIgaA6loY/0Smr81sI2GQQVA1zTeWX0Ryp6QAH+KUadLwDFg== X-Received: from ackerleytng-ctop.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:13f8]) (user=ackerleytng job=sendgmr) by 2002:a17:903:1c3:b0:205:71f1:853f with SMTP id d9443c01a7336-207521d6944mr178125ad.5.1726011878156; Tue, 10 Sep 2024 16:44:38 -0700 (PDT) Date: Tue, 10 Sep 2024 23:43:34 +0000 In-Reply-To: Mime-Version: 1.0 References: X-Mailer: git-send-email 2.46.0.598.g6f2099f65c-goog Message-ID: <5a5e998e8f154c28a28dcdab73fb563f658f2f51.1726009989.git.ackerleytng@google.com> Subject: [RFC PATCH 03/39] mm: hugetlb: Remove unnecessary check for avoid_reserve From: Ackerley Tng To: tabba@google.com, quic_eberman@quicinc.com, roypat@amazon.co.uk, jgg@nvidia.com, peterx@redhat.com, david@redhat.com, rientjes@google.com, fvdl@google.com, jthoughton@google.com, seanjc@google.com, pbonzini@redhat.com, zhiquan1.li@intel.com, fan.du@intel.com, jun.miao@intel.com, isaku.yamahata@intel.com, muchun.song@linux.dev, mike.kravetz@oracle.com Cc: erdemaktas@google.com, vannapurve@google.com, ackerleytng@google.com, qperret@google.com, jhubbard@nvidia.com, willy@infradead.org, shuah@kernel.org, brauner@kernel.org, bfoster@redhat.com, kent.overstreet@linux.dev, pvorel@suse.cz, rppt@kernel.org, richard.weiyang@gmail.com, anup@brainfault.org, haibo1.xu@intel.com, ajones@ventanamicro.com, vkuznets@redhat.com, maciej.wieczor-retman@intel.com, pgonda@google.com, oliver.upton@linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-fsdevel@kvack.org X-Rspam-User: X-Rspamd-Queue-Id: 9D948180009 X-Rspamd-Server: rspam01 X-Stat-Signature: 8pykrbi3sa8mqd1bumapmnimkjugaebw X-HE-Tag: 1726011879-234512 X-HE-Meta: U2FsdGVkX19i5xrSIJWJPGX34cf348T7wkvegcUOk/pcrju0mIK+rRjK4O5RyqZMnrjKEB017FH2Y6PHy6VN0CPiiX2e2QUYb6DPgHElhQ/LcypWRlSm7j/5iSPZP81wL5pZSJulgw4ahvb4EUH2+14aHu1He6impyvxscDvgQB+RqxCcCA3JHvuJdQUMoG7LHoxXs8soufIIbZ9VJ8GwK50UR6G7c96yNWhYQcWyNdWWY7B0RiYXHu7eiMUs3tG5xqfJovoIiWuCcpe8LECc/yVmr3OpFLr8bH+/QAvvCS5RK7oUTxcBUU5Vb1FHvd4yuysEsnxhniGKdD6fJBUKrIFKLMCO90cDqhTPmpO27GlZAP9Y1/qW4BqJx1JqcmoAHdQu54butjC+RtbggRsPDv9fTdff47zB4sDAhSL2ztm92PsDACAK5AHKngJIocygOEMg8/HLe9VgWUwn68T2ZiXgWetwWkEst+Jr2SJg4UHzOL8ZgE92z3DefbU8uz7wUZnHaOVm6gFi9mVi24H9yH0x7FU81vfK1IxkEag8qomJwwtKlb2+fu9yoRciSXJL9oZbpnIQfyKwH8Bd0n5cWaUbaNKHNYOiVgSrpgIBPWhpyLL/gJosC+/OHkp+GzB8F8jaTamfQAZ9vbW1CZtlXifaCf3eOtF0Ot3IeLKhD6lw7KkylodV9c4BjSASF3hdkIyjQoYFTqNAw/ZS+ghJCcy/DIrhA/YCxrKmIbjJiJHYGtyrvf+rKQrHR3uDLt7Fll7XE4j86x623xG6PGVrjJv02F+DuFXrw2f9FxG456RKvt/km6b/j6JZlSgcGHN9y8OodUkDwLcZBA4oI9aSd+MMfZO3YiHCL4E+yxmtNmgl2kMUrJQSskLED8AyTRn052n9NmwTfShg4ErduR6hk2A6zuaUcK/jbIDk0slpxbhLp/Jajkqg0+YXblX7AmtQViwqVI7FOhdz+jkw8Y yYeYBrUc XFTBntYzmAP28LW4f5GOC2jsj0325PQOaG7Q6dJyUJCoDkU6+RrYHjF2InFKvJw8qf7hP9ULuizh6k96AS9QVJKlAp9VXNJL6z2+3qx5rONAWJWZiPCjfiWG4iW83X/kWrhm7gPPgPU3j6KRLvMGgrXU7A7nypzpT1GdGwqqs9bj3cUB88x0nEKNq7xgy6XYC6lmpmi+bCQgcLkO3T5bATOp59I7B4xAVE720BtE5n2wNYGxrOImTevvXJ1u/ELxIO5vWnzheN19+2+zHxkC4eg1epHgieV3Q6V+Ovx9xq6Gjz0xb/tW/wtLWPq93zaOM2COeLZXBygu4B2j4t3qJmaTmcZtcg00QOUxTsM/8unfrMbFKHIeNSEKh7c7KqURwBHZcx54RNVo8NcV4RgFHTBRtl3KOIXnkZEIk9mSDaykG5Ue5KOJR4HpSL69kpOt/oDpLFCI2Zl7FpYovsqYkJUsGoRllnzeTEHkGI0267u2wxzQDjUbzHxIXW/xzZ5Nr8kA1T8xDMih7sURfvfZ4XqGftjj1f7o/C+RlnFMfI32G65GMI/S+6o7PHvOZN4GeFZmM6Lhcd8bUxRPUAswFHNunSu9ldsxuOhtLcRdjj117kTcQpAY+bY2N61urOD/vE1nYr0o5RhYX+vICkrr080eOaFbxIKJ1Y3EqTOdTjsx7Fg/NO4nZyri6OGruDcSHUhYU X-Bogosity: Ham, tests=bogofilter, spamicity=0.004488, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: If avoid_reserve is true, gbl_chg is not used anyway, so there is no point in setting gbl_chg. Signed-off-by: Ackerley Tng --- mm/hugetlb.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/mm/hugetlb.c b/mm/hugetlb.c index 597102ed224b..5cf7fb117e9d 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -3166,16 +3166,6 @@ struct folio *alloc_hugetlb_folio(struct vm_area_struct *vma, if (gbl_chg < 0) goto out_end_reservation; - /* - * Even though there was no reservation in the region/reserve - * map, there could be reservations associated with the - * subpool that can be used. This would be indicated if the - * return value of hugepage_subpool_get_pages() is zero. - * However, if avoid_reserve is specified we still avoid even - * the subpool reservations. - */ - if (avoid_reserve) - gbl_chg = 1; } /* If this allocation is not consuming a reservation, charge it now.