| Message ID | 663c930475c3c0a32965024c1094d3288629a3af.1650452552.git.remckee0@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | memblock tests: update style of comments | expand |
On 20.04.22 13:19, Rebecca Mckeever wrote: > Remove extra space at the beginning of each line in block comment > for consistency and to conform to Linux kernel coding style. > > Signed-off-by: Rebecca Mckeever <remckee0@gmail.com> > --- > tools/testing/memblock/tests/basic_api.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/tools/testing/memblock/tests/basic_api.c b/tools/testing/memblock/tests/basic_api.c > index 834d8705ff8a..05448a25f1f9 100644 > --- a/tools/testing/memblock/tests/basic_api.c > +++ b/tools/testing/memblock/tests/basic_api.c > @@ -303,12 +303,12 @@ static int memblock_add_checks(void) > return 0; > } > > - /* > - * A simple test that marks a memory block of a specified base address > - * and size as reserved and to the collection of reserved memory regions > - * (memblock.reserved). Expect to create a new entry. The region counter > - * and total memory size are updated. > - */ > +/* > + * A simple test that marks a memory block of a specified base address > + * and size as reserved and to the collection of reserved memory regions > + * (memblock.reserved). Expect to create a new entry. The region counter > + * and total memory size are updated. > + */ > static int memblock_reserve_simple_check(void) > { > struct memblock_region *rgn; I'd pull this patch to the front, so you don't end up modifying a wrong style in patch #2. You could also just squash this patch into patch #2 and mention it in the patch description.
On Thu, Apr 21, 2022 at 09:09:58AM +0200, David Hildenbrand wrote: > On 20.04.22 13:19, Rebecca Mckeever wrote: > > Remove extra space at the beginning of each line in block comment > > for consistency and to conform to Linux kernel coding style. > > > > Signed-off-by: Rebecca Mckeever <remckee0@gmail.com> > > --- > > tools/testing/memblock/tests/basic_api.c | 12 ++++++------ > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/tools/testing/memblock/tests/basic_api.c b/tools/testing/memblock/tests/basic_api.c > > index 834d8705ff8a..05448a25f1f9 100644 > > --- a/tools/testing/memblock/tests/basic_api.c > > +++ b/tools/testing/memblock/tests/basic_api.c > > @@ -303,12 +303,12 @@ static int memblock_add_checks(void) > > return 0; > > } > > > > - /* > > - * A simple test that marks a memory block of a specified base address > > - * and size as reserved and to the collection of reserved memory regions > > - * (memblock.reserved). Expect to create a new entry. The region counter > > - * and total memory size are updated. > > - */ > > +/* > > + * A simple test that marks a memory block of a specified base address > > + * and size as reserved and to the collection of reserved memory regions > > + * (memblock.reserved). Expect to create a new entry. The region counter > > + * and total memory size are updated. > > + */ > > static int memblock_reserve_simple_check(void) > > { > > struct memblock_region *rgn; > > I'd pull this patch to the front, so you don't end up modifying a wrong > style in patch #2. You could also just squash this patch into patch #2 > and mention it in the patch description. Let's squash this into patch 2. > -- > Thanks, > > David / dhildenb >
diff --git a/tools/testing/memblock/tests/basic_api.c b/tools/testing/memblock/tests/basic_api.c index 834d8705ff8a..05448a25f1f9 100644 --- a/tools/testing/memblock/tests/basic_api.c +++ b/tools/testing/memblock/tests/basic_api.c @@ -303,12 +303,12 @@ static int memblock_add_checks(void) return 0; } - /* - * A simple test that marks a memory block of a specified base address - * and size as reserved and to the collection of reserved memory regions - * (memblock.reserved). Expect to create a new entry. The region counter - * and total memory size are updated. - */ +/* + * A simple test that marks a memory block of a specified base address + * and size as reserved and to the collection of reserved memory regions + * (memblock.reserved). Expect to create a new entry. The region counter + * and total memory size are updated. + */ static int memblock_reserve_simple_check(void) { struct memblock_region *rgn;
Remove extra space at the beginning of each line in block comment for consistency and to conform to Linux kernel coding style. Signed-off-by: Rebecca Mckeever <remckee0@gmail.com> --- tools/testing/memblock/tests/basic_api.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)