From patchwork Tue Feb 4 22:48:06 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alistair Popple X-Patchwork-Id: 13960097 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0489BC02194 for ; Tue, 4 Feb 2025 22:50:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8771B280005; Tue, 4 Feb 2025 17:50:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8203B280001; Tue, 4 Feb 2025 17:50:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 64C28280005; Tue, 4 Feb 2025 17:50:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 41087280001 for ; Tue, 4 Feb 2025 17:50:43 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C45431C71EF for ; Tue, 4 Feb 2025 22:50:42 +0000 (UTC) X-FDA: 83083758324.15.2E16A35 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2044.outbound.protection.outlook.com [40.107.243.44]) by imf11.hostedemail.com (Postfix) with ESMTP id 0FFAA4000A for ; Tue, 4 Feb 2025 22:50:39 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=QhEG3U5D; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf11.hostedemail.com: domain of apopple@nvidia.com designates 40.107.243.44 as permitted sender) smtp.mailfrom=apopple@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738709440; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EN3974zWoQ1cF95sfJnVzGIZi2NU/qvevfsejO7+b0o=; b=luLSPztZvWrv7zdiU8qSOz2Yd6L8zMN0xOkxpUjm0cqnWKq+sZ0/d7xyJxOksO074ijx96 HhtgMAepS72T0IH4PoiTO2uYfHeG3/dD3CuI/QMbdBj9X77ZcD2m87N8x0fyaK57dubzLF NxYchYIWWWJoK/KLBpt3DHZx/BP1qy8= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1738709440; a=rsa-sha256; cv=pass; b=j/SZ64XOrYC2outERaAcKxSMC5inv3sIeL5A0Uet1LVC/fAvyPBfj4uBgz8ZRuo+bUSnto hHh4OokIrYRE+QvWSMbHC6M0lroMVudaKh7/0npsfplYPKCG7lDIET8Cy3DkDOQqVmvYNJ LbO+pu53KyimfUQmraGCI3cA1IsN8MA= ARC-Authentication-Results: i=2; imf11.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=QhEG3U5D; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf11.hostedemail.com: domain of apopple@nvidia.com designates 40.107.243.44 as permitted sender) smtp.mailfrom=apopple@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=aIb8upzgBc53rCsK6rOIxhSdc9WRKwYsIZCGmvXmU3Kxee/c04DCRTiHlqSTHczZn0WVBzw2tRwy+n7cVm+etMzMXCE2sWcxKIdtE2Nj15e78Bk4BLek1f7/f/KGLCWuPmhQJ4mh2c8rU3SbvM1hJBK5kh7oSdIgGIbMivd9n+5mdfRNZBJ84URZsvENql5Lf8CzHw+8aNYoiUEDkdqCkPtJXVFliXax72Y3aLGD8SKMgvnYXYvEu8hPoI+oKtWrDUZYF+1z7K7O1ZBLhgWo1RR89Ea/ZEZITekHd4jbIEjWEe0rcvcTSlU9O4pXdFwS7GsSfhBI5qTPbT+v02wDEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EN3974zWoQ1cF95sfJnVzGIZi2NU/qvevfsejO7+b0o=; b=ozn+K+fGDXU2cPqet86OvHsSZhvRXELYQTK/qU05/KD53zesOV9F2h9zgIN+5RfTEUY09H88GAmi+0Uog7LSC7i91LpsBF9gk4ye9rHgygc+Y2QD9LGpmRUZfStQzFehEugdd65Ey/+KyeROoims88xh8afRf0T8XonzR3o4apKtbh0KNgIvpFWvhP7njHTLcphcJPbEQ3OnTe/nTqGiIvvMmZURGBdQYvEu+T+/0zGExsK7E8YnsU2hQdI/jicr/lSUVzZptERIEMMHIgVByy8e29wL+9AqVA+1iREcxF4VshZcSmi6oP/8xydcVBmRIQ5y9kzmlDSddAMLzr+8MA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EN3974zWoQ1cF95sfJnVzGIZi2NU/qvevfsejO7+b0o=; b=QhEG3U5DyGzr4W/XrcF6HP5MKa6mLEvli4hqcPJA1oG43sbALeZlNAXJKAOMr7DH9kFIdjLMtsLK00vNoyfcc2UoWQDpLFLr8Rz062GxHim8mcno+enEFz1957UZhdOSIa0LnjNND7SGfy4w4GqVqnh8eN1j61iq/cmfJIOSqD1HBnrDKdenje846IBS5XFwAQdktB+0gfQ7ejbVWL3PsUrcAv9WCtD92u7J3XkX7LzcNlBFH0aTSmL+m3MND/XG6UhfIizbi7D6J85d4E5GQxFSNnyQF5Rl5WbOJyb8bPgbfXpcdK3ljJjB0kjHh+kCHVFE4J5+Z4YtcRc15gZNxQ== Received: from DS0PR12MB7726.namprd12.prod.outlook.com (2603:10b6:8:130::6) by IA1PR12MB8537.namprd12.prod.outlook.com (2603:10b6:208:453::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8398.22; Tue, 4 Feb 2025 22:49:19 +0000 Received: from DS0PR12MB7726.namprd12.prod.outlook.com ([fe80::953f:2f80:90c5:67fe]) by DS0PR12MB7726.namprd12.prod.outlook.com ([fe80::953f:2f80:90c5:67fe%7]) with mapi id 15.20.8398.025; Tue, 4 Feb 2025 22:49:19 +0000 From: Alistair Popple To: akpm@linux-foundation.org, dan.j.williams@intel.com, linux-mm@kvack.org Cc: Alistair Popple , Alison Schofield , lina@asahilina.net, zhang.lyra@gmail.com, gerald.schaefer@linux.ibm.com, vishal.l.verma@intel.com, dave.jiang@intel.com, logang@deltatee.com, bhelgaas@google.com, jack@suse.cz, jgg@ziepe.ca, catalin.marinas@arm.com, will@kernel.org, mpe@ellerman.id.au, npiggin@gmail.com, dave.hansen@linux.intel.com, ira.weiny@intel.com, willy@infradead.org, djwong@kernel.org, tytso@mit.edu, linmiaohe@huawei.com, david@redhat.com, peterx@redhat.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, jhubbard@nvidia.com, hch@lst.de, david@fromorbit.com, chenhuacai@kernel.org, kernel@xen0n.name, loongarch@lists.linux.dev, Jason Gunthorpe Subject: [PATCH v7 09/20] mm/gup: Remove redundant check for PCI P2PDMA page Date: Wed, 5 Feb 2025 09:48:06 +1100 Message-ID: <94d782acbb52a35f15fd6738992bdcc3ff11872c.1738709036.git-series.apopple@nvidia.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: References: X-ClientProxiedBy: SY0PR01CA0002.ausprd01.prod.outlook.com (2603:10c6:10:1bb::6) To DS0PR12MB7726.namprd12.prod.outlook.com (2603:10b6:8:130::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR12MB7726:EE_|IA1PR12MB8537:EE_ X-MS-Office365-Filtering-Correlation-Id: b5d44e31-5da8-493d-d5b9-08dd456e28dd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info: kJVl8mKc58bGkweJ2PoqYUVLMEgWkbTa4h/ScGB6s66597ZnAZAw1ObNbusohPaoyqUUDx/blXJBygpGXtQlFuHSAowyPohcQ4IqNHQYVo03xfnXqB6/vwG0Bw/AhlU3+1aN/qJqrzCGICyFz8IyBiUc3YbzoRPRVjmhN2uN2so993g97mYGJtoyh4QGxH2bV3fpH2ds7uUEX6YnLPW/sPZXt/VFS9f2s6E3t22tqeuzF7FNdSwFSswGH9SK9X28ZceQfJHh+Mm5g09D0m92ASzEmyBG41pS8t2erh0Xcj0rDfgS11c7Jw+H6i6eBy7HFjw3ihNFAreMR9+ARMH+llUZ7X2qUW9jQwxFKkpxJeMTNFNGRb0qhbp3fTUP2LoKwU5D7CMR0Dd/ywx/fwg7AUyiojr17Nml/BZuok9fatH62itwsinEnqcfSYa+gRh+A+i5YY07BDHaLAo//hDp1ONnmSbNsumNH0eEtWNAom7qx0nVYfkZbl9bLofmQXVNkgV6EDiV/jmP3uc8KIOd3nRGc/kymg9+zBvQ2y/QlY9zGOeZv4eMyfpDzQ/e1GDL4C2iV3CpePaT7qhZ/d8i+75umw3xQ2R7LaO5S9YBOQZuNhYtLdj6CaPjG/dcDQP9rPK4GUx5YPYP3L5CP1GvapQZMP7bA4x6dXke5eoQ4R99l/bEbZrp70AIbZoXrzXXFd4bw7H3sWTVCuf9dcdfZ1aM0fetC+eaXDkUURwyC8x3En6HShdMUvXZU3U7UfsWHjl3EqqYT0biH7iNUx7bbgwvzohGvKN+z5LqztrkGyTo3i849w+B6G21DGBSbW27jtYFGPzCc0a4LS5cWBNZ/Q7P/u1yQtAnNLGZVmJk286jiO/MAW8E0fUUsLN9Nj4N3GvOkNQ9BZcj+QIHGNcojwdCke0bSygysNTFVtcfX3Su8U+/EXMkgK/eWzzLWuZfNUYT71TiXIu0/Pt7q+vaMCmocCJDP+aAhX1DSNbrDQu92Ed8Vax2B5uwnuG0BfGmP+lXMzo1ZkFzyFHZJak0d5rr5mkmHZ9WzR7H1YKOJuu91tAZjVx4ftCTnt26XLnb/akMHw5Xyz5yYBcK3RpvA7f4QwSjDYhwUKSgb0i9oy3dskRtwC5vGV76tbQqYZBjRWSJu2R61xpF23CB4s94e4+5qgraRB9YSN+wSoUgNNu9mhvmEPGMt1g6qx9FIO+dhG/+as05hpkDIHK6QjnSbi59rqqXzc1O7tzJmk/OMjiIgadPr+Zc/GPPF8HHTMXgpKKpThuvuZjqiYMIirRj17Is9dc0mqgQK1IT4FLEmY7oBGeP9PtTiCgTbYN1H1j5n8WuOotDTtPhZwIID5GrSY68bQ+tFPAGfEJ5um1aVcUPBYzNjwFiyADJ4O8QjHid X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR12MB7726.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(366016)(376014)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 50dh3zVZGQoAi7aOvtzpVo9n9z1wVZlSoFU2/S1Hjez6iA1HUwUDtdKHX1zcRnJUeH1QCKWi0Nd/DbQKPW6E+zSAIFR+3KmECSM7jY/6OLpqtabU1WCVGWwmJSERHTP7RnG9rlQ5SGNDFoCS5uojzwA2y5pYe8wSgCYvVUV3FxLTl9pYTzlCYLzg5VY5Q8LvdqSo8DXYqfvEuRVt1H3Ws/v/4V1IAnr9QhJw6hzrIZP/h5kYFlYaocUNohoN1wuZYFtbE/7i+oe2hwy9X+lZ4dh/FYQWm7sH775fDbUia+se20S+jengw4vSaJg0hgmbWP/jDScHy99FHtdX25q5xNQrzol3xJ8YJLXS0XrEBC7r5M0tvHlYSvkZ399e+jdQxze5VVqct5oatYK8cOFPSlaFvCB28ZXb508MsvaDxcco/ploGLi0HrG/M5NLHX+eozBjhNu0DE62w1tXA3b9mYUTmmJk3FUcAZMYlZPQUjkF/Ilrn02G0ETwTLFXYY8d15ZoiABCpLPmeC3JJysKZIfyN84ZPvxkj0CmTq/+BSj3NqBJjvLM76mBmh3wRa+IJIKqFGhWY3aH5ha2hFBaP5ZEJvtINoD4zFsafE51WrJSM1GbhKJ1RkyySWjxOzT0mZMH9IOw87HZhXmMuq7s3RK14vHPF5njNuGEgDXLPD7KEXVxKVY4D9DAv9Bm+t21IXeSWP2a98jhKvrDQTtyP5y+mtnEnqq35qOaXaesug43EhlqFPhPUbsYEon/ydrzipWHRAbcv39/GaHsB7afu45ABc8o08MFHHWOVQE3SdlRrNGVfZaqGfKFG1OEUPs/48bv4xKt0UjbwjAKB1SoxHy7aUNYfuqtv2ewAi/qDSPJDhN/ipMfFvGzFsOFgFwjRLSo1+Mjq605NfXeFFfmOtQgsPRokr2Iwp/FVxhGzxVDZnC9wQLcSIpYtfGUId66EdcxQApMp+qiksA/G2z24SfL/3U889uQ20NtCzj9AcuIEUOlVqNE1AOyEV4mDBPn5sp8ichLJ/3uVdhxmnYEDeUSDnOe0pf7K6c0/vRmk0adN1EBCqUaTQFuL6s7hVzOM+DaEJqy2SQXhp1KjhznQr7+dQ+Y001ou+X3aV1EuOO31u7fzlgATNgipQUM2AKukVum8DUrMhmRayNEmc/ykvOib9qfUQhakwG5SCUXVT9MdhRxky3uut3gCafbvI2nvXVIfboYTLRDr4XgHUdUjXlEbRZTxaHK8zAFlNlUz+YdsVMigFoCDrTUvETrY0tyWmd6a8lGcHAa1M9PSklu3w1B0l2Or2Agg4BMucnxtydeIqYKCgry2+5mSkomA2W7jbq3ExPjMOEbH0di+/VMQqwq89cr+AESt7Gl7WDVQaFuX4k7fsLkDiZ+0r1zMRdqYxjYT3QNPh19Y9pAgXWtOLLKgfsB77QJQvOjvwRTmNa81Ga/BEoakDhqhWTbIwn7cs3Rb/gavMTxwkeWqrABzYD+B3yUFmfPZnWEZj3PSJ3rQvSbczbcreNBqS+ukJ4ZS2GM2VNoonjj1sEgIw7tecHdbpzCHJa9sh5lG4qxIinaVNL7QhtVSymmV6ziuS2L X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: b5d44e31-5da8-493d-d5b9-08dd456e28dd X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB7726.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2025 22:49:19.2060 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JHPp4zN/aMieY4pdIrX/njIOR8/eOSknt0x1CMV+iw5PUqExOOXmmZ2kd0zwxGuZcEGZzEhfY0QGlN4Gg2AHww== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8537 X-Stat-Signature: yzt7qfh7jwtqm7m7q1c7o7bup4eogfk8 X-Rspamd-Queue-Id: 0FFAA4000A X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1738709439-298165 X-HE-Meta: U2FsdGVkX184owUfXWwlF1reYNcj+tQZT8snZIT4oobzilZTS3RJYbu9aE8NGgASBkDqIf65P//6wvmt1FA/s4GqrTawQQHlqZefPSwCu4xSRCu6GnxTU4VRRoHkDtnCCRiCdmoyrhSgjiagHI6sotWP/VomPC47Fxqq03tnJSUA+aHr6pPCvSB0XNQk2VDRMUkgO8410UldNrkmZ7XGRIl5F01yqq0dcXRLPC7bBZGv2ZdPKhf7i6+TBvQOQVlrZZT48F8JInlIINnSaLvJod3Bez6MX6usgXdjZaJMleFnhV0lzHbTn5UpNrOqvwr3FEiGg5TQ23m+GNCXPFhA5yFLwozkcY++Yy1XRYAfxOrSuFXoqBpPJIBBU2SPcAjjGW1gD0AEFKRbH+GJhhvqhKg6DibPzSePAxewIRUBGib2A4WjwpqSYjmU/Dk5hNhpJoQtxMt7xFm1uY55VZ+FWYPrDK71gHcvYuz6UmIrp33VahGIu8GajfcEIA5zDp15z5jwBx9BATJB+BSe89S7BMsVf7r239rAj5NNQNqfmJMtvEpc47n08/0rPj4f1iFzRh19u4sR8CoS9YBNZT4f9EMo9pQY7u8PJpC1Ruxqb5EdVUnajtGHSTDpSp8XS95yVaFslJpm5vTvw2WLuN505ZwLI+jt03JaKyoMvc4qRxQFzixO1Vwe06PtXRl+6fqRN2Wma2fe1p8vABgg/XFEarh+uYoxeTRpODviFlXG5NDCWRpwdutxktXrvyIi3fiakfu9T/DsRyg84J6dalQUc/K6C4f/Cm7s5FJoc0wE1nii5czqlOd7xacs5zxYSwP05AR0E282JAMoQYY1o3ntmBrcTwS8YCG8BLU8LyRggtUwP9UMLqN6H2vibDKHZIzM+2STfLlDuNX0DWKfUHolupbr3qMwglTlCPyIlAt/M5iqy742+GmaefbfIhDefHV2MgVXBAVMmpkY9zNpOiE iqyQ9Pt9 0+lSLNlfOgDHM2HditsYGRVuYpgt4LPo0LPN8fBGyDy2rcw2IZ0KOfJ0O2AYl72+sEibECYhKk9XH6/0X5dKZJXyDQkQpmuJ+xSTVGK08LtX9wYldcUNK5tHitu5ptT6Ozxa60+YbQ2BgvjS4mtVZjqFGxa6JozD01o5RmxTwJ5/6PC3KXFMNm2a2fkFxZsQW3vtwbkXsZuSXNj673Gds+jArxBeSTtbR4vPABWe5U4ARFbbsggTJ1+7GMRII4/8qQtHRHQU0UKBngSPpVw9R8vCOXIn2I/0gGInE93/lfUKOqPK3/QvZ01+v1RW5YIeyHZFrTSKmFTgl5tgMmrvBGjNpVUK2086zpJfruvLBpLB99581dC+fRhv7kOyoheUtzxK1GohWZjKrAte/JVpTHzW0RIhcZ5Zljqh/lFpNcfpcvmMrUATuVOnl09AqHSYoywH2Gpdx+cPfg9k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: PCI P2PDMA pages are not mapped with pXX_devmap PTEs therefore the check in __gup_device_huge() is redundant. Remove it Signed-off-by: Alistair Popple Reviewed-by: Jason Gunthorpe Reviewed-by: Dan Wiliams Acked-by: David Hildenbrand --- mm/gup.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/mm/gup.c b/mm/gup.c index 3883b30..10f1ddd 100644 --- a/mm/gup.c +++ b/mm/gup.c @@ -3010,11 +3010,6 @@ static int gup_fast_devmap_leaf(unsigned long pfn, unsigned long addr, break; } - if (!(flags & FOLL_PCI_P2PDMA) && is_pci_p2pdma_page(page)) { - gup_fast_undo_dev_pagemap(nr, nr_start, flags, pages); - break; - } - folio = try_grab_folio_fast(page, 1, flags); if (!folio) { gup_fast_undo_dev_pagemap(nr, nr_start, flags, pages);