diff mbox series

[3/4] hugetlb: Remove redundant validation in has_same_uncharge_info()

Message ID 97fc68d3f8d34f63c204645e10d7a718997e50b7.1634797639.git.baolin.wang@linux.alibaba.com (mailing list archive)
State New
Headers show
Series Some cleanups and improvements for hugetlb | expand

Commit Message

Baolin Wang Oct. 21, 2021, 6:31 a.m. UTC 
The callers of has_same_uncharge_info() has accessed the original file_region
and new file_region, and they are impossible to be NULL now. So we can remove
the file_region validation in has_same_uncharge_info() to simplify the code.

Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
---
 mm/hugetlb.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Mike Kravetz Oct. 22, 2021, 9:04 p.m. UTC | #1 
On 10/20/21 11:31 PM, Baolin Wang wrote:
> The callers of has_same_uncharge_info() has accessed the original file_region
> and new file_region, and they are impossible to be NULL now. So we can remove
> the file_region validation in has_same_uncharge_info() to simplify the code.
> 
> Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
> ---
>  mm/hugetlb.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Thanks!

Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
diff mbox series

Patch

diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index 8902b07..5922629 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -333,8 +333,7 @@  static bool has_same_uncharge_info(struct file_region *rg,
 				   struct file_region *org)
 {
 #ifdef CONFIG_CGROUP_HUGETLB
-	return rg && org &&
-	       rg->reservation_counter == org->reservation_counter &&
+	return rg->reservation_counter == org->reservation_counter &&
 	       rg->css == org->css;
 
 #else