From patchwork Thu Mar 30 10:44:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johannes Thumshirn X-Patchwork-Id: 13193878 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD83EC761A6 for ; Thu, 30 Mar 2023 10:45:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5EF806B007E; Thu, 30 Mar 2023 06:45:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 48DBB280006; Thu, 30 Mar 2023 06:45:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2DFF2280001; Thu, 30 Mar 2023 06:45:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1AB376B007E for ; Thu, 30 Mar 2023 06:45:05 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id F207FA089F for ; Thu, 30 Mar 2023 10:45:04 +0000 (UTC) X-FDA: 80625232128.21.67E53DE Received: from esa3.hgst.iphmx.com (esa3.hgst.iphmx.com [216.71.153.141]) by imf26.hostedemail.com (Postfix) with ESMTP id E259A140011 for ; Thu, 30 Mar 2023 10:45:02 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=QVPs8zR0; spf=pass (imf26.hostedemail.com: domain of "prvs=446327cdf=johannes.thumshirn@wdc.com" designates 216.71.153.141 as permitted sender) smtp.mailfrom="prvs=446327cdf=johannes.thumshirn@wdc.com"; dmarc=pass (policy=quarantine) header.from=wdc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680173103; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fmpnWNPMV+BqMLoDCsDPI2a19KpwiU9iA+gUwkLC9vI=; b=a15as4301HaptmpNjGwLmThfIr9AbWqPoBZOkBr8J91BZVr3yNiOOfMdH3UgQTHveo96ZD LKInp0GX3b7LbW3SlnCceaPNCkS10xFfAV1uQxrdseXhNw9Or7aOHyeKyJj6yfAAHzdYp4 SFV+DN5aRopVEVljXvpgs9cojzlb8tM= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=QVPs8zR0; spf=pass (imf26.hostedemail.com: domain of "prvs=446327cdf=johannes.thumshirn@wdc.com" designates 216.71.153.141 as permitted sender) smtp.mailfrom="prvs=446327cdf=johannes.thumshirn@wdc.com"; dmarc=pass (policy=quarantine) header.from=wdc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680173103; a=rsa-sha256; cv=none; b=wCmstdN+QkBsvnhim+97Ea/o7lmSgYI2+gIFyBd4bUgM3QcHw6h/2ifztu/ecUxFdRmSa5 TIv1KdG1W9wUXSQbZnA+ILZ1RMgYzNPp3WVimBFyPWA0qj7J8xWfEgSU1eD3sOy+qRO82Q ttlKaes6TQPE+y+Uh8Q4dU4D9TQcOEY= DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1680173103; x=1711709103; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=9YnFTpWsIBbNef/OiYe0uKZ66yfnQqenOqdfFhTWuvw=; b=QVPs8zR0BRa2WNd7sJeSgXbf/Ub4AijvYOzeO3OIDdSlEeh8b9Cv0dNe JcSAh1DZcuzlIewcDv7euZxpJ/kQKMVVTbBaDsJ2PmSUhs6vFdR5pTJIX UETzXDN+s7VOI1HEjWLUjK+DuHhNgUrv3CTm9NaLstBb4Ao4tCn/jP93/ zdDAgkZuruFv9pp0e1zApAcdUxguDMfZwQuMrI8htN3gnh14MhyNqIADe 3+fvSLfkbSeNHYjfOE8PVz+o/ovNCus8pndpp2W0IN3tPm0v0UzkDNCmZ oKnD8iBba33e3AklwXP2EtZbi8W1FpV9okFmdu7S/8+n7hokUPewlsUPR g==; X-IronPort-AV: E=Sophos;i="5.98,303,1673884800"; d="scan'208";a="231854029" Received: from h199-255-45-15.hgst.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 30 Mar 2023 18:45:02 +0800 IronPort-SDR: TE9T4NG0izGmDM+rQ4cQ4aq/wzpFhkLbXll3nkZu312MzdZlKmh9rDp5TZb7FBW/YFFxoqLzQg z8zVzEfOhgM0HumxgWwqUrakvnaef2h9mv13ZReyZQXnfvdWk14vv8QwpbzSde4TZMKfIytpSC 6uh8j+TVqMDrZvAZzlL2/PRUCw1/8MfKERAACjfNrf9Cf1IctDbA+xne0jf+71C3wuDlG4bskt jiww/aHGEi6f54La4baiuUVGXtiispRfCKKb9Ypzv7D5A6rbO6WhCVyYkZvwEBsWsOjwKuuALl Jg4= Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 30 Mar 2023 02:55:29 -0700 IronPort-SDR: 9/iVByN1BTBiF+2N/dyRq0R7dQSPqShiTdspahbVYlwZj+qd277O1HWwqfoLFDxzoWSe+cmGNO qkqMCZzgrdZnDhpQxYdEe8150myn5LsK8KEx5pL72+ObD0hqMaaHSizvdtrMKOqlTNP+VQELhc NlTnbrlHYwL6lfM55WWo+X+nqbpVvrNh8MXJJfN+oROGcrGXbtZ95QXnOLEHZI8U/WSie1EYFD ciM8A+htMWi8T8Q2A6kN9QQtMNJHy+EVASUqPt+O4sCYrrpZ40AnMpPDuYxlZJyUb2MJgf0HsW yDM= WDCIronportException: Internal Received: from unknown (HELO redsun91.ssa.fujisawa.hgst.com) ([10.149.66.72]) by uls-op-cesaip01.wdc.com with ESMTP; 30 Mar 2023 03:45:00 -0700 From: Johannes Thumshirn To: Jens Axboe Cc: Christoph Hellwig , Hannes Reinecke , Chaitanya Kulkarni , Damien Le Moal , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, Song Liu , linux-raid@vger.kernel.org, Mike Snitzer , Matthew Wilcox , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Bob Peterson , Andreas Gruenbacher , David Sterba , linux-btrfs@vger.kernel.org, Johannes Thumshirn , Damien Le Moal Subject: [PATCH v2 19/19] block: mark bio_add_page as __must_check Date: Thu, 30 Mar 2023 03:44:01 -0700 Message-Id: <981a2b8809dedbd6dd756d7af1df4251944f42b0.1680172791.git.johannes.thumshirn@wdc.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: References: MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: E259A140011 X-Stat-Signature: nekka631gqoxgambrinfxc78as5u197e X-HE-Tag: 1680173102-708641 X-HE-Meta: U2FsdGVkX1/WLjm8z3JlmeUhSH/8MIjWwtn9eGfZl64uiOQHGQZiu+LVgNhQ3DWQUrdfAhdmaBfa6DB3n9dhTei0iIO95AMoYwwYQsG90uxcUW5nVMEZO6P9gGXWNjYhcqELxAuMj0bKgRo9n5fsEmD8sz7KYm/676dlncRPzF3J23JHzLkVqjtp5P45apGmXe8110ZJpss9O0MYSgvxcdb0laMspONXdrXMPuTPO5QnnlVFKgNazZWFrM19hVvBu76s6m4yUKvwg+Ksn23b0lEHamq8JiSnIuNCpyjanZz30iF1n5dUscCTcC0wi3wl/hpURxgGEKT0nz3jau3BmM6p9cHuTKiO956XHnVDlDoMP76yw4xbxCM7cbI7kuJrys6Xcb9gliQl9V355YYOtw/5mCEwlPL34LZiPap8uvDCZInYLbXEZgi29+pD7kW8l4vGwyIqu3T4BTTXcaTkIMlKb3Wzk2HpLCpMx7xMRpaOHtFnMiFQEtcX/XPs8dXrx5rTrDHephbssUnOTSUgcqZ+bFednh49JKDgTBlPBUZli1W3zkR4UCx9e4/iUsnV8wASdbIbULUYYJPgq3cE4a/In7grdms78G38QYMlLI87LatIFBgAJe4TFn5A/EK3tVrOocsuyo0iG3D4QA+x313v4MwzxFYKJLv6te19Xg5zOiG+M5QDBMTDu9LVfv+fFBfhYIHwFwXtI3YRs9i/Ffu/AlQyEvwVuzrjjYp+mG9ruXLJGPCn/i73gVMMhwy8syCe6zMAJN8qEBsJX2KGTiPAqptitI/XNVICVON6xkG7Kf8oH1VKL+xClqL6H2LsviHILxvtPbt6h9s4NPJpQrK9SprMptxXhx1mSM3Zot+iGGoDsnVOwt6ovh50De+/su2zEUjga2AgnbPmhniLfrMiqVapynPcmSWgP1ZpKbMZDbhX9dk4uVV7Mf2y2ciODdu/v295d4cCh7rbNzZ VfaXAb80 yZT+j6skuwECWJRQdRyQGfyZQZZPi9wPIGgcJXxn/caoQVd4HrXWEMF/Rlo2kJX/Oy/tJKwK/RSium4o3utw3CMH5pOpEDdDzoXh6ARqjfksROE2Zhl01rnp6LoaDB8+r6un9cFamJFkRAYsfj6Mz3sLvWQsmUI97YruiDvYBhBQdyKHs2ltWfFit82VKt0UR5hGvhyggwaNaUnikgm5oYfY7UUQJcQcwGgF7I6Bo93J+vpcz0cp/hbMz2RapxXo0BXu5+dGwyAgB/4O53Q/PEwtEn6sMLa03YCBI5WWE2mI1H8K/WLD0NpvzyqKQWlwtDdnMqCDcaZ5tY8vdYGevm9Hl8xTp1pedE6XprBpKSFkSJH3EWUH+lSkbfwSvdBlrnOR4vfA6HCYd81MWoTRQya+GEvgaqXEEOJjg X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Now that all users of bio_add_page check for the return value, mark bio_add_page as __must_check. Signed-off-by: Johannes Thumshirn Reviewed-by: Damien Le Moal --- include/linux/bio.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/bio.h b/include/linux/bio.h index d766be7152e1..0f8a8d7a6384 100644 --- a/include/linux/bio.h +++ b/include/linux/bio.h @@ -465,7 +465,7 @@ extern void bio_uninit(struct bio *); void bio_reset(struct bio *bio, struct block_device *bdev, blk_opf_t opf); void bio_chain(struct bio *, struct bio *); -int bio_add_page(struct bio *, struct page *, unsigned len, unsigned off); +int __must_check bio_add_page(struct bio *, struct page *, unsigned len, unsigned off); bool bio_add_folio(struct bio *, struct folio *, size_t len, size_t off); extern int bio_add_pc_page(struct request_queue *, struct bio *, struct page *, unsigned int, unsigned int);