From patchwork Mon Apr 7 11:31:35 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baolin Wang X-Patchwork-Id: 14040274 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB088C3601E for ; Mon, 7 Apr 2025 11:31:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B8F4C6B0008; Mon, 7 Apr 2025 07:31:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B17806B000A; Mon, 7 Apr 2025 07:31:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B88A6B000C; Mon, 7 Apr 2025 07:31:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7A1E56B0008 for ; Mon, 7 Apr 2025 07:31:47 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 7E2E1BAFBB for ; Mon, 7 Apr 2025 11:31:47 +0000 (UTC) X-FDA: 83307033054.03.D99F7D9 Received: from out30-112.freemail.mail.aliyun.com (out30-112.freemail.mail.aliyun.com [115.124.30.112]) by imf08.hostedemail.com (Postfix) with ESMTP id C89F916000C for ; Mon, 7 Apr 2025 11:31:44 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=cAFLNU+f; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf08.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.112 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744025506; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=NoR+jnV8vnFcnLEbN4HTkH2CWtR7FahKRF30+nlnMyQ=; b=D5sjKEUiLXyNC3yCZB/Nq3aO7tOcRj8vApSmonVUevpX7fHpVwWIvsfxdmdcpOGSYBYgfY sYBL1LCq9BeMCi/3satKL+JeegeV4GDgpbgIIgaEu2dupdsTUVb4f2aJmT6bRhHoOTrxej 8wpRtQZKgjeeyVSEMOBNtXpjiTxxXGA= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=cAFLNU+f; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf08.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.112 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744025506; a=rsa-sha256; cv=none; b=FoxBAt74IugA90yzAybDwMTKDaQbvYdCBGUdldAb0xTn5XKUYj/wOL7f51tFhjATB6ICZA mHgyVvpRfwAguxkxtMI0xpIMvhxpKbdiWiiJmGGCZw6WucUloF59IGKTM0UYOHk6AZr91s hT9bagjZJUzJTjC9q7v1HCxQiK/zsXg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1744025501; h=From:To:Subject:Date:Message-ID:MIME-Version; bh=NoR+jnV8vnFcnLEbN4HTkH2CWtR7FahKRF30+nlnMyQ=; b=cAFLNU+f4wh/quKdsWf4nl1AB/LO6bZ7TfRLsJuzHwmR32ciOVEpIe4lp1eXgpvpF8j0C9vf9WhqevNYz1ltRgLF/M0mP798rjSk02NF+S6qKSJqKRT1qX/4uqxK8511XaE/2TlMjhny3tKDyjrt4oRwKKzCiksIQyLsTIuPiWw= Received: from localhost(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0WVvlCKt_1744025500 cluster:ay36) by smtp.aliyun-inc.com; Mon, 07 Apr 2025 19:31:40 +0800 From: Baolin Wang To: akpm@linux-foundation.org, hughd@google.com Cc: willy@infradead.org, david@redhat.com, 21cnbao@gmail.com, ryan.roberts@arm.com, ziy@nvidia.com, baolin.wang@linux.alibaba.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] selftests: mincore: fix tmpfs mincore test failure Date: Mon, 7 Apr 2025 19:31:35 +0800 Message-ID: <9a00856cc6a8b4e46f4ab8b1af11ce5fc1a31851.1744025467.git.baolin.wang@linux.alibaba.com> X-Mailer: git-send-email 2.43.5 MIME-Version: 1.0 X-Rspamd-Server: rspam01 X-Stat-Signature: jxubmq84nc3hqm74dn9egxpgyfb4be57 X-Rspam-User: X-Rspamd-Queue-Id: C89F916000C X-HE-Tag: 1744025504-724275 X-HE-Meta: U2FsdGVkX18SPLIYjILyHqit1NvYcinB7dx7TjxEzWduXqlb1mgGn7PHAXktS+SsdQA/uJoLJ6sr+P3xDp3CGvtXM7Unddzug4yd5Lluh6EcWfQJMZn00mwbMSL3CiiQYZmhbo5CasBN3efHCgR1aqrzkTkEVHZ6+fdOHAC3UBXA+FS+Af6LpX182oWyUCiafvRXCGb2BNvQ0ui8Fqy1QS9FGk9+bHUBy5o/eSiX1/0miPbexQhPc7+lkfFuspL4kz2llABALYE3U6LId8I+9OqLn1bznQiBtTothVhjvVGW3FBL6yaFZbKcONUkguacaaRNchjWk7CikPJ8SrtoJxQkJ6jBsT9DffRcdhmf3Zsu/uCqz8YvqIuOi8zT1vOKs1DWaXceZj8t1kUG8Q99MW4BC2B6dUlyu9apuF2/LLNiUjm/onX8yOei5ehtwU7LdY//plOTmtJkdNmQ8a5U9MN3mPqxmWRuxhrMLa0w7ZKEr1Sl3x8u53noC0RIxNy7nhSovZj0OJB/N9pZxt1qjvIp7DS9k7oIDcjf6C7+X26CxNz4NciChRrISjF63SxeJnBCK/Y0aNAshG2UZOPXCUsJRLne7ddxEcdKNk+f7pVHkRiaP0ykPf4qiLfCbB0JRyiHz6TRjOKM59xjq8u2AAeaFUhtC/cAJ9wLVdYr/K99woa5ViIS3FYaH3QJp3QHq0SlPfUDHIUfx1QrrdVwVoc3jFWRsvc+KNuZTlCbKLf/n/y0Kp587ttgK73bJd5ZyxsjK06s1owpxv8zPINJn8r5FWdwsexmtEPtlOLJnzgl66ubC31iP7cCCOxhfwnqDfaujNhhKknHIs3hfTN5exfaITtGCyxkXlrnhWbomCVGDm1j94cUETlW7sB1wGlD9s1pD9QLUaoRFhl85KLrGgQ+ldS0GdI31f21R5THc8BpreTzbRH8e/wGL1Am6byHEvPKiFuIBGLiPGYiHpW EbLh+/bp QSUWUONySauN5qI0+kTkRAg9gVK/e2YDfXH8WtuDMC9oOkmcbLjBKNOa741GVfZuUvUwA1ORZLH3IMkM1eC6plEsMD5Dq7yMDCvUgXwgB6spuhIbT3u47A+CpBK+BEYQpzuzcRraaOHM8brBrbGU+dSSDmAciJg6oA9MvuotTsmHDDYF3zUDPXo1x28SrgdqPkokWVEewjNJW6d1lpWCty2wjXYCIr2N3rD4v X-Bogosity: Ham, tests=bogofilter, spamicity=0.000007, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: When running mincore test cases, I encountered the following failures: " mincore_selftest.c:359:check_tmpfs_mmap:Expected ra_pages (511) == 0 (0) mincore_selftest.c:360:check_tmpfs_mmap:Read-ahead pages found in memory check_tmpfs_mmap: Test terminated by assertion FAIL global.check_tmpfs_mmap not ok 5 global.check_tmpfs_mmap FAILED: 4 / 5 tests passed " The reason for the test case failure is that my system automatically enabled tmpfs large folio allocation by adding the 'transparent_hugepage_tmpfs=always' cmdline. However, the test case still expects the tmpfs mounted on /dev/shm to allocate small folios, which leads to assertion failures when verifying readahead pages. As discussed with David, there's no reason to continue checking the readahead logic for tmpfs. Drop it to fix this issue. Signed-off-by: Baolin Wang Acked-by: Zi Yan Acked-by: David Hildenbrand --- Changes from v1: - Drop the readahead logic check, per David. --- .../testing/selftests/mincore/mincore_selftest.c | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/tools/testing/selftests/mincore/mincore_selftest.c b/tools/testing/selftests/mincore/mincore_selftest.c index e949a43a6145..0fd4b00bd345 100644 --- a/tools/testing/selftests/mincore/mincore_selftest.c +++ b/tools/testing/selftests/mincore/mincore_selftest.c @@ -286,8 +286,7 @@ TEST(check_file_mmap) /* * Test mincore() behavior on a page backed by a tmpfs file. This test - * performs the same steps as the previous one. However, we don't expect - * any readahead in this case. + * performs the same steps as the previous one. */ TEST(check_tmpfs_mmap) { @@ -298,7 +297,6 @@ TEST(check_tmpfs_mmap) int page_size; int fd; int i; - int ra_pages = 0; page_size = sysconf(_SC_PAGESIZE); vec_size = FILE_SIZE / page_size; @@ -341,8 +339,7 @@ TEST(check_tmpfs_mmap) } /* - * Touch a page in the middle of the mapping. We expect only - * that page to be fetched into memory. + * Touch a page in the middle of the mapping. */ addr[FILE_SIZE / 2] = 1; retval = mincore(addr, FILE_SIZE, vec); @@ -351,15 +348,6 @@ TEST(check_tmpfs_mmap) TH_LOG("Page not found in memory after use"); } - i = FILE_SIZE / 2 / page_size + 1; - while (i < vec_size && vec[i]) { - ra_pages++; - i++; - } - ASSERT_EQ(ra_pages, 0) { - TH_LOG("Read-ahead pages found in memory"); - } - munmap(addr, FILE_SIZE); close(fd); free(vec);