From patchwork Thu May 17 11:33:17 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Andreas_Gr=C3=BCnbacher?= X-Patchwork-Id: 10406633 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 95CE460230 for ; Thu, 17 May 2018 11:33:22 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 05C5726E98 for ; Thu, 17 May 2018 11:33:22 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EE3222852B; Thu, 17 May 2018 11:33:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6DA5126E98 for ; Thu, 17 May 2018 11:33:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 294586B04D6; Thu, 17 May 2018 07:33:20 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 21BF76B04D7; Thu, 17 May 2018 07:33:20 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 132F16B04D8; Thu, 17 May 2018 07:33:20 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-wr0-f198.google.com (mail-wr0-f198.google.com [209.85.128.198]) by kanga.kvack.org (Postfix) with ESMTP id B192D6B04D6 for ; Thu, 17 May 2018 07:33:19 -0400 (EDT) Received: by mail-wr0-f198.google.com with SMTP id y6-v6so2867905wrm.10 for ; Thu, 17 May 2018 04:33:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:mime-version:in-reply-to :references:from:date:message-id:subject:to:cc; bh=UvCzzD0N+E53BQA+IXZ2XdiH/FbmeOgACI8PUXYhYQo=; b=SY7ucgiDUAeD5CG5R2s9qzjdYYMmso+ir3hJCjHZoXdToUeh82NsIio9IZjo5mOSLV 1C4S0+KDcOWHJBklc6BYFmfgc/H86o+xL29waoQTOaRnFkuIfigRUYNH9wqeDpwP5fI3 t2/QRRMTpUC47J7vV7nHt37keyuBhdWLqYGAkai5VffwRK0h2syH/xjCC36hWakieUH3 VIoUVJzRefxcwfLgCe9GfrWXea7crl2CtC1cKjko4RkpU0ckvSFtamEov0e0+SuK+kuF gVw6lci/ghoo8BOdKaT9pAe6dwb70d0DcOlANLGHyuFRNSlcmfCN/yddy8wi/erAhsHJ d8xQ== X-Gm-Message-State: ALKqPwd2iXRZiFlPFJ1UKQ+G4XmiOXe9tZm7muemg9/3X2Z3DfFDFMxN Qp+YMxjjjgfFpXf8ZAQbFsMwzxD74z/ixR06YBcVAbijLyk/1/R5PcT1QcbzeJDc8gLA14d2KY5 /WWlYSfXX0m3uVojAfi5qUo6t/BbEn/NOp2oYVcn0fijuP8p4pLEwV48Svds7VVTlUP0urNI5y/ 0H3GpIGtPllUBl5cDQs9EL99a3SUqNJzabEuU55iIaTKDZF78uc2BJWzS22JaU9xUTLZRyq0VO1 +HkbJvw4cU/adlVlbqmMgeNUMtktIkA+K2/MN6f4ivSe1FC/Kzi59JbqFpu4zJW6dQy+wh7WIfd HgTqBn6E3DPdT2DeATupBdTEs/5tiE9hdAm6vG6fvp4YmyStCQ/fYbrywedbGlcuTRj7jXahdAw q X-Received: by 2002:adf:9aea:: with SMTP id a97-v6mr4370099wrc.21.1526556799190; Thu, 17 May 2018 04:33:19 -0700 (PDT) X-Received: by 2002:adf:9aea:: with SMTP id a97-v6mr4370045wrc.21.1526556798206; Thu, 17 May 2018 04:33:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526556798; cv=none; d=google.com; s=arc-20160816; b=l/PBb32XRB80WuPo36TeMMO4zlyw1xpX3dsOIawNP09OfZNw/POZVqtA9Ba0Hroiqs rIQgz+kAs+iF6LipM6PWFCJSIf6zJOxH/ZBq5KJ8mlVeTowpelYPFDFWKaWp1NNA/8Lp gmlS8ZtOLHdDGxsjLgNTd3oeDRoFM4jcyuWERbQLSv+mchbFngRRRJG0joQvMzJAO0KV Rp0sz2MOej2xD8S6v5J8imWqy1NLmtSt8dA6Wmqj/OCFdCwjr24sFEv1H+IuoQcOmPER FRRFsf7VGwnCisYAvhWdTYSE90lYwe5PXnQSi9TgG730DnolIst905Ej3X0xO5coI74a 3R/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:dkim-signature:arc-authentication-results; bh=UvCzzD0N+E53BQA+IXZ2XdiH/FbmeOgACI8PUXYhYQo=; b=F/0H9FyAXZizKGqMnXKY/ZSzIMvF1CLoZbuHaUVfLEBnFKT9AgPGgls6LDrQih/xH/ hPADaN/RGYPcsva78kqZXn9N2sN2WYlQTdntfrGe9GVAO6WBLKMdsWVIZCU9ErDSbace 39su9NZ+WCzhla4lnMW79UP1wFvWyecNm0wPB7qUUyA8TLBhVSCsYL2ZXfnAzG80c1jO sbKX6BiEz9rtk+o08p0eH/WXJuZz3mcCIDVX/8BFCiCwbb7NWjg1sTYUlH6/mWpEz6FL 1vbM/2EEmQXbUlDL/mJZ07DVNelMvXcmNahNa9vA6xydVSWUNYxLCBdN5988ba3d2bo3 91yg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=KZ7DCtwW; spf=pass (google.com: domain of andreas.gruenbacher@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=andreas.gruenbacher@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id p65-v6sor1524106wmg.54.2018.05.17.04.33.17 for (Google Transport Security); Thu, 17 May 2018 04:33:18 -0700 (PDT) Received-SPF: pass (google.com: domain of andreas.gruenbacher@gmail.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=KZ7DCtwW; spf=pass (google.com: domain of andreas.gruenbacher@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=andreas.gruenbacher@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=UvCzzD0N+E53BQA+IXZ2XdiH/FbmeOgACI8PUXYhYQo=; b=KZ7DCtwWvhoTFr6Lp1jr1/+fje2GJyHUfbDFGhxY37dycBc1CnLTq15Ra7V1xIoUf4 O9fGIlGT23jNu6OREtYjSj346bYw1absoveC8IJZTyRXda8i2qZ1n+RNe1q6hWUp89VG y9wcnqD/ts6Bw8hOUOauiukKrdsh4yOy6EoHAL+y2tMlQ9OowFoOjqh+QQQstYu1A/G+ E0vbelLnAmBSddKZazjdM0Z5Q27ItVgwzZw+gfUVR7/H9GOHoSD7DNvDlRWwk/n2D1Ui C2cvo+XUtjcIuVeR2Rp290zJT3AlusBw9pVd87Ce37Orz/C32osMo5jjuHH+H3h9wWPD Hs5A== X-Google-Smtp-Source: AB8JxZrNs4UESWQsYHCppnDB530R04IpSA/C4PBUmefd7IGnxeDQAss+KAYS8n216oMbfuhalTJEz7jxdNWevPjiH90= X-Received: by 2002:a1c:c1c9:: with SMTP id r192-v6mr1449872wmf.120.1526556797630; Thu, 17 May 2018 04:33:17 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:adf:9592:0:0:0:0:0 with HTTP; Thu, 17 May 2018 04:33:17 -0700 (PDT) In-Reply-To: <20180509074830.16196-5-hch@lst.de> References: <20180509074830.16196-1-hch@lst.de> <20180509074830.16196-5-hch@lst.de> From: =?UTF-8?Q?Andreas_Gr=C3=BCnbacher?= Date: Thu, 17 May 2018 13:33:17 +0200 Message-ID: Subject: Re: [PATCH 04/33] fs: remove the buffer_unwritten check in page_seek_hole_data To: Christoph Hellwig Cc: linux-xfs@vger.kernel.org, Linux FS-devel Mailing List , linux-block@vger.kernel.org, linux-mm@kvack.org X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP 2018-05-09 9:48 GMT+02:00 Christoph Hellwig : > We only call into this function through the iomap iterators, so we already > know the buffer is unwritten. In addition to that we always require the > uptodate flag that is ORed with the result anyway. Please update the page_cache_seek_hole_data description as well: Thanks, Andreas --- a/fs/iomap.c +++ b/fs/iomap.c @@ -647,8 +647,8 @@ * Seek for SEEK_DATA / SEEK_HOLE in the page cache. * * Within unwritten extents, the page cache determines which parts are holes - * and which are data: unwritten and uptodate buffer heads count as data; - * everything else counts as a hole. + * and which are data: uptodate buffer heads count as data; everything else + * counts as a hole. * * Returns the resulting offset on successs, and -ENOENT otherwise. */