| Message ID | YXlKqCPY9suM4mfT@alley (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | vsprintf: Update %pGp documentation about that it prints hex value | expand |
On Wed, Oct 27, 2021 at 8:48 PM Petr Mladek <pmladek@suse.com> wrote: > > The commit 23efd0804c0a869dfb1e7 ("vsprintf: Make %pGp print > the hex value") changed the behavior of %pGp printk format. > Update the documentation accordingly. > > Fixes: 23efd0804c0a869dfb1e7 ("vsprintf: Make %pGp print the hex value") > Signed-off-by: Petr Mladek <pmladek@suse.com> Reviewed-by: Yafang Shao <laoar.shao@gmail.com> > --- > The commit ID 23efd0804c0a869dfb1e7 is taken from printk/linux.git, > branch for-5.16-vsprintf-pgp. It should get preserved when the branch > is merged into Linus tree. > > Documentation/core-api/printk-formats.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/core-api/printk-formats.rst b/Documentation/core-api/printk-formats.rst > index e08bbe9b0cbf..4eff98e06b4b 100644 > --- a/Documentation/core-api/printk-formats.rst > +++ b/Documentation/core-api/printk-formats.rst > @@ -580,7 +580,7 @@ Flags bitfields such as page flags, gfp_flags > > :: > > - %pGp referenced|uptodate|lru|active|private|node=0|zone=2|lastcpupid=0x1fffff > + %pGp 0x17ffffc0002036(referenced|uptodate|lru|active|private|node=0|zone=2|lastcpupid=0x1fffff > %pGg GFP_USER|GFP_DMA32|GFP_NOWARN > %pGv read|exec|mayread|maywrite|mayexec|denywrite > > -- > 2.26.2
On Fri, Oct 29, 2021 at 10:15 AM Yafang Shao <laoar.shao@gmail.com> wrote: > > On Wed, Oct 27, 2021 at 8:48 PM Petr Mladek <pmladek@suse.com> wrote: > > > > The commit 23efd0804c0a869dfb1e7 ("vsprintf: Make %pGp print > > the hex value") changed the behavior of %pGp printk format. > > Update the documentation accordingly. > > > > Fixes: 23efd0804c0a869dfb1e7 ("vsprintf: Make %pGp print the hex value") > > Signed-off-by: Petr Mladek <pmladek@suse.com> > > Reviewed-by: Yafang Shao <laoar.shao@gmail.com> > With below minor change: - %pGp 0x17ffffc0002036(referenced|uptodate|lru|active|private|node=0|zone=2|lastcpupid=0x1fffff + %pGp 0x17ffffc0002036(referenced|uptodate|lru|active|private|node=0|zone=2|lastcpupid=0x1fffff) The ')' is lost. I just checked the data before :( > > --- > > The commit ID 23efd0804c0a869dfb1e7 is taken from printk/linux.git, > > branch for-5.16-vsprintf-pgp. It should get preserved when the branch > > is merged into Linus tree. > > > > Documentation/core-api/printk-formats.rst | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Documentation/core-api/printk-formats.rst b/Documentation/core-api/printk-formats.rst > > index e08bbe9b0cbf..4eff98e06b4b 100644 > > --- a/Documentation/core-api/printk-formats.rst > > +++ b/Documentation/core-api/printk-formats.rst > > @@ -580,7 +580,7 @@ Flags bitfields such as page flags, gfp_flags > > > > :: > > > > - %pGp referenced|uptodate|lru|active|private|node=0|zone=2|lastcpupid=0x1fffff > > + %pGp 0x17ffffc0002036(referenced|uptodate|lru|active|private|node=0|zone=2|lastcpupid=0x1fffff > > %pGg GFP_USER|GFP_DMA32|GFP_NOWARN > > %pGv read|exec|mayread|maywrite|mayexec|denywrite > > > > -- > > 2.26.2 > > > > -- > Thanks > Yafang
On Fri 2021-10-29 10:18:29, Yafang Shao wrote: > On Fri, Oct 29, 2021 at 10:15 AM Yafang Shao <laoar.shao@gmail.com> wrote: > > > > On Wed, Oct 27, 2021 at 8:48 PM Petr Mladek <pmladek@suse.com> wrote: > > > > > > The commit 23efd0804c0a869dfb1e7 ("vsprintf: Make %pGp print > > > the hex value") changed the behavior of %pGp printk format. > > > Update the documentation accordingly. > > > > > > Fixes: 23efd0804c0a869dfb1e7 ("vsprintf: Make %pGp print the hex value") > > > Signed-off-by: Petr Mladek <pmladek@suse.com> > > > > Reviewed-by: Yafang Shao <laoar.shao@gmail.com> > > > > With below minor change: > - %pGp > 0x17ffffc0002036(referenced|uptodate|lru|active|private|node=0|zone=2|lastcpupid=0x1fffff > + %pGp > 0x17ffffc0002036(referenced|uptodate|lru|active|private|node=0|zone=2|lastcpupid=0x1fffff) > > The ')' is lost. Great catch! I have committed the fixed patch into printk/linux.git, branch for-5.16-vsprintf-pgp. Best Regards, Petr
diff --git a/Documentation/core-api/printk-formats.rst b/Documentation/core-api/printk-formats.rst index e08bbe9b0cbf..4eff98e06b4b 100644 --- a/Documentation/core-api/printk-formats.rst +++ b/Documentation/core-api/printk-formats.rst @@ -580,7 +580,7 @@ Flags bitfields such as page flags, gfp_flags :: - %pGp referenced|uptodate|lru|active|private|node=0|zone=2|lastcpupid=0x1fffff + %pGp 0x17ffffc0002036(referenced|uptodate|lru|active|private|node=0|zone=2|lastcpupid=0x1fffff %pGg GFP_USER|GFP_DMA32|GFP_NOWARN %pGv read|exec|mayread|maywrite|mayexec|denywrite
The commit 23efd0804c0a869dfb1e7 ("vsprintf: Make %pGp print the hex value") changed the behavior of %pGp printk format. Update the documentation accordingly. Fixes: 23efd0804c0a869dfb1e7 ("vsprintf: Make %pGp print the hex value") Signed-off-by: Petr Mladek <pmladek@suse.com> --- The commit ID 23efd0804c0a869dfb1e7 is taken from printk/linux.git, branch for-5.16-vsprintf-pgp. It should get preserved when the branch is merged into Linus tree. Documentation/core-api/printk-formats.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)