From patchwork Tue Jul 19 09:46:10 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 12922304 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1A3EC433EF for ; Tue, 19 Jul 2022 09:46:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 62BAC6B0071; Tue, 19 Jul 2022 05:46:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5DBA86B0073; Tue, 19 Jul 2022 05:46:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 454346B0074; Tue, 19 Jul 2022 05:46:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 34C426B0071 for ; Tue, 19 Jul 2022 05:46:35 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 037178103D for ; Tue, 19 Jul 2022 09:46:34 +0000 (UTC) X-FDA: 79703369550.10.1BD6042 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf01.hostedemail.com (Postfix) with ESMTP id 93EA940067 for ; Tue, 19 Jul 2022 09:46:34 +0000 (UTC) Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26J872FW024566; Tue, 19 Jul 2022 09:46:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : content-type : mime-version; s=corp-2022-7-12; bh=tYhTDaiKvaCpdj5IormPKDV/QN7a5o8gORfTDx4gHiA=; b=wTBV7qcz62YZV8EyYrUyp8M3I2XtLVKsLylPCEF8jlj5Ted5M+46GV6jayTGW2z2nqIz aFGt+v20AHpxCTP2Ok+Z+kBJTaLC4ZA5NQ8hqKDQbAy4Aow1K1HD0ayde9KX4aiSj1J1 k7dmpjxDzo3GBNX7zAORNmZlyKMydSxtkG9QJkDpC/nhmmNZkPCaFrrezCJUhffQcqUE YLc0jNnb12LSOptHhi7+R6WY6HcZhMBiNPDle31jk1BF8irKD/ikXStvvuFpVY1SOs6o UIjxtmfOQuL4ktfY90OWCXX6yfkrQJ1i5jOzyeNdOp5iaypmRQ41fMNG7hAEkLx8fi1c RA== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3hbm42druy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 19 Jul 2022 09:46:27 +0000 Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 26J8ZhKA039355; Tue, 19 Jul 2022 09:46:25 GMT Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2168.outbound.protection.outlook.com [104.47.58.168]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3hc1k4k52q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 19 Jul 2022 09:46:25 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B4VWa75wcNuy8FkPDGVf2h0HgJ6MD7yy2T6z3hwALYFjdVHXsoa33sljGOELrLU6hNvbRElg6bVqybQsPE2H8YfbCXQZ4UD8lRcI+n7/BdBdzBFxxN4ASKR4BCOgI9v72PyUUxfsWvR3sUhUi0IZ8fKPXCJNgced+cNSosw9uBUuvuIoT2exjHnw25Zlfx/ISDV+mBVzJATworlz5h7TrTPWB0pqtcWPGu6r1IH83ytc/Kb8LhruTd9+wFHN/ZSiks1dtAPEBnPr36Xlfr9FhSSIOsn1NiZgYADXia6ah9enfA78zT2EDyeTjKXWROjZIuxY6fImUJvZSLCikZETCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tYhTDaiKvaCpdj5IormPKDV/QN7a5o8gORfTDx4gHiA=; b=BaBXgs/3lCyZgX8exBTNA48va1HYZRbl8iAaSyNyw5rmQnN+gtrHA7xtXyuJz+0OExa4UZqHD47O/u68pGrWYMT5ZkL4A2P03d0VViJcMI1PSGrSUCz27LaBmofHXKUC5sdCZ22ZNckSO6jCSaRk3a6yI0DqDjsfs3OJOQDBkc150VBwnBIq4wJS0VxVOFiXNmIgCmBo2yPxq307rkgqA+dYoZ+0jKKsW1DUTXobg703REq8g2gMmqtWf+HqYeNMn/TKVHlEC6FwmTJoINt5gZNSHohkc2Yj2f2SVq1ARiJ6aQZZsLKoJXMdGrq2swe25L94jN22CFBh+6LqxMyHAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tYhTDaiKvaCpdj5IormPKDV/QN7a5o8gORfTDx4gHiA=; b=hLBXK37Deydb06HR5uTiyNGbyLNFRhGauxxMSXS8Sx5llEVVVr8+RoGtdkMsiCHaVnU7vt7PnduzhHZS+8K5cGPyVRNje+Cgw7Kz2N+Q4xyKe8wdh1f/UZ6/zZeJJVQFqUbJvYDTMxnukg0LD9h2WctRs1JWLmOq+8rTL74c/H8= Received: from MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) by IA1PR10MB5924.namprd10.prod.outlook.com (2603:10b6:208:3d4::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Tue, 19 Jul 2022 09:46:23 +0000 Received: from MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::5020:9b82:5917:40b]) by MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::5020:9b82:5917:40b%6]) with mapi id 15.20.5438.023; Tue, 19 Jul 2022 09:46:23 +0000 Date: Tue, 19 Jul 2022 12:46:10 +0300 From: Dan Carpenter To: Yosry Ahmed Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Tejun Heo , Zefan Li , Shuah Khan , David Rientjes , Andrew Morton , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] selftests: memcg: uninitialized variable in test_memcg_reclaim() Message-ID: Content-Disposition: inline X-Mailer: git-send-email haha only kidding X-ClientProxiedBy: ZR0P278CA0162.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:41::13) To MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c0583674-114a-4282-2ace-08da696b8a96 X-MS-TrafficTypeDiagnostic: IA1PR10MB5924:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yViyR3Qym5D+b1bmwZi2BRYt5ITL4xR9uvFXbNJ0u+Ss9uZq8ViGxbs27+wTmT8lxKNzLk1jM7U4JTAToNaz3xdEZKi2uQ2/p+b9DQnJ5Vtjn6CNZo6a6apdA5dITu4fpC3nRztQygbFdwPmUwVeF1jyCUbLgSXZMwNB0NpMAqsOmy5s0JuxescWfEsmeiwIlw17Pv7f7LOzQ5GLTLj4i0hXVz2fTl5XCrf4h526MEp1hoSnlQFsTSFt5MI0ASqfY1XRAIQvxxv9BQMMlV66C+Q+MS3UYT7CCirJQSbWmKkgYoa9gCvI57p5lUVF2ZLz8+Wi+W0Gs1TLjo0WLMNGDqpVLbnOACnH4+7S6MaeuzJpsYMGDXJVb120govhhoNqBjY5jwGeWcdQAkoRhWnZzkb7YNuUHaImYMUc4opmO3d6RF4LYybLR8eECV/8np24+M4ZTgicElSrA6Wlh1GCeqW02IkVHNJpxZQq3Osj2DUkSKLRZIw5Vf1b1pRu6p95dSc3SjK519GnZ9Z+DX8+HZhRlym9Mw3Sjweq5pbCCTziShiUi03KW7UpqggPu1Ag2Sot8VbynNqenjAf64x5eA0YXmrOVsuOMthEdAchiifLdCY6xPWjJ7zR5cVkvylWIUcYCEJo3LAMrQIFycxxWze+WzVOL/6q5d2/n034VMDnq4P/O71yGULMJv2uXtLt17/dxTzv7/u2NJ2vixe9zRUkj/KJi6kcQdGC/fq+RA6wa4ffKv5BPCqhVHflDX41QdeUUCxObCzF/StEULUPPOgZ80FuYtSlOteEthwqnAm2zKFM2S17iwhBCKePf66C X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2365.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(7916004)(376002)(136003)(346002)(39860400002)(396003)(366004)(86362001)(478600001)(6666004)(41300700001)(6486002)(26005)(9686003)(186003)(52116002)(6506007)(83380400001)(6916009)(316002)(6512007)(54906003)(66556008)(66476007)(4326008)(5660300002)(7416002)(8676002)(44832011)(8936002)(66946007)(33716001)(2906002)(38100700002)(38350700002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: QCuzQg/CHL9DXepLODPNqJXsKWgjdF8HwhMl5cu1E8BssHeSL+NcHXjjMlxq66f4o4rRS9j7gZiubaRdXrd/I02Nj0tMfHuQUHTYpEZj+hzMezecJcrII8LnOa3HPvCfnSx4vBQmnAYcLXmFgXkvQ1iwIwveg3LWa1Ij1eV6nehsUc/iYsRGzbtG7VJRjkZfMrh7cXd2ITK7UIFJzWxL4POeQYd1TxRR3EeSbYN1gTQ/ztP1Ik+rtKpfTc7atYRdD9AD+wfg/Q5DNN6vMAGlXvioMG046rk/6RnB/SsGo0leDlZ0ACs0hTqGvk2wBKrk8GEwciJgwFr/X2/NBXnFiaZjGXo44tRT2wsB5pQbO2uGPMWJTSzzPHUWCLpidG6KD6LqC0lzA5NtgzN04DNo/0aqPkt8NYSe+ufWWrdMOtUh4EDoWzcn6uheIkBCJsGxI8gbP7jYwp7OuKoUIOn7S+iDuYvlp59eAm1uRGQO4eqM6Eq6mPf4obf5FAKI7bfvl8Hp12ebWpEqy2moLLsjLmnbSE0Jy83lRt4whOWaHuGXeqdm0boX5U0eoqtvkNYXhTcbShBMP++Ein/MbEI8dCScSxesMWtz6Qmk8NPUTPReCH29Ov6MNiQaU/fYy0eHvWwFifqH2JFFZTt/a56oQNmwsblfnHaBj45fxQ0PW3Gd028wQONaPUhoCCGbKS8bH9Ao3R9dqdtuAU48PvJngql1axn3pzeZsRR1mmChky55LsgkFijXKDu1ApfLdJ33dzOFSTmTekJFvKiiehN17MxXORXGSTUEm3uAJ6PPrALFc7ECFm6OBYNSEkprUEDfwfY0Jv718zZP+kRFcvgb+9SDLOP9xECSwREvRGGCAvPqFtkgHb9zCy6E2kORwxQJ+42qdS0RJzLuvUtMQMXVGbBgVv1mVcjDYtTUS0vFqqpYTQeyuqoMMoBxXWcsgZa8ENBRBeaXLzkFIMz2luqn4PSoeXeyrbrNK+LOPxkb0m1p0Po1KB0AVockLyfb5TVHMDzLWGbsNVhqg4EZB+ahVMpgiaCLwcfCAerwOO5NbNKS5JCcum5hJ2XkgK5KsSIkR7L9X+bn25lSq6iZ1B+QQI93AwvvA7guoZXSXxwp931YG69Kbt3mUOH5TINMv1pWuXTei323qr/O8VNhPY0P6ivy7la3qi5z/pJ1GOtPc4KoE5oI+XzaE0178/xFsxx4IiLVs94f6npBYV762Dl/0a3s+BLi0STM+apVfv1D5wJezNxnIgRFPrEnPAtv66ShjCeepf3qwx5KlctARBRYZAinWjTIbf/sOUJZe4UfRyBHXUjB1KMSvnh7hjl5arYlUzgl9QR6iVeF+mz/1AVb/I0wwaM/s2nxf9l52PK7y8At5QgGqPmmJdhyKH/nVFBcbBW+wzGhazkQaYR4hkKfwZZwYZiV2Fa2gl/5hP9p50A8O8gg4eG0M+pU6fE2de2LfyuGEDl7JmIcdE7G+QEPx7piVtd/62zIeamWkjch1XFDtZfIGAn67+C6vUxpMDqly/iqIJ8udeLFOVQwSEgDcpg0OeF2MtVuTbU3RMQBEUwPT+mR0EIIGt51R3Qbw3qDrooijNzgd1UDwCThN3lm7Q== X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: c0583674-114a-4282-2ace-08da696b8a96 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2022 09:46:23.5110 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5Yrq2XdSfIGK0eNJrYNRJHCmwfATSYT3xo3ym/Q5IjafPtN4UlXTN1a0aULYl9g5WHK+WzgRyiViFimtmtdgGTbIi2Ez+LOvSpYLDlaJekU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB5924 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-18_22,2022-07-18_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0 mlxlogscore=999 malwarescore=0 adultscore=0 mlxscore=0 spamscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2207190041 X-Proofpoint-ORIG-GUID: MAyuIznvpew02vtYGwVXOzYyCP3_CYne X-Proofpoint-GUID: MAyuIznvpew02vtYGwVXOzYyCP3_CYne ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658223994; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=tYhTDaiKvaCpdj5IormPKDV/QN7a5o8gORfTDx4gHiA=; b=P2vQWMLFPeiL27aQiMnfS24Vosm7gn0PJvsmvWLODtCXW7DypLvZiK5b5Pp2wUGttFbdxY K7K1kVzjBKkxwxq9ZACMbXWeRheM2e84TTAz3lhnqkEO1cgUPD/RqRI/Vakub7t0c1RPKN myrcJLRQ9uqNclVs41X3Nm6xRpK6qEk= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1658223994; a=rsa-sha256; cv=pass; b=rqhbPFFLORot/s2zCRtN85q3Dp4DHmCET3EMGHxJnwQAVIG2KWSmYsSvyX6C+kWr4KGFfv BP4swlmHPy30ioHX3Fojtzw41frKOmkFNR/vp0Ilsq6Tcgf2Xz70N44o+dFj4ZtaP2v0ef 1xFQlRYRskcLstPPVwZV7tRc0bgh2h8= ARC-Authentication-Results: i=2; imf01.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2022-7-12 header.b=wTBV7qcz; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=hLBXK37D; dmarc=pass (policy=none) header.from=oracle.com; spf=none (imf01.hostedemail.com: domain of dan.carpenter@oracle.com has no SPF policy when checking 205.220.177.32) smtp.mailfrom=dan.carpenter@oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") X-Rspamd-Queue-Id: 93EA940067 Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2022-7-12 header.b=wTBV7qcz; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=hLBXK37D; dmarc=pass (policy=none) header.from=oracle.com; spf=none (imf01.hostedemail.com: domain of dan.carpenter@oracle.com has no SPF policy when checking 205.220.177.32) smtp.mailfrom=dan.carpenter@oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") X-Rspamd-Server: rspam12 X-Rspam-User: X-Stat-Signature: btmipr5uqn3tdt8775qess83hk1sr8wg X-HE-Tag: 1658223994-766979 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The "fd" is used on the clean up path without ever being initialized. Fixes: eae3cb2e87ff ("selftests: cgroup: add a selftest for memory.reclaim") Signed-off-by: Dan Carpenter Reviewed-by: Yosry Ahmed --- I kind of went over kill on fixing this as if it were real code which matters. :P .../selftests/cgroup/test_memcontrol.c | 23 +++++++++++-------- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/tools/testing/selftests/cgroup/test_memcontrol.c b/tools/testing/selftests/cgroup/test_memcontrol.c index 8833359556f3..08681699c2f9 100644 --- a/tools/testing/selftests/cgroup/test_memcontrol.c +++ b/tools/testing/selftests/cgroup/test_memcontrol.c @@ -658,18 +658,18 @@ static int test_memcg_reclaim(const char *root) memcg = cg_name(root, "memcg_test"); if (!memcg) - goto cleanup; + return KSFT_FAIL; if (cg_create(memcg)) - goto cleanup; + goto free_memcg; current = cg_read_long(memcg, "memory.current"); if (current != 0) - goto cleanup; + goto destroy_memcg; fd = get_temp_fd(); if (fd < 0) - goto cleanup; + goto destroy_memcg; cg_run_nowait(memcg, alloc_pagecache_50M_noexit, (void *)(long)fd); @@ -697,7 +697,7 @@ static int test_memcg_reclaim(const char *root) fprintf(stderr, "failed to allocate %ld for memcg reclaim test\n", expected_usage); - goto cleanup; + goto close; } } @@ -717,7 +717,7 @@ static int test_memcg_reclaim(const char *root) * not reclaim the full amount. */ if (to_reclaim <= 0) - goto cleanup; + goto close; snprintf(buf, sizeof(buf), "%ld", to_reclaim); @@ -729,7 +729,7 @@ static int test_memcg_reclaim(const char *root) */ current = cg_read_long(memcg, "memory.current"); if (!values_close(current, MB(30), 3) && current > MB(30)) - goto cleanup; + goto close; break; } @@ -738,14 +738,17 @@ static int test_memcg_reclaim(const char *root) continue; /* We got an unexpected error or ran out of retries. */ - goto cleanup; + goto close; } ret = KSFT_PASS; -cleanup: + +close: + close(fd); +destroy_memcg: cg_destroy(memcg); +free_memcg: free(memcg); - close(fd); return ret; }