Message ID | Z6V0/UvG1fvkQ4t/@fedora (mailing list archive) |
---|---|
State | New |
Headers | show
Return-Path: <owner-linux-mm@kvack.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 774CCC02198 for <linux-mm@archiver.kernel.org>; Fri, 7 Feb 2025 02:50:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0810E6B0082; Thu, 6 Feb 2025 21:50:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 030DA6B0085; Thu, 6 Feb 2025 21:50:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E3A216B0088; Thu, 6 Feb 2025 21:50:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C74BE6B0082 for <linux-mm@kvack.org>; Thu, 6 Feb 2025 21:50:53 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7BDDD140F58 for <linux-mm@kvack.org>; Fri, 7 Feb 2025 02:50:53 +0000 (UTC) X-FDA: 83091621186.10.3927C17 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 855401C0004 for <linux-mm@kvack.org>; Fri, 7 Feb 2025 02:50:51 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RSvbH9Wp; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738896651; a=rsa-sha256; cv=none; b=Wj3do9QvTXM1K5d9o5b9sKLBTlfaN0ILTJFrzbVBVvGK1IEmxt9LqkefpWR5QFWJacorC6 e217/EcmN2MbnB56ukLSDl+xoqtSYVSgPAiNpJY51QSNNQAEfWYfCqpZbIat5KZtLypqk2 HfcFd8h4PLHtBsfoPh2MFitKCqRsx/w= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RSvbH9Wp; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738896651; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lSgV3BL74gNbeFl9iKEmyG8+Z3L9756kZ4NrKNCbbCQ=; b=jSXQvjg6lLBnEuW8ixR/4+h7ruYk/3lze3O4rhWd5YVeVNStD/pt2+pDIdHE7Cuk/DV6YK dv9hSdy/NRC6v8GaDEzj9DReEvq27pCfR3MkqEpg8U3N4CpvOFREqphRT/e5KB+bJlOjrp 5Ru3zqQwsKRUtG9mUXfZehT5uVFlyH8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738896650; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lSgV3BL74gNbeFl9iKEmyG8+Z3L9756kZ4NrKNCbbCQ=; b=RSvbH9WpJYZylSYx2SK23iqG4zVxW/1G6+IfEqmZoliOP1A5pHENdilUILIs4qKoFZt26s vRQjefRZmbm/NVKIF6M/q425r2bhB5PYV1evpQiBpbxLFvY1/htMHgU6jvh6Xj6b0Rhkbn bajXT3Jvmih9+NKxz89B5iRwA7Oxd/8= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-153-uIHSDNPlNPuaAtaJ3LBx8Q-1; Thu, 06 Feb 2025 21:50:46 -0500 X-MC-Unique: uIHSDNPlNPuaAtaJ3LBx8Q-1 X-Mimecast-MFC-AGG-ID: uIHSDNPlNPuaAtaJ3LBx8Q Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 479D31955DD0; Fri, 7 Feb 2025 02:50:43 +0000 (UTC) Received: from localhost (unknown [10.72.112.206]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DDB4D19560AE; Fri, 7 Feb 2025 02:50:41 +0000 (UTC) Date: Fri, 7 Feb 2025 10:50:37 +0800 From: Baoquan He <bhe@redhat.com> To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, akpm@linux-foundation.org, ryncsn@gmail.com, chrisl@kernel.org Subject: [PATCH v2 06/12] mm/swapfile.c: update the code comment above swap_count_continued() Message-ID: <Z6V0/UvG1fvkQ4t/@fedora> References: <20250205092721.9395-1-bhe@redhat.com> <20250205092721.9395-7-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250205092721.9395-7-bhe@redhat.com> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Rspam-User: X-Rspamd-Queue-Id: 855401C0004 X-Rspamd-Server: rspam12 X-Stat-Signature: 63suqi8jm8nkdh6jgg11xffaj1gj8yfa X-HE-Tag: 1738896651-151442 X-HE-Meta: U2FsdGVkX19rHM8JBJvYXtoamjUpuFTA4uYaIRGhThovb2RvbpBaoUWv+kjI5n0HsCaX5R0wMSyNCDLUuWjtDjGNS8CKFlyVkvgsZNi120hpTMqH4QIcs6eIDMLzax3vYN/0AjJLuQaeMFriawi33tf5WQeKkndS14gkP74yz01lRagDXfApymhpVLHdZN6c1jHhQK5u95n8kwOf2pSGbP3to9KWXpPj0+xd+ncE4DTjHOuv6SXJpuSpPWGxo0GbbQ2YeXFIGuF5SAv1toGySsM1OI44Bn3ZvU8kWGn7WwQOltlxFraNy8bjdvF7ILtyR3aja3BwJ+bKy4rFRcheDPYKGvCLsftSeuqcBmgF5N03ral9uyz/uPkApeA7dfXHeKmGlA72jtlA9BFT3JLaPV8Gv4oSlIVmz8KAKcYAJZ9VBUp3JCCUjfX8HtokAysRGDEDSJytPeasoQW0c1WQF4U1WbQTd4kaoYVAQS3AyLkaLdY4qTPNqcV/ZzwcEuv5YaAofwMk0CLimAMQBOz4wOEfkbaKVPHOwVnP959zwtb8GIcqvOH7qpu1CY4LJA9i9WO9Uvfjg3ZcbiLIHrjCBi1Xs5DpguC3pfGou9pnwUhzBpRfsIQzBRHVMJgx9a6nzTSmG+nFDbdXl1FjKcfBsIvsFYst9PJW4je13myEX/NCQFPKLXAaCZMhQGTM5B25TO8WQDyIUKO2UU+cgZDl3Bo+AYhgKiWcc6zWrP4SOfQDx6GAKVaBAilDTr+AKwLrnC7+zTk5n39DWtLnJqLXqChv54xJavZKzGtYNdFx6qZelRWbDhIJZgBcttOGaJ0xRdPCDhW5NVIEVYOnZIqcKHCWReX8tNfOm6mtaZ7x4OMqf6ZjUEFhaQ5bnKD8dHQnMWNRwLJQiCRnqO2Situ0HcAXnLITCi1nc4+HlV7NoSif8jzGRcbnHd+qNKFIuNQZj9peLHAp90WrkUOtPAI fo2SoCGL +RrGm3VjFu7xpMlS28Q/Yo7D+T5BsmvxnrVLWV8hT21EQLh72qqqS9ibL2F9djtJOIh4DoFAfb4kexTg25fNpoJJJKS6TGnJxpvbS2FnFt5Y6l8/vMWu/hPVpF6F7XSWVZdYSZkIDsBQmta1JvMnT5unhLLX26x/aTs7C6Mc02H8FH/2nvZUEaDE8VklvOL+wOd9I74WO4oU4dVHJA6GUN8qQifiHeQ6bIRNvSfwlG1OZoqm1bHFlEFDNNMR05KAqZ97UVJrBtPZo1MwbsQwFLV2Pis6x4ORu1OyRtUQ8y1z4iNslhAHEab2rG4NvCpqs1zTsOuqtla/LEAPVNy0NLRexQN2N0S86BZHJwl7dszemZmw2HS+d5aF3xIiE3HGc6RC6sCURpIUHvUSMiZmh0ww8gWb15oqnwRYl+sumr6KYoK4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: <linux-mm.kvack.org> List-Subscribe: <mailto:majordomo@kvack.org> List-Unsubscribe: <mailto:majordomo@kvack.org> |
Series |
None
|
expand
|
diff --git a/mm/swapfile.c b/mm/swapfile.c index bf284ba16198..f6cc169f59d9 100644 --- a/mm/swapfile.c +++ b/mm/swapfile.c @@ -3789,8 +3789,8 @@ int add_swap_count_continuation(swp_entry_t entry, gfp_t gfp_mask) * into, carry if so, or else fail until a new continuation page is allocated; * when the original swap_map count is decremented from 0 with continuation, * borrow from the continuation and report whether it still holds more. - * Called while __swap_duplicate() or swap_entry_free() holds swap or cluster - * lock. + * Called while __swap_duplicate() or caller of __swap_entry_free_locked() + * holds cluster lock. */ static bool swap_count_continued(struct swap_info_struct *si, pgoff_t offset, unsigned char count)
Now, swap_count_continued() has two callers, __swap_duplicate() and __swap_entry_free_locked(), the relevant code comment is stale. Update it to reflect the current situation. Signed-off-by: Baoquan He <bhe@redhat.com> --- v1->v2: - Update the code comment according to Kairui's comment. mm/swapfile.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)