From patchwork Mon Jun 20 23:10:12 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kalra, Ashish" X-Patchwork-Id: 12888497 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04B05C433EF for ; Mon, 20 Jun 2022 23:10:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 956546B0071; Mon, 20 Jun 2022 19:10:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 907788E0002; Mon, 20 Jun 2022 19:10:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7A8BB8E0001; Mon, 20 Jun 2022 19:10:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 69CCD6B0071 for ; Mon, 20 Jun 2022 19:10:27 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 41811336D1 for ; Mon, 20 Jun 2022 23:10:27 +0000 (UTC) X-FDA: 79600160094.30.39E2603 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam07on2056.outbound.protection.outlook.com [40.107.212.56]) by imf02.hostedemail.com (Postfix) with ESMTP id C69478001E for ; Mon, 20 Jun 2022 23:10:26 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FqL3EpdA0kYy29uJ0HuFgnXFKYFwc19j5xgajLjNW4+uwQ5t3vIU/CGezY9qjFv6jm8SbvKR02fZnlXcfMXDCwOcgS3n3TRfM0WZEXrGrG6VIMV1EeOysqWjJal06RB4bcp3lEDusSoEClPJ7arsPxJ+sWQ2WKPpgr4fNLLlXHVJBjrlbTOqrxM85kW3FzYxCOdwvWz1X+NTR6+fWZpQ6XTQh6CrjP/DaNkH6bGq31prW49gN+6CAHAIGC4NmHwfVMs/crdc4UDUP37RO0ZjZXgyUt8msDLb00PtIO9vhHfypZ8cNArJFe6Q1bA6w/Jr+4oXRwnK4L9MXNyP0KVOyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=efta1cNDJs0WthUX36PuDzopevN1H6s1CA8wvV2cSvo=; b=NqBpL2POZwvxUMmQbZHUqn9/RW7rO7TF2uVX4nMZps1K3wpxNNNbWrVoLV3014xyzY29JAw+yIVLnbGOzhTWAwZ50AYhsStkQs4TL0UKDc8UaMEUu7pAezrQ1GL3d1DUraxIOFIvOGz7O68jCSpflX+VwXZ6ySw5W1XLgHi83XrbTLBrvqi0kqk3M5qq7k4dNhBhd66Gwm/ZOlL/KyWMwvBNBaC7NHi7EKe8UZCoHBnGNApu5KdSYmu8C22RJx5tmQui2FtBM/5gnm1s3w2Yon7oG6u3s/BQMoI+8LufsDdjAqufaaG8V8zeuYRlYBdndInKI4IWw+o1/7NZfrvwmQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=efta1cNDJs0WthUX36PuDzopevN1H6s1CA8wvV2cSvo=; b=K0GtHKpTaCdatcTkT11Qf2iLYRTRkjDaYwY8K8z53Vuw+RTtTJUN0i9EtyKh+xco/1t+jQNgRqJeJswupxis4ez8DA9p+I6gESejcNq2FwFjk/ZB8Re8FiPYtnGkUSvYsHCtJeR39tL8kG/cgRtfhEOAoDxFMdSR9Sbnm3pn1bY= Received: from FR1P15201CA0042.LAMP152.PROD.OUTLOOK.COM (2603:10d6:202:6::28) by DM5PR12MB2552.namprd12.prod.outlook.com (2603:10b6:4:b5::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.20; Mon, 20 Jun 2022 23:10:24 +0000 Received: from DM6NAM11FT024.eop-nam11.prod.protection.outlook.com (2603:10d6:202:6:cafe::ca) by FR1P15201CA0042.outlook.office365.com (2603:10d6:202:6::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.14 via Frontend Transport; Mon, 20 Jun 2022 23:10:23 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT024.mail.protection.outlook.com (10.13.172.159) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5353.14 via Frontend Transport; Mon, 20 Jun 2022 23:10:23 +0000 Received: from ashkalraubuntuserver.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 20 Jun 2022 18:10:20 -0500 From: Ashish Kalra To: , , , , , CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: [PATCH Part2 v6 33/49] KVM: x86: Update page-fault trace to log full 64-bit error code Date: Mon, 20 Jun 2022 23:10:12 +0000 Message-ID: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 33f3e937-cb27-4031-958d-08da53120e06 X-MS-TrafficTypeDiagnostic: DM5PR12MB2552:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QddsYhbpU0iH2igPO8ksmaLcFJDGY61RHUSg9oQ364jWWct0nW+Ol82yeTSl4KK7VUkl92Jj62Rs9dtQf3Sb9Ii7EWbwRSYYC3DPpdAQvCqI2InfSm2tZUMoZNJ3qaXqlYwzmQyWY7riUegV9E/dbf47bfmZP5ZjswRUTnf/hYB3vichM6XwhzLEdyv/C23UnlDZthaQZbXF4DwQkUKFpiT9AIk4PrN3MBGaBJkDahK76UjVRhN0D5MvVJlwZP0x6AFcbcuMQvNsO8V1SGYBXYGKqjgt5CvmjY0hIme0CRlM6Ty4v0xWMmc8p9bQ8N8pag5CTKdJM5Huqy5/83KiE28n2WFWEQO9fcNmNkVujZ0LH0tjcZ/9IDelJ06C7u+OxnCJa+n6cL3qjomdY3RDh/qpu4HDjckUo8e0aP9ldM1oYfAdVEALG3waxrfOCH6rrlbjdKT8tuD/H7TUpAMWj33hx3tuqgp0VR84hoX3netjaIFLAJbPsAxvi+5MiInQ4KEuA6EUJyq9MNVKT2W5bRUZ7CVcWcFGcey5GN8m0kvCN5zjGB5A+TE3tYZmqgU7I3L9uPaIWzw0qmhDV69yadkr02olvEWoGztg94b6B5z6Yw1Uch135fVEe15kS0m+zqj89e5evL0c8m1SZDK4CDEZ17V+qYsdkOuGsxTUcnAbSoiWOwXmJwPkEBEG+lTmPm1r06a7usc6YuoQtUHjVZAaozl84nPhdB6FvsO/jzKAYgAXBhTkOtshDua8R5kyvGXOjBU11VYXq0ULoLyKNA== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(136003)(376002)(39860400002)(396003)(346002)(46966006)(36840700001)(40470700004)(26005)(110136005)(41300700001)(316002)(6666004)(54906003)(16526019)(186003)(40460700003)(7696005)(82310400005)(478600001)(40480700001)(2906002)(70206006)(70586007)(4326008)(8676002)(36860700001)(83380400001)(7416002)(36756003)(7406005)(5660300002)(86362001)(356005)(336012)(81166007)(82740400003)(47076005)(426003)(2616005)(8936002)(36900700001)(2101003);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2022 23:10:23.5082 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 33f3e937-cb27-4031-958d-08da53120e06 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT024.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB2552 ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1655766626; a=rsa-sha256; cv=pass; b=fYnjIcQr88MMe0wlNUPaB1920B3SyYF9J0Dtggs7WWbk7CyTnb/oAwpC8Y1S3LMP0JgCtj Vbuam1ONViNNd5Pq7egIrzSsBuJAPArmb+cEGc/7dQsRxTEyJpvLHIiNqfZ2vJ+Uvq2hfa bLqlej+7LpR+5owm13BQ0UNBg3i/6as= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655766626; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=efta1cNDJs0WthUX36PuDzopevN1H6s1CA8wvV2cSvo=; b=0zoqx/31Tonrfed+2p+k/rTOu0BYrBuXG8t8RpxaXi5VBzmufce76g20PqVP3jyYmme9Ck qC5q/v9iTu1nir6KcNs26HCTkgv8LIof606MMn/C69iKOBXbnZvtxGNKFkHdAT/Gwtj2+a IhaLUOnztAD2MhExJPF1Yxa8fO3O+og= ARC-Authentication-Results: i=2; imf02.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=K0GtHKpT; dmarc=pass (policy=quarantine) header.from=amd.com; spf=pass (imf02.hostedemail.com: domain of Ashish.Kalra@amd.com designates 40.107.212.56 as permitted sender) smtp.mailfrom=Ashish.Kalra@amd.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=K0GtHKpT; dmarc=pass (policy=quarantine) header.from=amd.com; spf=pass (imf02.hostedemail.com: domain of Ashish.Kalra@amd.com designates 40.107.212.56 as permitted sender) smtp.mailfrom=Ashish.Kalra@amd.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: C69478001E X-Stat-Signature: 9p6jw6mkub4uhctc9xnrkjq4eh38uq6p X-HE-Tag: 1655766626-958116 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Brijesh Singh The #NPT error code is a 64-bit value but the trace prints only the lower 32-bits. Some of the fault error code (e.g PFERR_GUEST_FINAL_MASK) are available in the upper 32-bits. Cc: Signed-off-by: Brijesh Singh --- arch/x86/kvm/trace.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/x86/kvm/trace.h b/arch/x86/kvm/trace.h index e3a24b8f04be..9b9bc5468103 100644 --- a/arch/x86/kvm/trace.h +++ b/arch/x86/kvm/trace.h @@ -383,12 +383,12 @@ TRACE_EVENT(kvm_inj_exception, * Tracepoint for page fault. */ TRACE_EVENT(kvm_page_fault, - TP_PROTO(unsigned long fault_address, unsigned int error_code), + TP_PROTO(unsigned long fault_address, u64 error_code), TP_ARGS(fault_address, error_code), TP_STRUCT__entry( __field( unsigned long, fault_address ) - __field( unsigned int, error_code ) + __field( u64, error_code ) ), TP_fast_assign( @@ -396,7 +396,7 @@ TRACE_EVENT(kvm_page_fault, __entry->error_code = error_code; ), - TP_printk("address %lx error_code %x", + TP_printk("address %lx error_code %llx", __entry->fault_address, __entry->error_code) );