diff mbox series

lib: fix for_each_child.cocci warnings

Message ID alpine.DEB.2.22.394.2105112244370.50955@hadrien (mailing list archive)
State New, archived
Headers show
Series lib: fix for_each_child.cocci warnings | expand

Commit Message

Julia Lawall May 11, 2021, 8:46 p.m. UTC 
From: kernel test robot <lkp@intel.com>

For_each_available_child_of_node should have of_node_put() before return
around line 1121.

Generated by: scripts/coccinelle/iterators/for_each_child.cocci

Fixes: 7d37cb2c912d ("lib: fix kconfig dependency on ARCH_WANT_FRAME_POINTERS")
CC: Julian Braha <julianbraha@gmail.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   1140ab592e2ebf8153d2b322604031a8868ce7a5
commit: 7d37cb2c912dc5c25ffac784a4f9b98c06c6bd08 lib: fix kconfig dependency on ARCH_WANT_FRAME_POINTERS
:::::: branch date: 15 hours ago
:::::: commit date: 5 weeks ago

 mcde_dsi.c |    1 +
 1 file changed, 1 insertion(+)

Comments

Linus Walleij May 17, 2021, 10:08 p.m. UTC | #1 
On Tue, May 11, 2021 at 10:46 PM Julia Lawall <julia.lawall@inria.fr> wrote:

> From: kernel test robot <lkp@intel.com>
>
> For_each_available_child_of_node should have of_node_put() before return
> around line 1121.
>
> Generated by: scripts/coccinelle/iterators/for_each_child.cocci
>
> Fixes: 7d37cb2c912d ("lib: fix kconfig dependency on ARCH_WANT_FRAME_POINTERS")
> CC: Julian Braha <julianbraha@gmail.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@inria.fr>

Acked-by: Linus Walleij <linus.walleij@linaro.org>

Shall I apply it to the DRM tree or do you plan on funneling it
some other way?

Yours,
Linus Walleij
diff mbox series

Patch

--- a/drivers/gpu/drm/mcde/mcde_dsi.c
+++ b/drivers/gpu/drm/mcde/mcde_dsi.c
@@ -1118,6 +1118,7 @@  static int mcde_dsi_bind(struct device *
 			bridge = of_drm_find_bridge(child);
 			if (!bridge) {
 				dev_err(dev, "failed to find bridge\n");
+				of_node_put(child);
 				return -EINVAL;
 			}
 		}