From patchwork Sun Aug 30 21:01:30 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hugh Dickins X-Patchwork-Id: 11745331 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1B18F14E5 for ; Sun, 30 Aug 2020 21:01:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D15B82083E for ; Sun, 30 Aug 2020 21:01:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="oFyFWS/k" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D15B82083E Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 08CDA6B0002; Sun, 30 Aug 2020 17:01:35 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 040076B0003; Sun, 30 Aug 2020 17:01:34 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E94636B0005; Sun, 30 Aug 2020 17:01:34 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0137.hostedemail.com [216.40.44.137]) by kanga.kvack.org (Postfix) with ESMTP id D01776B0002 for ; Sun, 30 Aug 2020 17:01:34 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 8FD18363C for ; Sun, 30 Aug 2020 21:01:34 +0000 (UTC) X-FDA: 77208456108.13.vase16_6214e4a2708a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin13.hostedemail.com (Postfix) with ESMTP id 66E5C18140B67 for ; Sun, 30 Aug 2020 21:01:34 +0000 (UTC) X-Spam-Summary: 1,0,0,435fdf92cb353c54,d41d8cd98f00b204,hughd@google.com,,RULES_HIT:41:355:379:800:960:973:988:989:1260:1277:1313:1314:1345:1359:1437:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:3138:3139:3140:3141:3142:3152:3352:3865:3866:3870:3871:3872:3874:4321:5007:6261:6653:7875:8660:8957:10004:10400:11026:11232:11658:11914:12043:12297:12517:12519:12555:12740:12895:12986:13069:13148:13149:13230:13311:13357:13439:14096:14097:14181:14394:14659:14721:21060:21080:21324:21444:21451:21627:21939:30054,0,RBL:209.85.210.65:@google.com:.lbl8.mailshell.net-66.100.201.100 62.18.0.100;04yrwk8bh9tt6cw3zxgcia85bbposycd7ojnkisg3hygda3tz98m4u5s7t1rw79.km94j4yyoza99eus3ikrag7beu1d53gfjzgamsiytaoqd7f1hpmazqm9wisj3ge.1-lbl8.mailshell.net-223.238.255.100,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fp,MSBL:0,DNSBL:neutral,Custom_rules:0:0:0,LFtime:22,LUA_SUMMARY:none X-HE-Tag: vase16_6214e4a2708a X-Filterd-Recvd-Size: 4132 Received: from mail-ot1-f65.google.com (mail-ot1-f65.google.com [209.85.210.65]) by imf06.hostedemail.com (Postfix) with ESMTP for ; Sun, 30 Aug 2020 21:01:33 +0000 (UTC) Received: by mail-ot1-f65.google.com with SMTP id j3so3728466otk.13 for ; Sun, 30 Aug 2020 14:01:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=0A0MgBvdZsn83Ew2Ktjq3B8TXEsbXPWHsWkGfR3n5Sk=; b=oFyFWS/knp2ok2Qu0qsMN8fKLiiU0kOo/mIL5IkekajG5x9dgm1oAvakoa5SgfZHsu 1qzYznn+LwXijJPZS5UvQ28q4NzUqmQb5JYoYoaQQusdmgpdVzkKh2AOHSU9euxcpNYl omLFmPd1dP35wP+etXy3lmrM1uUlWvqnZPAKCuZ/k8Dno8MbpcvA8qEhhlhnzQXBYM+B ux5CuQ7sti0552QPWjIrs+ZMNYXdqpMx98JzBmfA6sPypX7LUj7UIwUjrVLfIvb3FIfd T5tlwA6YskZ2woohS40ycZRntDy8zFveF5niV8KmeDlng4hl5LLHWoI5KQ7NQ/26N/xN dVTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=0A0MgBvdZsn83Ew2Ktjq3B8TXEsbXPWHsWkGfR3n5Sk=; b=JzNraY8pzSD12oAYQ/iswgkJ+Sqt5IAByuvm9YuT/HwYslwNx/ypwOoO33xGIxYnP6 hpzs1ZyGgfF6KEfY4uwlBPendIdoHs0NRxIuOWieRBFpo63+UFETIv0zJmUwOzGRX4Ko jiyW/rJzTdW5e/hFjWQl+h1Kfj7ESbFOE9xFgnd87uFkj8tOAX7iTHYDbtHQ+WaFGAJH 2bKVWPiiFgQkimdrSWcibYL0PVfvCd/agbxdALdWIdNY1mFNQ/MuUziinstDOEtotI/L sQvQnMhhUuNlxDYEXzylDr43G8qE40Tnl+iqFGO7EcN9eVonFus2cnX+3091BmNBj6mJ SyYg== X-Gm-Message-State: AOAM531MxDWEHhGVyRY7x/+njrzakO2GMWTg7553Eb2H0V5bURuT8VaG v1GR60G7J5r/lnoB7xxL6VKGRQ== X-Google-Smtp-Source: ABdhPJyM3ZCANKZOyGmfG66cOB7Sxsfltxqe3tzoqaKIbYnuzUsBOB5hyE7Vr76l2sr1FdMpsJQYTw== X-Received: by 2002:a9d:24c6:: with SMTP id z64mr2594644ota.97.1598821293211; Sun, 30 Aug 2020 14:01:33 -0700 (PDT) Received: from eggly.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id m11sm281916ooe.43.2020.08.30.14.01.31 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Sun, 30 Aug 2020 14:01:32 -0700 (PDT) Date: Sun, 30 Aug 2020 14:01:30 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@eggly.anvils To: Andrew Morton cc: Alex Shi , Johannes Weiner , Michal Hocko , Mike Kravetz , Shakeel Butt , Matthew Wilcox , Qian Cai , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 2/5] mm: migration of hugetlbfs page skip memcg In-Reply-To: Message-ID: References: User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 X-Rspamd-Queue-Id: 66E5C18140B67 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: hugetlbfs pages do not participate in memcg: so although they do find most of migrate_page_states() useful, it would be better if they did not call into mem_cgroup_migrate() - where Qian Cai reported that LTP's move_pages12 triggers the warning in Alex Shi's prospective commit "mm/memcg: warning on !memcg after readahead page charged". Signed-off-by: Hugh Dickins Reviewed-by: Shakeel Butt Acked-by: Johannes Weiner --- This fixes a likely future warning, but is just a cleanup right now. mm/migrate.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- 5.9-rc2/mm/migrate.c 2020-08-16 17:32:50.665507048 -0700 +++ linux/mm/migrate.c 2020-08-28 17:42:07.967278385 -0700 @@ -668,7 +668,8 @@ void migrate_page_states(struct page *ne copy_page_owner(page, newpage); - mem_cgroup_migrate(page, newpage); + if (!PageHuge(page)) + mem_cgroup_migrate(page, newpage); } EXPORT_SYMBOL(migrate_page_states);